From nobody Fri May 3 05:18:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1618840940; cv=none; d=zohomail.com; s=zohoarc; b=aIZSlE8PXJjB9nVqNhDvl75KxPCmQ6DZHpB9eqphz9Yki40vWJXDBwbw6729+r8a509Cd2dS0srInhOThcpDEnkIjpNhG4K23q2/CobWvKuZy5Vxaytdoj2a/NAjDdDJpryYoDJry/C0cGyDYgB9nLwQt8m47Z0+y2O0umrsBzI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618840940; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=fAFVkVswriu1HI2fBu99dG4MPuwJlGnL+S1rbWIu/WY=; b=k7cvnDa4WzwjBXE3dnYsoKJWhVcYs7TfH69g8+PCyAFBkdmq8TtwKG+PxJLuam1q3gb8mEzG8HSt8z/NCWvcf61B3P/pJqiHCHEuynoxAgweqtqkedENk+eMjaLqjWUFxIGKYB89liz21Ih3VVyJoHToBPkhX5qtTBmiH6wC7gE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1618840940817276.69111306342575; Mon, 19 Apr 2021 07:02:20 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.112933.215315 (Exim 4.92) (envelope-from ) id 1lYUTM-00065Z-1V; Mon, 19 Apr 2021 14:01:56 +0000 Received: by outflank-mailman (output) from mailman id 112933.215315; Mon, 19 Apr 2021 14:01:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lYUTL-00065S-UN; Mon, 19 Apr 2021 14:01:55 +0000 Received: by outflank-mailman (input) for mailman id 112933; Mon, 19 Apr 2021 14:01:54 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lYUTK-0005yZ-EA for xen-devel@lists.xenproject.org; Mon, 19 Apr 2021 14:01:54 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f6bedd42-5dc3-48a5-932f-a3843df327d4; Mon, 19 Apr 2021 14:01:50 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f6bedd42-5dc3-48a5-932f-a3843df327d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1618840910; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=c90n3UWvZdBwaNrzfvCy7mTTendEDQlhzxhGFVDknR8=; b=MPL87x1DMhqWgltjz6XXLEN57+nhEy/dzRd8XG/s6Mlg6Wgu7oYd67Yr ca1fyD+hOCUj8U+vqwN/PSEudkbFhqEJP1WgVBz9h92H17wOb311axzgk HwUY8tLkPntmvyWgtX9/cfhC4X4gMrCZEGiueIVwELFq30JnPLsHS28zU A=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: iXgvNWFjzftq9wYGBW4oTykAuHznRLeVbKnWNBvkEotkRAa7LkhsKGKva+s+305aXAaJlabshm IU6D7u32Pb1HhvtT+UTsSrSAzHa16UmyUZJPPZ6EOMkH5+3NDLV+chuPzdfdkqfM+MRsW1/YZG yFcpbkZBFGHNMTZ6qWKBb8MXY9cYJZa3AaeAKTXaODDerlNxzTyZ+c1OlNBBirJTul8AD60g/a LKPt4G4z+3Cx034+kv1/cQdG+0JXkbt+pAB+j3ApuJfX8pqQtmxmf+Zy8HPPxXMLRi1q4qrngx TYQ= X-SBRS: 5.1 X-MesageID: 41885044 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:Ye+oyarXkTvSLtWJtdAfZY8aV5qzeYIsi2QD101hICF9WObwra GTtd4c0gL5jytUZWE4lbm7SdG9aF7V6JId2/hzAZ6MRw/j0VHGEKhD6s/YzyTkC2nC8IdmpM NdWoxfLPG1MlRgl8b952CDYq8d6f2K6rqhi+ub71oFd3AJV4ha4w10ChmWHyRNLWEsb/dUKL Om6sVKvDamc3gMB/7LYUUtZOTfu8bN0KvvfB9uPW9A1CC1kTiq5LTmeiL54j4iVVp0r4sKwC zgmwz96r7LiYDf9iPh X-IronPort-AV: E=Sophos;i="5.82,234,1613451600"; d="scan'208";a="41885044" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH 1/7] xen/arm: Make make_cpus_node() compile at -Og Date: Mon, 19 Apr 2021 15:01:26 +0100 Message-ID: <20210419140132.16909-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20210419140132.16909-1-andrew.cooper3@citrix.com> References: <20210419140132.16909-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 X-ZohoMail-DKIM: pass (identity @citrix.com) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When compiling at -Og: domain_build.c: In function 'make_cpus_node': domain_build.c:926:12: error: 'clock_valid' may be used uninitialized in = this function [-Werror=3Dmaybe-uninitialized] 926 | if ( clock_valid ) | ^ The compiler hasn't spotted that clock_valid is always initialised after the "if ( !compatible )" check. Initialise clock_valid to false. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich --- CC: Stefano Stabellini CC: Julien Grall CC: Volodymyr Babchuk --- xen/arch/arm/domain_build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index b1d7b9849f..b10f5c8f85 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -831,7 +831,7 @@ static int __init make_cpus_node(const struct domain *d= , void *fdt) /* Placeholder for cpu@ + a 32-bit hexadecimal number + \0 */ char buf[13]; u32 clock_frequency; - bool clock_valid; + bool clock_valid =3D false; uint64_t mpidr_aff; =20 dt_dprintk("Create cpus node\n"); --=20 2.11.0 From nobody Fri May 3 05:18:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1618840935; cv=none; d=zohomail.com; s=zohoarc; b=Ek/UDuHZGOSRod/A5HA+wbHmWUdYkeESbXFQl8rlTTLxV3LJPFdguHvfLBfDHEISurcq1iCjbu4TNOGPJaHgeaqQoLbo9ih++5CdnqavjDUmNiwph+/a0d0vskY619yPN/4xmpdzDG93DJybGO1US6RGvFFeGgcnvPjaU+YCyEA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618840935; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=a7HGO6R7gM38PXaMHFsEfFzzW66fxgyuDTYVhYQJ9aU=; b=DiLYNmF1Jmm0blFiOrzFKCP/WkeGA/Vz1DBiYrIDJ7H4TOLECrbZE9465HLlPV3ijvQcGjziy1Py9fA68mPyNHm/S5sIo8NYkZWDTmJYT8URzZbJJ8PTG/MZo8j4bFJJijIKQb3AASU55WFH2UJVb9rpD9jxSflIg/CB6FQDen8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1618840935173708.3291248237495; Mon, 19 Apr 2021 07:02:15 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.112931.215292 (Exim 4.92) (envelope-from ) id 1lYUTG-000608-G7; Mon, 19 Apr 2021 14:01:50 +0000 Received: by outflank-mailman (output) from mailman id 112931.215292; Mon, 19 Apr 2021 14:01:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lYUTG-000600-C5; Mon, 19 Apr 2021 14:01:50 +0000 Received: by outflank-mailman (input) for mailman id 112931; Mon, 19 Apr 2021 14:01:49 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lYUTF-0005yZ-Du for xen-devel@lists.xenproject.org; Mon, 19 Apr 2021 14:01:49 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 98467370-7f61-41ad-84a3-b50c4d4368dc; Mon, 19 Apr 2021 14:01:48 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 98467370-7f61-41ad-84a3-b50c4d4368dc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1618840908; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=u9A8Xbp2f28xpiyEql1FXS9QDyMZHqIW8dHroVxEQz0=; b=damj74y7thsnEtJgAqNQsH7qvba371RodFW5o/h4CozHQDXSOT3Gb4+n WteTk3aS4KWEquTli3301epwJQTUxy3XPi2KI3yVnRSGG6qJfSh+bumh9 EaHZ13HnvqwKwH0FeTjQ2kp0An+DLxfdi/x3jIGkSr7yZTmFrP0xDNuci A=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 9dLxGOaIsnB66Fuzg95ph/S9+suSyg6IWMg+z9hhurXGdoZA5tb3pUkQGGadGtQyIqHDplGWwY aJ1/XU0bwious1VjmOyp+YBy6PF+VAIbBtt0OtKuCAGqcH/br8zyTuqIReMFLee4fTHtjBwCSP 4OWoy7wOC8ksgqyluh4Hjh2LKdtXFEux4H1aMrA59k4hkJlp6LTJWby5wv2SMD8RFujrULqmpQ BzNP/37eL4OdmULPuRYn/BR3Hq5iYK4MBslA8oGjtOOZL5LVZ67heT6c60m2h5ygNTlFds2KQB X/E= X-SBRS: 5.1 X-MesageID: 42271885 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:HRN7aaCJLywv6UHlHekp55DYdL4zR+YMi2QD/WoZc3JoW+afkN 2jm+le6AT9jywfVGpltdeLPqSBRn20z+8N3aA6O7C+UA76/Fa5NY0K1/qF/xTMEzDzn9Q86Y 5OaK57YeedMXFbioLA7BC8A5IcxrC8gcWVrMP/61socg1wcaFn6G5Ce2GmO2l7XhNPC5Z8NL f03LslmxOadX4abtu2CxA+NoCpzbD2vanrbhIcCxks5BPmt0LN1JfAHwWFxRBbajtTwN4ZgB D4ujbk7aauuezT8H7h/lLUhq44pPLRjv9KBMmBkaEuW1fRtjo= X-IronPort-AV: E=Sophos;i="5.82,234,1613451600"; d="scan'208";a="42271885" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 2/7] x86/shim: Fix compilation at -Og Date: Mon, 19 Apr 2021 15:01:27 +0100 Message-ID: <20210419140132.16909-3-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20210419140132.16909-1-andrew.cooper3@citrix.com> References: <20210419140132.16909-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) When compiling at -Og: shim.c: In function =E2=80=98write_start_info=E2=80=99: shim.c:288:22: error: =E2=80=98param=E2=80=99 may be used uninitialized i= n this function[-Werror=3Dmaybe-uninitialized] si->store_evtchn =3D param; ~~~~~~~~~~~~~~~~~^~~~~~~ and a slew of knock-on failures. All are caused by xen_hypercall_hvm_get_param(), and presumably insufficient analysis to obse= rve that *value is always written on the ret=3D0 path. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monn=C3=A9 CC: Wei Liu --- xen/arch/x86/pv/shim.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/pv/shim.c b/xen/arch/x86/pv/shim.c index d16c0048c0..a05aaa7bcc 100644 --- a/xen/arch/x86/pv/shim.c +++ b/xen/arch/x86/pv/shim.c @@ -282,7 +282,7 @@ static void write_start_info(struct domain *d) struct cpu_user_regs *regs =3D guest_cpu_user_regs(); start_info_t *si =3D map_domain_page(_mfn(is_pv_32bit_domain(d) ? regs= ->edx : regs->= rdx)); - uint64_t param; + uint64_t param =3D 0; =20 snprintf(si->magic, sizeof(si->magic), "xen-3.0-x86_%s", is_pv_32bit_domain(d) ? "32p" : "64"); @@ -311,8 +311,8 @@ int pv_shim_shutdown(uint8_t reason) struct domain *d =3D current->domain; struct vcpu *v; unsigned int i; - uint64_t old_store_pfn, old_console_pfn =3D 0, store_pfn, console_pfn; - uint64_t store_evtchn, console_evtchn; + uint64_t old_store_pfn =3D 0, old_console_pfn =3D 0, store_pfn =3D 0, = console_pfn =3D 0; + uint64_t store_evtchn =3D 0, console_evtchn =3D 0; long rc; =20 if ( reason !=3D SHUTDOWN_suspend ) --=20 2.11.0 From nobody Fri May 3 05:18:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1618840955; cv=none; d=zohomail.com; s=zohoarc; b=MpAMm03voDQ4o6z+EuhR/8mnPkMXiQkMO8OS7Btvue0KBUu6sA3vX2LiExe2Go0KC1lADew52eEZClsJ8eno1Pz4ogp5v7Ie4nW5A1GMyASQu6WQ3QrKmu8GQuOl49PXK87ETQkgQD/QZaQ7IjJCPqvXJruy2Tc+OyJ7sqVaZLc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618840955; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=6tapKh6d5PHevDu3WRLDEbFh+5q8dSqew9g7ZdxZ0uQ=; b=NgxPmKabGsa8jMW6l5cAenNeNbMrOVZLmTg/gUY3kBlSFSVxLQrJxpYLzaxLXwTuT5VOi+iS6g5Tw6Nrqxb0dc5uCLe3QfhNmO2lh3H+rLqGRcn1p4jEfNOkIX1rbEUkATmhgPhuD6VrDNdW5H2D7rF6K3vR1XVoqPSFz8fdhyo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 161884095560486.97925848718342; Mon, 19 Apr 2021 07:02:35 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.112938.215364 (Exim 4.92) (envelope-from ) id 1lYUTe-0006S3-G8; Mon, 19 Apr 2021 14:02:14 +0000 Received: by outflank-mailman (output) from mailman id 112938.215364; Mon, 19 Apr 2021 14:02:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lYUTe-0006Rv-CA; Mon, 19 Apr 2021 14:02:14 +0000 Received: by outflank-mailman (input) for mailman id 112938; Mon, 19 Apr 2021 14:02:12 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lYUTc-0006QM-Bo for xen-devel@lists.xenproject.org; Mon, 19 Apr 2021 14:02:12 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b13ecffd-e884-429d-bb22-b875312286bf; Mon, 19 Apr 2021 14:02:11 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b13ecffd-e884-429d-bb22-b875312286bf DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1618840931; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=u6xZF4AS6Juh0CnMhBXmEKwxg8OoZ/J9DOH4kfOLJfA=; b=c53hk5+W4kVJ8d4ZUrD7cWHx8i8edF5z4sXmuXo4rGBz++MYLy+RwJn5 Y/ZI8lIix7D9I9dsdVoGpqG8gXotvRLIofGryHP+YGj2bSNs1snLhD6iu XfF4SkKCv2lO4X209PSgpO5PDdQoNbNqSJc5YWv9v3YfFEnzIqx2aMmyq 8=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: NU+hIBYOJW1NTGbSS7SOmO7OVY1i25GCM83QCTxO9ZPCfx8JHafeLE4RGDGTRu8x/LCCSx629+ oAxidGLERL13DGoEsuDuWD4s6YDieuMHtsrGSFtAj9iTeRSboSq7AKde4UNaC42Kqy7Vh5zg/5 qAQ11u/sPWlf1rKj3dPp612g1TRUYn62DsTxrxNUmpX77ZZKRjKorgXexZsuw5oL7mLfpMvBDH 2p+q4KfJPf6HvfTC1+D7vm+LCTK//C7ZgDfMvM47e1MRcwD8sXULqx7s4CHveQ5MZfrLrvFUZG 4sE= X-SBRS: 5.1 X-MesageID: 42017041 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:HA/5Oativ8mr/VQn9PmpCrD17skD89V00zAX/kB9WHVpW+az/v rBoN0w0xjohDENHEw6kdebN6WaBV/a/5h54Y4eVI3SJTXOkm2uMY1k8M/e0yTtcheOkNJ1+K 98f8FFaOHYIkN9ia/BjDWQM9Fl+9Wf9bDtuOG29QYJcShPS4VNqzh0ERyaFEoefnggObMcGI CH7sRK4xqMEE5nDfiTPXUOU+jdq9CjrvuPCnRqOzcd5AaDlj+u4rLheiLouis2aD9T3awktV HMjg2R3NTaj9iA1hTe22XPhq42pPLdzLJ4a/Cku4wwIjXohh3AXvUCZ4G/ X-IronPort-AV: E=Sophos;i="5.82,234,1613451600"; d="scan'208";a="42017041" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 3/7] x86/sysctl: Make arch_do_sysctl() compile at -Og Date: Mon, 19 Apr 2021 15:01:28 +0100 Message-ID: <20210419140132.16909-4-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20210419140132.16909-1-andrew.cooper3@citrix.com> References: <20210419140132.16909-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) When compiling at -Og: sysctl.c: In function =E2=80=98arch_do_sysctl=E2=80=99: sysctl.c:197:19: error: =E2=80=98hcpu=E2=80=99 may be used uninitialized = in this function[-Werror=3Dmaybe-uninitialized] ret =3D continue_hypercall_on_cpu(0, fn, hcpu); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sysctl.c: In function =E2=80=98arch_do_sysctl=E2=80=99: sysctl.c:197:19: error: =E2=80=98fn=E2=80=99 may be used uninitialized in= this function[-Werror=3Dmaybe-uninitialized] ret =3D continue_hypercall_on_cpu(0, fn, hcpu); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ These look to be caused by insufficient analysis around the !ret conditiona= ls. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monn=C3=A9 CC: Wei Liu --- xen/arch/x86/sysctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/sysctl.c b/xen/arch/x86/sysctl.c index aff52a13f3..6ac09bac79 100644 --- a/xen/arch/x86/sysctl.c +++ b/xen/arch/x86/sysctl.c @@ -150,8 +150,8 @@ long arch_do_sysctl( unsigned int cpu =3D sysctl->u.cpu_hotplug.cpu; unsigned int op =3D sysctl->u.cpu_hotplug.op; bool plug; - long (*fn)(void *); - void *hcpu; + long (*fn)(void *) =3D NULL; + void *hcpu =3D NULL; =20 switch ( op ) { --=20 2.11.0 From nobody Fri May 3 05:18:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1618840942; cv=none; d=zohomail.com; s=zohoarc; b=Jp2K8oAd3jB56CSc+S6M/WXautw8Yg60Esoammg5a5tjvsZLC5pT/dRMeUmlH2OUQcM0+rGk4b8/OpCrkREix8BMxWZuqMuFzUxwRD9csFirV47Lo52T2L2Ttww0U4NNSNCF0XbXx5fUWQuFLnx2bN1Rv6YKkIWD/GLW6OGg8Fc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618840942; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=riRYE/a0UuVO2PBSPxNIXTtwYht0iPznfIetUCsquTc=; b=UtopLTQeFMiczE4hKspvn/SupaLzZnQWKdYqpZZFMlRDwRK0D3me1pJfxvFO/goyStPGovwGv6MrBoyEjcwjokBySL1GjVHXEdaJHxsPKDEAUGEA7KECyts0LjU+mEZmKD/zhPezkDEmFFVCsntD07F6NuK8ueoi3FhJNTScQv8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1618840942178160.03906832869484; Mon, 19 Apr 2021 07:02:22 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.112935.215340 (Exim 4.92) (envelope-from ) id 1lYUTQ-0006Bb-L4; Mon, 19 Apr 2021 14:02:00 +0000 Received: by outflank-mailman (output) from mailman id 112935.215340; Mon, 19 Apr 2021 14:02:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lYUTQ-0006BS-Hh; Mon, 19 Apr 2021 14:02:00 +0000 Received: by outflank-mailman (input) for mailman id 112935; Mon, 19 Apr 2021 14:01:59 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lYUTP-0005yZ-EP for xen-devel@lists.xenproject.org; Mon, 19 Apr 2021 14:01:59 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1a82269e-fe70-47a8-9879-c76ff1e105b8; Mon, 19 Apr 2021 14:01:54 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1a82269e-fe70-47a8-9879-c76ff1e105b8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1618840914; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=6BUv+N6okA8eie29SW3frkmwZ8F2KRqBim4h2q/ANWM=; b=GeVz/Jgr1jzbMApAonIcLm1STwz1KWUlgDq42uy7M5D/C8j0DlGKJtVX S05y4G7ekjxcj9zX5qK/BgCb27ZyrO1AUXScdpaKmqqKPdWXzHd8eTICh HQiUzvx0P44/dbokgHmAne74xL2bLfxV65xDhry5RjPxrDH3w0+Dqr+cm A=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 2gZqkBYH1WeWqjKj9X9QFQDsCYxJLRAsGlWbdyIOlKNIXNu7DPePxXjniCpR4YIUoXnja2wAfv Jhskh1lGM37FwZPP+EUkGDJ7zy5VJMKFwwEneXji6w/KYrdnA+bhuCwYN6I4ZdGF9ddJLigRLJ +PH8GI+FMk8wv7u3MCCaA237dF9bJ2WCye1l3flV1Wnctzh7h/6MExASKBSqPTE7n9XxeZ2jxo t8+9AQZK8z4G+vpOo/8lhibZTPV0chl6qF9J3oz2K6Vi/+5cYHf66jBHaBexhSyRzYxDus12KK nsk= X-SBRS: 5.1 X-MesageID: 42271924 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:JzmgOqEN8ZxqED95pLqFP5HXdLJzesId70hD6mlaTxtJfsuE0/ 2/hfhz726ItB89UGwt8OrhBICuWnXZnKQZ3aAwOvOYUBDiqC+UKuhZnO7f6hnBPwG7yeJHz6 dndMFFeaHNJHx3l9zz7gX9M/tI+qjlzImSie3Tz2hgQGhRAskKhTtRMQqVHlZ7QwNLH/MCZf ihz/BarDmtc2l/VKuGL0QFROTKqpnqk5/rcHc9ZiIP1QiUgTukrIP9ChiTty1xbxpzx94ZnV TtokjQ+rik98q20Abb0HXeq65LgcL7xsFYbfb87fQ9G3HJsEKFdY5hU7qNsHQUp+qo+RIQjN zBuVMEOcJrgkmhGF2dkF/I4U3A2Cxrw2L+wVWY6EGTxfDRdXYfMY59oq53NjHe8FEtudlg1r kj5RPhi7NeEQ7H2D7g7NzJSgxnmyOP0AEfuP9Wi2YaXZoVabdXo4Ba8k9THIwJAS72rIQqCv NnAs2Z/vBLalmXBkqpxFVH0ZipRDA+Dx2GSk8NtoiN2yNbm208y0cD3sQQkjMB+fsGOuF529 g= X-IronPort-AV: E=Sophos;i="5.82,234,1613451600"; d="scan'208";a="42271924" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 4/7] x86/irq: Make create_irq() compile at -Og Date: Mon, 19 Apr 2021 15:01:29 +0100 Message-ID: <20210419140132.16909-5-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20210419140132.16909-1-andrew.cooper3@citrix.com> References: <20210419140132.16909-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) When compiling at -Og: irq.c: In function =E2=80=98create_irq=E2=80=99: irq.c:310:38: error: =E2=80=98desc=E2=80=99 may be used uninitialized in = this function[-Werror=3Dmaybe-uninitialized] desc->arch.creator_domid =3D currd->domain_id; ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~ This diagnostic is bogus, because desc is already read on earlier paths. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monn=C3=A9 CC: Wei Liu --- xen/arch/x86/irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c index a1693f92dd..72b86c6155 100644 --- a/xen/arch/x86/irq.c +++ b/xen/arch/x86/irq.c @@ -264,7 +264,7 @@ void __init clear_irq_vector(int irq) int create_irq(nodeid_t node, bool grant_access) { int irq, ret; - struct irq_desc *desc; + struct irq_desc *desc =3D NULL; =20 for (irq =3D nr_irqs_gsi; irq < nr_irqs; irq++) { --=20 2.11.0 From nobody Fri May 3 05:18:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1618840970; cv=none; d=zohomail.com; s=zohoarc; b=R6UrlKwD9YYPuIbkw1s6ww3PoSJfRD0eKKVg5fpYBYWycC3af/gecWa+iJGdshXkLhzW9HK83TMullDyJIHMth088s7XHIVBSrbzfbEzc62I0j2nSwLLw43uiRxoq+wnk5+DlazuouX2570O3t3+qznoEPGkrRYOmlRxE0G42kA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618840970; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=nKKOi55kx/hXQC2ez5pPjH7Mw7KVNo7o7qefDWraGO8=; b=KeDQCchV+lwz+niSvVue9+EGhLPhunYSDrFW2e6SgLRR045IIYOyKRmwsihdsABgpm0aSaZKXrfToXPzRanhZxkOpWtYcxtVoMXzad8tNZg4bsTfSheDxN00WZ51Q2Gdbomj1AaQYRthMOJAzDTkwZyHsvE2glAe0qkz/cYmZ1A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1618840970484286.15142393980784; Mon, 19 Apr 2021 07:02:50 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.112934.215328 (Exim 4.92) (envelope-from ) id 1lYUTO-00068V-BA; Mon, 19 Apr 2021 14:01:58 +0000 Received: by outflank-mailman (output) from mailman id 112934.215328; Mon, 19 Apr 2021 14:01:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lYUTO-00068L-7g; Mon, 19 Apr 2021 14:01:58 +0000 Received: by outflank-mailman (input) for mailman id 112934; Mon, 19 Apr 2021 14:01:56 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lYUTM-00061N-7t for xen-devel@lists.xenproject.org; Mon, 19 Apr 2021 14:01:56 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3d8c9cff-9d38-4858-b45b-5293e1ff64da; Mon, 19 Apr 2021 14:01:51 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3d8c9cff-9d38-4858-b45b-5293e1ff64da DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1618840911; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=WbuAM+uwsh6c1saV41wYeADSZOzR/5RKAn88if8bPyM=; b=A8pT1l5vjedITgUCkmCs9lPQ4pVvKscfCeN/F2Ve4eRuD7lrqco60qae hDxc4njU+pwSf3JbF29KVzQlredxfGcGCcN0rCHZcfgaltrh1iuDzsbsO fhb1sCQBNUD7gIrf6YtJ11JtXLKnasLnbKQUjMvHEH3AAJonmMbgVuooM I=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: P6yr2jg8xyhDuopW+En6ofy7BsjwOLPEi/Ca3SB/Td7eg3ZR5tda6w7jBiEIQJOYR72MSpS4Dt 7nqi6xygM0kS6eqqRCjGgcPgLKUiGMevz9omQE4ZagNdRcUL6U0u/cZJFSbbXNXxKXU8GmGjPb CBZIFcJhvgLoub85fN79EewHu6uMkCWxV11uwWrLYJcz+qbgJo1NAwb6J4cATgihCjEm0L8cNP bsWmSemPxSINgi443qDy5TPpCk0NXXviH+Vg8gmrxC37em49CfsjhwbF43d8WqCCyxmhCoo/Yi laM= X-SBRS: 5.1 X-MesageID: 41892062 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:0KAQoKB9VSieYVLlHeh+sceALOonbusQ8zAX/mhsVB1YddGZnc iynPIdkST5kioVRWtIo729EYOLKEm9ybde544NMbC+GDT3oWfAFvAH0aLO4R3FXxf/+OlUyL t6f8FFYuHYIFBmga/BjzWQPM0nxLC8npyAocf74zNTQRpxa6dmhj0JbzqzNkFtXgFJCd4YOf Onl6l6jgGtc3gWcci3b0NtN4T+jubGiY78Zlo+DwMngTPksRqT9LX4HxKEty1uMQ9n/LFKyw n4uj283IqPmbWRyhjQ12jchq4m5efJ+594K+GnzuQQIjXooA60aIpmQK3qhkFInMifrGwEvf OJjxA8P9liy365RBDLnTLdnzPO/Rxry3j+xUSWiXHuyPaJOg4SOo56qq9yNj76gnBQ2+1U4e Zw8E+y86dzN1fmmh/w4tDZPisa7XackD4ZvsM4y0BEXZB2Us42kaUvuHl7Pb0nByzA5IUuAI BVfbvhzccTS1+cYnzD11MfueCEbzA2FheCdEAIptaY5ThQhGx41EsV3qUk7w89yK4= X-IronPort-AV: E=Sophos;i="5.82,234,1613451600"; d="scan'208";a="41892062" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich Subject: [PATCH 5/7] xen/efi: Make efi_start() compile at -Og Date: Mon, 19 Apr 2021 15:01:30 +0100 Message-ID: <20210419140132.16909-6-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20210419140132.16909-1-andrew.cooper3@citrix.com> References: <20210419140132.16909-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 X-ZohoMail-DKIM: pass (identity @citrix.com) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When compiling at -Og: boot.c: In function 'efi_start': boot.c:1339:9: error: 'argc' may be used uninitialized in this function [= -Werror=3Dmaybe-uninitialized] 1339 | efi_arch_handle_cmdline(argc ? *argv : NULL, options, nam= e.s); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~= ~~~~ although this appears to be limited to the ARM build only. It also seems to be bogus, because it is immediately preceding by a read of argc which doesn= 't yield a diagnostic. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich --- CC: Jan Beulich --- xen/common/efi/boot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c index 63e289ab85..f1e7a5267c 100644 --- a/xen/common/efi/boot.c +++ b/xen/common/efi/boot.c @@ -1126,7 +1126,7 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *S= ystemTable) static EFI_GUID __initdata shim_lock_guid =3D SHIM_LOCK_PROTOCOL_GUID; EFI_LOADED_IMAGE *loaded_image; EFI_STATUS status; - unsigned int i, argc; + unsigned int i, argc =3D 0; CHAR16 **argv, *file_name, *cfg_file_name =3D NULL, *options =3D NULL; UINTN gop_mode =3D ~0; EFI_SHIM_LOCK_PROTOCOL *shim_lock; --=20 2.11.0 From nobody Fri May 3 05:18:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1618840937; cv=none; d=zohomail.com; s=zohoarc; b=b404KR43iOiInekd6CzkJNgKAhvees0X2kMteceG3X5ACL5Out5pNiRapROI839/SdVm86QL8jLUJoUW7dfZQd0eruqBtgkz1Jnmmi4xpKhyHnhtJ3+q+E4FhlC8AYMlgS0I2L3D8RcsVtasm3gI8dfByr8icxsCem4sYf3ZbZ4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618840937; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ZwfJRpfteD6/eLvz4r1eW3t22vJU4TQCIfFEVc2G0Ew=; b=oC3e0UExLvLSUDB61Uod9kHpep2rMHxb1AbEUlp53/2lt/IZ2EHb5dEh7DqLB2PyCmgMaFd/5wNYuNn42/MLBbyXwERML807W3N5Rb/gnSc75jlxXrZRJx3bR/uVti74YO4y2qIUJvZcNqVynKaIhudMjqw3I2byKPCXKHXsKds= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1618840937403596.9763451910159; Mon, 19 Apr 2021 07:02:17 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.112936.215352 (Exim 4.92) (envelope-from ) id 1lYUTS-0006FW-Vb; Mon, 19 Apr 2021 14:02:02 +0000 Received: by outflank-mailman (output) from mailman id 112936.215352; Mon, 19 Apr 2021 14:02:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lYUTS-0006FK-S2; Mon, 19 Apr 2021 14:02:02 +0000 Received: by outflank-mailman (input) for mailman id 112936; Mon, 19 Apr 2021 14:02:01 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lYUTR-00061N-8E for xen-devel@lists.xenproject.org; Mon, 19 Apr 2021 14:02:01 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 665d3f7c-ab3f-4023-ab3e-e0dc9239117f; Mon, 19 Apr 2021 14:01:51 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 665d3f7c-ab3f-4023-ab3e-e0dc9239117f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1618840911; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=1jko2KVCpjzrndGXx0YAEFP0pnOv6quT6EsQagA40cw=; b=AHNLTHPdaI0BZhchszAI9lV3MSwZnS1EHxVEMnuKJ1dbjjVOjtDe13xN KVGH7CR/b06qQHkvbScwNhkRNNzCb/K3ck14hpyd0VUCctHMwPBuCCQvt BhBTpAdAlXyJtNBNlGeDM4TZpetbBL0X5YBtd+WHgw8reWjFJflqSTy/W c=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 4dw8FPQQdflBDRcafRhL0AdCLPex3/yZ9EWa56O9Ip9Lx67CF9Puw1pAF6geEP8bZYpRBLFagD EsRqPZHTaZGt0poXjK79QmTWY611BSqyBKPxwQVNz00N4ZC8TbwXPtKvXLJdQYaOAJdq1c3w2N BdUSskXTOvp9ormIvJY2RFppqJZko8MdrmOghVKlRYu90jU/QufkCWG05Tig5pCsCeymO9MLfR Ga34BGL+ZeB+xtr2nmbtAsVPFsn/6VEVal/O1nTKxjq1Ake/zQQSUpDPPEKY743ab6EOGIvHpf +VI= X-SBRS: 5.1 X-MesageID: 41892066 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:t6oF1qgSpEjUF7F8VFLowa1vMHBQXwh13DAbvn1ZSRFFG/Gwv9 yynfgdyB//gCsQXnZlotybJKycWxrnmKJdy4N5B9efdSPhv3alK5wn0Jv6z1TbaknD38N+9Y MlSahxD9XsEUN35PyR3CCUG8stqePpzImGnuHbpk0CcShPS4VNqzh0ERyaFEoefngiObMcGI CH7sRK4xqMEE5nDfiTPXUOU+jdq9CjrvuPDSIuPBI79BKIyQqh9b+SKXOl9y0DWDBCy6pKyx mmryXF4MyY0s2T+1vn+EL4q79Xn9bgzdUrPr3wtuElbg/CpyztSIBoW7iptC04rue1+D8R4a XxiiZlBetfwTf8eXy0vAvM1mDboUkTwk6n83C0qz/CptH0Xz0zAcYpv/MmTjLpr3AOkfs59Y Aj5RP/i7NnSSnusQ642v3zEzZtrUawqWpKq59ps1VvFbEwRZUUkZYS5ypuYfE9NRO/0q8LOs 90AvrR4f5HGGnqFUzxjy1UzNugUm9bJGb+fmEy/sic0z1hlHtk1UcvxMsGgnca9J4mIqM0n9 j5Dg== X-IronPort-AV: E=Sophos;i="5.82,234,1613451600"; d="scan'208";a="41892066" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Tim Deegan , "Jan Beulich" , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 6/7] x86/shadow: Make _shadow_prealloc() compile at -Og Date: Mon, 19 Apr 2021 15:01:31 +0100 Message-ID: <20210419140132.16909-7-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20210419140132.16909-1-andrew.cooper3@citrix.com> References: <20210419140132.16909-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) When compiling at -Og: In file included from /builds/xen-project/people/andyhhp/xen/xen/include/asm/domain.h:4:0, from /builds/xen-project/people/andyhhp/xen/xen/include/= xen/domain.h:8, from /builds/xen-project/people/andyhhp/xen/xen/include/= xen/sched.h:11, from /builds/xen-project/people/andyhhp/xen/xen/include/= xen/ioreq.h:22, from common.c:23: common.c: In function '_shadow_prealloc': /builds/xen-project/people/andyhhp/xen/xen/include/xen/mm.h:252:55: error= : 't' may be used uninitialized in this function [-Werror=3Dmaybe-uninitial= ized] return page !=3D head->next ? pdx_to_page(page->list.prev) : NULL; ^ common.c:933:28: note: 't' was declared here struct page_info *sp, *t; ^ I'm not certain the analysis is correct. 't' is a temporary variable, and = is clearly initialised before use in foreach_pinned_shadow(). Either way, initialising it to NULL placates the compiler. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Acked-by: Tim Deegan --- CC: Tim Deegan CC: Jan Beulich CC: Roger Pau Monn=C3=A9 CC: Wei Liu --- xen/arch/x86/mm/shadow/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/mm/shadow/common.c b/xen/arch/x86/mm/shadow/commo= n.c index b99ca14e71..737e6b365a 100644 --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -931,7 +931,7 @@ static inline void trace_shadow_prealloc_unpin(struct d= omain *d, mfn_t smfn) static void _shadow_prealloc(struct domain *d, unsigned int pages) { struct vcpu *v; - struct page_info *sp, *t; + struct page_info *sp, *t =3D NULL; mfn_t smfn; int i; =20 --=20 2.11.0 From nobody Fri May 3 05:18:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1618840931; cv=none; d=zohomail.com; s=zohoarc; b=mzfhEJDjcyH5bibioqY9ZvAo9Q1wNuIkbtsjzB7L2ysdVAXN9qq8fwkJZn9eXucVMCR4LsVV2qAnFhfZljozuGsMEUJLYAXakaZFqyrHEaUlTJvrqj79XuF/pPKA5UBSHHqTYzJ0yEcQ1BtAy/sQLWEq5cGAoVnHs+A8wuoF0H4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618840931; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qeFMoMtMpYcesHpbbE0ZmemtTt3Jg0dhAQZjvxwYQZE=; b=PxtMTja3jN1nWwtLRveNLkCYxa5M9rEkL8AVsnIRB7s3dMCw3gm0+1iNDaCPZkbAK+DyWtlEw8D82UnUtgSP9xFYtF3B/4TFUWDvQHfL8f2GbRuJG64sCaRBcmaZF0vOGgowgaPQNMnO0/x+JHu9EHut9YfZfiYWSCgGS3p2hDI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1618840931002443.85609243375654; Mon, 19 Apr 2021 07:02:11 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.112932.215304 (Exim 4.92) (envelope-from ) id 1lYUTI-00062Q-P4; Mon, 19 Apr 2021 14:01:52 +0000 Received: by outflank-mailman (output) from mailman id 112932.215304; Mon, 19 Apr 2021 14:01:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lYUTI-00062H-LC; Mon, 19 Apr 2021 14:01:52 +0000 Received: by outflank-mailman (input) for mailman id 112932; Mon, 19 Apr 2021 14:01:51 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lYUTH-00061N-Ga for xen-devel@lists.xenproject.org; Mon, 19 Apr 2021 14:01:51 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ecb8b980-4f33-41e0-a0f6-492d4d5acdf7; Mon, 19 Apr 2021 14:01:49 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ecb8b980-4f33-41e0-a0f6-492d4d5acdf7 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1618840909; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=TA5ZKAuUwi4CHsYgJ25Kg8HIPW9/JmPHtVST3zPieb0=; b=cDQ75ETNDtCEjGA/sxnJFDdZxJPCtjwZp16m6/C1FAU9obRRxsDPfzgF /dNHaW70bpSu+iw1v+Qev1MzzcwDtnnCJx8QqXdb50tQ05VsdQO+lAFXJ J/aoc9++NPMReO/XYUytwMj2/YMsRUmKkbBvz2iCkCM1XcN8EIe2WESDc 8=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: nKAw0paORZWMn2xzxBZJ2gUU4K0T24s3gCftZ+WLUFp7Wc7pFBsBftdOgcZEd9J0sgnBF31DiR SSIyoOJ4OQ/xIwm/ShX4wGAFGRFnhtH2svdemK1CK9cBWQqxtrFhKq5waGiPTf81k3ZyfsRusH EIm0FKVkByrusRU7vH4wKhyEvIbfkP5GP8E6AgC6NUMO2JYXfGKoGsJPYDiIHPin0YZFvMHqjO AC/ApiRRfIvXlLFENcv6m5ExEpvGhVW4r2ZbKikcRreLDiilHvpK33F4BQbYJ1NZaXLavKNV6D E5s= X-SBRS: 5.1 X-MesageID: 41892058 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:Rd5jdKopNcXHAQ2UlMnTX4YaV5u6KtV00zAX/kB9WHVpW+SivY SHgOkb2RjoiDwYRXEnnpS6NLOdRG7HnKQZ3aA4Bp3neAX9omOnIMVZ7YXkyyD9ACGWzIRg/I 9aWexFBNX0ZGIQse/T6gO1Cstl5dGB/ryhi+u29QYUcShBbaZ84wBlTiOSFUNrTAdLbKBJb6 a0zMxBujamZDArft22b0N1FNTriv/qsNbdYRAADwM68wXmt1+VwZPzDhTw5GZ7bxph2rEnmF KlryXY4eGZv+i/2lvg0Qbonu1rsf/A7vcGO8CWkMgSLVzX+0yVTaBsQaeLsjxwgMzH0idMrP D2rx0tP9t+5hrqFwnbzyfF4AXu3C0j7HXv0zaj8B3eiPbkTzE3Adcpv/M7TjLl6lEttNw58K VH03PxjeszMTr8nT/w79WNahdylkDcmwtBrccviRVkMbc2Wft0l8gy7UlVGJAPEGbR84Y8Ct RjC8na+bJ/bU6aR2qxhBgi/PWcGlAIWjuWSEkLvcKYlxJMmmpi8kcezMsD2l8d6ZMGTYVe7e isCNUmqJh+CustKY5tDuYIRsW6TkbXRwjXDW6UKVP7UIYKJmzKsJyyxLku/umldNgpwfIJ6d r8eWIdkVR3V1PlCMWI0pEO2AvKWn+BUTPkzdwb6IN+vrH6Wbr3ISyOQF0jiKKb0rUiK/yef8 z2FINdAvflI2erM51OxRfCV55bLmRbUMB9gKd5Z3u+5ubwbqH6vO3Sd/jeYJD3Fyw/Z2/5Cn wfGDz6JMBK6FG3Smb16SKhGU/FSwjax9ZdAaLa9+8cxMwmLYtXqDUYjly/+4WMMj1Nsqs/eU NkO7P5mqanpW27lFy4rllBC154NAJ48b/gW3RFqUshKEXva4sOvN2ZZCRPxnedPwR+SMnXCQ ZboFxy9cuMXtmt7BFnL+jiHnORjnMVqn7PcowVnbeb49z5PrkiCIw9ZaB3HQLXNhB8lApwsl 1fYAscSkK3LEKrtYyVyLgvQMDWbZ1VnRqiK888kwOkiWys4eUUAkY9cxHre8iNmgoqTydTnT RKgtIiqYvFvy2uJ2s5iPk/K3tWZg2scf97JQyYeYRZna3qcglsTWGMwSeXkQ03Z3CCzTRvuk XxaSKTYv3FGVxbpzRR1bvr6kp9ciGHc1t3cW0Si/wKKU3W/nJy2/SMfKy9zi+YbUYD2PgUNF j+EE8vCxIrw9C8zxiOnjmeUX0g25U1J+TYSLAuaava1H/oKIqGk8g9bohp1YcgMNDlqekQV+ 2DPweTMTPjEussnxWPuWxNAlgGlFA01ffznBH15mmx23AyRfLUPVR9XrkeZ9WR9XLtSfqE2I hw5OhF9NeYIyH0cJqL2KvXZzlMJlfIrWm6Q/ohpJpUsagx3YEDaqXzQH/NzjVKzR8+JMD7mA cCW6x9+qnGIZIqcMoIeS5Vl2BZ3OinPQ8uqEjxDeA/d1120COeMNON/rbSqb0gRkeGvxD9PF GD8ytbu/fJNhHzpIIyGuY1OyBRbkN59XFpuOWFfIfUAB+xd+5C8EGhW0XNAoN1WeyAA/EIsh 1+49uUhOeZeCrzxRDIsVJAU9xz2nfiRdn3HRmFFuFJ+cGrIFiAgqOl58iokTf8IAHLG3gwlM lCbkwfbsNKlzkkgsk2y0GJO9PKnn4= X-IronPort-AV: E=Sophos;i="5.82,234,1613451600"; d="scan'208";a="41892058" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Juergen Gross Subject: [PATCH 7/7] xen: Use -Og for debug builds when available Date: Mon, 19 Apr 2021 15:01:32 +0100 Message-ID: <20210419140132.16909-8-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20210419140132.16909-1-andrew.cooper3@citrix.com> References: <20210419140132.16909-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) The recommended optimisation level for debugging is -Og, and is what tools such as gdb prefer. In practice, it equates to -01 with a few specific optimisations turned off. While the use of gdb isn't necessarily very helpful for Xen, the disassembly will have fewer structural transformations vs C, and therefore will be easi= er to follow. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monn=C3=A9 CC: Wei Liu CC: Stefano Stabellini CC: Julien Grall CC: Volodymyr Babchuk CC: Juergen Gross Successful CI runs: https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/287769787 https://cirrus-ci.com/build/5086280275984384 --- xen/Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/xen/Makefile b/xen/Makefile index 9f3be7766d..128de93f5e 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -195,7 +195,9 @@ include/config/%.conf include/config/%.conf.cmd: $(KCON= FIG_CONFIG) $(MAKE) $(kconfig) syncconfig =20 ifeq ($(CONFIG_DEBUG),y) -CFLAGS +=3D -O1 +# Use -Og if available, -O1 otherwise +dbg_opt_level :=3D $(call cc-option,$(CC),-Og,-O1) +CFLAGS +=3D $(dbg_opt_level) else CFLAGS +=3D -O2 endif --=20 2.11.0