From nobody Mon May 20 17:16:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1618391687; cv=none; d=zohomail.com; s=zohoarc; b=BXzUKBmHipubD+7/R9RqzBGZPdJKiegMqzyvKQkM32/+43a5xxzZNFIRLiNoIKwohLCvnSd4yjileYaM9TmR4+TrW5f9iN7nIDzNnF5q60lOmeDc97daJ2TINdG7AS/k2YTs5cJl1cdRzhjITSDh6moQMlbgEyds7wniPMkIO0s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618391687; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=bSeKlDb30JAldFdk/+aD+FyWZ3+xRXsZfzZQ6/fBf48=; b=hv2SzqZOQ5ObC90/OGIfMAKQ199sN47a/RyI7jIRJey2JCnvswVDB8N314b1UpQ6Zh8GBWAE+P4viAJzaZgjzbsygZfR4tq6hyccz8SS5CLXkQeCZ5swyi+AfFRg0il3tYzuQ9zWuz016wjJvIoFEKfeloYGfB4NjZ8HP3uy8Bk= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1618391687425748.4383820146005; Wed, 14 Apr 2021 02:14:47 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.110389.210694 (Exim 4.92) (envelope-from ) id 1lWbbM-0000Y6-9n; Wed, 14 Apr 2021 09:14:24 +0000 Received: by outflank-mailman (output) from mailman id 110389.210694; Wed, 14 Apr 2021 09:14:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lWbbM-0000Xy-6l; Wed, 14 Apr 2021 09:14:24 +0000 Received: by outflank-mailman (input) for mailman id 110389; Wed, 14 Apr 2021 09:14:22 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lWbbK-0000WW-8U for xen-devel@lists.xenproject.org; Wed, 14 Apr 2021 09:14:22 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id c7d372f0-ac64-4c8b-be3c-a9fe2ab04792; Wed, 14 Apr 2021 09:14:16 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id ED49111D4; Wed, 14 Apr 2021 02:14:15 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.197.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 12AE63F73B; Wed, 14 Apr 2021 02:14:14 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c7d372f0-ac64-4c8b-be3c-a9fe2ab04792 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH v4 1/4] xen/arm: Move dom0 creation in domain_build.c Date: Wed, 14 Apr 2021 10:14:01 +0100 Message-Id: <20210414091404.14215-2-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210414091404.14215-1-luca.fancellu@arm.com> References: <20210414091404.14215-1-luca.fancellu@arm.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Move dom0 create and start from setup.c to a dedicated function in domain_build.c. With this change, the function construct_dom0() is not used outside of domain_build.c anymore. So it is now a static function. No functional changes intended. Signed-off-by: Luca Fancellu Reviewed-by: Julien Grall Reviewed-by: Bertrand Marquis --- v4 changes: - changes to the commit message v3 changes: - move create_dom0 function after construct_dom0 and make construct_dom0 static --- xen/arch/arm/domain_build.c | 38 ++++++++++++++++++++++++++++++++++++- xen/arch/arm/setup.c | 29 +--------------------------- xen/include/asm-arm/setup.h | 2 +- 3 files changed, 39 insertions(+), 30 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 374bf655ee..359957dc1b 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -21,6 +21,7 @@ #include #include #include +#include #include #include #include @@ -2520,7 +2521,7 @@ void __init create_domUs(void) } } =20 -int __init construct_dom0(struct domain *d) +static int __init construct_dom0(struct domain *d) { struct kernel_info kinfo =3D {}; int rc; @@ -2578,6 +2579,41 @@ int __init construct_dom0(struct domain *d) return construct_domain(d, &kinfo); } =20 +struct domain* __init create_dom0(void) +{ + struct domain *dom0; + struct xen_domctl_createdomain dom0_cfg =3D { + .flags =3D XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap, + .max_evtchn_port =3D -1, + .max_grant_frames =3D gnttab_dom0_frames(), + .max_maptrack_frames =3D -1, + }; + + /* The vGIC for DOM0 is exactly emulating the hardware GIC */ + dom0_cfg.arch.gic_version =3D XEN_DOMCTL_CONFIG_GIC_NATIVE; + /* + * Xen vGIC supports a maximum of 992 interrupt lines. + * 32 are substracted to cover local IRQs. + */ + dom0_cfg.arch.nr_spis =3D min(gic_number_lines(), (unsigned int) 992) = - 32; + if ( gic_number_lines() > 992 ) + printk(XENLOG_WARNING "Maximum number of vGIC IRQs exceeded.\n"); + dom0_cfg.arch.tee_type =3D tee_get_type(); + dom0_cfg.max_vcpus =3D dom0_max_vcpus(); + + if ( iommu_enabled ) + dom0_cfg.flags |=3D XEN_DOMCTL_CDF_iommu; + + dom0 =3D domain_create(0, &dom0_cfg, true); + if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) =3D=3D NULL) ) + panic("Error creating domain 0\n"); + + if ( construct_dom0(dom0) !=3D 0) + panic("Could not set up DOM0 guest OS\n"); + + return dom0; +} + /* * Local variables: * mode: C diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 2532ec9739..b405f58996 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -51,7 +51,6 @@ #include #include #include -#include #include #include =20 @@ -805,12 +804,6 @@ void __init start_xen(unsigned long boot_phys_offset, const char *cmdline; struct bootmodule *xen_bootmodule; struct domain *dom0; - struct xen_domctl_createdomain dom0_cfg =3D { - .flags =3D XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap, - .max_evtchn_port =3D -1, - .max_grant_frames =3D gnttab_dom0_frames(), - .max_maptrack_frames =3D -1, - }; int rc; =20 dcache_line_bytes =3D read_dcache_line_bytes(); @@ -965,27 +958,7 @@ void __init start_xen(unsigned long boot_phys_offset, enable_errata_workarounds(); =20 /* Create initial domain 0. */ - /* The vGIC for DOM0 is exactly emulating the hardware GIC */ - dom0_cfg.arch.gic_version =3D XEN_DOMCTL_CONFIG_GIC_NATIVE; - /* - * Xen vGIC supports a maximum of 992 interrupt lines. - * 32 are substracted to cover local IRQs. - */ - dom0_cfg.arch.nr_spis =3D min(gic_number_lines(), (unsigned int) 992) = - 32; - if ( gic_number_lines() > 992 ) - printk(XENLOG_WARNING "Maximum number of vGIC IRQs exceeded.\n"); - dom0_cfg.arch.tee_type =3D tee_get_type(); - dom0_cfg.max_vcpus =3D dom0_max_vcpus(); - - if ( iommu_enabled ) - dom0_cfg.flags |=3D XEN_DOMCTL_CDF_iommu; - - dom0 =3D domain_create(0, &dom0_cfg, true); - if ( IS_ERR(dom0) || (alloc_dom0_vcpu0(dom0) =3D=3D NULL) ) - panic("Error creating domain 0\n"); - - if ( construct_dom0(dom0) !=3D 0) - panic("Could not set up DOM0 guest OS\n"); + dom0 =3D create_dom0(); =20 heap_init_late(); =20 diff --git a/xen/include/asm-arm/setup.h b/xen/include/asm-arm/setup.h index 28bf622aa1..5283244015 100644 --- a/xen/include/asm-arm/setup.h +++ b/xen/include/asm-arm/setup.h @@ -93,8 +93,8 @@ void acpi_create_efi_mmap_table(struct domain *d, =20 int acpi_make_efi_nodes(void *fdt, struct membank tbl_add[]); =20 -int construct_dom0(struct domain *d); void create_domUs(void); +struct domain* create_dom0(void); =20 void discard_initial_modules(void); void fw_unreserved_regions(paddr_t s, paddr_t e, --=20 2.17.1 From nobody Mon May 20 17:16:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1618391690; cv=none; d=zohomail.com; s=zohoarc; b=EvdCpPqj70nIDhre/g0+DuLbD5OUUqCGCpFNoqwaF1X2PbyXLvGM6E4fuFQBFnqGONwlamW5AuGnb3a1osAB1afsqZyV0BwjnlA35PaCDbxupp+z3gBsTnL+TuZBGwk9iw9BO5ElWfTbrjj2mwyMl9gdOHQEFH3KgBbrrg1oR/Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618391690; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=8LbwDrxk7r6XRDjGyv83Kkf6RZ60Ws/rWz9IT1z/T/Y=; b=JPZwzbTKMIfe1F117bIjs+zYPcKDOmv8UdN664fgYyH7Fs4CfVFS7KsLca+fCmg+Kb5ePpprWwNanW1jH4NlTpPdmtTAGQSSeo2CGqVLxqHfnKOtMCkZkdPDE3kdmcAHmAip0c1cV4QZTFYSvipczRPodelrD0EoMvZr0LjiF2E= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1618391690016520.3513313934963; Wed, 14 Apr 2021 02:14:50 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.110390.210706 (Exim 4.92) (envelope-from ) id 1lWbbQ-0000am-K3; Wed, 14 Apr 2021 09:14:28 +0000 Received: by outflank-mailman (output) from mailman id 110390.210706; Wed, 14 Apr 2021 09:14:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lWbbQ-0000ad-GV; Wed, 14 Apr 2021 09:14:28 +0000 Received: by outflank-mailman (input) for mailman id 110390; Wed, 14 Apr 2021 09:14:27 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lWbbP-0000WW-8g for xen-devel@lists.xenproject.org; Wed, 14 Apr 2021 09:14:27 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 92e6865c-ce27-4444-8413-6449d678ba19; Wed, 14 Apr 2021 09:14:17 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2E04811FB; Wed, 14 Apr 2021 02:14:17 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.197.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2C1883F73B; Wed, 14 Apr 2021 02:14:16 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 92e6865c-ce27-4444-8413-6449d678ba19 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Rahul Singh Subject: [PATCH v4 2/4] xen/arm: Handle cases when hardware_domain is NULL Date: Wed, 14 Apr 2021 10:14:02 +0100 Message-Id: <20210414091404.14215-3-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210414091404.14215-1-luca.fancellu@arm.com> References: <20210414091404.14215-1-luca.fancellu@arm.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Among the common and arm codebase there are few cases where the hardware_domain variable is checked to see if the current domain is equal to the hardware_domain, change this cases to use is_hardware_domain() function instead. Signed-off-by: Luca Fancellu Reviewed-by: Bertrand Marquis --- v4 changes: - removed unneeded check for domain NULL from is_hardware_domain introduced in v3 v3 changes: - removed unneeded parenthesis for macro is_domain_direct_mapped - is_hardware_domain() checks for the passed domain and if it is NULL, it returns false. - reverted back checks in the function late_hwdom_init --- xen/arch/arm/irq.c | 2 +- xen/drivers/passthrough/arm/ipmmu-vmsa.c | 2 +- xen/drivers/passthrough/arm/smmu-v3.c | 2 +- xen/drivers/passthrough/arm/smmu.c | 2 +- xen/include/asm-arm/domain.h | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c index b71b099e6f..b761d90c40 100644 --- a/xen/arch/arm/irq.c +++ b/xen/arch/arm/irq.c @@ -412,7 +412,7 @@ bool is_assignable_irq(unsigned int irq) */ bool irq_type_set_by_domain(const struct domain *d) { - return (d =3D=3D hardware_domain); + return is_hardware_domain(d); } =20 /* diff --git a/xen/drivers/passthrough/arm/ipmmu-vmsa.c b/xen/drivers/passthr= ough/arm/ipmmu-vmsa.c index aef358d880..8b8e3a00ba 100644 --- a/xen/drivers/passthrough/arm/ipmmu-vmsa.c +++ b/xen/drivers/passthrough/arm/ipmmu-vmsa.c @@ -1168,7 +1168,7 @@ static int ipmmu_reassign_device(struct domain *s, st= ruct domain *t, int ret =3D 0; =20 /* Don't allow remapping on other domain than hwdom */ - if ( t && t !=3D hardware_domain ) + if ( t && !is_hardware_domain(t) ) return -EPERM; =20 if ( t =3D=3D s ) diff --git a/xen/drivers/passthrough/arm/smmu-v3.c b/xen/drivers/passthroug= h/arm/smmu-v3.c index 53d150cdb6..d115df7320 100644 --- a/xen/drivers/passthrough/arm/smmu-v3.c +++ b/xen/drivers/passthrough/arm/smmu-v3.c @@ -3366,7 +3366,7 @@ static int arm_smmu_reassign_dev(struct domain *s, st= ruct domain *t, int ret =3D 0; =20 /* Don't allow remapping on other domain than hwdom */ - if (t && t !=3D hardware_domain) + if ( t && !is_hardware_domain(t) ) return -EPERM; =20 if (t =3D=3D s) diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/a= rm/smmu.c index 3e8aa37866..932fdfd6dd 100644 --- a/xen/drivers/passthrough/arm/smmu.c +++ b/xen/drivers/passthrough/arm/smmu.c @@ -2670,7 +2670,7 @@ static int arm_smmu_reassign_dev(struct domain *s, st= ruct domain *t, int ret =3D 0; =20 /* Don't allow remapping on other domain than hwdom */ - if (t && t !=3D hardware_domain) + if ( t && !is_hardware_domain(t) ) return -EPERM; =20 if (t =3D=3D s) diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h index 1da90f207d..0a74df9931 100644 --- a/xen/include/asm-arm/domain.h +++ b/xen/include/asm-arm/domain.h @@ -30,7 +30,7 @@ enum domain_type { #endif =20 /* The hardware domain has always its memory direct mapped. */ -#define is_domain_direct_mapped(d) ((d) =3D=3D hardware_domain) +#define is_domain_direct_mapped(d) is_hardware_domain(d) =20 struct vtimer { struct vcpu *v; --=20 2.17.1 From nobody Mon May 20 17:16:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1618391687; cv=none; d=zohomail.com; s=zohoarc; b=BEiFYFj2D3RtFJMeDsLfcF3mtofyE+I5pwVF86oGeSIkp7eTwbBmRcAgX3+KfRatww+tY8HNyQWCAvwesyMKO7dUF30o9d/RJ0UVJtpGxOxz9z4+OHCF8QoXKnXmMaAjV6zqRjyoYM2L04ZZey6J4HMOkIDP6Ft4/9tXnEUDhUc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618391687; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=kEh9nnPRdfEmcbLlaJBAOR5nBlZa0mem9K6ZUgmQ1/E=; b=B2DsvHpubvkDQbgGwimyyNj7rB6H4SJ6yZ4lR6I6UgeGBLya5rmrWqKv2fBucV4IZXSk5uyBO9mLcRfef2c9VY4x4R/nvoLRa0jfZp8F53xCO8hCqrx8+w8mk+l4PQ5e4P6ZHDoDTAN5kutgnI9stNMv81V/svT1xTF385r+ghE= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1618391687459275.54960517183963; Wed, 14 Apr 2021 02:14:47 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.110391.210718 (Exim 4.92) (envelope-from ) id 1lWbbV-0000f6-Ty; Wed, 14 Apr 2021 09:14:33 +0000 Received: by outflank-mailman (output) from mailman id 110391.210718; Wed, 14 Apr 2021 09:14:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lWbbV-0000ex-Q5; Wed, 14 Apr 2021 09:14:33 +0000 Received: by outflank-mailman (input) for mailman id 110391; Wed, 14 Apr 2021 09:14:32 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lWbbU-0000WW-8i for xen-devel@lists.xenproject.org; Wed, 14 Apr 2021 09:14:32 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 0ce19af9-f6a3-457b-b6d4-ff9b5050315a; Wed, 14 Apr 2021 09:14:18 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 461DF11B3; Wed, 14 Apr 2021 02:14:18 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.197.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 605463F73B; Wed, 14 Apr 2021 02:14:17 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0ce19af9-f6a3-457b-b6d4-ff9b5050315a From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH v4 3/4] xen/arm: Clarify how the domid is decided in create_domUs() Date: Wed, 14 Apr 2021 10:14:03 +0100 Message-Id: <20210414091404.14215-4-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210414091404.14215-1-luca.fancellu@arm.com> References: <20210414091404.14215-1-luca.fancellu@arm.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This patch adds a comment in create_domUs() right before domain_create() to explain the importance of the pre-increment operator on the variable max_init_domid, to ensure that the domid 0 is allocated only during start_xen() function by the create_dom0() and not on any other possible code path to the domain_create() function. Signed-off-by: Luca Fancellu Acked-by: Julien Grall Reviewed-by: Bertrand Marquis --- Changes in v4: - Change to the commit title Changes in v3: - removed check introduced in v2. --- xen/arch/arm/domain_build.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 359957dc1b..b1d7b9849f 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -2508,6 +2508,11 @@ void __init create_domUs(void) GUEST_VPL011_SPI - 32 + 1); } =20 + /* + * The variable max_init_domid is initialized with zero, so here i= t's + * very important to use the pre-increment operator to call + * domain_create() with a domid > 0. (domid =3D=3D 0 is reserved f= or Dom0) + */ d =3D domain_create(++max_init_domid, &d_cfg, false); if ( IS_ERR(d) ) panic("Error creating domain %s\n", dt_node_name(node)); --=20 2.17.1 From nobody Mon May 20 17:16:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1618391692; cv=none; d=zohomail.com; s=zohoarc; b=WPzxsq6/+/jAikOAnawiIadEFLURfcFlylFb8wO0YJhJCcT1QkS5hbfXPrEGGVjlq1F2fbD32p1bQUkQePqVtn6lITf8V7V4/fzrHxwLYD2dbYmmDtT+SsX3KAn/y0wCvmnHlN3XqZNnTHgw033cAdOefbgp3MIOEaR6q5iw7Co= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618391692; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=WwxCEsrDxqmovzTcRf7Ng86JC6EKkxlvbSXxWLM68Jk=; b=VHDTjTOVAlyudNaMnfxr+K0dw8GpkjFAa2nBaOu/D/9cCcNl3SK6gRkdEoBO9K3gWmjO+vFQje3mLHoj3BDnaVVQKhoxvdndJeU7JuxqLKqOvihB/xAPvvlEqWV0p6ASWQncut1cwlrLl8/EPxhKDUIQ3rz6X0JRMNB6DftJyQY= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 16183916920215.210284940449469; Wed, 14 Apr 2021 02:14:52 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.110394.210730 (Exim 4.92) (envelope-from ) id 1lWbbb-0000kJ-5z; Wed, 14 Apr 2021 09:14:39 +0000 Received: by outflank-mailman (output) from mailman id 110394.210730; Wed, 14 Apr 2021 09:14:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lWbbb-0000kA-21; Wed, 14 Apr 2021 09:14:39 +0000 Received: by outflank-mailman (input) for mailman id 110394; Wed, 14 Apr 2021 09:14:37 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lWbbZ-0000WW-8l for xen-devel@lists.xenproject.org; Wed, 14 Apr 2021 09:14:37 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 509b9bdd-2b28-4f00-b62a-231a8a4782a9; Wed, 14 Apr 2021 09:14:20 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E728E11B3; Wed, 14 Apr 2021 02:14:19 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.197.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7A4443F73B; Wed, 14 Apr 2021 02:14:18 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 509b9bdd-2b28-4f00-b62a-231a8a4782a9 From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Volodymyr Babchuk Subject: [PATCH v4 4/4] xen/arm: Prevent Dom0 to be loaded when using dom0less Date: Wed, 14 Apr 2021 10:14:04 +0100 Message-Id: <20210414091404.14215-5-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210414091404.14215-1-luca.fancellu@arm.com> References: <20210414091404.14215-1-luca.fancellu@arm.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This patch prevents the dom0 to be loaded skipping its building and going forward to build domUs when the dom0 kernel is not found and at least one domU is present. Signed-off-by: Luca Fancellu Reviewed-by: Julien Grall Reviewed-by: Bertrand Marquis --- v3 changes: - Rephrase documentation --- docs/features/dom0less.pandoc | 7 +++--- xen/arch/arm/setup.c | 42 ++++++++++++++++++++++++++++++++--- 2 files changed, 43 insertions(+), 6 deletions(-) diff --git a/docs/features/dom0less.pandoc b/docs/features/dom0less.pandoc index d798596cdf..c9edb529e1 100644 --- a/docs/features/dom0less.pandoc +++ b/docs/features/dom0less.pandoc @@ -16,9 +16,10 @@ Multiboot specification has been extended to allow for m= ultiple domains to be passed to Xen. See docs/misc/arm/device-tree/booting.txt for more information about the Multiboot specification and how to use it. =20 -Currently, a control domain ("dom0") is still required, but in the -future it will become unnecessary when all domains are created -directly from Xen. Instead of waiting for the control domain to be fully +Currently, a control domain ("dom0") is still required to manage the DomU +domains, but the system can start also without dom0 if the Device Tree +doesn't specify the dom0 kernel and it declares one or more domUs. +Instead of waiting for the control domain (when declared) to be fully booted and the Xen tools to become available, domains created by Xen this way are started right away in parallel. Hence, their boot time is typically much shorter. diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index b405f58996..ecc4f0ae98 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -793,6 +793,38 @@ static void __init setup_mm(void) } #endif =20 +static bool __init is_dom0less_mode(void) +{ + struct bootmodules *mods =3D &bootinfo.modules; + struct bootmodule *mod; + unsigned int i; + bool dom0found =3D false; + bool domUfound =3D false; + + /* Look into the bootmodules */ + for ( i =3D 0 ; i < mods->nr_mods ; i++ ) + { + mod =3D &mods->module[i]; + /* Find if dom0 and domU kernels are present */ + if ( mod->kind =3D=3D BOOTMOD_KERNEL ) + { + if ( mod->domU =3D=3D false ) + { + dom0found =3D true; + break; + } + else + domUfound =3D true; + } + } + + /* + * If there is no dom0 kernel but at least one domU, then we are in + * dom0less mode + */ + return ( !dom0found && domUfound ); +} + size_t __read_mostly dcache_line_bytes; =20 /* C entry point for boot CPU */ @@ -803,7 +835,7 @@ void __init start_xen(unsigned long boot_phys_offset, int cpus, i; const char *cmdline; struct bootmodule *xen_bootmodule; - struct domain *dom0; + struct domain *dom0 =3D NULL; int rc; =20 dcache_line_bytes =3D read_dcache_line_bytes(); @@ -958,7 +990,10 @@ void __init start_xen(unsigned long boot_phys_offset, enable_errata_workarounds(); =20 /* Create initial domain 0. */ - dom0 =3D create_dom0(); + if ( !is_dom0less_mode() ) + dom0 =3D create_dom0(); + else + printk(XENLOG_INFO "Xen dom0less mode detected\n"); =20 heap_init_late(); =20 @@ -976,7 +1011,8 @@ void __init start_xen(unsigned long boot_phys_offset, if ( acpi_disabled ) create_domUs(); =20 - domain_unpause_by_systemcontroller(dom0); + if ( dom0 ) + domain_unpause_by_systemcontroller(dom0); =20 /* Switch on to the dynamically allocated stack for the idle vcpu * since the static one we're running on is about to be freed. */ --=20 2.17.1