From nobody Sat Nov 30 03:55:18 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1618224809; cv=none; d=zohomail.com; s=zohoarc; b=kCJzk4XzRCV+zpLjqVth27f/PFwERxGeM3okLMpHfjCn8v/Bb6hV2TFlo8feyLLNBzzMdJlnBOwA6vd/YA+N8zWR5yhXU5sUnL99GMLg/dsKHHsbfWb5c0TiqRusKd5qPlu6IQKADjOYnlDLWGNkPX1nQOKUithWvKjW6iZ50sM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618224809; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=GnesJ9CicCjTP/u5mIoSmC8D8Z18a4x3jHnzip6E8zg=; b=K2Hh0TYEM0gw0LtH5QUIHbpmXeMwoIarOFsbpGcQ1NG8dm5ML1z5zf1bguhsAxEnz0LclrX9sNQMMXS0GrWXVk1f3HXGlDUS7tO4LVUbd1D38vCKhZdAsXh2dY66fj7enuF+UsAD6WJQAXvXYRSBPtO7gafdXSNwCqIgEgD7cfk= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1618224809504614.8823937759444; Mon, 12 Apr 2021 03:53:29 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.108962.207975 (Exim 4.92) (envelope-from ) id 1lVuBr-0000pD-Up; Mon, 12 Apr 2021 10:53:11 +0000 Received: by outflank-mailman (output) from mailman id 108962.207975; Mon, 12 Apr 2021 10:53:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lVuBr-0000p5-R7; Mon, 12 Apr 2021 10:53:11 +0000 Received: by outflank-mailman (input) for mailman id 108962; Mon, 12 Apr 2021 10:53:10 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lVuBq-0000jA-Kz for xen-devel@lists.xenproject.org; Mon, 12 Apr 2021 10:53:10 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id fea0e1d6-044f-4d5b-b334-ffe3636f831e; Mon, 12 Apr 2021 10:53:05 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1A329D6E; Mon, 12 Apr 2021 03:53:05 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.197.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 33BF53F694; Mon, 12 Apr 2021 03:53:04 -0700 (PDT) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fea0e1d6-044f-4d5b-b334-ffe3636f831e From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH v3 3/4] xen/arm: Reserve domid 0 for Dom0 Date: Mon, 12 Apr 2021 11:52:42 +0100 Message-Id: <20210412105243.23354-4-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210412105243.23354-1-luca.fancellu@arm.com> References: <20210412105243.23354-1-luca.fancellu@arm.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This patch adds a comment in create_domUs() right before domain_create() to explain the importance of the pre-increment operator on the variable max_init_domid, to ensure that the domid 0 is allocated only during start_xen() function by the create_dom0() and not on any other possible code path to the domain_create() function. Signed-off-by: Luca Fancellu --- Changes in v3: - removed check introduced in v2. --- xen/arch/arm/domain_build.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 359957dc1b..b1d7b9849f 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -2508,6 +2508,11 @@ void __init create_domUs(void) GUEST_VPL011_SPI - 32 + 1); } =20 + /* + * The variable max_init_domid is initialized with zero, so here i= t's + * very important to use the pre-increment operator to call + * domain_create() with a domid > 0. (domid =3D=3D 0 is reserved f= or Dom0) + */ d =3D domain_create(++max_init_domid, &d_cfg, false); if ( IS_ERR(d) ) panic("Error creating domain %s\n", dt_node_name(node)); --=20 2.17.1