From nobody Sat May 4 18:46:47 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1dmarc=pass fromdomain=citrix.com); dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=2; a=rsa-sha256; t=1616600641; cv=pass; d=zohomail.com; s=zohoarc; b=StV1SFyI6ty+OWful5pKO4AXhMasMQRzpoeoBO1JsUaiKN+cQiK+ff51yMkAcB1qCjLzJ4l7wrjjWsQN5/BHHUuSw+PGDPH/ibF7nOzY3J0Vmz9y61CESyw0MLMMqK2oJgtuEwxFv+A4dmjDR1KlDoKiG5Ya/bJKweeAcriuynI= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616600641; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Qq4b7bnXXGYqfMK4UXF62lbfQFGPIykj3uOrnpw+JOE=; b=RJgwqv5r1p30A7o/VaJaUHraStWKLZirqLCXUHwbNEljKuxQ0b2AnIrX3fGbWoFS2SH5YTQKke5o0EVqAyXKzrJmE6nt7oOYBmwHxXITvdwn8KNX9UIGe6lEeN1OpKUwrnjSFLKS6BXSx5tPvCLyBP4v4QcPVpM4nsv0chXXyro= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1dmarc=pass fromdomain=citrix.com); dmarc=pass header.from= (p=reject dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 16166006411351014.8893078241864; Wed, 24 Mar 2021 08:44:01 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.101056.192964 (Exim 4.92) (envelope-from ) id 1lP5ff-0001zq-2x; Wed, 24 Mar 2021 15:43:47 +0000 Received: by outflank-mailman (output) from mailman id 101056.192964; Wed, 24 Mar 2021 15:43:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP5fe-0001zj-VW; Wed, 24 Mar 2021 15:43:46 +0000 Received: by outflank-mailman (input) for mailman id 101056; Wed, 24 Mar 2021 15:43:46 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP5fe-0001zS-0y for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 15:43:46 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ea048142-bf51-44d4-9072-f04d3e3b7faa; Wed, 24 Mar 2021 15:43:45 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea048142-bf51-44d4-9072-f04d3e3b7faa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616600625; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=MH2vcgX1iP1YoB7u3Yc9kqwdnVDijhCvJ0ADzJxA2dU=; b=NEBLwkj4lLniVa6rWGj3c9Ty4iCSFyKRU3bnpNLIosQswtLWFTQSw2TE 963fPjEqAAlxxAMZDm9Ti2ykhb+DHajgzjoh1vSRguDgGzUNIZXZaBowU W1AiV+usEHVt1jod/VOwjkpFuRsCY1Hb25F/qKaK59vI2iT3FVzxwksOG U=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 5rhY5lB0i9CxlOCBdxMMDh3Z094c3due3mky5Yc7WrWa/NNY9LBlsl7VH+QRdHQgvvfaU1qr76 yJNDxxyNjGRLDlh8ETK9Xy/InOF7mI0GZ+WF6rPabEGsT3//uIk9S19YUh/l40Gs8Q6KcK+CpH 9xK2Ara4SVYKvGxBbk/UTGburYl5uVMmO/jbQEKwe21k/J8NmoUTcP7hsSVAjnWmTs5CAi0b/c BYej6vYJeWlj5QaaoGAPfUBZ2wXXkt9vFA2QBdyRgQ/2EYZwXGCt20+6s1buOSnYTCWFIaJ0dy Wes= X-SBRS: 5.2 X-MesageID: 40018139 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:f2hnHqskKeAC8OSM/cIRMxB57skC8YYji2hD6mlwRA09T+WxrO rrtOgH1BPylTYaUGwhn9fFA6WbXXbA7/dOj7U5FYyJGC3ronGhIo0n14vtxDX8Bzbzn9Qz6Y 5JSII7MtH5CDFB4frSyBWkEtom3dmM+L2pg+Cb9Ht2UQR2cchbjztRICzzKDwQeCBtA50lGJ 2Aovddrz27dngNKui9DH8JX+/Mzue7667OSxgAGhIh9U2ynSqlgYSKbySw8zU/d3d0wbkk+X XYiACR3MSemtyy1xO07R6r0714g93ko+EzYfCkqs9QETn0jxbtWYIJYcz5gBkQgMWCrGkni8 PNpRBIBbUB11r0cnuuqRXgnynMuQxek0PK8lOTjXv9rcGRfltTYKAt9OEpEGqt12MasN5xy6 5N1W6C3qAncC/opyjh+8POEyhji0vcmwtTrccok3ddXYECAYUhy7A3wUU9KuZlIAvKrKojEO VoEfjG4udXfV6wfxnizxhS6e3pcXIpEhicRE8e/uSTzjhNhXh8i3AV3coFgx47hd0AYqgBw9 6BHrVjlblIQMNTRaVhBN0ZSc/yLmDWWxrDPE+bPFyPLtBIB1v977rMpJkl7uCjf5IFiLEono 7abV9evWkuP2rzFMynxvRwg1PwaVT4eQ6o5tBV5pB/tLG5bqHsKze/RFcnlNbli+kDA/fcR+ 24NPttcr/eBFqrPbwM8xz1WpFUJ3VbetYSoMwHV1WHpd+OBZbtssDdbfbPNJvgGTspQQrEcz 4+dQm2AP8FwlGgW3f+jhSUcWjqYFbD8ZV5F7Wf3+V78vlICqR89iwuzXip7MCCLjNP9oYsel FlHb/hmqSn4U2//WPC6XRVKgNQZ3wlp4nIYjdvn0snIkn0ebEMt5G0YmZJxkaKIRd5UofwHB NAoU90vYa6NYaZyyxnK9/PCBPas1Ij4FaxC7sMkKyK4snoPrkiCIw9ZaB3HQLXUzpvmQhrr2 9HQBQeRlDWEw7vjanNtu1XOMjvM/1HxCu7K89drnzS8W+Go9s0e3cdVzmyFfKMjR0WXDpSjF 1p+6o5iL6N8Azfb1cXsaAdChlheW6XCLVJAECgaJ9Pkr7mQg12UFyHnCeXkR01Z2rs+XgDn2 CJF1znRdj7Rn5m/lxI2Kfj9115Ml+QeE99cVhWm4xwH2augAc47ca7Io6Il0eBYFoLxe8QdA zfaTwJOwV02pSczxiOgguPEn0g27QjNuHQF64YbrnWw3+hQbf4zJ0uLrtxxtJIJdruuugEXa ajYAeTNir/EP5s9AqPpHopURME4UUMoLfN4lnC42e51nJkXqaXD1RiWr0BI9aTq0LjXO2F1Z 1ljdQz+cu8W1+BHeKu+OXyVXpkLBiWnEudC8cPgrpQtbgptLRyE4LAOAG4n01v7VEbFoPMiE gaQK5H+7jPNY9kQtwKd0tijy4UveXKCHFujxf/DeA/d2w8lnP3P9uG5LzTtLoka3fx0jfYCB 26+y1Z8+ytZVr56ZcqT4YxK39Rck4y9TBL+/6DbZTZDGyRBqx+1Wv/Fn+2a7lGTqeZXZ0Wsx Zh+tmN28uabTDx1gyVnTx1JMt1giqaaPL3JAKHAuhT9dOmfXyKn6ux+ca2yA7NdgHTUTVRua R1MWoKbspCjTE+jIo4lgiKI5aH3H4Noh95+jFollnkx468xnzUdHs2aTHkvg== X-IronPort-AV: E=Sophos;i="5.81,275,1610427600"; d="scan'208";a="40018139" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I9i5+MptozR2K/iNrgQlUaxg/DBa8/q1xPiPc9xKchkfU0HnBE5NjTbafp3MfQqF27W1RZQQlbDoh8wrujc1jJK7785UOped0IP0LHGgv/HEDCVCnJuYWdyRcsHm5U2w2PgfwYD0A59ocvxTVe+69WbLu3ka19YIeIVeymLkeqEA5sScinxxdwL2eMUKg1ottElO9PzQD5Wh57YdTDfuTfWue9L7oqSEmL2oKe2NwHzOFMOU47W51UfBChsdL8uFOLH0ADf6KGHSANoBYgeqlGlv3EJaiEWU68IHz4QkhMCIIApP1m0hmZ1dfXabagYExrG+W9zM70bTr4LY0JuKEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qq4b7bnXXGYqfMK4UXF62lbfQFGPIykj3uOrnpw+JOE=; b=JfJ/uPyyGwDcX/gNbMlQL0UCiW9Ss6ZEQeI8OpIDf2pxhA9sdpBiiRVFENGuZeyj1swPI+uPxv32erZ738vQH/3kABIMZ24r6HAtPePe807xm+8szQk+CpxK2lkmCTIh+OFpOKRG3ZibziRDszt+DTIlHB3ttH8eicT2VNZX/WoJ6ea++mlD0Ku41ZaI3+g0fL8c7ER51cjKjkKuxov/pg10qnC4Rb2CjafgOzAVx97giNt2c27ivhX9VzOi9ble5A0uso6cwWpZ3oEAzsxvTZMdHOcVahfGMxmqPtqEDYtmO/L5P8or8+S7DIDfrzHmOM5rE3V7UYRHpSlWJ6GMWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qq4b7bnXXGYqfMK4UXF62lbfQFGPIykj3uOrnpw+JOE=; b=nGTQXdhNcw2dt1nwIkGJ0AMbSsVii+glgYBZ1FjGoKbaosPUJE6E/zCTwM6+VnUlRC/3lXA7HaPdZNqnxmf9yMh7RBICEy/l0vYuQa0jad/3BsdW2Xq9urLaHaTFOveU1+/UkHT3kurKGPnuEG2Cxf4UrH4+8TWRtDYWIyGSYG0= From: Roger Pau Monne To: CC: , Roger Pau Monne , Andy Shevchenko , Mika Westerberg , Linus Walleij , Subject: [PATCH v2 1/2] intel/pinctrl: check REVID register value for device presence Date: Wed, 24 Mar 2021 16:43:11 +0100 Message-ID: <20210324154312.61878-2-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210324154312.61878-1-roger.pau@citrix.com> References: <20210324154312.61878-1-roger.pau@citrix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MR2P264CA0113.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:33::29) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a7215346-c06c-428e-e61a-08d8eedb98f2 X-MS-TrafficTypeDiagnostic: DM6PR03MB4763: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3276; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Jcuy9OdhwcZdLmVGDwo+XChUNxH5yBEo+r/tJTkh+m6JpYBuAahywapAZOsL2l8pvgTCAJsS611ZYVTPaNKZjrem6e8AazHBOYtd/+wcTpFvQIQJTnU1Vj9qBmOWDadYWkINKmUbhL/4SxUOFMKsAC4KsH2eiCPQwF8Dq7o5ENgOAT1ms9pQm2PeR+ISht7j7UO+KMAiMv2a28CgR9UN+txUA9XxHakNJb39/sWqMyWy9avts6fcQ+zax4eqJzLpUWpdYeQMRrqVLTxwPVirzQG8SIzULH7/kfFPZEXcRMZ8DJtCfc5lDizOAKPTI/1Iagr+mZkLM/8f8vX4m/aSZiWkYxNzxsJUUIdutBjI4iupKw1lq7c83mfGLUEikTIgrSxEtRJUxcx8DO44kXsD695akoPz0n5qUhk03et/Q81ev/Lyq/yMXxOtvH5DvQmuxinp5lBId7r3OaxjlwCJL9rpJsmp0Og8ZiwrETdRpjqi0qvDnZp0qO0JfuiqPHP46lN2QIlWBM15muNkhAhHt7I6cQAPpjcE77ef2OoraXcHfBklMUVjijkyhxFMGyhg0bezITb3oHlv6BUt11fR36caeYsqvBYItRhPXjMXNO9kQyGDv/5ay81qiRSs05mis8TFlAuXgKZlvZNpgZlQlS4rCLva8Yt4oQHg+7sIyv4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(346002)(366004)(39860400002)(136003)(396003)(956004)(478600001)(8676002)(186003)(6666004)(4326008)(86362001)(36756003)(16526019)(54906003)(26005)(8936002)(38100700001)(6486002)(316002)(6496006)(2906002)(6916009)(66556008)(66476007)(83380400001)(66946007)(1076003)(2616005)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?VXE0VnBHSjVtalBObUsyMlc4TXY2VkFWTW5QRXJDSytkd09aallRbGFzSFZI?= =?utf-8?B?dUFUODZ0Q0Q5QUZMOWZRK3ZPeHdMUHNUZmxiczZwY2ZCQ3lyOGd5bS9kTVZ0?= =?utf-8?B?b0I2K2FmeS9OaElRUVBLMzF4Zks4ajRwTFlzNWF3VXFMOU9NN0doWDg1TnZp?= =?utf-8?B?dW51cTZ0dGFmNnZ6Q201dDVibHdNUG9zOFUxQUlUazZGL3MwQ051cDBEaFc0?= =?utf-8?B?aVR1bmZwWEpKckx3NkszcENIQm8xY0JOV2J5d2RkUUhBS09JL2c1RzBFMUR0?= =?utf-8?B?UDcxd1hFZXI3VXNVZUFweU56ejZvdTEyVndTNjA0QjZ0OTkyazVtb2UwbFlR?= =?utf-8?B?b0hvSEtzelhvd1FyY0RPWU9yRXNUb3JranlsWjBrOG40Vm5zRW9rQ2l5N2R4?= =?utf-8?B?MXhNY2pzVHE2ZEJBakNHQzZQWWwza1RGTXk3R1orOHBqK1A3WG9vZGJHdW5M?= =?utf-8?B?anN6a0NRbGtHQm0zV2pLbXRkK1hWMi9Rcmxhb1JSUHZYWXgvc2NXeHgrV2lK?= =?utf-8?B?NVBva2M2VklwTU1Mb3lORzM2MVFvdTRkd2xuRytjdHd2aWdQTnFnNjR4NDkw?= =?utf-8?B?aGx2QzR6aVlJcEpWdHZWTFpjOTMvU1l4anBJWmZYYTU0TmJXcmh2N1JNTGYy?= =?utf-8?B?Ti8rT0ZuYVlJMHZMWTR5RUd4elIyNUQ3QUdqeGdOVzBzNVJONUxxZTB6ODl4?= =?utf-8?B?NXVNd0JNZjl5L2VlK2pzUkhHSXc0VkFEb1JuTCtCRXlTM0NRMHBDOVdRYzRE?= =?utf-8?B?Zng0QmFjdDlwdmZ1TEdEZWpxMVdqSTVLcDJoNFRvRzlIYkQ5SldKZktHKzcz?= =?utf-8?B?MUlVRldWQTFjK24zVE5DNUV6bFh4MU0yV1EvcUlkQjNFWHRpdVQrUGJPUFNl?= =?utf-8?B?UmVITmdTYmY4Tks5WW05My9LMVpDWktoVURlV0hIS0doWVJiQVNUeGtUSmtJ?= =?utf-8?B?RmhtMC9UK1NUSkM2cHdrZm5saldwUHhMMkM5UVE3QXVYVVdpMHBicjE3R08z?= =?utf-8?B?MEt4cXJCbW5oK2tnR1JDbjAyT0p1WjJoRWtBL0c3TEZZcXlZdi9sK1ovYXhS?= =?utf-8?B?R014bXBjSUk0OTg0TGVaWENNTUNmMitpNHdaK2duN2Nid1IvdlptWC9UdW9L?= =?utf-8?B?eVE0ZG5xSDdRZEtsTWRvNVdxWWgxL0V4SjVaMFRHbWhyci9tU0daamQ1TXJw?= =?utf-8?B?UzlDZjBtQkFEa2RrSGNxTjNEL3VPN3RNWmJ4MUtIZVA0MXlxZ0FnendsbFBp?= =?utf-8?B?cmYwQWJ4M1BiSlNZZlM2eEJjcnI1YyszZTNaYXd1MUpLT0NhbFdGMSsxTkhX?= =?utf-8?B?Zmx1bHVNVTlzci9WL3NseWxOb2k0WFNpVU5Eb2NmM2llZnFPV2JPVmZyRW1F?= =?utf-8?B?cjdRZWlCNTc1T3lIM2tIL2hTcWwveThwdlo0RTdjYmIyOVdRWVhKV09SZlJQ?= =?utf-8?B?WUZBSmdtWjlqdXRVZmNHOWdMaWhYQTd4TkhEN3QwbnBNV3NTdGdXQlRFRDVN?= =?utf-8?B?NUx2ZEhmd1pYd29oaENXOEliZmVaSVVvRE9SNGNUeUdNcGhXK2oxN2tOVEly?= =?utf-8?B?MXVwenorWTNoaHJiYTkyWGVMVmFZckxMa09PTHZYTDZvZ2lVNzBnWE9jdHY4?= =?utf-8?B?TkJ3WEJaMGxFLzlEMHM5VkcvVW0zeFhnTnF5azdGOG9jZzNnaTB2bkJTMUZO?= =?utf-8?B?V0FKRDl2RVdNYXlVbElGanIvcURGZHByM3hrcXpCQ2pCYWxEOTNkaXc1Q3BG?= =?utf-8?Q?6EedMSy/aWDFAPWhWMKHf4u71x6m2xFGXTfQnaj?= X-MS-Exchange-CrossTenant-Network-Message-Id: a7215346-c06c-428e-e61a-08d8eedb98f2 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2021 15:43:40.4946 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pVQw++uW6v06IKC/sH1qabWoQxoIlJO2l5zUWRrZBHZy6eqiK+e0qgxoiYm7rV7cxdxJHhr8vEBvedz8QdZAoQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4763 X-OriginatorOrg: citrix.com X-ZohoMail-DKIM: pass (identity @citrix.com) Use the value read from the REVID register in order to check for the presence of the device. A read of all ones is treated as if the device is not present, and hence probing is ended. This fixes an issue when running as a Xen PVH dom0, where the ACPI DSDT table is provided unmodified to dom0 and hence contains the pinctrl devices, but the MMIO region(s) containing the device registers might not be mapped in the guest physical memory map if such region(s) are not exposed on a PCI device BAR or marked as reserved in the host memory map. Suggested-by: Andy Shevchenko Signed-off-by: Roger Pau Monn=C3=A9 --- Changes since v1: - New in this version. --- Cc: Mika Westerberg Cc: Andy Shevchenko Cc: Linus Walleij Cc: linux-gpio@vger.kernel.org --- drivers/pinctrl/intel/pinctrl-intel.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/= pinctrl-intel.c index 8085782cd8f9..59d13342caf6 100644 --- a/drivers/pinctrl/intel/pinctrl-intel.c +++ b/drivers/pinctrl/intel/pinctrl-intel.c @@ -1493,6 +1493,8 @@ static int intel_pinctrl_probe(struct platform_device= *pdev, =20 /* Determine community features based on the revision */ value =3D readl(regs + REVID); + if (value =3D=3D ~0u) + return -ENODATA; if (((value & REVID_MASK) >> REVID_SHIFT) >=3D 0x94) { community->features |=3D PINCTRL_FEATURE_DEBOUNCE; community->features |=3D PINCTRL_FEATURE_1K_PD; --=20 2.30.1 From nobody Sat May 4 18:46:47 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1dmarc=pass fromdomain=citrix.com); dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=2; a=rsa-sha256; t=1616600648; cv=pass; d=zohomail.com; s=zohoarc; b=WcoiEO6tV51Wz42qwkw22/y76cuNRYtFiFPUzqsNyq2B6B41XJDhRXQqihlaIP8s+PIln0xFb0DIIjjrqSYnf9bnp0PJIb25ezXbKeVzKrbYC8ANZUQ5A4nZyn0Et+DbvCux7VNSJMurCZr1R5g2pyvaR5oyFAo7wK5WndZHanU= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616600648; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Ub0sbUt19Z455MEMout2SS1YkpeYLQCcmLvqKsToEuA=; b=AhcWwCLEoCE5eUVgz4kGk99Ez6SsQB3lRj3hWJTGzQMXxPp+3zMrzNCb0QhBg9pC10ErMCbRRIg09gkROw2pGHmDuTAKV+1xKWmG/lBozJrB1DCxNS3sc7pByXCDyZhdgX8SKza9YaQXyjlKBVpPDNr9VThJylqhxV63+6FiLgI= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1dmarc=pass fromdomain=citrix.com); dmarc=pass header.from= (p=reject dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1616600648007523.4771054642877; Wed, 24 Mar 2021 08:44:08 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.101057.192975 (Exim 4.92) (envelope-from ) id 1lP5fm-00024U-BS; Wed, 24 Mar 2021 15:43:54 +0000 Received: by outflank-mailman (output) from mailman id 101057.192975; Wed, 24 Mar 2021 15:43:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP5fm-00024M-8M; Wed, 24 Mar 2021 15:43:54 +0000 Received: by outflank-mailman (input) for mailman id 101057; Wed, 24 Mar 2021 15:43:52 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lP5fk-00023b-Mr for xen-devel@lists.xenproject.org; Wed, 24 Mar 2021 15:43:52 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 501eaa9a-5033-41ec-8788-e2d5a48f3217; Wed, 24 Mar 2021 15:43:51 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 501eaa9a-5033-41ec-8788-e2d5a48f3217 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1616600631; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=3SSMjXLR2Pw8e0lwOcBT/8UcWH1S4+UdZqxdNTeo0c4=; b=NH6R8iEOmWeruMVSATL8byarCe7Aaup3RXSuhmTKxD2l6EcPznqHHXXU wzvaiv2KedXxt3fgeJ3mofKW3juDiNjTo90Pj3oqLuPuCrRNhHKq6r4Qi x+m9dFcuMAQRmeu9YYWMGtnM51pY56cjwV76YUyuHepnan9Ssj7A3j1Bc 4=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: T2L+nUH0GVj4TT8m8wtOGnV8vZLqkRcN/TSm4y4PfQ4ZjqVvdavR16HW6mBzsmafsLUnyiA+ow 64bEwZ1Rl+2jnhaJiCY7djrDk8ysavXvq95v5CsLZi4LHZ/S6HUST+l7mjZY5pnzfLML2P982j hmNerLpJNyl8SCOyjVTmP2au3eYza3fBfdmGcMMAdZwaCL4jLpWCKDGcBBhxqywG64hnHpVI2R NWx3mEN4m26GvGWUNAoArM04uBGVeDlw/9QAesvImrfAbXyBsiIQr+pSn9mzhjVaMMxVcZ4m02 we8= X-SBRS: 5.2 X-MesageID: 40188095 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:XDgRN6zPgOrBtE6uKU/KKrPx/uskLtp033Aq2lEZdDV8btGYm8 eynP4SyB/zj3IrVGs9nM2bUZPsfVr3//dOgbU5F7GkQQXgpS+UPJhvhLGSpwHINg/f0qpm1a lme7VjE9GYNzJHpOvz/QXQKbkd6fad9qTAv4nj5lNMaS0vVK169Qd+DW+gYyhLbS1LH4AwGp bZxucvnUvCRV0tYs62BmYIUoH4zrWmqLvcbQMbHBli0QGSjFqTg4LSKQSS3RsVTlp0sNUf2F XC+jaZ2oyT98uV5zWZ/G/V4pRQlrLau6Z+Lf3JsOc5AHHBjg6pYa5oRrGNuiskydvflGoCoZ 33jDoLe+h19nPNbkG5yCGdpDXI4XIVxFLJjX+enHf5rsTySFsBerR8rLMcSDT1wQ4EnrhHoc V29lPcjbV7J1f8uR64wN7yWxRjhiOP0AEfuN9WtVNze88jcrNLxLZvmn99IdM7Mw/RzpsoK+ VqBNG03octTXqqK0rUuWRi27WXLw0ONybDRkADv/qc2CRNkEZ4yFMFxNcekm1ozuNEd6V5 X-IronPort-AV: E=Sophos;i="5.81,275,1610427600"; d="scan'208";a="40188095" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JvftgZFiTf8F2z9JvoYNbVzO8LCL3AFYEok7Yb23FH8KbpczKO76MYtBVQFpVlJSOkYC5Q/Z2ofeCYVj27QW53CrfmD7vz/QzB5IawQxyKA9RiY089Iz1eOsjougRKbnOQssRRmYqheOT4olJyobIUxpa8FiV+0vqLp48QK2LrNxbrAoE7TTDAVo26WKRcloogBoqwnalGH8lh+jvqtq4CaKAEMIlU939bXVbhVKoERPL3I1oO42VXlxdIt0lePiILI5/9xRfaZWiC6a7AeCmZwk924gbx5kxThRNlJt0K3fMtU9SJ42LyZ/e87nMNyUK7OZxO33dYggOnYgQ/XKSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ub0sbUt19Z455MEMout2SS1YkpeYLQCcmLvqKsToEuA=; b=MyDkuMZLSkGhDK06hHHTWn5cz3gGZ4b95y5N6B2Cwn1Cml1KmIfp5pe5oavF+gJ+J+j1QKE3ovtWnzugAHJPaGFajM5ljibwZ0Bu2KZDtoLRFuhvmE8yxnRKcv4fGetehFNe3Lbi33HpdRRHTp+y8gncVcQcfK39oo/56sMRBgQwhUUCJUWq+jGad180dgOcmy22qlfXk8mhmbkZXtNAZo6M8O1DmMBWa0HwM56RkVQgryynbknmZ/AAXVzPjD6QRhBojgvxLxGw/FQQx+9gMwssMLZ6TAFPOUsVMYeuJVkk7sfmOi/6x13z4kbAQTV217puHNGiPGIyyDfNB6KmLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ub0sbUt19Z455MEMout2SS1YkpeYLQCcmLvqKsToEuA=; b=XpNVOtT44B455bjm1RoXko+cMLriNYY2UYyTc2L8fAmNH7IGhou7hBEOqor8U+xtE3wYjH5He5DvswcBt6DQOJrpu9Qo9UM9PW8uxYfDeMuR3xbEY9H4/Mak0CHmuB2JoPHBQQg1gT/o2YvXIUwrItYC8Z1XUHJgLuqZxwnIAdA= From: Roger Pau Monne To: CC: , Roger Pau Monne , Mika Westerberg , Andy Shevchenko , Linus Walleij , Subject: [PATCH v2 2/2] intel/pinctrl: check capability offset is between MMIO region Date: Wed, 24 Mar 2021 16:43:12 +0100 Message-ID: <20210324154312.61878-3-roger.pau@citrix.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210324154312.61878-1-roger.pau@citrix.com> References: <20210324154312.61878-1-roger.pau@citrix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MR1P264CA0030.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:2f::17) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2a898119-3a44-4b47-231b-08d8eedb9bca X-MS-TrafficTypeDiagnostic: DM4PR03MB6062: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:240; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iUSZn4Z/mitWANUDBIi1vmCnml/K7B9YOrGUHjxHbd6+EhtYZH4qAS2lKP1aHQpgNdjySrCCjexep0+3uISBq0M6YJUQ5mjM5H/e4L4DJvXxQLLotrNNNL5/rWcEqZZuNf0vBrrJ9KbWI1AqHx7EFgQVOmxI1yy9MPg0KTd4HIGdrnHH5CUfPjCMR5jTERUTqUu8D5O41E3TFpekY4bL/F3S8xwls6EyGaCwb/EIpdus/vX/2IDHfYc/LOqypLbY/vQVXNYzwHS1DOI4gnyCIqiWzIT2c0z8ctUftt1Q/hoDOSU5uJcPRsbdsHcTRNmxjt2rQZyLYMIW1dsMxjor5IdhEHQypRdS4R1Z0+01o8LXTebWDlB+78alkI2FIJXSpNhmz0mmCbGC1+bcAdMcYJKKe8V8tkjMHyYLiZp8gRIb5XgC6APu1nRWov6PWPxcvWg0SSZyf1o7xBT8pg/HBVQBeMGcgiFBXoLUohRVyeXcVybF9FJl4eyF29vPb/UkDdlOIAng3kpZQ4+TQzkbYGqZu70D5aArPOVpr9DqiVmTkfWCIiOnM5O55fLGJwSryiy4QaRJgRhynT/S+U29tA//ktGDal/9Fkxs427AjULUU6ejlFf9UmDkxfifLcZjnO7PRBiP9cjyLYka90PgeDcixXBuvvDREbOk3AqZAV4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(396003)(39860400002)(136003)(346002)(376002)(54906003)(6916009)(478600001)(956004)(16526019)(186003)(26005)(83380400001)(86362001)(2616005)(1076003)(4326008)(38100700001)(2906002)(36756003)(316002)(5660300002)(8936002)(66556008)(8676002)(66476007)(6496006)(6666004)(66946007)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ZEN2SDNwR29EV0ZaVXFTZFptMVRTRnBrYWd1a0U1d3ZDV0xJaGw3MklEL0Jn?= =?utf-8?B?L1F1Y0lVa1BRQW8wK3VxUzVHRkFwNDBjSmg0NFpTd1ZocndNVHJZSC8xQjh1?= =?utf-8?B?WTQ1cDU1SU80SUVTdlVVOVBNNGtDYWdlRTUrU1M2UEVFZUpSVW5BMC95RE5Q?= =?utf-8?B?QVhxejVjQXJYNk16V0lqZ2VtSzJIRk9RclVrajZVenY1ejMxVmNLd1VnWDVS?= =?utf-8?B?TGYrdzFvNTZTbFl4Z0QxcXdQYjdwanBRQi9ZQzJyc0loY2loZ3paQXlmaTZB?= =?utf-8?B?azVFd2dzaURVdTNENmI2b1Z0V1J0ZG4xa0JieXd1SzdpamxRL3doUDFFN21W?= =?utf-8?B?ZE5sUmpiZlVIQkI2TUFQQjJ3U2JmMmhGdktmTDlTRktoZnZJLzJiZjgxYnJS?= =?utf-8?B?d2VheXdjYTV5eG5SdzZUbDFjSlRPYk45RjB1cWltemJxYWpqUHNLTTRXTWQ4?= =?utf-8?B?bjNBYnh1cmtNdHlLWldwSWJBU0N1ME41cnBHcVZpY0o1U1ArVnJMK3FNR3Q1?= =?utf-8?B?VUl1b1dkUXFTSWp0SStKM3ZmR0NDRnVKbzRycE4wQVFzbUw3QWFhVTNKeDNp?= =?utf-8?B?MjFmS21KaWhjSWRhN09pejl4V0RvbkhpUTRQVzIwRURwT25uWE11OTZZYk5M?= =?utf-8?B?MnFRenlWMVhhdlhHTkZKbXo2Y0ttU3VnclZEU2syN3duTDQvNjF2YWZ6cVpv?= =?utf-8?B?Z2YzM2xFQ0R1NjNSZU55eFhOY2t3aW5BRngxNjBtdGRsSUR0UlVuQlJKKytq?= =?utf-8?B?VEhNYllPTGs2RHA5a2pCYUlpVWF1OHRkVERRMndzeW9hUjhQM0J1ZDBEU1Jy?= =?utf-8?B?OXdKVkRVbWxoZTlQRzM5Y3JaUG9UQmU3M0l3YTI2a20reGExNGxNM0Ivem5G?= =?utf-8?B?K1pwZjlSaFlNM2M5N2x1d2NrNHM2dHcxbGJqUjVFOC91cmJKV2N1RUluK0Qx?= =?utf-8?B?OVJMUWpSanpLaStWVVhzVzA1MlY1NURJOHpoZnlhaHRtbWgrVzh3S1RpU1Q0?= =?utf-8?B?TDRaUVlyT0xtampLUVJkZzFxdnNkQm1DMC9NUCtkajZnNklrSEQ2WkN1UERU?= =?utf-8?B?Z2JMck55eVN0dEhHbFZxQVlPUFpwWkdTTTNVbktEOWRWWGM1akNGc3RiTm9w?= =?utf-8?B?cUFXcmxCMnlHYWYrN2NWL004QTM1cHZiUHdhQmJKZlVCTGUwVkhZa0hPT051?= =?utf-8?B?MWd3NkFoMnQ2ajRCaFJ4dXlBZGFQMHdESEdWa2FrNUcrTDRidTdTZURPSVBK?= =?utf-8?B?OFZrUXFDOVpYOFhhMERKOVRxdWJqNHU5MHowS2tFK0dVcXZpWThDeGxQTDkv?= =?utf-8?B?YVdtMjh5NzRMdXR1UWpYbTN3YmhhL1czb2VOdU1QbkdJQ0wzSW1ES0QrWXZ1?= =?utf-8?B?MndyMDFNbWRDcXYrZk1Tak82YkhBMjNFUHU4WU1lUXRWaDhHOGlFSHRoeFpC?= =?utf-8?B?ZHN5WTR3dkpPbVZPQXR0aVh2T0hPLzhrZDE2UzBjMU94QzZuVWhkY083amlD?= =?utf-8?B?UlpJNnlkYWx6dlY1RGRWZE9UekVXWlcveGtMYVNDY2FjU0prWFpEVjh6V1o5?= =?utf-8?B?UUdFSGVMWEQrcHhCWkpjZGc2OXZ6eGcyYXlVWXRpKzd6U0ZIRVFMZGNOTVhG?= =?utf-8?B?eWJiZmMzTFRwSENRc1I4aEZHV0haNThxVzVKL3ZHdDdlT1dITUYwUmdYUXNj?= =?utf-8?B?dTcrWFlzNGc0bTNRdTV5c3g3dUV3R2VJbEJRcFViZE96bm9YTWZYQ1RSR1Az?= =?utf-8?Q?Rw9X3YAKXcFsKf25ax3E0z2qTdUm4jjFIEUvnYo?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2a898119-3a44-4b47-231b-08d8eedb9bca X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2021 15:43:45.3771 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wZG1u4rKV0LIawGl3is2QIotERP5/BRvYVqhwhxiS1snYI20Y6IfoSAmgvN9cb6zhruhzZZzSz/xonNArgbHKA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6062 X-OriginatorOrg: citrix.com X-ZohoMail-DKIM: pass (identity @citrix.com) When parsing the capability list make sure the offset is between the MMIO region mapped in 'regs', or else the kernel hits a page fault. Adding the check is harmless, and prevents buggy or broken systems from crashing the kernel if the capability linked list is somehow broken. Fixes: 91d898e51e60 ('pinctrl: intel: Convert capability list to features') Signed-off-by: Roger Pau Monn=C3=A9 --- Changes since v1: - Adjust commit message. --- Cc: Mika Westerberg Cc: Andy Shevchenko Cc: Linus Walleij Cc: linux-gpio@vger.kernel.org --- drivers/pinctrl/intel/pinctrl-intel.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/= pinctrl-intel.c index 59d13342caf6..d45a6994b2a3 100644 --- a/drivers/pinctrl/intel/pinctrl-intel.c +++ b/drivers/pinctrl/intel/pinctrl-intel.c @@ -1481,16 +1481,22 @@ static int intel_pinctrl_probe(struct platform_devi= ce *pdev, =20 for (i =3D 0; i < pctrl->ncommunities; i++) { struct intel_community *community =3D &pctrl->communities[i]; + struct resource *res; void __iomem *regs; + size_t size; u32 offset; u32 value; =20 *community =3D pctrl->soc->communities[i]; =20 - regs =3D devm_platform_ioremap_resource(pdev, community->barno); + regs =3D devm_platform_get_and_ioremap_resource(pdev, + community->barno, + &res); if (IS_ERR(regs)) return PTR_ERR(regs); =20 + size =3D res->end - res->start; + /* Determine community features based on the revision */ value =3D readl(regs + REVID); if (value =3D=3D ~0u) @@ -1521,6 +1527,12 @@ static int intel_pinctrl_probe(struct platform_devic= e *pdev, break; } offset =3D (value & CAPLIST_NEXT_MASK) >> CAPLIST_NEXT_SHIFT; + if (offset >=3D size) { + dev_err(&pdev->dev, + "wrong capability offset: %#x\n", + offset); + return -ENOENT; + } } while (offset); =20 dev_dbg(&pdev->dev, "Community%d features: %#08x\n", i, community->featu= res); --=20 2.30.1