From nobody Fri May 3 11:40:16 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1614364054; cv=none; d=zohomail.com; s=zohoarc; b=LDG8vMS5xuH9pKN3m5eUipWcVOk5UHfz9VQea/VhJQS9oZHcxqB8j7LrJMM1KY7xgaQr83XfFtwaOZs/GuU0Om7BHotQW+rw0BenxY1YuBVaKSLvrn5SfPeOwK8NcVGWyOuj02Ljn4MgU5vAnk7zvU8Tk07kQ0sD6neUgEKbI5U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614364054; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To; bh=iNuTvkc4LGs0VPE3lG554tVwPfj5Ug5Vg9CmENqGtyQ=; b=fzfh/5Zz79cZHl5ENM6vOq+t4SVR1Ma229X51aIz6JYlLNAccWF1oxwUwwjY9+8HmTLzdx6DKQfJN9frFu0XkxWtuEdMfxCgFWv1Mh7fm6FfE7h7H+iWUFwbu49GRrwVAgNhIt4xB7ZrDVlxXYCzFfJCmfiV/8ychdJ2NqDO8dI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1614364054636173.0203421037512; Fri, 26 Feb 2021 10:27:34 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.90553.171462 (Exim 4.92) (envelope-from ) id 1lFhpN-0005FH-IQ; Fri, 26 Feb 2021 18:27:01 +0000 Received: by outflank-mailman (output) from mailman id 90553.171462; Fri, 26 Feb 2021 18:27:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lFhpN-0005FA-FM; Fri, 26 Feb 2021 18:27:01 +0000 Received: by outflank-mailman (input) for mailman id 90553; Fri, 26 Feb 2021 18:27:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lFhpM-0005F5-4s for xen-devel@lists.xenproject.org; Fri, 26 Feb 2021 18:27:00 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lFhpK-0001GE-TR; Fri, 26 Feb 2021 18:26:58 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lFhpK-00089O-G4; Fri, 26 Feb 2021 18:26:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=iNuTvkc4LGs0VPE3lG554tVwPfj5Ug5Vg9CmENqGtyQ=; b=hMRJuUFgprHCGy+sCM2Y8Xqu4P 7eMu2yWG4Z2lOPbCotS9SYYOcT3936s+7ChDl4mRUlLBOkiImdiDX8KL9toL+8Sqab5TYXzEbkFD9 2KH1g2hRlSGKfFyfIeuEpkRAYitNcolXn/UeXX+aYI8Eps26/g52CDQlP+rKTN1cpMsw=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: raphning@amazon.co.uk, iwj@xenproject.org, Julien Grall , Wei Liu , Juergen Gross Subject: [PATCH for-4.15] tools/xenstored: Avoid dereferencing a NULL pointer if LiveUpdate is failing Date: Fri, 26 Feb 2021 18:26:55 +0000 Message-Id: <20210226182655.2499-1-julien@xen.org> X-Mailer: git-send-email 2.17.1 X-ZohoMail-DKIM: pass (identity @xen.org) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Julien Grall In case of failure in do_lu_start(), XenStored will first free lu_start and then try to dereference it. This will result to a NULL dereference as the destruction callback will set lu_start to NULL. The crash can be avoided by freeing lu_start *after* the reply has been set. Fixes: af216a99fb4a ("tools/xenstore: add the basic framework for doing the= live update") Signed-off-by: Julien Grall Reviewed-by: Juergen Gross --- This is a bug fix candidate for 4.15. The easiest way to trigger it is to have a XTF test that starts a transaction but never terminates it. In this case, live-updating would fail and trigger a crash. --- tools/xenstore/xenstored_control.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/xenstore/xenstored_control.c b/tools/xenstore/xenstored_= control.c index 653890f2d9e0..766b2438396a 100644 --- a/tools/xenstore/xenstored_control.c +++ b/tools/xenstore/xenstored_control.c @@ -657,9 +657,8 @@ static bool do_lu_start(struct delayed_request *req) =20 /* We will reach this point only in case of failure. */ out: - talloc_free(lu_status); - send_reply(lu_status->conn, XS_CONTROL, ret, strlen(ret) + 1); + talloc_free(lu_status); =20 return true; } --=20 2.17.1