From nobody Sun May 5 19:07:41 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1614273049; cv=none; d=zohomail.com; s=zohoarc; b=JtszdVUf/SL/1IWcmfZC3D4+T39IUHwQdNd3RX2liSNGch71c9YnJc9jnTkreVoVs3vTdfYpK0tJ+68fCgzT38WD6+ND1HDsUcz5Sn6ha50+udFTjmTowEbR5jcuQgeJq9wpquNSOgHd3CrlyXliy9qghSorrwTN6OtVzNjR/oQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614273049; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=IlP0suNGfYi5EicmpiVEDO6797MzH9y+tzMooI3fXtg=; b=T9iB2GOoeVj0R8qRRkHo+ISJRMj4MWtDlw20c2u02qGJMcKtZsnNh15pIIcwA7J+TgbOgxUc90mc77KgP1UiDt8M6uSrAIZ0+eCtXK1Bu3nVvu83kgvHK+5KFzERr1+h73TJQgxCVqsLl6n9C4t4Lu+ZCZ028TRN0Ais53NCFEA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1614273049557600.5319018748934; Thu, 25 Feb 2021 09:10:49 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.89868.169704 (Exim 4.92) (envelope-from ) id 1lFK9m-0002PI-C8; Thu, 25 Feb 2021 17:10:30 +0000 Received: by outflank-mailman (output) from mailman id 89868.169704; Thu, 25 Feb 2021 17:10:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lFK9m-0002PB-8v; Thu, 25 Feb 2021 17:10:30 +0000 Received: by outflank-mailman (input) for mailman id 89868; Thu, 25 Feb 2021 17:10:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lFK9k-0002NX-Ue for xen-devel@lists.xenproject.org; Thu, 25 Feb 2021 17:10:28 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c3a0ebe1-0e34-4ef8-8561-8587438a6937; Thu, 25 Feb 2021 17:10:24 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c3a0ebe1-0e34-4ef8-8561-8587438a6937 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1614273023; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=kNj715ReiVr9iSfrE07jiAXIxtnsUBFtABZQwDxEAto=; b=JZC/ui6zn5yR9PtebrpHjyfnZYyIMJe14PmNOuU9iR/HiIF6UW+IJ+T5 FTyoY8X93BFA6HszRO93OrhLfYj26Hg2xnl/1RBg2sAVETZTPv3hBGPca Bz9PRRwr++/tWcLNJrRpVbZd+o3x0P9J/BrDTy3o3ENTPrtJ5GqjNMb3w w=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: COegb4ZToJqx916T8zRxHV6xoRQ9dWyjVxY4ybCI4Wamia0/emKp4ch94xhJY8KnYWQq8fJeaQ 8N+hjidaM9JqLF9WwQkJ3k5/WiTuZTVSgQSNGDC2q8a3CPGWqr6ac05unLW4ytuG/KhoTKP18h QXkwoxaxeENybYC1GjPqj0LCIFixkzmjnUM1vG8eR0WySu/8LLSHY930kigrmzz3X4wBcGK0pV kM0E5g5N+9S1VTm4xnoN6mvAjFHQ+prBPhCHfPLa88MXJ5mU+v/hcsUrX65uSW0m71yGEsKodF Dsk= X-SBRS: 5.2 X-MesageID: 38055921 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,206,1610427600"; d="scan'208";a="38055921" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Ian Jackson , Paul Durrant Subject: [PATCH for-4.15] x86/dmop: Properly fail for PV guests Date: Thu, 25 Feb 2021 17:09:36 +0000 Message-ID: <20210225170936.3008-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) The current code has an early exit for PV guests, but it returns 0 having d= one nothing. Fixes: 524a98c2ac5 ("public / x86: introduce __HYPERCALL_dm_op...") Signed-off-by: Andrew Cooper Reviewed-by: Ian Jackson Reviewed-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monn=C3=A9 CC: Wei Liu CC: Ian Jackson CC: Paul Durrant For 4.15. Found while testing XEN_DMOP_nr_vcpus. Needs backporting to all stable releases. --- xen/arch/x86/hvm/dm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/arch/x86/hvm/dm.c b/xen/arch/x86/hvm/dm.c index 5bc172a5d4..612749442e 100644 --- a/xen/arch/x86/hvm/dm.c +++ b/xen/arch/x86/hvm/dm.c @@ -365,6 +365,7 @@ int dm_op(const struct dmop_args *op_args) if ( rc ) return rc; =20 + rc =3D -EINVAL; if ( !is_hvm_domain(d) ) goto out; =20 --=20 2.11.0