From nobody Mon Feb 9 10:29:14 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1613144448; cv=none; d=zohomail.com; s=zohoarc; b=EgxBiNjF6cCdPHrkAH1MiNiBPwgPOuln9+Nm/o1hw38u/02UYC8+NSIrYKtTtom/51cle3h1jeYRGkCMXU+L4cLHMJxPMIdBbntARL8vkryKFEhBK4QAaW2bQeUaAhKOVk1HPCQ1RJ2MaUTNcPaOi9vWMR54Y3wEaShUF/kfD/I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1613144448; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=EYtAQuBvb+eZYsl6M49YejFumqWmBMvStr7MifS0teM=; b=ZIGeTEjFr8TxpOwzgSW8kT6iepjFVZnn2zNdjIKQHUQMrulOK9Kmz991uvnu/ctWCNL4b11RW7J4aO9KMqIjdtKmjUjvKHbPabZv4PRYD3/PxN/pxJQDN4aLwKnLiVrhCCz4kSPEKJY9gs29Bv4hX28LoKVCEsZSIdA/Ga7z60Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1613144448434736.1316239326335; Fri, 12 Feb 2021 07:40:48 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.84306.158025 (Exim 4.92) (envelope-from ) id 1lAaYL-0000j9-HT; Fri, 12 Feb 2021 15:40:17 +0000 Received: by outflank-mailman (output) from mailman id 84306.158025; Fri, 12 Feb 2021 15:40:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lAaYL-0000j2-EQ; Fri, 12 Feb 2021 15:40:17 +0000 Received: by outflank-mailman (input) for mailman id 84306; Fri, 12 Feb 2021 15:40:16 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lAaYJ-0000ix-UV for xen-devel@lists.xenproject.org; Fri, 12 Feb 2021 15:40:16 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0497549c-6442-4ccf-ba19-070ba799dfdc; Fri, 12 Feb 2021 15:40:14 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0497549c-6442-4ccf-ba19-070ba799dfdc DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1613144414; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=9ilKt//pD9WWwJmxzImNAH8JgkNnaX0KcmVT6/nsyOQ=; b=TGuIyEm4uG2FoOiaRkgb+qI7ura6onEHhWcky31AlNrEr+T0yqwoMQj+ i7gGdjG8lUGQhXdCxfTRGI1pzPLMzLTOuGwwhmpgzQHwCx1SSxpjPBDgs lUVC1vKwJ/dwecPMiM+KQPwJxhzpOorOIpDQbmXjgQkwEbElYUPBBkoWY s=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: yZYg3LdXWpas36oecYc8GfAQ44qTZtj34YojGj+i3Y/nUAffyNtu041+sfrB7t0+QzgSQnU4Vx CE6fbK/BHU37/SdXYauPMkSVq4Kuw7kZVQWw66pkpyl63zDqcRMX+75ukBgAJSkBtFuDTsr15f L6DBL/e93xWopf1n88mpx6DOurQDlD37sa1pHwN62lENUtfkIuodDMnYt7WNe4rESdpMxNza9J PvevuBg0Zbcdri/Nx9avtE4h5McP0/HWlr4Jux+x7NdRYdJG9XZlDDMbfSfTYgyfoPr6ekp8ut iTc= X-SBRS: 5.2 X-MesageID: 38508879 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,174,1610427600"; d="scan'208";a="38508879" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Ian Jackson , Wei Liu , Stefano Stabellini , Julien Grall Subject: [PATCH 03/10] tools/libxg: Fix uninitialised variable in meminit() Date: Fri, 12 Feb 2021 15:39:46 +0000 Message-ID: <20210212153953.4582-4-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20210212153953.4582-1-andrew.cooper3@citrix.com> References: <20210212153953.4582-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 X-ZohoMail-DKIM: pass (identity @citrix.com) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Various version of gcc, when compiling with -Og, complain: xg_dom_arm.c: In function 'meminit': xg_dom_arm.c:420:19: error: 'p2m_size' may be used uninitialized in this = function [-Werror=3Dmaybe-uninitialized] 420 | dom->p2m_size =3D p2m_size; | ~~~~~~~~~~~~~~^~~~~~~~~~ Signed-off-by: Andrew Cooper --- CC: Ian Jackson CC: Wei Liu CC: Stefano Stabellini CC: Julien Grall Julien/Stefano: I can't work out how this variable is supposed to work, and the fact that it isn't a straight accumulation across the RAM banks looks suspect. --- tools/libs/guest/xg_dom_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libs/guest/xg_dom_arm.c b/tools/libs/guest/xg_dom_arm.c index 94948d2b20..f1b8d06f75 100644 --- a/tools/libs/guest/xg_dom_arm.c +++ b/tools/libs/guest/xg_dom_arm.c @@ -373,7 +373,7 @@ static int meminit(struct xc_dom_image *dom) const uint64_t modsize =3D dtb_size + ramdisk_size; const uint64_t ram128mb =3D bankbase[0] + (128<<20); =20 - xen_pfn_t p2m_size; + xen_pfn_t p2m_size =3D 0; uint64_t bank0end; =20 assert(dom->rambase_pfn << XC_PAGE_SHIFT =3D=3D bankbase[0]); --=20 2.11.0