From nobody Mon Feb 9 11:06:38 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1613144451; cv=none; d=zohomail.com; s=zohoarc; b=XtE+W04YHbGC/x0ltVtnfOvIb9HhwFbNYywsxOciIoTc2XyczuQo2X4is55eR4zsOBD2AaRIlAsjokC7Pl6Xq+g4dvomcOUN+rMSl0/na97oJBloWPD7rin3Yqn0YZ3oMWgZamoKcSTQ/Bz64B77aTpEV5FX6YSiToR3LpwtHpU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1613144451; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=YG0PWqPbtDTuca0HwuF9jDvyAElNd09tc3Qoknh5IxA=; b=I1rJDkS7qTe6nZCPNwxjdXe9I8966slayYeJzn38rJYravAJhfhEV3F0OZC5UhNxAQGsqd0HBawj2R+9cWfHrN5keFiG1gmUUMmw94Cu1Pow0kIAa952ge+u3Z0RORTUXl/eUag3cP1a2elR7mW87Jc3eWQkp2HIuGxB3pgAe+E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1613144451058826.3266452339316; Fri, 12 Feb 2021 07:40:51 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.84310.158074 (Exim 4.92) (envelope-from ) id 1lAaYf-0000xK-Ni; Fri, 12 Feb 2021 15:40:37 +0000 Received: by outflank-mailman (output) from mailman id 84310.158074; Fri, 12 Feb 2021 15:40:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lAaYf-0000xB-Jr; Fri, 12 Feb 2021 15:40:37 +0000 Received: by outflank-mailman (input) for mailman id 84310; Fri, 12 Feb 2021 15:40:35 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lAaYd-0000ix-O8 for xen-devel@lists.xenproject.org; Fri, 12 Feb 2021 15:40:35 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b6990a41-5224-4e58-86c7-bbec74fd5ff9; Fri, 12 Feb 2021 15:40:16 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b6990a41-5224-4e58-86c7-bbec74fd5ff9 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1613144416; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=xRy21DvjvCrpVWjUNEKJmq6KENL31WHuSFgYxPxdZ5Y=; b=BXgLuG64lHW7VUdMo+kj1T03GBulBkrF7agZRDm92wN4Rg9lccD1tOe4 Wmdk5HEfXGdVxayckaXRfzablsU1en8Pp2wdnzbICxIyGCnnyk/aFgBvA O16rPrv8XtATh75ZdMruQXm0jqMPGop1q/cD+bD7n81sV8yBysYoV7WmN 4=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 1GPl3yxibCxgECKAjeZrzdszMYAG2TEfiCuJFMKA6SDBa3uPSy8e9DGGtSxuqhLr6synXsJZOL dw98UqTfaA1mUFGvgnR5N9EP6+tdudSPFnvx6VHznAbe+sKdRMej/e23fe4zxLg+JhZrA65YOq 8/m0Zgv0qQ5FQATavZE6BIEDEFTEo7YvIblWmNtAWdydiQtbdu1hHYLQ58JqrlersoyvoEQgpF i3B2L8ANF3HB15BjhG6euS/wJOEp3uP2qFIo/wTYL8axOjWuc63b8bRrgUch9gf8n1tn4M1Rjz 7SA= X-SBRS: 5.2 X-MesageID: 38508886 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.81,174,1610427600"; d="scan'208";a="38508886" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Ian Jackson , Wei Liu , Anthony PERARD Subject: [PATCH 01/10] tools/xl: Fix exit code for `xl vkbattach` Date: Fri, 12 Feb 2021 15:39:44 +0000 Message-ID: <20210212153953.4582-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20210212153953.4582-1-andrew.cooper3@citrix.com> References: <20210212153953.4582-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 X-ZohoMail-DKIM: pass (identity @citrix.com) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Various version of gcc, when compiling with -Og, complain: xl_vkb.c: In function 'main_vkbattach': xl_vkb.c:79:12: error: 'rc' may be used uninitialized in this function [-= Werror=3Dmaybe-uninitialized] 79 | return rc; | ^~ The dryrun_only path really does leave rc uninitalised. Introduce a done label for success paths to use. Fixes: a15166af7c3 ("xl: add vkb config parser and CLI") Signed-off-by: Andrew Cooper Reviewed-by: Ian Jackson --- CC: Ian Jackson CC: Wei Liu CC: Anthony PERARD --- tools/xl/xl_vkb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/xl/xl_vkb.c b/tools/xl/xl_vkb.c index f6ed9e05ee..728ac9470b 100644 --- a/tools/xl/xl_vkb.c +++ b/tools/xl/xl_vkb.c @@ -64,7 +64,7 @@ int main_vkbattach(int argc, char **argv) char *json =3D libxl_device_vkb_to_json(ctx, &vkb); printf("vkb: %s\n", json); free(json); - goto out; + goto done; } =20 if (libxl_device_vkb_add(ctx, domid, &vkb, 0)) { @@ -72,6 +72,7 @@ int main_vkbattach(int argc, char **argv) rc =3D ERROR_FAIL; goto out; } =20 +done: rc =3D 0; =20 out: --=20 2.11.0