From nobody Sun May 5 12:09:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1612281438; cv=none; d=zohomail.com; s=zohoarc; b=Fod8yRAbIqqsUcQshAybs/fmZYodIHtRxX6962FSlg0ltwMWGvXePF23SY/jnU94wrQvy+sobb5TaS9BOFy9w6+b+LAkcqJVpwuTHqIsE86mf64uotJPZF1FGNu0F3zutxl4F4ELevdraDuuvnoopvIfzO6EKx2K/xdRdXvesKQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612281438; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=FIeU5vr6P9ETMb5WrDe1IVgUMo9nsV2GwJpRkYb6CD0=; b=YEWb4qSW2QeqSY+EMwBrxyQfeNPUFCXD67tKVHX/V0pvP3zoIe/R6JeJ5TVFWAJoZUJzCn16mKpRWd3SBAQfH0wxfpjSlgoweX+i45upKGltfwM+CtOnG566ttB5ua702YfaeM8q3YUiCbSBPlP0LeuKVBGv46TwfSRrcp07/WE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1612281438267279.2682961325846; Tue, 2 Feb 2021 07:57:18 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.80614.147523 (Exim 4.92) (envelope-from ) id 1l6y2y-0004sV-Jl; Tue, 02 Feb 2021 15:56:56 +0000 Received: by outflank-mailman (output) from mailman id 80614.147523; Tue, 02 Feb 2021 15:56:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l6y2y-0004sO-Ge; Tue, 02 Feb 2021 15:56:56 +0000 Received: by outflank-mailman (input) for mailman id 80614; Tue, 02 Feb 2021 15:56:55 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l6y2x-0004s2-Bs for xen-devel@lists.xenproject.org; Tue, 02 Feb 2021 15:56:55 +0000 Received: from us-smtp-delivery-124.mimecast.com (unknown [216.205.24.124]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 0810bf4a-0376-4a38-baf6-545f2149b5f5; Tue, 02 Feb 2021 15:56:54 +0000 (UTC) Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-59-SAE8JIHWPN2Un753zj4IYA-1; Tue, 02 Feb 2021 10:56:50 -0500 Received: by mail-wm1-f70.google.com with SMTP id b201so1624354wmb.9 for ; Tue, 02 Feb 2021 07:56:50 -0800 (PST) Received: from x1w.redhat.com (7.red-83-57-171.dynamicip.rima-tde.net. [83.57.171.7]) by smtp.gmail.com with ESMTPSA id u206sm3928158wme.12.2021.02.02.07.56.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Feb 2021 07:56:46 -0800 (PST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0810bf4a-0376-4a38-baf6-545f2149b5f5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612281413; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FIeU5vr6P9ETMb5WrDe1IVgUMo9nsV2GwJpRkYb6CD0=; b=UzIapkeEU1SxYG/lEu20y2R2YdcwSNeckq+OcI36h6+uTSA3Bj2VAxRYcELUCqs9dKaDcp iXUCi71VtOA4GgsC8+j5koC/JHHe7W74UEx5gs0PGOwC4hzsXYwHk46GJ+egCEy5ifKFpl ClIrXAuDwzjOfVzb2DrmdeMlqCvwcqE= X-MC-Unique: SAE8JIHWPN2Un753zj4IYA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FIeU5vr6P9ETMb5WrDe1IVgUMo9nsV2GwJpRkYb6CD0=; b=JXqNc5mDa91In2MHGWTY6Memec9Y01wY2+sGOjDj1CPwkvHGrf2EYJrYHwVbJATQu8 /vdIPD4fbCVkhCXulEonwtBpW6rjD3uu87HGyjc7i4bVy7tgRKPnbpGuBo+45jMUF8FO WnMLUGdh5Z56+CeuKzA08ydH/6XpmdG0XyTNzgreYHDAasVwRBAOa+gj5YpFcHZnnOgH x3y3CqQuusX64uheZw1udRLHExmcygKxpQLxHyNW2m7ycJBgF4QKLUfljH2oa6POXeBU 8+RTO1jff5Kripg27iTPea7sl2QXisNBiJ9JHYxJzw64gK28cdO+E+HbuD2W5oZOoQcu wnbA== X-Gm-Message-State: AOAM533DdhE2w2zkoBvG1YgyGdyp5+CRsacfbaI2nszD1HRL5DyZfwOu cD15ytymg8ikr1E4w4TiWHYZcaEjH4o9x/asqqP7pzw2x++YxK/bxvED9UrYdW8/YqB8gIX3Sf7 DmL06MiM/YRsHQvQSlTYbkJ4igFQ= X-Received: by 2002:a05:600c:28b:: with SMTP id 11mr4281530wmk.98.1612281409506; Tue, 02 Feb 2021 07:56:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJzKYLHerQzAoFfIr5Ish+YXWqEJkYkVd0aR+Ev7o1WaT/vyuU1T9BTgcwcLSBvcLIpm7WrhFg== X-Received: by 2002:a05:600c:28b:: with SMTP id 11mr4281362wmk.98.1612281406773; Tue, 02 Feb 2021 07:56:46 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Paolo Bonzini , Eduardo Habkost , qemu-trivial@nongnu.org, "Michael S. Tsirkin" , Marcel Apfelbaum , xen-devel@lists.xenproject.org, Paul Durrant , Anthony Perard , Stefano Stabellini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH] hw/i386/xen: Remove dead code Date: Tue, 2 Feb 2021 16:56:44 +0100 Message-Id: <20210202155644.998812-1-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) 'drivers_blacklisted' is never accessed, remove it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Paul Durrant --- hw/i386/xen/xen_platform.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/hw/i386/xen/xen_platform.c b/hw/i386/xen/xen_platform.c index 7c4db35debb..01ae1fb1618 100644 --- a/hw/i386/xen/xen_platform.c +++ b/hw/i386/xen/xen_platform.c @@ -60,7 +60,6 @@ struct PCIXenPlatformState { MemoryRegion bar; MemoryRegion mmio_bar; uint8_t flags; /* used only for version_id =3D=3D 2 */ - int drivers_blacklisted; uint16_t driver_product_version; =20 /* Log from guest drivers */ @@ -245,18 +244,10 @@ static void platform_fixed_ioport_writeb(void *opaque= , uint32_t addr, uint32_t v =20 static uint32_t platform_fixed_ioport_readw(void *opaque, uint32_t addr) { - PCIXenPlatformState *s =3D opaque; - switch (addr) { case 0: - if (s->drivers_blacklisted) { - /* The drivers will recognise this magic number and refuse - * to do anything. */ - return 0xd249; - } else { - /* Magic value so that you can identify the interface. */ - return 0x49d2; - } + /* Magic value so that you can identify the interface. */ + return 0x49d2; default: return 0xffff; } --=20 2.26.2