From nobody Tue Feb 10 20:51:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass header.i=@wdc.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=wdc.com ARC-Seal: i=1; a=rsa-sha256; t=1611817954; cv=none; d=zohomail.com; s=zohoarc; b=g7jpgn7jVjIyfzjBg69f5b2g7SfVTVV7gg6/thivPcH+DRu+Vu27UP2Px3LaGyQDcR5HS98yXQw14kmN79JEfPOhfv6N1QdTW7FB17zTTESv/7w8HINZKKgimwADD4E/75VYkEdPrLwIkwe9srkhmsjyoOzMVkF7razF/m5baXg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611817954; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ia5fXlQX9lTkNHmhu3mfW6jmqWGZQitD4Adk//xg1g8=; b=WDm3OIppZeA2SPGtNobZn8kuVYgWSPN/FmQV9kTH+dxOsk/QoHjLE+eeE+3wA5IyztaQ1li8gJuwsLDBB7pe8apVBUPqB5YKxnnnuA8pA1UzcdCtVuoiUKe//FECeqsrnqMoJvT3BXTkFCDj8LWN+5rRpNyocySi158KCyQTD9s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@wdc.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1611817954288332.56426633721037; Wed, 27 Jan 2021 23:12:34 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.76579.138227 (Exim 4.92) (envelope-from ) id 1l51TY-0003ep-Rx; Thu, 28 Jan 2021 07:12:20 +0000 Received: by outflank-mailman (output) from mailman id 76579.138227; Thu, 28 Jan 2021 07:12:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l51TY-0003eg-Nl; Thu, 28 Jan 2021 07:12:20 +0000 Received: by outflank-mailman (input) for mailman id 76579; Thu, 28 Jan 2021 07:12:19 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l51TX-0003e2-GD for xen-devel@lists.xenproject.org; Thu, 28 Jan 2021 07:12:19 +0000 Received: from esa5.hgst.iphmx.com (unknown [216.71.153.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8155d42f-4410-473e-9aec-c33bf1545e19; Thu, 28 Jan 2021 07:12:18 +0000 (UTC) Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 28 Jan 2021 15:12:16 +0800 Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2021 22:56:36 -0800 Received: from vm.labspan.wdc.com (HELO vm.sc.wdc.com) ([10.6.137.102]) by uls-op-cesaip02.wdc.com with ESMTP; 27 Jan 2021 23:12:16 -0800 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8155d42f-4410-473e-9aec-c33bf1545e19 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1611817938; x=1643353938; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=H5WYNiBvrNWIzR/dDsyAI0RzKPxZxlDuB4vWYUDlMrE=; b=nTCJ/jo6Ravq1fP7M7IF2+lgEPjN9ey5djcz2unlL5FDEMGuhD6cUyK8 iZ06mGy8V/A2r5wqd6kLwsj4NrvQH3M979SFcamKcpIUNDj8xiIoiszYY Pp4SC0IDJYmaovKrkiGT0ysPRKU4Z/yORg6PiGVeSWJvJYXhMAh7T17Fm 4zPkDDVJDUv46+d38RVKBko5bzVXPv57ddmlEheqIVlm8JALbDtUXEAI6 v8mbiJQZPF3F/QDXPnMI9qApDMtxSwcEnmlikzusXsyMdudJtTMTTZrQh LOnFcI0J8VdIke4yuH0YDrZuBmrTthOddYocxoa9H//YaHk9BQmJV4avA g==; IronPort-SDR: gdFFU5PZNAYOhnKxNZLzR/eMpHEKmd5S6QzV4b7iDR/oQnrAdr4QVw2tqljSiwQrUgX3C9YccN 3rixqsLpteMciiAzZ823QwdhSvvQZxCEvRF3wk+wvsWkwT9y6v92AFAk1DNzuqn8ZlojCVdDSv 71ObpD8V1BVRqckwnGU2vYGA9iep2DpypMt0BhJGTvqwIwnW+khuntXoHCq7QiCRySRyCR2hAJ dkYuyMwrCWiKHNubJGed7RHDxQgF9ErKvmj1H9AcmwfcYK/E3b3U/VwdGnMBe4/Zt9sB/0I6dl EoA= X-IronPort-AV: E=Sophos;i="5.79,381,1602518400"; d="scan'208";a="158518045" IronPort-SDR: TnX6CdAM0G669YD2/0mFLpB/iYawSSNiP4c9iqDMqX1DZp2e7WWQ+pnV/pFUq+AtYqBpnMTsRT Wp60HApwwH6w5mm2JeZy8nmGENxMsHWw8aec68dB1/c/65vLKBtUz03+jVpm+0B15nx5H1WRKq hfFj0rECp61vKw3Gb2eQTvjRW03bLiSeFBrRbBuic+qFBl450DZstf0FZg+DclUIPeJVfPrCZr cTwGdhS9YMFLzZ9umS/vxFaFCNAa6gXkI1FleVQCUiQGjtzyEBGWD7Af1BZa78h+C2gTPiw7cy h3GHNFwJLNg/0Vd9eG89nC2p IronPort-SDR: sJ1sB4+NIXrk86BqB2mBiNRkLb2CtaUtTUjLUptuVolKqncgiWgms0hBmEnyXBHOe2LGJgTWAc Mtkqx7/Ji/KEF3P2zVgoCc4AZmvUpaw07sB7pwwqNDwBZIjeJgdIawB6xDKz7hKZuinbJ6FPFN v+digmuqEID+qvvg+Pvdb6mLkPbYX8es6TqyRNtA6iTBnQbrstI0JA9CgrvLf0RhQ0DnF83KdI QwpSDAYi/vWthDgyxzldo4sKChZfQfmY/MjRYeTOvpJG4q5JRSujoZAO3KJfZIMHz0OJMVK9L1 YPQ= WDCIronportException: Internal From: Chaitanya Kulkarni To: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@redhat.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com, xen-devel@lists.xenproject.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-fscrypt@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-nilfs@vger.kernel.org, ocfs2-devel@oss.oracle.com, linux-pm@vger.kernel.org, linux-mm@kvack.org Cc: axboe@kernel.dk, philipp.reisner@linbit.com, lars.ellenberg@linbit.com, konrad.wilk@oracle.com, roger.pau@citrix.com, minchan@kernel.org, ngupta@vflare.org, sergey.senozhatsky.work@gmail.com, agk@redhat.com, snitzer@redhat.com, hch@lst.de, sagi@grimberg.me, chaitanya.kulkarni@wdc.com, martin.petersen@oracle.com, viro@zeniv.linux.org.uk, tytso@mit.edu, jaegeuk@kernel.org, ebiggers@kernel.org, djwong@kernel.org, shaggy@kernel.org, konishi.ryusuke@gmail.com, mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com, damien.lemoal@wdc.com, naohiro.aota@wdc.com, jth@kernel.org, rjw@rjwysocki.net, len.brown@intel.com, pavel@ucw.cz, akpm@linux-foundation.org, hare@suse.de, gustavoars@kernel.org, tiwai@suse.de, alex.shi@linux.alibaba.com, asml.silence@gmail.com, ming.lei@redhat.com, tj@kernel.org, osandov@fb.com, bvanassche@acm.org, jefflexu@linux.alibaba.com Subject: [RFC PATCH 04/34] drdb: use bio_new() in submit_one_flush Date: Wed, 27 Jan 2021 23:11:03 -0800 Message-Id: <20210128071133.60335-5-chaitanya.kulkarni@wdc.com> X-Mailer: git-send-email 2.22.1 In-Reply-To: <20210128071133.60335-1-chaitanya.kulkarni@wdc.com> References: <20210128071133.60335-1-chaitanya.kulkarni@wdc.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @wdc.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Chaitanya Kulkarni --- drivers/block/drbd/drbd_receiver.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_r= eceiver.c index e1cd3427b28b..b86bbf725cbd 100644 --- a/drivers/block/drbd/drbd_receiver.c +++ b/drivers/block/drbd/drbd_receiver.c @@ -1277,8 +1277,10 @@ static void one_flush_endio(struct bio *bio) =20 static void submit_one_flush(struct drbd_device *device, struct issue_flus= h_context *ctx) { - struct bio *bio =3D bio_alloc(GFP_NOIO, 0); + struct block_device *bdev =3D device->ldev->backing_bdev; + struct bio *bio =3D bio_new(bdev, 0, REQ_OP_FLUSH, REQ_PREFLUSH, 0, GFP_N= OIO); struct one_flush_context *octx =3D kmalloc(sizeof(*octx), GFP_NOIO); + if (!bio || !octx) { drbd_warn(device, "Could not allocate a bio, CANNOT ISSUE FLUSH\n"); /* FIXME: what else can I do now? disconnecting or detaching @@ -1296,10 +1298,8 @@ static void submit_one_flush(struct drbd_device *dev= ice, struct issue_flush_cont =20 octx->device =3D device; octx->ctx =3D ctx; - bio_set_dev(bio, device->ldev->backing_bdev); bio->bi_private =3D octx; bio->bi_end_io =3D one_flush_endio; - bio->bi_opf =3D REQ_OP_FLUSH | REQ_PREFLUSH; =20 device->flush_jif =3D jiffies; set_bit(FLUSH_PENDING, &device->flags); --=20 2.22.1