From nobody Tue May 7 01:27:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1611701349; cv=none; d=zohomail.com; s=zohoarc; b=ANCS7h3qO33RbYEWMibEM+C9FaJ/ZDVP1lezcB5TOnJqIsMk1/SVPX1v1PMC6FyR65XkMQJqQ9jBjc+1QaDHgfZlJwjnEF5WanVftU6cbHeErjlYXHQUSQh/NeU+141O3gtNJo74q8fxCoSX08F1Nkaxz4JsXckRCVLkUBt69QU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611701349; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=lLP5F0SEcv2HgCDAlePPIDIjxDGY9o6GJu1I/xVZ4zM=; b=h2+UTn1So4X1bFnehzUOF0kbBHfmDm9nafnnTLdvwAKZ0xZQRXKZI6ZU3alsmrOFl838uyFrZgwQzJ0ODeu8J+Lm/AKpQw9TM6ErWNOnr94+d0/QGFd8mH8CsZnLjfIUzKlHxm1e5kii0Y/jQcXmJC4v2x7KZmIl1aYqsq02e2c= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1611701349147602.2634024532969; Tue, 26 Jan 2021 14:49:09 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.75603.136157 (Exim 4.92) (envelope-from ) id 1l4X8r-0001ic-Fs; Tue, 26 Jan 2021 22:48:57 +0000 Received: by outflank-mailman (output) from mailman id 75603.136157; Tue, 26 Jan 2021 22:48:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l4X8r-0001iU-CD; Tue, 26 Jan 2021 22:48:57 +0000 Received: by outflank-mailman (input) for mailman id 75603; Tue, 26 Jan 2021 22:48:55 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l4X8p-0001QY-Ns for xen-devel@lists.xenproject.org; Tue, 26 Jan 2021 22:48:55 +0000 Received: from isis.lip6.fr (unknown [2001:660:3302:283c::2]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6ee208be-7012-4cc5-beef-93afe801676c; Tue, 26 Jan 2021 22:48:35 +0000 (UTC) Received: from asim.lip6.fr (asim.lip6.fr [132.227.86.2]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id 10QMmYMd013239; Tue, 26 Jan 2021 23:48:34 +0100 (CET) Received: from borneo.soc.lip6.fr (borneo [132.227.103.47]) by asim.lip6.fr (8.15.2/8.14.4) with ESMTP id 10QMmYAO006814; Tue, 26 Jan 2021 23:48:34 +0100 (MET) Received: by borneo.soc.lip6.fr (Postfix, from userid 373) id 58E0DAA8C1; Tue, 26 Jan 2021 23:48:34 +0100 (MET) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6ee208be-7012-4cc5-beef-93afe801676c From: Manuel Bouyer To: xen-devel@lists.xenproject.org Cc: Manuel Bouyer , Ian Jackson , Wei Liu Subject: [PATCH v2] xenpmd.c: use dynamic allocation Date: Tue, 26 Jan 2021 23:48:00 +0100 Message-Id: <20210126224800.1246-14-bouyer@netbsd.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210126224800.1246-1-bouyer@netbsd.org> References: <20210126224800.1246-1-bouyer@netbsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Tue, 26 Jan 2021 23:48:34 +0100 (CET) X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 Content-Type: text/plain; charset="utf-8" On NetBSD, d_name is larger than 256, so file_name[284] may not be large enough (and gcc emits a format-truncation error). Use asprintf() instead of snprintf() on a static on-stack buffer. Signed-off-by: Manuel Bouyer Reviewed-by: Roger Pau Monn=C3=A9 --- tools/xenpmd/xenpmd.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/xenpmd/xenpmd.c b/tools/xenpmd/xenpmd.c index 12b82cf43e..e432aad856 100644 --- a/tools/xenpmd/xenpmd.c +++ b/tools/xenpmd/xenpmd.c @@ -101,7 +101,7 @@ FILE *get_next_battery_file(DIR *battery_dir, { FILE *file =3D 0; struct dirent *dir_entries; - char file_name[284]; + char *file_name; int ret; =20 do=20 @@ -112,16 +112,16 @@ FILE *get_next_battery_file(DIR *battery_dir, if ( strlen(dir_entries->d_name) < 4 ) continue; if ( battery_info_type =3D=3D BIF )=20 - ret =3D snprintf(file_name, sizeof(file_name), BATTERY_INFO_FI= LE_PATH, + ret =3D asprintf(&file_name, BATTERY_INFO_FILE_PATH, dir_entries->d_name); else=20 - ret =3D snprintf(file_name, sizeof(file_name), BATTERY_STATE_F= ILE_PATH, + ret =3D asprintf(&file_name, BATTERY_STATE_FILE_PATH, dir_entries->d_name); /* This should not happen but is needed to pass gcc checks */ if (ret < 0) continue; - file_name[sizeof(file_name) - 1] =3D '\0'; file =3D fopen(file_name, "r"); + free(file_name); } while ( !file ); =20 return file; --=20 2.29.2