From nobody Thu May 2 09:13:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1611701317; cv=none; d=zohomail.com; s=zohoarc; b=OFWaRMD7pK80iPFLrbL8/OvkPIimTG4CEQ/decPfPPWiY3RbimWsmIGba28s2QS8+RO+meXrqfppry3w+Fdvt+dYNwJnauSPrjlY62gKKy/UbrDCXBi/TJS9h/oF/5ZDI004H4x4ZxQ00eSAVjZiWh/Bmx8LKf5oFfLfrIbn4v8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611701317; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=xAV0hvrGWEibGocePtRa4S7XX8WksGdhpjr/cXkOrYA=; b=OfbC4KYIbk19A/et27MRxymhFzs18SdMVBRIEt0KvbIZKfZZegF3DCnnrlPvUhl8AI9yI/rgEd/IHbMvghNhde2Eo3VMuNLybB9cms/BXAYaUntYLaF6grAPxPaYpH77XVm9x3CmQqTTfEu7nmU33+VV8+HnRpbSeR/4+PjbxXU= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1611701317803781.582978172908; Tue, 26 Jan 2021 14:48:37 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.75593.136097 (Exim 4.92) (envelope-from ) id 1l4X8C-0001MK-Tw; Tue, 26 Jan 2021 22:48:16 +0000 Received: by outflank-mailman (output) from mailman id 75593.136097; Tue, 26 Jan 2021 22:48:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l4X8C-0001MD-Ql; Tue, 26 Jan 2021 22:48:16 +0000 Received: by outflank-mailman (input) for mailman id 75593; Tue, 26 Jan 2021 22:48:15 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l4X8B-0001M8-KS for xen-devel@lists.xenproject.org; Tue, 26 Jan 2021 22:48:15 +0000 Received: from isis.lip6.fr (unknown [2001:660:3302:283c::2]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d5226b15-163f-4324-b8dc-7662a9593298; Tue, 26 Jan 2021 22:48:14 +0000 (UTC) Received: from asim.lip6.fr (asim.lip6.fr [132.227.86.2]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id 10QMm44f000532; Tue, 26 Jan 2021 23:48:04 +0100 (CET) Received: from borneo.soc.lip6.fr (borneo [132.227.103.47]) by asim.lip6.fr (8.15.2/8.14.4) with ESMTP id 10QMm4oc007224; Tue, 26 Jan 2021 23:48:04 +0100 (MET) Received: by borneo.soc.lip6.fr (Postfix, from userid 373) id 271B1AA8C1; Tue, 26 Jan 2021 23:48:01 +0100 (MET) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d5226b15-163f-4324-b8dc-7662a9593298 From: Manuel Bouyer To: xen-devel@lists.xenproject.org Cc: Manuel Bouyer , Ian Jackson , Ian Jackson , Wei Liu , Anthony PERARD , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini Subject: [PATCH v2] Fix error: array subscript has type 'char' Date: Tue, 26 Jan 2021 23:47:47 +0100 Message-Id: <20210126224800.1246-1-bouyer@netbsd.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Tue, 26 Jan 2021 23:48:04 +0100 (CET) X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 Content-Type: text/plain; charset="utf-8" Use unsigned char variable, or cast to (unsigned char), for tolower()/islower() and friends. Fix compiler error array subscript has type 'char' [-Werror=3Dchar-subscripts] Signed-off-by: Manuel Bouyer Reviewed-by: Ian Jackson Release-Acked-by: Ian Jackson Acked-by: Andrew Cooper --- tools/libs/light/libxl_qmp.c | 2 +- tools/xentrace/xentrace.c | 2 +- xen/tools/symbols.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/libs/light/libxl_qmp.c b/tools/libs/light/libxl_qmp.c index c394000ea9..9b638e6f54 100644 --- a/tools/libs/light/libxl_qmp.c +++ b/tools/libs/light/libxl_qmp.c @@ -1249,7 +1249,7 @@ static int qmp_error_class_to_libxl_error_code(libxl_= _gc *gc, se++; continue; } - if (tolower(*s) !=3D tolower(*se)) + if (tolower((unsigned char)*s) !=3D tolower((unsigned char)*se= )) break; s++, se++; } diff --git a/tools/xentrace/xentrace.c b/tools/xentrace/xentrace.c index 4b50b8a53e..a8903ebf46 100644 --- a/tools/xentrace/xentrace.c +++ b/tools/xentrace/xentrace.c @@ -957,7 +957,7 @@ static int parse_cpumask_range(const char *mask_str, xc= _cpumap_t map) { unsigned int a, b; int nmaskbits; - char c; + unsigned char c; int in_range; const char *s; =20 diff --git a/xen/tools/symbols.c b/xen/tools/symbols.c index 9f9e2c9900..0b12452616 100644 --- a/xen/tools/symbols.c +++ b/xen/tools/symbols.c @@ -173,11 +173,11 @@ static int read_symbol(FILE *in, struct sym_entry *s) /* include the type field in the symbol name, so that it gets * compressed together */ s->len =3D strlen(str) + 1; - if (islower(stype) && filename) + if (islower((unsigned char)stype) && filename) s->len +=3D strlen(filename) + 1; s->sym =3D malloc(s->len + 1); sym =3D SYMBOL_NAME(s); - if (islower(stype) && filename) { + if (islower((unsigned char)stype) && filename) { sym =3D stpcpy(sym, filename); *sym++ =3D '#'; } --=20 2.29.2