From nobody Sun May 5 21:49:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1611559449; cv=none; d=zohomail.com; s=zohoarc; b=kFJFeVkAYdHCT3J76VYltFXCigEQvvcE0aCuOAug56vBjWDGyaJRCpkOxje/C+c+yQqAtBZTU98sR5uXYPSCR+vV6YH3Yg4HXN1Jf5BGzVkNF2rXhw+GnjEHhtjrtRYJ9juurEQJ2+BTMTIdAk1u6PAS4uQTDK6IwIwy2oGyQS8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611559449; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=NILakaMyMe3fTR3UEujfMXB8OZbRBtBBIA5NcbBma/Y=; b=n/Fj0PvXfr24Iod3ME+p24pdQiFNRtBDQ5ERi7Js2uc2QFG3Yi4DKUymq3EcWABdB/UVqWS/l9ChCJcKWVbSkF3HJQeJUcG2yTIq3QJ2eVkDuuXCP8qaGFLAUITijf0XM28K8ywq6mAc7+aIyNhqunms4IZFwOrzriVnUmRaOWw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=quarantine dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1611559449346671.8052550668106; Sun, 24 Jan 2021 23:24:09 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.73888.132800 (Exim 4.92) (envelope-from ) id 1l3wDo-0006cq-Fm; Mon, 25 Jan 2021 07:23:36 +0000 Received: by outflank-mailman (output) from mailman id 73888.132800; Mon, 25 Jan 2021 07:23:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l3wDo-0006cj-Bp; Mon, 25 Jan 2021 07:23:36 +0000 Received: by outflank-mailman (input) for mailman id 73888; Mon, 25 Jan 2021 07:23:35 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l3wDn-0006ce-K8 for xen-devel@lists.xenproject.org; Mon, 25 Jan 2021 07:23:35 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c6459db7-488c-4244-98a9-dc609bcc1605; Mon, 25 Jan 2021 07:23:34 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 82B4BAF49; Mon, 25 Jan 2021 07:23:33 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c6459db7-488c-4244-98a9-dc609bcc1605 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1611559413; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=NILakaMyMe3fTR3UEujfMXB8OZbRBtBBIA5NcbBma/Y=; b=XpSjAL7RjoaTgBd9cGHH3pmQTZporVuwewvP2JFtPCiNOqSZVKa/5fFCglM+ivn6FyVh5A b1X7TYE7gpXBwy1zmqAwxLdYkNx7OtK2vCzk3u9U8bYTYRXLZM1jLxfyaOXERJ3FQ+wldE 7dfYWPl5HrPrW0NfCVIGIC5Fw/+4SD0= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Ian Jackson , Wei Liu Subject: [PATCH] tools/xenstore: fix use after free bug in xenstore_control Date: Mon, 25 Jan 2021 08:23:31 +0100 Message-Id: <20210125072331.22093-1-jgross@suse.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) Content-Type: text/plain; charset="utf-8" There is a very unlikely use after free bug and a memory leak in live_update_start() of xenstore_control. Fix those. Coverity-Id: 1472399 Fixes: 7f97193e6aa858 ("tools/xenstore: add live update command to xenstore= -control") Signed-off-by: Juergen Gross Acked-by: Andrew Cooper --- tools/xenstore/xenstore_control.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tools/xenstore/xenstore_control.c b/tools/xenstore/xenstore_co= ntrol.c index 0c95cf767c..f6f4626c06 100644 --- a/tools/xenstore/xenstore_control.c +++ b/tools/xenstore/xenstore_control.c @@ -43,7 +43,12 @@ static int live_update_start(struct xs_handle *xsh, bool= force, unsigned int to) if (len < 0) return 1; =20 + ret =3D strdup("BUSY"); + if (!ret) + return 1; + for (time_start =3D time(NULL); time(NULL) - time_start < to;) { + free(ret); ret =3D xs_control_command(xsh, "live-update", buf, len); if (!ret) goto err; --=20 2.26.2