[PATCH] NetBSD: Fix lock directory path

Manuel Bouyer posted 1 patch 2 weeks, 1 day ago
Test gitlab-ci failed
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/20210112181242.1570-2-bouyer@antioche.eu.org
m4/paths.m4     | 2 +-
tools/configure | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

[PATCH] NetBSD: Fix lock directory path

Posted by Manuel Bouyer 2 weeks, 1 day ago
From: Manuel Bouyer <bouyer@netbsd.org>

On NetBSD the lock directory is in /var/run/

Signed-off-by: Manuel Bouyer <bouyer@netbsd.org>
---
 m4/paths.m4     | 2 +-
 tools/configure | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/m4/paths.m4 b/m4/paths.m4
index 89d3bb8312..1c107b1a61 100644
--- a/m4/paths.m4
+++ b/m4/paths.m4
@@ -142,7 +142,7 @@ AC_SUBST(XEN_SCRIPT_DIR)
 
 case "$host_os" in
 *freebsd*) XEN_LOCK_DIR=$localstatedir/lib ;;
-*netbsd*) XEN_LOCK_DIR=$localstatedir/lib ;;
+*netbsd*) XEN_LOCK_DIR=$rundir_path ;;
 *) XEN_LOCK_DIR=$localstatedir/lock ;;
 esac
 AC_SUBST(XEN_LOCK_DIR)
diff --git a/tools/configure b/tools/configure
index 8a708e9baa..131112c41e 100755
--- a/tools/configure
+++ b/tools/configure
@@ -4030,7 +4030,7 @@ XEN_SCRIPT_DIR=$XEN_CONFIG_DIR/scripts
 
 case "$host_os" in
 *freebsd*) XEN_LOCK_DIR=$localstatedir/lib ;;
-*netbsd*) XEN_LOCK_DIR=$localstatedir/lib ;;
+*netbsd*) XEN_LOCK_DIR=$localstatedir/run ;;
 *) XEN_LOCK_DIR=$localstatedir/lock ;;
 esac
 
-- 
2.29.2


Re: [PATCH] NetBSD: Fix lock directory path

Posted by Roger Pau Monné 1 week, 5 days ago
On Tue, Jan 12, 2021 at 07:12:22PM +0100, Manuel Bouyer wrote:
> From: Manuel Bouyer <bouyer@netbsd.org>
> 
> On NetBSD the lock directory is in /var/run/
> 
> Signed-off-by: Manuel Bouyer <bouyer@netbsd.org>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.

Re: [PATCH] NetBSD: Fix lock directory path

Posted by Manuel Bouyer 1 week, 5 days ago
On Fri, Jan 15, 2021 at 04:09:19PM +0100, Roger Pau Monné wrote:
> On Tue, Jan 12, 2021 at 07:12:22PM +0100, Manuel Bouyer wrote:
> > From: Manuel Bouyer <bouyer@netbsd.org>
> > 
> > On NetBSD the lock directory is in /var/run/
> > 
> > Signed-off-by: Manuel Bouyer <bouyer@netbsd.org>
> 
> Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

thanks
I already asked, but ...
should I resend the patch with this tag, or will the commiter add it itself ?

-- 
Manuel Bouyer <bouyer@antioche.eu.org>
     NetBSD: 26 ans d'experience feront toujours la difference
--

Re: [PATCH] NetBSD: Fix lock directory path

Posted by Andrew Cooper 1 week, 5 days ago
On 15/01/2021 15:13, Manuel Bouyer wrote:
> On Fri, Jan 15, 2021 at 04:09:19PM +0100, Roger Pau Monné wrote:
>> On Tue, Jan 12, 2021 at 07:12:22PM +0100, Manuel Bouyer wrote:
>>> From: Manuel Bouyer <bouyer@netbsd.org>
>>>
>>> On NetBSD the lock directory is in /var/run/
>>>
>>> Signed-off-by: Manuel Bouyer <bouyer@netbsd.org>
>> Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
> thanks
> I already asked, but ...
> should I resend the patch with this tag, or will the commiter add it itself ?

Please accumulate tags yourself, so that if you need to send out another
version of the series, they're already included.

However, this patch is trivial, so I'll commit it right now.  The same
might be true in practice of other patches as well.

~Andrew