From nobody Fri Apr 26 06:31:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=antioche.eu.org ARC-Seal: i=1; a=rsa-sha256; t=1610475224; cv=none; d=zohomail.com; s=zohoarc; b=EicwrARiH9GG4eBGsZrZ6aU4Wdc4nMqu2jv3EcpECLGYWPUUoMb1DKqQYJ5lzQCouoEPUTxbS12XEogMeaUXppItwPwV0iE1EPTrbq+dV1VYlUniFk1q+WjB4eiFyzau5VebvvkrDC+np7EQ3dLEZSMlTflGfq4fvxUvkxqWywU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610475224; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=8VAiPl8uvL6QPOzOmuJpGOpKElwEFh1UueW+KH4KXRs=; b=ZasiHCD+Lx3R1AsABs7I5Lz5IssQWviYz9+GovubpGwGXHqZvvavDwj/k2jTFtVmGNurzPpN8KvFiCnPkm+5jpcw3qrf06Wo8SuqTGmOw0QMDRyPdPR7yYXAwWXw4aZzGqZDV7+NMUJayLo8dHGSzavU6isGLXrbaSvTnNVCOeU= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1610475224499121.24682038050798; Tue, 12 Jan 2021 10:13:44 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.65829.116654 (Exim 4.92) (envelope-from ) id 1kzOAe-0003lG-5S; Tue, 12 Jan 2021 18:13:32 +0000 Received: by outflank-mailman (output) from mailman id 65829.116654; Tue, 12 Jan 2021 18:13:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kzOAe-0003l8-0k; Tue, 12 Jan 2021 18:13:32 +0000 Received: by outflank-mailman (input) for mailman id 65829; Tue, 12 Jan 2021 18:13:30 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kzOAc-0003Yo-So for xen-devel@lists.xenproject.org; Tue, 12 Jan 2021 18:13:30 +0000 Received: from isis.lip6.fr (unknown [2001:660:3302:283c::2]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6af9ba9a-f110-4bfa-9ef3-c6e59713c1af; Tue, 12 Jan 2021 18:13:14 +0000 (UTC) Received: from asim.lip6.fr (asim.lip6.fr [132.227.86.2]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id 10CID1Gu016415; Tue, 12 Jan 2021 19:13:01 +0100 (CET) Received: from armandeche.soc.lip6.fr (armandeche [132.227.63.133]) by asim.lip6.fr (8.15.2/8.14.4) with ESMTP id 10CID1n3015326; Tue, 12 Jan 2021 19:13:01 +0100 (MET) Received: by armandeche.soc.lip6.fr (Postfix, from userid 20331) id 3BE407218; Tue, 12 Jan 2021 19:13:01 +0100 (MET) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6af9ba9a-f110-4bfa-9ef3-c6e59713c1af From: Manuel Bouyer To: xen-devel@lists.xenproject.org Cc: Manuel Bouyer , Ian Jackson , Wei Liu , Anthony PERARD , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini Subject: [PATCH] Fix error: array subscript has type 'char' Date: Tue, 12 Jan 2021 19:12:21 +0100 Message-Id: <20210112181242.1570-1-bouyer@antioche.eu.org> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Tue, 12 Jan 2021 19:13:01 +0100 (CET) X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 Content-Type: text/plain; charset="utf-8" From: Manuel Bouyer Use unsigned char variable, or cast to (unsigned char), for tolower()/islower() and friends. Fix compiler error array subscript has type 'char' [-Werror=3Dchar-subscripts] Signed-off-by: Manuel Bouyer Reviewed-by: Ian Jackson --- tools/libs/light/libxl_qmp.c | 2 +- tools/xentrace/xentrace.c | 2 +- xen/tools/symbols.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/libs/light/libxl_qmp.c b/tools/libs/light/libxl_qmp.c index c394000ea9..9b638e6f54 100644 --- a/tools/libs/light/libxl_qmp.c +++ b/tools/libs/light/libxl_qmp.c @@ -1249,7 +1249,7 @@ static int qmp_error_class_to_libxl_error_code(libxl_= _gc *gc, se++; continue; } - if (tolower(*s) !=3D tolower(*se)) + if (tolower((unsigned char)*s) !=3D tolower((unsigned char)*se= )) break; s++, se++; } diff --git a/tools/xentrace/xentrace.c b/tools/xentrace/xentrace.c index 4b50b8a53e..a8903ebf46 100644 --- a/tools/xentrace/xentrace.c +++ b/tools/xentrace/xentrace.c @@ -957,7 +957,7 @@ static int parse_cpumask_range(const char *mask_str, xc= _cpumap_t map) { unsigned int a, b; int nmaskbits; - char c; + unsigned char c; int in_range; const char *s; =20 diff --git a/xen/tools/symbols.c b/xen/tools/symbols.c index 9f9e2c9900..0b12452616 100644 --- a/xen/tools/symbols.c +++ b/xen/tools/symbols.c @@ -173,11 +173,11 @@ static int read_symbol(FILE *in, struct sym_entry *s) /* include the type field in the symbol name, so that it gets * compressed together */ s->len =3D strlen(str) + 1; - if (islower(stype) && filename) + if (islower((unsigned char)stype) && filename) s->len +=3D strlen(filename) + 1; s->sym =3D malloc(s->len + 1); sym =3D SYMBOL_NAME(s); - if (islower(stype) && filename) { + if (islower((unsigned char)stype) && filename) { sym =3D stpcpy(sym, filename); *sym++ =3D '#'; } --=20 2.29.2