From nobody Sat Apr 20 03:38:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1610378437; cv=none; d=zohomail.com; s=zohoarc; b=LB7mmI8zLbK16mTtnAUoyCxiAuchZb1CArveTlrYitakokN9cAgfSJrq1E68o3iQG3G1Az7kQ36T6bOAG1bKTz7XedsoKZM10xk0w1EBHAfYADqkBAVuToUhfoHwqDj3WsW2C3gSj37NxjD2MWXp7xNt1Kb927HP3b95d2xb1QA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610378437; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=97BNT6jh6NRO0TVk+TL23RreQDhzFRma0TINePq+NK8=; b=CLl4jfWIIRflxkxPoSOOO9VJtGiP8JoO+qLZ9gqrXXx1HdPglpzqrgGf2RpXb8MLFozqMb+kDuc3iqmonUkq4NKCdoSNi+SnGzcZXK9qymxLM5sLQXV9b3LAt2EHOscIGxdDRYptsXtrkrHw/yIXdhIJDjMToIx64Oqn3qEFIig= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 161037843720264.84300906971714; Mon, 11 Jan 2021 07:20:37 -0800 (PST) Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-565-gJJF8iiVMiqlLKMKcAEHgw-1; Mon, 11 Jan 2021 10:20:32 -0500 Received: by mail-ed1-f69.google.com with SMTP id dc6so8358941edb.14 for ; Mon, 11 Jan 2021 07:20:32 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (129.red-88-21-205.staticip.rima-tde.net. [88.21.205.129]) by smtp.gmail.com with ESMTPSA id c12sm76932edw.55.2021.01.11.07.20.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 07:20:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610378436; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=97BNT6jh6NRO0TVk+TL23RreQDhzFRma0TINePq+NK8=; b=WmrD/QMLLe6mMlP9odwpyo3CG/WprmCO3tuHBOCOnFr5nKsyybD7J8lFKV398L+OslpC5T k2U7+AjUbAeco4+MvOBuSrrnulaYnN53YwinaYfDDo9g0cjm0QjFwHDySsIZZhcJrgT8sR EkSNuvQjbOH01Ut1W9TpfFYuPNYBAu0= X-MC-Unique: gJJF8iiVMiqlLKMKcAEHgw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=97BNT6jh6NRO0TVk+TL23RreQDhzFRma0TINePq+NK8=; b=LzQxo00Ue3xG111+pwKjz63uHR9z+ufoXSJACXMSRM1crynJ9QrocrnZkjql4nX5oI hO+LmLOYjLkED2JCFHy9+0vlnwC4ow5y6frmo4voGhRCx0YNkOcTCb0+3++Etvwpd3w5 NPftrXEOxfw6AQiHPcRm1q3biVWbgeacp9CRatVeXBS00YxSkpzXXguK64juVp6GVnVB 7nXVdkx2LZCHADvKH5PiOxnxpPN1Do/kX4mH4j7qdQGViSVYkGi9waOuRmoKD/KSQx25 QxIgZ/Mu58Iq8SIRpSo/IjW9z/kiDtsaK0P55tJOUqAJ2RopJz7Sj/BkFrJxcYkWs1de ampQ== X-Gm-Message-State: AOAM532I0EXw2C4TIo+eOQH2yyIuGvujQ9FLiySbev+CVPaUuAa1FbtL tCASfAbc2cQLqYH78P4v2LQgWahpEo3fAvHcuzeUYmpO7VTeUdmDzorUCrpd3RsVUWyJqv4iZu2 JxvkTM0mE5yR2QA== X-Received: by 2002:aa7:cdc3:: with SMTP id h3mr14237012edw.52.1610378431357; Mon, 11 Jan 2021 07:20:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJxfzQ4g/Xi77uXbjKsyJn2nZrlWGnmTOg2kIy8FkRbXj1BTf3rxwC5MxkZMkcW73D4xDrLEXw== X-Received: by 2002:aa7:cdc3:: with SMTP id h3mr14236981edw.52.1610378431207; Mon, 11 Jan 2021 07:20:31 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Huacai Chen , Greg Kurz , "Michael S. Tsirkin" , qemu-trivial@nongnu.org, Amit Shah , Dmitry Fleytman , qemu-arm@nongnu.org, John Snow , qemu-s390x@nongnu.org, Paul Durrant , Anthony Perard , Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Gerd Hoffmann , Kevin Wolf , Marcelo Tosatti , Max Reitz , Alex Williamson , Aurelien Jarno , Aleksandar Rikalo , Marcel Apfelbaum , Jason Wang , Peter Maydell , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Halil Pasic , Fam Zheng , qemu-ppc@nongnu.org, Paolo Bonzini , kvm@vger.kernel.org, Stefano Stabellini , xen-devel@lists.xenproject.org, Cornelia Huck , David Hildenbrand , qemu-block@nongnu.org, Christian Borntraeger , Sunil Muthuswamy , David Gibson , Richard Henderson , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier , Thomas Huth , Stefan Hajnoczi , Jiaxun Yang Subject: [PATCH 1/2] sysemu/runstate: Let runstate_is_running() return bool Date: Mon, 11 Jan 2021 16:20:19 +0100 Message-Id: <20210111152020.1422021-2-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210111152020.1422021-1-philmd@redhat.com> References: <20210111152020.1422021-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) runstate_check() returns a boolean. runstate_is_running() returns what runstate_check() returns, also a boolean. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alex Benn=C3=A9e Reviewed-by: David Hildenbrand Reviewed-by: Stefan Hajnoczi --- include/sysemu/runstate.h | 2 +- softmmu/runstate.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/sysemu/runstate.h b/include/sysemu/runstate.h index e557f470d42..3ab35a039a0 100644 --- a/include/sysemu/runstate.h +++ b/include/sysemu/runstate.h @@ -6,7 +6,7 @@ =20 bool runstate_check(RunState state); void runstate_set(RunState new_state); -int runstate_is_running(void); +bool runstate_is_running(void); bool runstate_needs_reset(void); bool runstate_store(char *str, size_t size); =20 diff --git a/softmmu/runstate.c b/softmmu/runstate.c index 636aab0addb..c7a67147d17 100644 --- a/softmmu/runstate.c +++ b/softmmu/runstate.c @@ -217,7 +217,7 @@ void runstate_set(RunState new_state) current_run_state =3D new_state; } =20 -int runstate_is_running(void) +bool runstate_is_running(void) { return runstate_check(RUN_STATE_RUNNING); } --=20 2.26.2 From nobody Sat Apr 20 03:38:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1610378443; cv=none; d=zohomail.com; s=zohoarc; b=gHe8q9IfzPROzYR60pUFRKxjbO1+o47c2n6hln3W+57l0xRo09ptjBLWUgrnrdineeFMRP7PCvm9OjWzsuCeXAQ9jzZNi5WfcItbfngWY3UF9nXuTsXuSHll3DAPPaU8+Bn+Xo/lhES8uXeyb2+dDsa2jXgfFy4MIjZxZPBICJs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610378443; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=2MgTFVQIGAogKeGjtgnMyQWeyj36PU1W60Mle8ZvTl4=; b=Vmepv/ozoMQdhEZGwCV0976FpFGJpcOPHcVOts8PGAV3w/KP5xJgtSA1hRBrBQew1TT6eMtz8JZZWmUj0dZ2pVSV9IW7puOFPiVy4T5pVGyRV3mDnYJb33Vd7cYrM19WNHoJ7+du4akPYds6rUUBbXBTJ/mY58pIuN5bT6D4CJQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1610378443682601.7065835110951; Mon, 11 Jan 2021 07:20:43 -0800 (PST) Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-335-5I0GORwhPC2NqdxXswwazw-1; Mon, 11 Jan 2021 10:20:40 -0500 Received: by mail-ed1-f72.google.com with SMTP id z20so8333658edl.21 for ; Mon, 11 Jan 2021 07:20:40 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (129.red-88-21-205.staticip.rima-tde.net. [88.21.205.129]) by smtp.gmail.com with ESMTPSA id h16sm7097043eji.110.2021.01.11.07.20.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 07:20:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610378442; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2MgTFVQIGAogKeGjtgnMyQWeyj36PU1W60Mle8ZvTl4=; b=L+5LGoXeCY++gBa66HHF3WqtDp/SrAFDmTHluzrgX6gdt3St+CzYrMQtoTTk1lm0dAGRIz +nkxwVKOUgFnoIajgNnNn/bZ5/2MWHoo9fWXQEkxVHuZZ8Zl7NgpUsw0QKR/gm8gar6v4T /SmgBUv+9Lglizwgi75Fu633RYT6+gA= X-MC-Unique: 5I0GORwhPC2NqdxXswwazw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2MgTFVQIGAogKeGjtgnMyQWeyj36PU1W60Mle8ZvTl4=; b=GxJOTe5TlOAT8QJfXORRq8PPNxhlkt7x/k7X2EXUfdEdxRFQ99jtgNkNsE9dX+v8FE JNepwHRObdBrgXi3ZPTzzvWSgaYJOZfUYQXYWHY76Ia7knnMnH+fs/m5DfDn1SRtjTLv EZqYyEOOMtPeiz7gr/wxWErrHRNXb59GnjrZLGepumXqgmFa0iLDDrjpT5cxNOj1CZ06 3XKlDZYD78gMGOa4/JI9Y8JZHTDgpLJr1HsxAlsFdMrJ0DfS9W/hUy3jzSl06lLQONhN pKPkWi8Lyp0zb9cBhF0TYPtebzKw+AaFaZt58rWUZkDqCG1u2Y5tFHNmw8bafC+iyR03 +5hQ== X-Gm-Message-State: AOAM530PDwj20FETTfSCuGiFU199EpsGAmsuOQBVae6aJ/k8O8PtuUaP MniCWawqjlbKpZ0haJ94ZT/lAvT1ynTkeCptl6dIX5KVGX35t7eu+i+FxKezJ4fOaG0T0hn19se Qh0SySoV54o7QXg== X-Received: by 2002:aa7:cccf:: with SMTP id y15mr14611641edt.112.1610378438961; Mon, 11 Jan 2021 07:20:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJxcMF+UJehYZiO17PyZzy9+j70Zu9ldss/OST7FfZYyo9mNlmtdppkrmgXvwyrPuWC1Fb5iiw== X-Received: by 2002:aa7:cccf:: with SMTP id y15mr14611598edt.112.1610378438650; Mon, 11 Jan 2021 07:20:38 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Huacai Chen , Greg Kurz , "Michael S. Tsirkin" , qemu-trivial@nongnu.org, Amit Shah , Dmitry Fleytman , qemu-arm@nongnu.org, John Snow , qemu-s390x@nongnu.org, Paul Durrant , Anthony Perard , Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Gerd Hoffmann , Kevin Wolf , Marcelo Tosatti , Max Reitz , Alex Williamson , Aurelien Jarno , Aleksandar Rikalo , Marcel Apfelbaum , Jason Wang , Peter Maydell , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Halil Pasic , Fam Zheng , qemu-ppc@nongnu.org, Paolo Bonzini , kvm@vger.kernel.org, Stefano Stabellini , xen-devel@lists.xenproject.org, Cornelia Huck , David Hildenbrand , qemu-block@nongnu.org, Christian Borntraeger , Sunil Muthuswamy , David Gibson , Richard Henderson , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier , Thomas Huth , Stefan Hajnoczi , Jiaxun Yang Subject: [PATCH 2/2] sysemu: Let VMChangeStateHandler take boolean 'running' argument Date: Mon, 11 Jan 2021 16:20:20 +0100 Message-Id: <20210111152020.1422021-3-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210111152020.1422021-1-philmd@redhat.com> References: <20210111152020.1422021-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) The 'running' argument from VMChangeStateHandler does not require other value than 0 / 1. Make it a plain boolean. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: David Gibson Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Stefan Hajnoczi --- include/sysemu/runstate.h | 10 ++++++++-- target/arm/kvm_arm.h | 2 +- target/ppc/cpu-qom.h | 2 +- accel/xen/xen-all.c | 2 +- audio/audio.c | 2 +- block/block-backend.c | 2 +- gdbstub.c | 2 +- hw/block/pflash_cfi01.c | 2 +- hw/block/virtio-blk.c | 2 +- hw/display/qxl.c | 2 +- hw/i386/kvm/clock.c | 2 +- hw/i386/kvm/i8254.c | 2 +- hw/i386/kvmvapic.c | 2 +- hw/i386/xen/xen-hvm.c | 2 +- hw/ide/core.c | 2 +- hw/intc/arm_gicv3_its_kvm.c | 2 +- hw/intc/arm_gicv3_kvm.c | 2 +- hw/intc/spapr_xive_kvm.c | 2 +- hw/misc/mac_via.c | 2 +- hw/net/e1000e_core.c | 2 +- hw/nvram/spapr_nvram.c | 2 +- hw/ppc/ppc.c | 2 +- hw/ppc/ppc_booke.c | 2 +- hw/s390x/tod-kvm.c | 2 +- hw/scsi/scsi-bus.c | 2 +- hw/usb/hcd-ehci.c | 2 +- hw/usb/host-libusb.c | 2 +- hw/usb/redirect.c | 2 +- hw/vfio/migration.c | 2 +- hw/virtio/virtio-rng.c | 2 +- hw/virtio/virtio.c | 2 +- net/net.c | 2 +- softmmu/memory.c | 2 +- softmmu/runstate.c | 2 +- target/arm/kvm.c | 2 +- target/i386/kvm/kvm.c | 2 +- target/i386/sev.c | 2 +- target/i386/whpx/whpx-all.c | 2 +- target/mips/kvm.c | 4 ++-- ui/gtk.c | 2 +- ui/spice-core.c | 2 +- 41 files changed, 49 insertions(+), 43 deletions(-) diff --git a/include/sysemu/runstate.h b/include/sysemu/runstate.h index 3ab35a039a0..a5356915734 100644 --- a/include/sysemu/runstate.h +++ b/include/sysemu/runstate.h @@ -10,7 +10,7 @@ bool runstate_is_running(void); bool runstate_needs_reset(void); bool runstate_store(char *str, size_t size); =20 -typedef void VMChangeStateHandler(void *opaque, int running, RunState stat= e); +typedef void VMChangeStateHandler(void *opaque, bool running, RunState sta= te); =20 VMChangeStateEntry *qemu_add_vm_change_state_handler(VMChangeStateHandler = *cb, void *opaque); @@ -20,7 +20,13 @@ VMChangeStateEntry *qdev_add_vm_change_state_handler(Dev= iceState *dev, VMChangeStateHandler = *cb, void *opaque); void qemu_del_vm_change_state_handler(VMChangeStateEntry *e); -void vm_state_notify(int running, RunState state); +/** + * vm_state_notify: Notify the state of the VM + * + * @running: whether the VM is running or not. + * @state: the #RunState of the VM. + */ +void vm_state_notify(bool running, RunState state); =20 static inline bool shutdown_caused_by_guest(ShutdownCause cause) { diff --git a/target/arm/kvm_arm.h b/target/arm/kvm_arm.h index eb81b7059eb..68ec970c4f4 100644 --- a/target/arm/kvm_arm.h +++ b/target/arm/kvm_arm.h @@ -352,7 +352,7 @@ void kvm_arm_get_virtual_time(CPUState *cs); */ void kvm_arm_put_virtual_time(CPUState *cs); =20 -void kvm_arm_vm_state_change(void *opaque, int running, RunState state); +void kvm_arm_vm_state_change(void *opaque, bool running, RunState state); =20 int kvm_arm_vgic_probe(void); =20 diff --git a/target/ppc/cpu-qom.h b/target/ppc/cpu-qom.h index 63b9e8632ca..118baf8d41f 100644 --- a/target/ppc/cpu-qom.h +++ b/target/ppc/cpu-qom.h @@ -218,7 +218,7 @@ extern const VMStateDescription vmstate_ppc_timebase; .offset =3D vmstate_offset_value(_state, _field, PPCTimebase), \ } =20 -void cpu_ppc_clock_vm_state_change(void *opaque, int running, +void cpu_ppc_clock_vm_state_change(void *opaque, bool running, RunState state); #endif =20 diff --git a/accel/xen/xen-all.c b/accel/xen/xen-all.c index 878a4089d97..3756aca27be 100644 --- a/accel/xen/xen-all.c +++ b/accel/xen/xen-all.c @@ -122,7 +122,7 @@ static void xenstore_record_dm_state(struct xs_handle *= xs, const char *state) } =20 =20 -static void xen_change_state_handler(void *opaque, int running, +static void xen_change_state_handler(void *opaque, bool running, RunState state) { if (running) { diff --git a/audio/audio.c b/audio/audio.c index b48471bb3f6..f2d56e7e57d 100644 --- a/audio/audio.c +++ b/audio/audio.c @@ -1549,7 +1549,7 @@ static int audio_driver_init(AudioState *s, struct au= dio_driver *drv, } } =20 -static void audio_vm_change_state_handler (void *opaque, int running, +static void audio_vm_change_state_handler (void *opaque, bool running, RunState state) { AudioState *s =3D opaque; diff --git a/block/block-backend.c b/block/block-backend.c index ce78d30794a..9175eb237a2 100644 --- a/block/block-backend.c +++ b/block/block-backend.c @@ -163,7 +163,7 @@ static const char *blk_root_get_name(BdrvChild *child) return blk_name(child->opaque); } =20 -static void blk_vm_state_changed(void *opaque, int running, RunState state) +static void blk_vm_state_changed(void *opaque, bool running, RunState stat= e) { Error *local_err =3D NULL; BlockBackend *blk =3D opaque; diff --git a/gdbstub.c b/gdbstub.c index d99bc0bf2ea..9f2998f8d03 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2691,7 +2691,7 @@ void gdb_set_stop_cpu(CPUState *cpu) } =20 #ifndef CONFIG_USER_ONLY -static void gdb_vm_state_change(void *opaque, int running, RunState state) +static void gdb_vm_state_change(void *opaque, bool running, RunState state) { CPUState *cpu =3D gdbserver_state.c_cpu; g_autoptr(GString) buf =3D g_string_new(NULL); diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c index ccf326793db..badcbccf012 100644 --- a/hw/block/pflash_cfi01.c +++ b/hw/block/pflash_cfi01.c @@ -1014,7 +1014,7 @@ void pflash_cfi01_legacy_drive(PFlashCFI01 *fl, Drive= Info *dinfo) loc_pop(&loc); } =20 -static void postload_update_cb(void *opaque, int running, RunState state) +static void postload_update_cb(void *opaque, bool running, RunState state) { PFlashCFI01 *pfl =3D opaque; =20 diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index bac2d6fa2b2..5207ef617f0 100644 --- a/hw/block/virtio-blk.c +++ b/hw/block/virtio-blk.c @@ -870,7 +870,7 @@ static void virtio_blk_dma_restart_bh(void *opaque) virtio_blk_process_queued_requests(s, true); } =20 -static void virtio_blk_dma_restart_cb(void *opaque, int running, +static void virtio_blk_dma_restart_cb(void *opaque, bool running, RunState state) { VirtIOBlock *s =3D opaque; diff --git a/hw/display/qxl.c b/hw/display/qxl.c index 431c1070967..d22e84ba13e 100644 --- a/hw/display/qxl.c +++ b/hw/display/qxl.c @@ -1992,7 +1992,7 @@ static void qxl_dirty_surfaces(PCIQXLDevice *qxl) } } =20 -static void qxl_vm_change_state_handler(void *opaque, int running, +static void qxl_vm_change_state_handler(void *opaque, bool running, RunState state) { PCIQXLDevice *qxl =3D opaque; diff --git a/hw/i386/kvm/clock.c b/hw/i386/kvm/clock.c index 2d8a3663693..51872dd84c0 100644 --- a/hw/i386/kvm/clock.c +++ b/hw/i386/kvm/clock.c @@ -162,7 +162,7 @@ static void do_kvmclock_ctrl(CPUState *cpu, run_on_cpu_= data data) } } =20 -static void kvmclock_vm_state_change(void *opaque, int running, +static void kvmclock_vm_state_change(void *opaque, bool running, RunState state) { KVMClockState *s =3D opaque; diff --git a/hw/i386/kvm/i8254.c b/hw/i386/kvm/i8254.c index c73254e8866..c558893961b 100644 --- a/hw/i386/kvm/i8254.c +++ b/hw/i386/kvm/i8254.c @@ -239,7 +239,7 @@ static void kvm_pit_irq_control(void *opaque, int n, in= t enable) kvm_pit_put(pit); } =20 -static void kvm_pit_vm_state_change(void *opaque, int running, +static void kvm_pit_vm_state_change(void *opaque, bool running, RunState state) { KVMPITState *s =3D opaque; diff --git a/hw/i386/kvmvapic.c b/hw/i386/kvmvapic.c index 2c1898032e4..46315445d22 100644 --- a/hw/i386/kvmvapic.c +++ b/hw/i386/kvmvapic.c @@ -748,7 +748,7 @@ static void do_vapic_enable(CPUState *cs, run_on_cpu_da= ta data) s->state =3D VAPIC_ACTIVE; } =20 -static void kvmvapic_vm_state_change(void *opaque, int running, +static void kvmvapic_vm_state_change(void *opaque, bool running, RunState state) { MachineState *ms =3D MACHINE(qdev_get_machine()); diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c index 68821d90f52..7ce672e5a5c 100644 --- a/hw/i386/xen/xen-hvm.c +++ b/hw/i386/xen/xen-hvm.c @@ -1235,7 +1235,7 @@ static void xen_main_loop_prepare(XenIOState *state) } =20 =20 -static void xen_hvm_change_state_handler(void *opaque, int running, +static void xen_hvm_change_state_handler(void *opaque, bool running, RunState rstate) { XenIOState *state =3D opaque; diff --git a/hw/ide/core.c b/hw/ide/core.c index b49e4cfbc6c..b5c6e967b2e 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -2677,7 +2677,7 @@ static void ide_restart_bh(void *opaque) } } =20 -static void ide_restart_cb(void *opaque, int running, RunState state) +static void ide_restart_cb(void *opaque, bool running, RunState state) { IDEBus *bus =3D opaque; =20 diff --git a/hw/intc/arm_gicv3_its_kvm.c b/hw/intc/arm_gicv3_its_kvm.c index 057cb53f13c..b554d2ede0a 100644 --- a/hw/intc/arm_gicv3_its_kvm.c +++ b/hw/intc/arm_gicv3_its_kvm.c @@ -71,7 +71,7 @@ static int kvm_its_send_msi(GICv3ITSState *s, uint32_t va= lue, uint16_t devid) * * The tables get flushed to guest RAM whenever the VM gets stopped. */ -static void vm_change_state_handler(void *opaque, int running, +static void vm_change_state_handler(void *opaque, bool running, RunState state) { GICv3ITSState *s =3D (GICv3ITSState *)opaque; diff --git a/hw/intc/arm_gicv3_kvm.c b/hw/intc/arm_gicv3_kvm.c index d040a5d1e99..65a4c880a35 100644 --- a/hw/intc/arm_gicv3_kvm.c +++ b/hw/intc/arm_gicv3_kvm.c @@ -743,7 +743,7 @@ static const ARMCPRegInfo gicv3_cpuif_reginfo[] =3D { * * The tables get flushed to guest RAM whenever the VM gets stopped. */ -static void vm_change_state_handler(void *opaque, int running, +static void vm_change_state_handler(void *opaque, bool running, RunState state) { GICv3State *s =3D (GICv3State *)opaque; diff --git a/hw/intc/spapr_xive_kvm.c b/hw/intc/spapr_xive_kvm.c index acc8c3650c4..c0083311607 100644 --- a/hw/intc/spapr_xive_kvm.c +++ b/hw/intc/spapr_xive_kvm.c @@ -504,7 +504,7 @@ static int kvmppc_xive_get_queues(SpaprXive *xive, Erro= r **errp) * runs again. If an interrupt was queued while the VM was stopped, * simply generate a trigger. */ -static void kvmppc_xive_change_state_handler(void *opaque, int running, +static void kvmppc_xive_change_state_handler(void *opaque, bool running, RunState state) { SpaprXive *xive =3D opaque; diff --git a/hw/misc/mac_via.c b/hw/misc/mac_via.c index 488d086a17c..ca2f939dd58 100644 --- a/hw/misc/mac_via.c +++ b/hw/misc/mac_via.c @@ -1098,7 +1098,7 @@ static void mac_via_init(Object *obj) TYPE_ADB_BUS, DEVICE(obj), "adb.0"); } =20 -static void postload_update_cb(void *opaque, int running, RunState state) +static void postload_update_cb(void *opaque, bool running, RunState state) { MacVIAState *m =3D MAC_VIA(opaque); =20 diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c index 4dcb92d966b..b75f2ab8fc1 100644 --- a/hw/net/e1000e_core.c +++ b/hw/net/e1000e_core.c @@ -3298,7 +3298,7 @@ e1000e_autoneg_resume(E1000ECore *core) } =20 static void -e1000e_vm_state_change(void *opaque, int running, RunState state) +e1000e_vm_state_change(void *opaque, bool running, RunState state) { E1000ECore *core =3D opaque; =20 diff --git a/hw/nvram/spapr_nvram.c b/hw/nvram/spapr_nvram.c index 9e51bc82ae4..01f77520146 100644 --- a/hw/nvram/spapr_nvram.c +++ b/hw/nvram/spapr_nvram.c @@ -217,7 +217,7 @@ static int spapr_nvram_pre_load(void *opaque) return 0; } =20 -static void postload_update_cb(void *opaque, int running, RunState state) +static void postload_update_cb(void *opaque, bool running, RunState state) { SpaprNvram *nvram =3D opaque; =20 diff --git a/hw/ppc/ppc.c b/hw/ppc/ppc.c index 5cbbff1f8d0..bf28d6bfc8d 100644 --- a/hw/ppc/ppc.c +++ b/hw/ppc/ppc.c @@ -1059,7 +1059,7 @@ static void timebase_load(PPCTimebase *tb) } } =20 -void cpu_ppc_clock_vm_state_change(void *opaque, int running, +void cpu_ppc_clock_vm_state_change(void *opaque, bool running, RunState state) { PPCTimebase *tb =3D opaque; diff --git a/hw/ppc/ppc_booke.c b/hw/ppc/ppc_booke.c index 652a21b8064..974c0c8a752 100644 --- a/hw/ppc/ppc_booke.c +++ b/hw/ppc/ppc_booke.c @@ -317,7 +317,7 @@ static void ppc_booke_timer_reset_handle(void *opaque) * action will be taken. To avoid this we always clear the watchdog state = when * state changes to running. */ -static void cpu_state_change_handler(void *opaque, int running, RunState s= tate) +static void cpu_state_change_handler(void *opaque, bool running, RunState = state) { PowerPCCPU *cpu =3D opaque; CPUPPCState *env =3D &cpu->env; diff --git a/hw/s390x/tod-kvm.c b/hw/s390x/tod-kvm.c index 6e21d83181d..0b944774861 100644 --- a/hw/s390x/tod-kvm.c +++ b/hw/s390x/tod-kvm.c @@ -78,7 +78,7 @@ static void kvm_s390_tod_set(S390TODState *td, const S390= TOD *tod, Error **errp) } } =20 -static void kvm_s390_tod_vm_state_change(void *opaque, int running, +static void kvm_s390_tod_vm_state_change(void *opaque, bool running, RunState state) { S390TODState *td =3D opaque; diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c index c349fb7f2d1..f990d5b3b03 100644 --- a/hw/scsi/scsi-bus.c +++ b/hw/scsi/scsi-bus.c @@ -181,7 +181,7 @@ void scsi_req_retry(SCSIRequest *req) req->retry =3D true; } =20 -static void scsi_dma_restart_cb(void *opaque, int running, RunState state) +static void scsi_dma_restart_cb(void *opaque, bool running, RunState state) { SCSIDevice *s =3D opaque; =20 diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index aca018d8b5f..98d08c325ea 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -2436,7 +2436,7 @@ static int usb_ehci_post_load(void *opaque, int versi= on_id) return 0; } =20 -static void usb_ehci_vm_state_change(void *opaque, int running, RunState s= tate) +static void usb_ehci_vm_state_change(void *opaque, bool running, RunState = state) { EHCIState *ehci =3D opaque; =20 diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index b950501d100..ecbf3f66f42 100644 --- a/hw/usb/host-libusb.c +++ b/hw/usb/host-libusb.c @@ -1755,7 +1755,7 @@ type_init(usb_host_register_types) static QEMUTimer *usb_auto_timer; static VMChangeStateEntry *usb_vmstate; =20 -static void usb_host_vm_state(void *unused, int running, RunState state) +static void usb_host_vm_state(void *unused, bool running, RunState state) { if (running) { usb_host_auto_check(unused); diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index 7e9e3fecbfe..17f06f34179 100644 --- a/hw/usb/redirect.c +++ b/hw/usb/redirect.c @@ -1395,7 +1395,7 @@ static void usbredir_chardev_event(void *opaque, QEMU= ChrEvent event) * init + destroy */ =20 -static void usbredir_vm_state_change(void *priv, int running, RunState sta= te) +static void usbredir_vm_state_change(void *priv, bool running, RunState st= ate) { USBRedirDevice *dev =3D priv; =20 diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c index 00daa50ed81..134bdccc4f8 100644 --- a/hw/vfio/migration.c +++ b/hw/vfio/migration.c @@ -727,7 +727,7 @@ static SaveVMHandlers savevm_vfio_handlers =3D { =20 /* ---------------------------------------------------------------------- = */ =20 -static void vfio_vmstate_change(void *opaque, int running, RunState state) +static void vfio_vmstate_change(void *opaque, bool running, RunState state) { VFIODevice *vbasedev =3D opaque; VFIOMigration *migration =3D vbasedev->migration; diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/virtio-rng.c index 76ce9376931..cc8e9f775d8 100644 --- a/hw/virtio/virtio-rng.c +++ b/hw/virtio/virtio-rng.c @@ -133,7 +133,7 @@ static uint64_t get_features(VirtIODevice *vdev, uint64= _t f, Error **errp) return f; } =20 -static void virtio_rng_vm_state_change(void *opaque, int running, +static void virtio_rng_vm_state_change(void *opaque, bool running, RunState state) { VirtIORNG *vrng =3D opaque; diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index b308026596f..38dc623c89e 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -3208,7 +3208,7 @@ void virtio_cleanup(VirtIODevice *vdev) qemu_del_vm_change_state_handler(vdev->vmstate); } =20 -static void virtio_vmstate_change(void *opaque, int running, RunState stat= e) +static void virtio_vmstate_change(void *opaque, bool running, RunState sta= te) { VirtIODevice *vdev =3D opaque; BusState *qbus =3D qdev_get_parent_bus(DEVICE(vdev)); diff --git a/net/net.c b/net/net.c index e1035f21d18..8a85d1e3f7b 100644 --- a/net/net.c +++ b/net/net.c @@ -1341,7 +1341,7 @@ void qmp_set_link(const char *name, bool up, Error **= errp) } } =20 -static void net_vm_change_state_handler(void *opaque, int running, +static void net_vm_change_state_handler(void *opaque, bool running, RunState state) { NetClientState *nc; diff --git a/softmmu/memory.c b/softmmu/memory.c index 333e1ed7b05..ab7f2e5aa07 100644 --- a/softmmu/memory.c +++ b/softmmu/memory.c @@ -2675,7 +2675,7 @@ static void memory_global_dirty_log_do_stop(void) MEMORY_LISTENER_CALL_GLOBAL(log_global_stop, Reverse); } =20 -static void memory_vm_change_state_handler(void *opaque, int running, +static void memory_vm_change_state_handler(void *opaque, bool running, RunState state) { if (running) { diff --git a/softmmu/runstate.c b/softmmu/runstate.c index c7a67147d17..cb07a65925c 100644 --- a/softmmu/runstate.c +++ b/softmmu/runstate.c @@ -316,7 +316,7 @@ void qemu_del_vm_change_state_handler(VMChangeStateEntr= y *e) g_free(e); } =20 -void vm_state_notify(int running, RunState state) +void vm_state_notify(bool running, RunState state) { VMChangeStateEntry *e, *next; =20 diff --git a/target/arm/kvm.c b/target/arm/kvm.c index ffe186de8d1..53d6c4a17eb 100644 --- a/target/arm/kvm.c +++ b/target/arm/kvm.c @@ -844,7 +844,7 @@ MemTxAttrs kvm_arch_post_run(CPUState *cs, struct kvm_r= un *run) return MEMTXATTRS_UNSPECIFIED; } =20 -void kvm_arm_vm_state_change(void *opaque, int running, RunState state) +void kvm_arm_vm_state_change(void *opaque, bool running, RunState state) { CPUState *cs =3D opaque; ARMCPU *cpu =3D ARM_CPU(cs); diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c index 6dc1ee052d5..170ad55c09c 100644 --- a/target/i386/kvm/kvm.c +++ b/target/i386/kvm/kvm.c @@ -690,7 +690,7 @@ static int kvm_inject_mce_oldstyle(X86CPU *cpu) return 0; } =20 -static void cpu_update_state(void *opaque, int running, RunState state) +static void cpu_update_state(void *opaque, bool running, RunState state) { CPUX86State *env =3D opaque; =20 diff --git a/target/i386/sev.c b/target/i386/sev.c index 15466068118..e7890f61906 100644 --- a/target/i386/sev.c +++ b/target/i386/sev.c @@ -670,7 +670,7 @@ sev_launch_finish(SevGuestState *sev) } =20 static void -sev_vm_state_change(void *opaque, int running, RunState state) +sev_vm_state_change(void *opaque, bool running, RunState state) { SevGuestState *sev =3D opaque; =20 diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index 3b824fc9d7c..850dfe72e75 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -1318,7 +1318,7 @@ void whpx_cpu_synchronize_pre_loadvm(CPUState *cpu) =20 static Error *whpx_migration_blocker; =20 -static void whpx_cpu_update_state(void *opaque, int running, RunState stat= e) +static void whpx_cpu_update_state(void *opaque, bool running, RunState sta= te) { CPUX86State *env =3D opaque; =20 diff --git a/target/mips/kvm.c b/target/mips/kvm.c index 477692566a4..09945ad2455 100644 --- a/target/mips/kvm.c +++ b/target/mips/kvm.c @@ -37,7 +37,7 @@ const KVMCapabilityInfo kvm_arch_required_capabilities[] = =3D { KVM_CAP_LAST_INFO }; =20 -static void kvm_mips_update_state(void *opaque, int running, RunState stat= e); +static void kvm_mips_update_state(void *opaque, bool running, RunState sta= te); =20 unsigned long kvm_arch_vcpu_id(CPUState *cs) { @@ -552,7 +552,7 @@ static int kvm_mips_restore_count(CPUState *cs) /* * Handle the VM clock being started or stopped */ -static void kvm_mips_update_state(void *opaque, int running, RunState stat= e) +static void kvm_mips_update_state(void *opaque, bool running, RunState sta= te) { CPUState *cs =3D opaque; int ret; diff --git a/ui/gtk.c b/ui/gtk.c index a752aa22be0..a5bf8ed8429 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -672,7 +672,7 @@ static const DisplayChangeListenerOps dcl_egl_ops =3D { =20 /** QEMU Events **/ =20 -static void gd_change_runstate(void *opaque, int running, RunState state) +static void gd_change_runstate(void *opaque, bool running, RunState state) { GtkDisplayState *s =3D opaque; =20 diff --git a/ui/spice-core.c b/ui/spice-core.c index 5746d0aae7c..22c77c04151 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -622,7 +622,7 @@ static int add_channel(void *opaque, const char *name, = const char *value, return 0; } =20 -static void vm_change_state_handler(void *opaque, int running, +static void vm_change_state_handler(void *opaque, bool running, RunState state) { if (running) { --=20 2.26.2