From nobody Tue May 7 14:21:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1609891196; cv=none; d=zohomail.com; s=zohoarc; b=fwiZau/L0MJ3gI112crne3bFjhXAfSlDp515lvnpTwwfVxauRwD2X/j06i3+yKiOBuKlJakeq3iz3vjoY3AlM3auvNW3WCKgp4ogI71eClpwba9Fbl6toyeOVXDQ70Lqqp991WtMqIgJ4rhb0Kp0it1fTkfpVkaAziuJITqYyr4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1609891196; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=5PjujQZ9wwpjTNtRotMyqGzLTZB87ASy5Gvxw2Qw3ZE=; b=Y5NiJGPDitQKDlhdD9CfpYoemqaQou4cjRwsrH0Lwx4HUpALTyJRjJLxTMKoFb9ezofQpibIeDBMkcNjw5zchKdE0JbHLFqr2ewFTu8k5t2XMWVPnJuo9sE0P3qHStrA/0i6dSJGAeyeTN8fAu624wq1JDsF8kOYXVTb/MJeC8U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1609891196090676.040815879418; Tue, 5 Jan 2021 15:59:56 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.62251.110150 (Exim 4.92) (envelope-from ) id 1kwwEn-000102-TM; Tue, 05 Jan 2021 23:59:41 +0000 Received: by outflank-mailman (output) from mailman id 62251.110150; Tue, 05 Jan 2021 23:59:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kwwEn-0000zu-Py; Tue, 05 Jan 2021 23:59:41 +0000 Received: by outflank-mailman (input) for mailman id 62251; Tue, 05 Jan 2021 23:59:40 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kwwEm-0000xb-Eo for xen-devel@lists.xenproject.org; Tue, 05 Jan 2021 23:59:40 +0000 Received: from casper.infradead.org (unknown [2001:8b0:10b:1236::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3c16b767-a52b-4ba4-9f2d-2ff6818ef52e; Tue, 05 Jan 2021 23:59:33 +0000 (UTC) Received: from i7.infradead.org ([2001:8b0:10b:1:21e:67ff:fecb:7a92]) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1kwwCy-001o4T-DS; Tue, 05 Jan 2021 23:58:32 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1kwwCx-001NA6-4T; Tue, 05 Jan 2021 23:57:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 3c16b767-a52b-4ba4-9f2d-2ff6818ef52e DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=5PjujQZ9wwpjTNtRotMyqGzLTZB87ASy5Gvxw2Qw3ZE=; b=uLNN/nt0moBRekDFaD8ujA2yNR L8/o7wvHtLYMXktZ93tt6d2bhjhbctPYHgouiGG8rYc+jXGA7B8J/q+WwgoClrGswBAS0ket8bpG2 zb9bPy9shwh0nwgv8NgpDYobS266wm8ZkUYzbH/wuqm1ByN574f4dELDDamAb4Ru5J4SfDkiLx8WM K+xxC9KcWBYAsemwR1ZegA1uLPn8Eb0mTuYsVt6z5scjmq+2Gp35pahz3Kv7GDmo95WFaHnrOExgw kq6lGZGTcr6j8xHDkwbqITozHydJJVu2bmQKCLJbOdmCmNKVAR0JrfIULEtun9ZXsA1bRRI3qJrCB VOATNBVg==; From: David Woodhouse To: x86@kernel.org Cc: Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Paul Durrant , jgrall@amazon.com, karahmed@amazon.de, xen-devel Subject: [PATCH v2 1/5] xen: Fix event channel callback via INTX/GSI Date: Tue, 5 Jan 2021 23:57:32 +0000 Message-Id: <20210105235736.326797-2-dwmw2@infradead.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210105235736.326797-1-dwmw2@infradead.org> References: <20210105235736.326797-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-ZohoMail-DKIM: pass (identity @infradead.org) Content-Type: text/plain; charset="utf-8" From: David Woodhouse For a while, event channel notification via the PCI platform device has been broken, because we attempt to communicate with xenstore before we even have notifications working, with the xs_reset_watches() call in xs_init(). We tend to get away with this on Xen versions below 4.0 because we avoid calling xs_reset_watches() anyway, because xenstore might not cope with reading a non-existent key. And newer Xen *does* have the vector callback support, so we rarely fall back to INTX/GSI delivery. To fix it, clean up a bit of the mess of xs_init() and xenbus_probe() startup. Call xs_init() directly from xenbus_init() only in the !XS_HVM case, deferring it to be called from xenbus_probe() in the XS_HVM case instead. Then fix up the invocation of xenbus_probe() to happen either from its device_initcall if the callback is available early enough, or when the callback is finally set up. This means that the hack of calling xenbus_probe() from a workqueue after the first interrupt, or directly from the PCI platform device setup, is no longer needed. Signed-off-by: David Woodhouse Reviewed-by: Boris Ostrovsky --- arch/arm/xen/enlighten.c | 2 +- drivers/xen/events/events_base.c | 10 ----- drivers/xen/platform-pci.c | 1 - drivers/xen/xenbus/xenbus.h | 1 + drivers/xen/xenbus/xenbus_comms.c | 8 ---- drivers/xen/xenbus/xenbus_probe.c | 68 ++++++++++++++++++++++++------- include/xen/xenbus.h | 2 +- 7 files changed, 57 insertions(+), 35 deletions(-) diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c index 60e901cd0de6..5a957a9a0984 100644 --- a/arch/arm/xen/enlighten.c +++ b/arch/arm/xen/enlighten.c @@ -371,7 +371,7 @@ static int __init xen_guest_init(void) } gnttab_init(); if (!xen_initial_domain()) - xenbus_probe(NULL); + xenbus_probe(); =20 /* * Making sure board specific code will not set up ops for diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_b= ase.c index a8030332a191..e850f79351cb 100644 --- a/drivers/xen/events/events_base.c +++ b/drivers/xen/events/events_base.c @@ -2060,16 +2060,6 @@ static struct irq_chip xen_percpu_chip __read_mostly= =3D { .irq_ack =3D ack_dynirq, }; =20 -int xen_set_callback_via(uint64_t via) -{ - struct xen_hvm_param a; - a.domid =3D DOMID_SELF; - a.index =3D HVM_PARAM_CALLBACK_IRQ; - a.value =3D via; - return HYPERVISOR_hvm_op(HVMOP_set_param, &a); -} -EXPORT_SYMBOL_GPL(xen_set_callback_via); - #ifdef CONFIG_XEN_PVHVM /* Vector callbacks are better than PCI interrupts to receive event * channel notifications because we can receive vector callbacks on any diff --git a/drivers/xen/platform-pci.c b/drivers/xen/platform-pci.c index dd911e1ff782..9db557b76511 100644 --- a/drivers/xen/platform-pci.c +++ b/drivers/xen/platform-pci.c @@ -149,7 +149,6 @@ static int platform_pci_probe(struct pci_dev *pdev, ret =3D gnttab_init(); if (ret) goto grant_out; - xenbus_probe(NULL); return 0; grant_out: gnttab_free_auto_xlat_frames(); diff --git a/drivers/xen/xenbus/xenbus.h b/drivers/xen/xenbus/xenbus.h index 2a93b7c9c159..dc1537335414 100644 --- a/drivers/xen/xenbus/xenbus.h +++ b/drivers/xen/xenbus/xenbus.h @@ -115,6 +115,7 @@ int xenbus_probe_node(struct xen_bus_type *bus, const char *type, const char *nodename); int xenbus_probe_devices(struct xen_bus_type *bus); +void xenbus_probe(void); =20 void xenbus_dev_changed(const char *node, struct xen_bus_type *bus); =20 diff --git a/drivers/xen/xenbus/xenbus_comms.c b/drivers/xen/xenbus/xenbus_= comms.c index eb5151fc8efa..e5fda0256feb 100644 --- a/drivers/xen/xenbus/xenbus_comms.c +++ b/drivers/xen/xenbus/xenbus_comms.c @@ -57,16 +57,8 @@ DEFINE_MUTEX(xs_response_mutex); static int xenbus_irq; static struct task_struct *xenbus_task; =20 -static DECLARE_WORK(probe_work, xenbus_probe); - - static irqreturn_t wake_waiting(int irq, void *unused) { - if (unlikely(xenstored_ready =3D=3D 0)) { - xenstored_ready =3D 1; - schedule_work(&probe_work); - } - wake_up(&xb_waitq); return IRQ_HANDLED; } diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_= probe.c index 44634d970a5c..b1b5b6fe9b52 100644 --- a/drivers/xen/xenbus/xenbus_probe.c +++ b/drivers/xen/xenbus/xenbus_probe.c @@ -683,29 +683,63 @@ void unregister_xenstore_notifier(struct notifier_blo= ck *nb) } EXPORT_SYMBOL_GPL(unregister_xenstore_notifier); =20 -void xenbus_probe(struct work_struct *unused) +void xenbus_probe(void) { xenstored_ready =3D 1; =20 + /* + * In the HVM case, xenbus_init() deferred its call to + * xs_init() in case callbacks were not operational yet. + * So do it now. + */ + if (xen_store_domain_type =3D=3D XS_HVM) + xs_init(); + /* Notify others that xenstore is up */ blocking_notifier_call_chain(&xenstore_chain, 0, NULL); } -EXPORT_SYMBOL_GPL(xenbus_probe); =20 static int __init xenbus_probe_initcall(void) { - if (!xen_domain()) - return -ENODEV; - - if (xen_initial_domain() || xen_hvm_domain()) - return 0; + /* + * Probe XenBus here in the XS_PV case, and also XS_HVM unless we + * need to wait for the platform PCI device to come up, which is + * the (XEN_PVPVM && !xen_have_vector_callback) case. + */ + if (xen_store_domain_type =3D=3D XS_PV || + (xen_store_domain_type =3D=3D XS_HVM && + (!IS_ENABLED(CONFIG_XEN_PVHVM) || xen_have_vector_callback))) + xenbus_probe(); =20 - xenbus_probe(NULL); return 0; } - device_initcall(xenbus_probe_initcall); =20 +int xen_set_callback_via(uint64_t via) +{ + struct xen_hvm_param a; + int ret; + + a.domid =3D DOMID_SELF; + a.index =3D HVM_PARAM_CALLBACK_IRQ; + a.value =3D via; + + ret =3D HYPERVISOR_hvm_op(HVMOP_set_param, &a); + if (ret) + return ret; + + /* + * If xenbus_probe_initcall() deferred the xenbus_probe() + * due to the callback not functioning yet, we can do it now. + */ + if (!xenstored_ready && xen_store_domain_type =3D=3D XS_HVM && + IS_ENABLED(CONFIG_XEN_PVHVM) && !xen_have_vector_callback) + xenbus_probe(); + + return ret; +} +EXPORT_SYMBOL_GPL(xen_set_callback_via); + /* Set up event channel for xenstored which is run as a local process * (this is normally used only in dom0) */ @@ -818,11 +852,17 @@ static int __init xenbus_init(void) break; } =20 - /* Initialize the interface to xenstore. */ - err =3D xs_init(); - if (err) { - pr_warn("Error initializing xenstore comms: %i\n", err); - goto out_error; + /* + * HVM domains may not have a functional callback yet. In that + * case let xs_init() be called from xenbus_probe(), which will + * get invoked at an appropriate time. + */ + if (xen_store_domain_type !=3D XS_HVM) { + err =3D xs_init(); + if (err) { + pr_warn("Error initializing xenstore comms: %i\n", err); + goto out_error; + } } =20 if ((xen_store_domain_type !=3D XS_LOCAL) && diff --git a/include/xen/xenbus.h b/include/xen/xenbus.h index 00c7235ae93e..2c43b0ef1e4d 100644 --- a/include/xen/xenbus.h +++ b/include/xen/xenbus.h @@ -192,7 +192,7 @@ void xs_suspend_cancel(void); =20 struct work_struct; =20 -void xenbus_probe(struct work_struct *); +void xenbus_probe(void); =20 #define XENBUS_IS_ERR_READ(str) ({ \ if (!IS_ERR(str) && strlen(str) =3D=3D 0) { \ --=20 2.29.2 From nobody Tue May 7 14:21:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1609891117; cv=none; d=zohomail.com; s=zohoarc; b=T4iv2z3sG13doafPSGocz0Y4caoMFtC9xMCWrBwtUy8uUllEiEdnjQNAR1pGAHlkFdHVOpSXUx9X4+oyc+ZFYveRsa+WEOSMNTUyafq3OjyaAZ5t3vgMvOQ3GN22COjgYozh13oAfZJ1j/h5pVRo4qIv52gwDDNGQjii0Wlujls= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1609891117; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=syx4fu3vYSlHpqPUTOPP75qBiFyto3EbQNXax9AAeb0=; b=JAjJmdhXuFUcij0/SB0yqGE8uvToklItfee5CBlj/dN85pJZrOq2Zby9uzGTMtSy2n+u36zJSFqKXX7Fv6sQZKtyKfQ1N7m117cYwxjzrmPNI+KPnII9FkBWeRZ9xyQjD+ueQ5ddB9pwJVW6xH2NRf59gxIAMirSvXPy5Eqblm8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1609891117408321.49901851459254; Tue, 5 Jan 2021 15:58:37 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.62237.110126 (Exim 4.92) (envelope-from ) id 1kwwDS-0000go-AL; Tue, 05 Jan 2021 23:58:18 +0000 Received: by outflank-mailman (output) from mailman id 62237.110126; Tue, 05 Jan 2021 23:58:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kwwDS-0000ge-6O; Tue, 05 Jan 2021 23:58:18 +0000 Received: by outflank-mailman (input) for mailman id 62237; Tue, 05 Jan 2021 23:58:17 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kwwDR-0000XD-3z for xen-devel@lists.xenproject.org; Tue, 05 Jan 2021 23:58:17 +0000 Received: from merlin.infradead.org (unknown [2001:8b0:10b:1231::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 582cf231-8df7-4e50-9533-c6ada03bd513; Tue, 05 Jan 2021 23:57:58 +0000 (UTC) Received: from i7.infradead.org ([2001:8b0:10b:1:21e:67ff:fecb:7a92]) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwwCz-0002IP-4D; Tue, 05 Jan 2021 23:57:49 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1kwwCx-001NA8-5B; Tue, 05 Jan 2021 23:57:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 582cf231-8df7-4e50-9533-c6ada03bd513 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=syx4fu3vYSlHpqPUTOPP75qBiFyto3EbQNXax9AAeb0=; b=2uSiPNivq8Z5lylo8O9e7Urt2U mYOLP/tb16OxKt/wKZfZsZ5Gf+BQitrcJoMZUgvu5o8QbsQ/okz3S+oCrTSc+IVgcEqcvttQM3OQq Ht83qiax9FV2xYFEfrNujAo4wBDCIFpGqIIx8LjRdk+EqyaAt1KbQoK7fZmv/rxhY8WwmSgdnwOEC EETqlSocKW/BZJ3GdtozI/Ic8vVx5y60RZtpo1vTV7jmEo3GovtK6793mXGGrL9V4dYNgeEkhdkwl K3pL89WQP9R1YYAT2Al+Ol0jPrpMIl/p4IAUiYDWpxtDefTKMUMCdlneT9SlEaoj8mlOwBvc8pXdM TAUQGD5Q==; From: David Woodhouse To: x86@kernel.org Cc: Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Paul Durrant , jgrall@amazon.com, karahmed@amazon.de, xen-devel Subject: [PATCH v2 2/5] xen: Set platform PCI device INTX affinity to CPU0 Date: Tue, 5 Jan 2021 23:57:33 +0000 Message-Id: <20210105235736.326797-3-dwmw2@infradead.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210105235736.326797-1-dwmw2@infradead.org> References: <20210105235736.326797-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by merlin.infradead.org. See http://www.infradead.org/rpr.html X-ZohoMail-DKIM: pass (identity @infradead.org) Content-Type: text/plain; charset="utf-8" From: David Woodhouse With INTX or GSI delivery, Xen uses the event channel structures of CPU0. If the interrupt gets handled by Linux on a different CPU, then no events are seen as pending. Rather than introducing locking to allow other CPUs to process CPU0's events, just ensure that the PCI interrupts happens only on CPU0. Signed-off-by: David Woodhouse Reviewed-by: Boris Ostrovsky --- drivers/xen/platform-pci.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/xen/platform-pci.c b/drivers/xen/platform-pci.c index 9db557b76511..18f0ed8b1f93 100644 --- a/drivers/xen/platform-pci.c +++ b/drivers/xen/platform-pci.c @@ -132,6 +132,13 @@ static int platform_pci_probe(struct pci_dev *pdev, dev_warn(&pdev->dev, "request_irq failed err=3D%d\n", ret); goto out; } + /* + * It doesn't strictly *have* to run on CPU0 but it sure + * as hell better process the event channel ports delivered + * to CPU0. + */ + irq_set_affinity(pdev->irq, cpumask_of(0)); + callback_via =3D get_callback_via(pdev); ret =3D xen_set_callback_via(callback_via); if (ret) { --=20 2.29.2 From nobody Tue May 7 14:21:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1609891115; cv=none; d=zohomail.com; s=zohoarc; b=QySszZqXtqM1wIQ9/AWmj7RacTM6tze9UUKDzbXOMKD/9j13z9/Fghn+Anp+4XD8sePQPlVa3jDn26cKqBcqe9TpMVwBqsToRlKjBw2uzYocdOdqDpOILGWEHqXQGmC1tOcpBU6UAe8nJBJNHIHVtZa1azR4gwzu2QL1WE8hHnM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1609891115; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=SleIGNuBIkcJy/BuzaYlQ36nlrAW+Se74wmuZZts4Ek=; b=fSrV6fZNCgo12V76vxNXEn+R5+DKlzNSqZAlPcD0geZm6qYOHKRrQXQT9CtccyIdxJD4IT6Qvijl9eKZi7d211CgcIeLt8baVcZmq+VOIHD8LYnn6i1EnHKWN7p2w+z+pd87zoXuPMeRnnmbypy/TOxM0VbJrL94oVI3RnrN70o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1609891115541287.1999769135424; Tue, 5 Jan 2021 15:58:35 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.62234.110089 (Exim 4.92) (envelope-from ) id 1kwwDE-0000XP-EU; Tue, 05 Jan 2021 23:58:04 +0000 Received: by outflank-mailman (output) from mailman id 62234.110089; Tue, 05 Jan 2021 23:58:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kwwDE-0000XI-BK; Tue, 05 Jan 2021 23:58:04 +0000 Received: by outflank-mailman (input) for mailman id 62234; Tue, 05 Jan 2021 23:58:03 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kwwDC-0000XD-Ca for xen-devel@lists.xenproject.org; Tue, 05 Jan 2021 23:58:03 +0000 Received: from merlin.infradead.org (unknown [2001:8b0:10b:1231::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4711cb5e-3905-4f64-91be-f7748cd7014b; Tue, 05 Jan 2021 23:57:58 +0000 (UTC) Received: from i7.infradead.org ([2001:8b0:10b:1:21e:67ff:fecb:7a92]) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwwCz-0002IN-46; Tue, 05 Jan 2021 23:57:49 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1kwwCx-001NAA-5k; Tue, 05 Jan 2021 23:57:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 4711cb5e-3905-4f64-91be-f7748cd7014b DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=SleIGNuBIkcJy/BuzaYlQ36nlrAW+Se74wmuZZts4Ek=; b=WWlEYHCy85R/FFTF9dse/4uOWn 69q0oDCx3QogTFEtX3QRLMJWT+iSZCYOdDYz3gtFbc6gZf6yoaIkboa7jKyPVi9DL7QWH/qFD7Ht1 PRAKKvAq4XXgNJnFCRG1P/68w664Al30+sxiJ5wJgtGpdo3aXbRUkQDbH76DzWgfYLQt+XfOvIPT9 6jw2Kd8lkhOFtd+OWeekBy+3KbDIoq6tEW4d6xSUZE3ErutqMfAgoBpf4Ufz7K7k2u/3jIlm6Zlph qQ/rzbfJjHTDI/GOUJlCTqbXxhrVdHiZW8Uo2tfuRTHBOki2CPcFbtl1GoDmWpuCR9ayYl3CXObM2 jqUQPZaQ==; From: David Woodhouse To: x86@kernel.org Cc: Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Paul Durrant , jgrall@amazon.com, karahmed@amazon.de, xen-devel Subject: [PATCH v2 3/5] x86/xen: Add a no_vector_callback option to test PCI INTX delivery Date: Tue, 5 Jan 2021 23:57:34 +0000 Message-Id: <20210105235736.326797-4-dwmw2@infradead.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210105235736.326797-1-dwmw2@infradead.org> References: <20210105235736.326797-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by merlin.infradead.org. See http://www.infradead.org/rpr.html X-ZohoMail-DKIM: pass (identity @infradead.org) Content-Type: text/plain; charset="utf-8" From: David Woodhouse It's useful to be able to test non-vector event channel delivery, to make sure Linux will work properly on older Xen which doesn't have it. It's also useful for those working on Xen and Xen-compatible hypervisors, because there are guest kernels still in active use which use PCI INTX even when vector delivery is available. Signed-off-by: David Woodhouse --- Documentation/admin-guide/kernel-parameters.txt | 4 ++++ arch/x86/xen/enlighten_hvm.c | 11 ++++++++++- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentatio= n/admin-guide/kernel-parameters.txt index c722ec19cd00..35b10982d363 100644 --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -3389,6 +3389,10 @@ =20 nosync [HW,M68K] Disables sync negotiation for all devices. =20 + no_vector_callback + [KNL,X86,XEN] Disable the vector callback for Xen + event channel interrupts. + nowatchdog [KNL] Disable both lockup detectors, i.e. soft-lockup and NMI watchdog (hard-lockup). =20 diff --git a/arch/x86/xen/enlighten_hvm.c b/arch/x86/xen/enlighten_hvm.c index 9e87ab010c82..a1c07e0c888e 100644 --- a/arch/x86/xen/enlighten_hvm.c +++ b/arch/x86/xen/enlighten_hvm.c @@ -188,6 +188,8 @@ static int xen_cpu_dead_hvm(unsigned int cpu) return 0; } =20 +static bool no_vector_callback __initdata; + static void __init xen_hvm_guest_init(void) { if (xen_pv_domain()) @@ -207,7 +209,7 @@ static void __init xen_hvm_guest_init(void) =20 xen_panic_handler_init(); =20 - if (xen_feature(XENFEAT_hvm_callback_vector)) + if (!no_vector_callback && xen_feature(XENFEAT_hvm_callback_vector)) xen_have_vector_callback =3D 1; =20 xen_hvm_smp_init(); @@ -233,6 +235,13 @@ static __init int xen_parse_nopv(char *arg) } early_param("xen_nopv", xen_parse_nopv); =20 +static __init int xen_parse_no_vector_callback(char *arg) +{ + no_vector_callback =3D true; + return 0; +} +early_param("no_vector_callback", xen_parse_no_vector_callback); + bool __init xen_hvm_need_lapic(void) { if (xen_pv_domain()) --=20 2.29.2 From nobody Tue May 7 14:21:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1609891117; cv=none; d=zohomail.com; s=zohoarc; b=d/KqU0eFIAkp5Be2oVmB+D0vlZOUmvZt2vxc4VN3TX1SWt+8cdT1lfrhxV/44o3lBjNa2xQ5MbkKLNCpDkvkAprcCIPa8+5/w+8TytuF6zWiNknJpa5WtTH6HLMhV/IaCt0USFAnMuTMJNls3UaaR7LM8aSW+q3bfR4kimczuOY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1609891117; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/y7xyBOWQdiArZhUHR7tQEOTtNCkH0Fdd/x6jF59FFM=; b=VyXpBnxHfsGJ2wj5UDfI6miUzRCxS50CX/YgnSGb8qaPPnQgUWW4C8qg33gRUQ7FYboFGxv8tj1J9cy+SyxZBCq9JimgFpuFi7R0RtXVHXMP1YAlP3E5Qdm6fDZ0Jh92evQIcs1Hf20uhbq0oPRZ3LQy24pbPTBsBp0+iELDX4g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1609891116997209.93882911971696; Tue, 5 Jan 2021 15:58:36 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.62235.110101 (Exim 4.92) (envelope-from ) id 1kwwDI-0000Yb-N7; Tue, 05 Jan 2021 23:58:08 +0000 Received: by outflank-mailman (output) from mailman id 62235.110101; Tue, 05 Jan 2021 23:58:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kwwDI-0000YU-Ja; Tue, 05 Jan 2021 23:58:08 +0000 Received: by outflank-mailman (input) for mailman id 62235; Tue, 05 Jan 2021 23:58:07 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kwwDH-0000XD-3f for xen-devel@lists.xenproject.org; Tue, 05 Jan 2021 23:58:07 +0000 Received: from merlin.infradead.org (unknown [2001:8b0:10b:1231::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 938706ca-fba1-4ef9-87bb-146cbb89eadb; Tue, 05 Jan 2021 23:57:58 +0000 (UTC) Received: from i7.infradead.org ([2001:8b0:10b:1:21e:67ff:fecb:7a92]) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwwCz-0002IO-4A; Tue, 05 Jan 2021 23:57:49 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1kwwCx-001NAC-6H; Tue, 05 Jan 2021 23:57:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 938706ca-fba1-4ef9-87bb-146cbb89eadb DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=/y7xyBOWQdiArZhUHR7tQEOTtNCkH0Fdd/x6jF59FFM=; b=oIB8OYonJRE6F71e28aFk+v1Sl UttYfCEFViiABygjefGU8+obqfER82s56AncqN0r+11hNqgx+cVeqHgO3OEvxWGeTyMCm+lQ5d4NE fGUAaoJY+NDnxwUGZjahHJiUPHK5IHaXYU891i187OVq3z/Sv5WpwYKmkH2NrS8ZRW/5XLJAgJqmn 3hCfmkKEtfKXxdClf4S48SBxsQ/cwmm0LITcB1CvzM3PphOKwRxRig6vejsB6/hZfsjNQGMTsMv/v 8HA/sZ54yyPFC5/4TvDYBfvLsiIWxLuzg7QNuHDBH6wx4yXU64r+RirhoY6ddticzFbUFnaBec4vE n2g1kKsA==; From: David Woodhouse To: x86@kernel.org Cc: Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Paul Durrant , jgrall@amazon.com, karahmed@amazon.de, xen-devel Subject: [PATCH v2 4/5] x86/xen: Don't register Xen IPIs when they aren't going to be used Date: Tue, 5 Jan 2021 23:57:35 +0000 Message-Id: <20210105235736.326797-5-dwmw2@infradead.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210105235736.326797-1-dwmw2@infradead.org> References: <20210105235736.326797-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by merlin.infradead.org. See http://www.infradead.org/rpr.html X-ZohoMail-DKIM: pass (identity @infradead.org) Content-Type: text/plain; charset="utf-8" From: David Woodhouse In the case where xen_have_vector_callback is false, we still register the IPI vectors in xen_smp_intr_init() for the secondary CPUs even though they aren't going to be used. Stop doing that. Signed-off-by: David Woodhouse Reviewed-by: Boris Ostrovsky --- arch/x86/xen/enlighten_hvm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/xen/enlighten_hvm.c b/arch/x86/xen/enlighten_hvm.c index a1c07e0c888e..7a6ef517e81a 100644 --- a/arch/x86/xen/enlighten_hvm.c +++ b/arch/x86/xen/enlighten_hvm.c @@ -164,10 +164,10 @@ static int xen_cpu_up_prepare_hvm(unsigned int cpu) else per_cpu(xen_vcpu_id, cpu) =3D cpu; rc =3D xen_vcpu_setup(cpu); - if (rc) + if (rc || !xen_have_vector_callback) return rc; =20 - if (xen_have_vector_callback && xen_feature(XENFEAT_hvm_safe_pvclock)) + if (xen_feature(XENFEAT_hvm_safe_pvclock)) xen_setup_timer(cpu); =20 rc =3D xen_smp_intr_init(cpu); --=20 2.29.2 From nobody Tue May 7 14:21:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1609891116; cv=none; d=zohomail.com; s=zohoarc; b=eflmAy6GARNaDigWYwx9agG9jD3wvzs2/9RGigc8s0tSY0KFXYqMcZYS9ZmssA4mHpNWmgSq18bfP1QbhGaWJR9vIX5E6BpZd/Gw8uMZRzFuDjtEq/bMRQdngO1jVOQQYrXdVatDgBGqm6VVwwaEG0Qr1jwHYV75A/fvnzvLnZM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1609891116; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=zJdWT4nmYH9PrIng9c798nP3ZS4w64deCUNFYYU8vyE=; b=c+M3xBYPnEn/zEizp5cnt9hMonzllmgaP1iBkGlg7Lj/DYMvJQ9ij4SnvM4q6kGmAWZTweiUT5/FiFPvxtI5dx7RgcTqRlKtLjIh0rZaGOp2PKSFSIdQXn/9hVbEdlY4Gap1RSgsfza/BZxFbKqBaS6xggYJPzSEfos6XABRAj8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1609891116118580.9647221420366; Tue, 5 Jan 2021 15:58:36 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.62236.110114 (Exim 4.92) (envelope-from ) id 1kwwDN-0000cW-17; Tue, 05 Jan 2021 23:58:13 +0000 Received: by outflank-mailman (output) from mailman id 62236.110114; Tue, 05 Jan 2021 23:58:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kwwDM-0000cN-T6; Tue, 05 Jan 2021 23:58:12 +0000 Received: by outflank-mailman (input) for mailman id 62236; Tue, 05 Jan 2021 23:58:12 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kwwDM-0000XD-3r for xen-devel@lists.xenproject.org; Tue, 05 Jan 2021 23:58:12 +0000 Received: from merlin.infradead.org (unknown [2001:8b0:10b:1231::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d4d66d20-92f5-41c9-83cd-e02f8b3b4aae; Tue, 05 Jan 2021 23:57:58 +0000 (UTC) Received: from i7.infradead.org ([2001:8b0:10b:1:21e:67ff:fecb:7a92]) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwwCz-0002IQ-49; Tue, 05 Jan 2021 23:57:49 +0000 Received: from dwoodhou by i7.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1kwwCx-001NAE-6n; Tue, 05 Jan 2021 23:57:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: d4d66d20-92f5-41c9-83cd-e02f8b3b4aae DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description; bh=zJdWT4nmYH9PrIng9c798nP3ZS4w64deCUNFYYU8vyE=; b=sUjEHfZ1QaH1h9zMPolJq5y2g9 FFv4flX2JOBRPbLepCMAkg88N2V1GWDiy8zF4psyj9/nndMK0kCCT7TaZpiN44y/L/9GOGCCF0+Dm +ZGLYZ47hwHQcZ0TpDkhQ4/gbsXemPbWuNHSJl2LhtamagIRC0XxRJJhMnddahuVIb4KlumdccDRS 8c1w554+TMsArwhIKpMT+ia6//RqhDg7i6R6kplFqhrTHTBeo2Lx4yybkFF+Dzx0f+STBDlfHVPDy QWa/Fl0QF57N5kkF3ZKqN+Pm/GHqA9/Tgyvn3G0959zHDsa7U1cU8Q4SoLb0uw1hVxPX/mL26vSE0 dDOKFe6w==; From: David Woodhouse To: x86@kernel.org Cc: Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Paul Durrant , jgrall@amazon.com, karahmed@amazon.de, xen-devel Subject: [PATCH v2 5/5] x86/xen: Fix xen_hvm_smp_init() when vector callback not available Date: Tue, 5 Jan 2021 23:57:36 +0000 Message-Id: <20210105235736.326797-6-dwmw2@infradead.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210105235736.326797-1-dwmw2@infradead.org> References: <20210105235736.326797-1-dwmw2@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: David Woodhouse X-SRS-Rewrite: SMTP reverse-path rewritten from by merlin.infradead.org. See http://www.infradead.org/rpr.html X-ZohoMail-DKIM: pass (identity @infradead.org) From: David Woodhouse Only the IPI-related functions in the smp_ops should be conditional on the vector callback being available. The rest should still happen: =E2=80=A2 xen_hvm_smp_prepare_boot_cpu() This function does two things, both of which should still happen if there is no vector callback support. The call to xen_vcpu_setup() for vCPU0 should still happen as it just sets up the vcpu_info for CPU0. That does happen for the secondary vCPUs too, from xen_cpu_up_prepare_hvm(). The second thing it does is call xen_init_spinlocks(), which perhaps counter-intuitively should *also* still be happening in the case without vector callbacks, so that it can clear its local xen_pvspin flag and disable the virt_spin_lock_key accordingly. Checking xen_have_vector_callback in xen_init_spinlocks() itself would affect PV guests, so set the global nopvspin flag in xen_hvm_smp_init() instead, when vector callbacks aren't available. =E2=80=A2 xen_hvm_smp_prepare_cpus() This does some IPI-related setup by calling xen_smp_intr_init() and xen_init_lock_cpu(), which can be made conditional. And it sets the xen_vcpu_id to XEN_VCPU_ID_INVALID for all possible CPUS, which does need to happen. =E2=80=A2 xen_smp_cpus_done() This offlines any vCPUs which doesn't fit in the global shared_info page, if separate vcpu_info placement isn't available. That part also needs to happen regardless of vector callback support. =E2=80=A2 xen_hvm_cpu_die() This doesn't actually do anything other than commin_cpu_die() right right now in the !vector_callback case; all three teardown functions it calls should be no-ops. But to guard against future regressions it's useful to call it anyway, and for it to explicitly check for xen_have_vector_callback before calling those additional functions. Signed-off-by: David Woodhouse Reviewed-by: Boris Ostrovsky --- arch/x86/xen/smp_hvm.c | 27 +++++++++++++++++---------- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/arch/x86/xen/smp_hvm.c b/arch/x86/xen/smp_hvm.c index f5e7db4f82ab..056430a1080b 100644 --- a/arch/x86/xen/smp_hvm.c +++ b/arch/x86/xen/smp_hvm.c @@ -33,9 +33,11 @@ static void __init xen_hvm_smp_prepare_cpus(unsigned int= max_cpus) int cpu; =20 native_smp_prepare_cpus(max_cpus); - WARN_ON(xen_smp_intr_init(0)); =20 - xen_init_lock_cpu(0); + if (xen_have_vector_callback) { + WARN_ON(xen_smp_intr_init(0)); + xen_init_lock_cpu(0); + } =20 for_each_possible_cpu(cpu) { if (cpu =3D=3D 0) @@ -50,9 +52,11 @@ static void __init xen_hvm_smp_prepare_cpus(unsigned int= max_cpus) static void xen_hvm_cpu_die(unsigned int cpu) { if (common_cpu_die(cpu) =3D=3D 0) { - xen_smp_intr_free(cpu); - xen_uninit_lock_cpu(cpu); - xen_teardown_timer(cpu); + if (xen_have_vector_callback) { + xen_smp_intr_free(cpu); + xen_uninit_lock_cpu(cpu); + xen_teardown_timer(cpu); + } } } #else @@ -64,14 +68,17 @@ static void xen_hvm_cpu_die(unsigned int cpu) =20 void __init xen_hvm_smp_init(void) { - if (!xen_have_vector_callback) + smp_ops.smp_prepare_boot_cpu =3D xen_hvm_smp_prepare_boot_cpu; + smp_ops.smp_prepare_cpus =3D xen_hvm_smp_prepare_cpus; + smp_ops.smp_cpus_done =3D xen_smp_cpus_done; + smp_ops.cpu_die =3D xen_hvm_cpu_die; + + if (!xen_have_vector_callback) { + nopvspin =3D true; return; + } =20 - smp_ops.smp_prepare_cpus =3D xen_hvm_smp_prepare_cpus; smp_ops.smp_send_reschedule =3D xen_smp_send_reschedule; - smp_ops.cpu_die =3D xen_hvm_cpu_die; smp_ops.send_call_func_ipi =3D xen_smp_send_call_function_ipi; smp_ops.send_call_func_single_ipi =3D xen_smp_send_call_function_single_i= pi; - smp_ops.smp_prepare_boot_cpu =3D xen_hvm_smp_prepare_boot_cpu; - smp_ops.smp_cpus_done =3D xen_smp_cpus_done; } --=20 2.29.2