From nobody Wed May 8 00:35:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1608298314; cv=none; d=zohomail.com; s=zohoarc; b=Yw3gvO8IsqbIlkrDVC1TrXJxV7t38xXMX5rXrUZx4mXNg2kd4nVMs6/6OmgRqeesaiOgHbJ/xCgIV3YekWOUK/hN0BEXQBeRGfOUDIde5/WvWXCOU0uxg7pwukKaU5WsPxOXfydgJPu3HzppeT6uxV4AcxCVF2TX3QpBAFM4nx0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608298314; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To; bh=78IRszokJjcwXWRlJq8XMydnKIcEdWhnJEaC/s7+CP4=; b=dlQw3vhmM91qaELyhms7KMiuSe+DXnp1E0bhUHBtup3cA+oDE+B4GCKfhvZDLu/PzO+sBqVxqXUVa4/wPgk3Ljsy58TzNFfuh83ZuHe+nVViDMu4MwXmX/0AFu36uiBZZXEyS1zEKCqxzHhmNzYF5Ke3ejcf7hP5/kTmr5QzAqc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1608298313998945.5573370088687; Fri, 18 Dec 2020 05:31:53 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.56504.98954 (Exim 4.92) (envelope-from ) id 1kqFqi-0006zu-58; Fri, 18 Dec 2020 13:31:12 +0000 Received: by outflank-mailman (output) from mailman id 56504.98954; Fri, 18 Dec 2020 13:31:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kqFqi-0006zn-1g; Fri, 18 Dec 2020 13:31:12 +0000 Received: by outflank-mailman (input) for mailman id 56504; Fri, 18 Dec 2020 13:31:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kqFqg-0006zi-Vz for xen-devel@lists.xenproject.org; Fri, 18 Dec 2020 13:31:11 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kqFqf-00088R-L5; Fri, 18 Dec 2020 13:31:09 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kqFqf-00037b-7v; Fri, 18 Dec 2020 13:31:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=78IRszokJjcwXWRlJq8XMydnKIcEdWhnJEaC/s7+CP4=; b=ta0capm8ycKAgPRg10EyVyYXOv Eq3yXoDsz5zRDR2pWtdnmZpkhBj5B2wrSZe8T/7LHXp8IlQUyeHykEoY+YgnNGWqEZR4vY8tuaj7b EHVTIh/qq0V9nxVpVYLYxQroVl+ew+/ezFN+501bbZmHhAmBd1ET6Cv0V3/U3kUZ9iCc=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, Rahul.Singh@arm.com, Julien Grall , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Juergen Gross Subject: [PATCH v2] xen: Rework WARN_ON() to return whether a warning was triggered Date: Fri, 18 Dec 2020 13:30:54 +0000 Message-Id: <20201218133054.7744-1-julien@xen.org> X-Mailer: git-send-email 2.17.1 X-ZohoMail-DKIM: pass (identity @xen.org) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Julien Grall So far, our implementation of WARN_ON() cannot be used in the following situation: if ( WARN_ON() ) ... This is because WARN_ON() doesn't return whether a warning has been triggered. Such construciton can be handy if you want to print more information and also dump the stack trace. Therefore, rework the WARN_ON() implementation to return whether a warning was triggered. The idea was borrowed from Linux Signed-off-by: Julien Grall Reviewed-by: Juergen Gross Reviewed-by: Bertrand Marquis Acked-by: Jan Beulich Acked-by: Stefano Stabellini --- Changes in v2: - Rework the commit message - Don't use trailing underscore - Add Bertrand's and Juergen's reviewed-by --- xen/include/xen/lib.h | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/xen/include/xen/lib.h b/xen/include/xen/lib.h index 48429b69b8df..5841bd489c35 100644 --- a/xen/include/xen/lib.h +++ b/xen/include/xen/lib.h @@ -23,7 +23,13 @@ #include =20 #define BUG_ON(p) do { if (unlikely(p)) BUG(); } while (0) -#define WARN_ON(p) do { if (unlikely(p)) WARN(); } while (0) +#define WARN_ON(p) ({ \ + bool ret_warn_on_ =3D (p); \ + \ + if ( unlikely(ret_warn_on_) ) \ + WARN(); \ + unlikely(ret_warn_on_); \ +}) =20 /* All clang versions supported by Xen have _Static_assert. */ #if defined(__clang__) || \ --=20 2.17.1