[PATCH v4 00/11] viridian: add support for ExProcessorMasks

Paul Durrant posted 11 patches 3 years, 3 months ago
Only 9 patches received!
There is a newer version of this series
docs/man/xl.cfg.5.pod.in             |   8 +
tools/include/libxl.h                |   7 +
tools/libs/light/libxl_types.idl     |   1 +
tools/libs/light/libxl_x86.c         |   3 +
xen/arch/x86/hvm/viridian/viridian.c | 604 +++++++++++++++++++++------
xen/include/asm-x86/hvm/viridian.h   |  10 +
xen/include/public/hvm/params.h      |   7 +-
7 files changed, 516 insertions(+), 124 deletions(-)
[PATCH v4 00/11] viridian: add support for ExProcessorMasks
Posted by Paul Durrant 3 years, 3 months ago
From: Paul Durrant <pdurrant@amazon.com>

Paul Durrant (11):
  viridian: don't blindly write to 32-bit registers is 'mode' is invalid
  viridian: move flush hypercall implementation into separate function
  viridian: move IPI hypercall implementation into separate function
  viridian: introduce a per-cpu hypercall_vpmask and accessor
    functions...
  viridian: use hypercall_vpmask in hvcall_ipi()
  viridian: use softirq batching in hvcall_ipi()
  viridian: add ExProcessorMasks variants of the flush hypercalls
  viridian: add ExProcessorMasks variant of the IPI hypercall
  viridian: log initial invocation of each type of hypercall
  viridian: add a new '_HVMPV_ex_processor_masks' bit into
    HVM_PARAM_VIRIDIAN...
  xl / libxl: add 'ex_processor_mask' into
    'libxl_viridian_enlightenment'

 docs/man/xl.cfg.5.pod.in             |   8 +
 tools/include/libxl.h                |   7 +
 tools/libs/light/libxl_types.idl     |   1 +
 tools/libs/light/libxl_x86.c         |   3 +
 xen/arch/x86/hvm/viridian/viridian.c | 604 +++++++++++++++++++++------
 xen/include/asm-x86/hvm/viridian.h   |  10 +
 xen/include/public/hvm/params.h      |   7 +-
 7 files changed, 516 insertions(+), 124 deletions(-)

-- 
2.20.1


Re: [PATCH v4 00/11] viridian: add support for ExProcessorMasks
Posted by Jan Beulich 3 years, 3 months ago
Wei,

On 02.12.2020 10:21, Paul Durrant wrote:
> From: Paul Durrant <pdurrant@amazon.com>
> 
> Paul Durrant (11):
>   viridian: don't blindly write to 32-bit registers is 'mode' is invalid
>   viridian: move flush hypercall implementation into separate function
>   viridian: move IPI hypercall implementation into separate function
>   viridian: introduce a per-cpu hypercall_vpmask and accessor
>     functions...
>   viridian: use hypercall_vpmask in hvcall_ipi()
>   viridian: use softirq batching in hvcall_ipi()
>   viridian: add ExProcessorMasks variants of the flush hypercalls
>   viridian: add ExProcessorMasks variant of the IPI hypercall
>   viridian: log initial invocation of each type of hypercall
>   viridian: add a new '_HVMPV_ex_processor_masks' bit into
>     HVM_PARAM_VIRIDIAN...
>   xl / libxl: add 'ex_processor_mask' into
>     'libxl_viridian_enlightenment'
> 
>  docs/man/xl.cfg.5.pod.in             |   8 +
>  tools/include/libxl.h                |   7 +
>  tools/libs/light/libxl_types.idl     |   1 +
>  tools/libs/light/libxl_x86.c         |   3 +
>  xen/arch/x86/hvm/viridian/viridian.c | 604 +++++++++++++++++++++------
>  xen/include/asm-x86/hvm/viridian.h   |  10 +
>  xen/include/public/hvm/params.h      |   7 +-
>  7 files changed, 516 insertions(+), 124 deletions(-)

the status of this series was one of the topics of yesterday's
community call. Since Paul's prior ping hasn't had a response by
you (possibly because you're on PTO for an extended period of
time) the plan is to get this series in with as much of
reviewing that I was able to do by, perhaps, the middle of next
week. Unless of course we hear back from you earlier, giving at
least an indication of when you might be able to look at this.

Thanks for your understanding.

Paul, I notice v4 patches 10 and 11 never arrived in my inbox.
The list archives also don't have them. Therefore I can't check
the status of the tools side changes, and I don't think I'd
want to commit those anyway without tool stack side acks, the
more that they weren't part of what I've looked at.

Jan

RE: [PATCH v4 00/11] viridian: add support for ExProcessorMasks
Posted by Paul Durrant 3 years, 3 months ago
> -----Original Message-----
> From: Jan Beulich <jbeulich@suse.com>
> Sent: 04 December 2020 08:12
> To: Wei Liu <wl@xen.org>; Paul Durrant <paul@xen.org>
> Cc: Paul Durrant <pdurrant@amazon.com>; xen-devel@lists.xenproject.org
> Subject: Re: [PATCH v4 00/11] viridian: add support for ExProcessorMasks
> 
> Wei,
> 
> On 02.12.2020 10:21, Paul Durrant wrote:
> > From: Paul Durrant <pdurrant@amazon.com>
> >
> > Paul Durrant (11):
> >   viridian: don't blindly write to 32-bit registers is 'mode' is invalid
> >   viridian: move flush hypercall implementation into separate function
> >   viridian: move IPI hypercall implementation into separate function
> >   viridian: introduce a per-cpu hypercall_vpmask and accessor
> >     functions...
> >   viridian: use hypercall_vpmask in hvcall_ipi()
> >   viridian: use softirq batching in hvcall_ipi()
> >   viridian: add ExProcessorMasks variants of the flush hypercalls
> >   viridian: add ExProcessorMasks variant of the IPI hypercall
> >   viridian: log initial invocation of each type of hypercall
> >   viridian: add a new '_HVMPV_ex_processor_masks' bit into
> >     HVM_PARAM_VIRIDIAN...
> >   xl / libxl: add 'ex_processor_mask' into
> >     'libxl_viridian_enlightenment'
> >
> >  docs/man/xl.cfg.5.pod.in             |   8 +
> >  tools/include/libxl.h                |   7 +
> >  tools/libs/light/libxl_types.idl     |   1 +
> >  tools/libs/light/libxl_x86.c         |   3 +
> >  xen/arch/x86/hvm/viridian/viridian.c | 604 +++++++++++++++++++++------
> >  xen/include/asm-x86/hvm/viridian.h   |  10 +
> >  xen/include/public/hvm/params.h      |   7 +-
> >  7 files changed, 516 insertions(+), 124 deletions(-)
> 
> the status of this series was one of the topics of yesterday's
> community call. Since Paul's prior ping hasn't had a response by
> you (possibly because you're on PTO for an extended period of
> time) the plan is to get this series in with as much of
> reviewing that I was able to do by, perhaps, the middle of next
> week. Unless of course we hear back from you earlier, giving at
> least an indication of when you might be able to look at this.
> 
> Thanks for your understanding.
> 
> Paul, I notice v4 patches 10 and 11 never arrived in my inbox.

Oh, yes... I don't see them in my mail either. (I guess I did 'git send-email 000*' instead of 'git send-email 00*'). I'll send v5 (with the extra style fix) and get them on list.

> The list archives also don't have them. Therefore I can't check
> the status of the tools side changes, and I don't think I'd
> want to commit those anyway without tool stack side acks, the
> more that they weren't part of what I've looked at.
> 

Sure. The toolstack side is pretty trivial so hopefully Anthony or Ian would happy to give an ack.

  Paul

> Jan


Re: [PATCH v4 00/11] viridian: add support for ExProcessorMasks
Posted by Wei Liu 3 years, 3 months ago
On Fri, Dec 04, 2020 at 08:26:01AM -0000, Paul Durrant wrote:
> > -----Original Message-----
> > From: Jan Beulich <jbeulich@suse.com>
> > Sent: 04 December 2020 08:12
> > To: Wei Liu <wl@xen.org>; Paul Durrant <paul@xen.org>
> > Cc: Paul Durrant <pdurrant@amazon.com>; xen-devel@lists.xenproject.org
> > Subject: Re: [PATCH v4 00/11] viridian: add support for ExProcessorMasks
> > 
> > Wei,
> > 
> > On 02.12.2020 10:21, Paul Durrant wrote:
> > > From: Paul Durrant <pdurrant@amazon.com>
> > >
> > > Paul Durrant (11):
> > >   viridian: don't blindly write to 32-bit registers is 'mode' is invalid
> > >   viridian: move flush hypercall implementation into separate function
> > >   viridian: move IPI hypercall implementation into separate function
> > >   viridian: introduce a per-cpu hypercall_vpmask and accessor
> > >     functions...
> > >   viridian: use hypercall_vpmask in hvcall_ipi()
> > >   viridian: use softirq batching in hvcall_ipi()
> > >   viridian: add ExProcessorMasks variants of the flush hypercalls
> > >   viridian: add ExProcessorMasks variant of the IPI hypercall
> > >   viridian: log initial invocation of each type of hypercall
> > >   viridian: add a new '_HVMPV_ex_processor_masks' bit into
> > >     HVM_PARAM_VIRIDIAN...
> > >   xl / libxl: add 'ex_processor_mask' into
> > >     'libxl_viridian_enlightenment'
> > >
> > >  docs/man/xl.cfg.5.pod.in             |   8 +
> > >  tools/include/libxl.h                |   7 +
> > >  tools/libs/light/libxl_types.idl     |   1 +
> > >  tools/libs/light/libxl_x86.c         |   3 +
> > >  xen/arch/x86/hvm/viridian/viridian.c | 604 +++++++++++++++++++++------
> > >  xen/include/asm-x86/hvm/viridian.h   |  10 +
> > >  xen/include/public/hvm/params.h      |   7 +-
> > >  7 files changed, 516 insertions(+), 124 deletions(-)
> > 
> > the status of this series was one of the topics of yesterday's
> > community call. Since Paul's prior ping hasn't had a response by
> > you (possibly because you're on PTO for an extended period of
> > time) the plan is to get this series in with as much of
> > reviewing that I was able to do by, perhaps, the middle of next
> > week. Unless of course we hear back from you earlier, giving at
> > least an indication of when you might be able to look at this.
> > 
> > Thanks for your understanding.
> > 
> > Paul, I notice v4 patches 10 and 11 never arrived in my inbox.
> 
> Oh, yes... I don't see them in my mail either. (I guess I did 'git send-email 000*' instead of 'git send-email 00*'). I'll send v5 (with the extra style fix) and get them on list.
> 
> > The list archives also don't have them. Therefore I can't check
> > the status of the tools side changes, and I don't think I'd
> > want to commit those anyway without tool stack side acks, the
> > more that they weren't part of what I've looked at.
> > 
> 
> Sure. The toolstack side is pretty trivial so hopefully Anthony or Ian would happy to give an ack.

You have my ack on that part too.

Wei.