From nobody Sun May 5 06:38:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1606563086; cv=none; d=zohomail.com; s=zohoarc; b=GMiA7uTeY9hYR1x/u0Y3+XNECLWH6iDkpoh2FKRFconzpxMNKbTFfaDWFyLv0sVQDeAcsUYLnDyq2y0Fl8yTsm1IIHodXKH8Q/ckyEwI3JlT1RNfLwD39yZVCgt6BVPMq8b9WqZW1QXdcSL/tIA7yrSJirTUwXZBdJyJdWL1w8w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606563086; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=x08oKDPsYhZfnq1rzPGbIzqD44Wkh09Na1i2ws0EUmg=; b=HSl4rMgPmRckTqNWa+eDpWgi59x6xo2cM5D5iUVpE3cBEDobYdgIS6WP7ZgBjodr4OMVJEVltQ9ybdhX8Z6HXvGIMtyyFUW7WfhWYA6cKwTce7wE/7/Qpp0gE87L2EHlAwnYfaI6GUWKkKrnHCAzfezBP3vgSmLwWCXpd1RQXD4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1606563086476261.7070766449398; Sat, 28 Nov 2020 03:31:26 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.39954.73001 (Exim 4.92) (envelope-from ) id 1kiyRX-0001Yg-Lh; Sat, 28 Nov 2020 11:31:07 +0000 Received: by outflank-mailman (output) from mailman id 39954.73001; Sat, 28 Nov 2020 11:31:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kiyRX-0001YZ-H7; Sat, 28 Nov 2020 11:31:07 +0000 Received: by outflank-mailman (input) for mailman id 39954; Sat, 28 Nov 2020 11:31:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kiyRW-0001YU-6J for xen-devel@lists.xenproject.org; Sat, 28 Nov 2020 11:31:06 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kiyRV-00053m-Tz; Sat, 28 Nov 2020 11:31:05 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kiyRV-0004ry-JI; Sat, 28 Nov 2020 11:31:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:MIME-Version: Message-Id:Date:Subject:Cc:To:From; bh=x08oKDPsYhZfnq1rzPGbIzqD44Wkh09Na1i2ws0EUmg=; b=dVkY1BUejtiAxv1ihPPgma2BP2 eLYN8ElHe5CmHoyZH1raJAVIjH2BU+d7Maq25284XFPUhgdUNJ5N6r5jgMPfN4YhywIKrRHd7pPBa zIqmG4y2ArD+dsf4jY7/6Qkr9nn9plsHxjsqB88D8RAlUBdmjdPdzur8gFvDVRuW5zUY=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , =?UTF-8?q?Roger=20Paul=20Monn=C3=A9?= Subject: [PATCH v2] xen/irq: Propagate the error from init_one_desc_irq() in init_*_irq_data() Date: Sat, 28 Nov 2020 11:31:02 +0000 Message-Id: <20201128113102.6446-1-julien@xen.org> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @xen.org) From: Julien Grall init_one_desc_irq() can return an error if it is unable to allocate memory. While this is unlikely to happen during boot (called from init_{,local_}irq_data()), it is better to harden the code by propagting the return value. Spotted by coverity. CID: 106529 Signed-off-by: Julien Grall Reviewed-by: Roger Paul Monn=C3=A9 --- Changes in v2: - Add Roger's reviewed-by for x86 - Handle --- xen/arch/arm/irq.c | 12 ++++++++++-- xen/arch/x86/irq.c | 7 ++++++- 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c index 3877657a5277..b71b099e6fa2 100644 --- a/xen/arch/arm/irq.c +++ b/xen/arch/arm/irq.c @@ -88,7 +88,11 @@ static int __init init_irq_data(void) for ( irq =3D NR_LOCAL_IRQS; irq < NR_IRQS; irq++ ) { struct irq_desc *desc =3D irq_to_desc(irq); - init_one_irq_desc(desc); + int rc =3D init_one_irq_desc(desc); + + if ( rc ) + return rc; + desc->irq =3D irq; desc->action =3D NULL; } @@ -105,7 +109,11 @@ static int init_local_irq_data(void) for ( irq =3D 0; irq < NR_LOCAL_IRQS; irq++ ) { struct irq_desc *desc =3D irq_to_desc(irq); - init_one_irq_desc(desc); + int rc =3D init_one_irq_desc(desc); + + if ( rc ) + return rc; + desc->irq =3D irq; desc->action =3D NULL; =20 diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c index 45966947919e..3ebd684415ac 100644 --- a/xen/arch/x86/irq.c +++ b/xen/arch/x86/irq.c @@ -428,9 +428,14 @@ int __init init_irq_data(void) =20 for ( irq =3D 0; irq < nr_irqs_gsi; irq++ ) { + int rc; + desc =3D irq_to_desc(irq); desc->irq =3D irq; - init_one_irq_desc(desc); + + rc =3D init_one_irq_desc(desc); + if ( rc ) + return rc; } for ( ; irq < nr_irqs; irq++ ) irq_to_desc(irq)->irq =3D irq; --=20 2.17.1