From nobody Mon Feb 9 18:44:50 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1606244896; cv=none; d=zohomail.com; s=zohoarc; b=ACzr80Cdoo+q9+GJqoi7798KlV4iBXd5RvvLnobSZ00dD48MTgQuVGFKotXKcjAxmP4WEr4ADBeanUkXXoI/ElYu/ZbKEcF/3Izl126L1RmOosBCvNLDCek36lySO7xhYTASR4+D6RKv9D/WSSaNsp4N77N+6g/+T4qW8YGP2Uc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606244896; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=oFMSo+GJNEgaaZ5yNsIGpJUzjgKARczCMDIFteDVII8=; b=gE3qs2153Og5jUKr1pmYq4K5b36uwIvDznmd++rzbM6wpKbAFw/qax1ViSaSzMxm3oYafugBhmON3OPyf+yJQHWRCU+xXTITUoGPRlVXHW++bXYRdM6HqdVDE1fWKy+W3zehcnEi8LtcAXgeyLJBfTM5B+CnCGPo/FGl+zVWEt4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1606244896566861.0399753535278; Tue, 24 Nov 2020 11:08:16 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.36804.68835 (Exim 4.92) (envelope-from ) id 1khdfI-0001IQ-OQ; Tue, 24 Nov 2020 19:07:48 +0000 Received: by outflank-mailman (output) from mailman id 36804.68835; Tue, 24 Nov 2020 19:07:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1khdfI-0001IJ-It; Tue, 24 Nov 2020 19:07:48 +0000 Received: by outflank-mailman (input) for mailman id 36804; Tue, 24 Nov 2020 19:07:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1khdfH-0001HM-BD for xen-devel@lists.xenproject.org; Tue, 24 Nov 2020 19:07:47 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1khdfH-0003sb-1P; Tue, 24 Nov 2020 19:07:47 +0000 Received: from host86-183-162-145.range86-183.btcentralplus.com ([86.183.162.145] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1khdfG-0000r4-PC; Tue, 24 Nov 2020 19:07:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1khdfH-0001HM-BD for xen-devel@lists.xenproject.org; Tue, 24 Nov 2020 19:07:47 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1khdfH-0003sb-1P; Tue, 24 Nov 2020 19:07:47 +0000 Received: from host86-183-162-145.range86-183.btcentralplus.com ([86.183.162.145] helo=u2f063a87eabd5f.home) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1khdfG-0000r4-PC; Tue, 24 Nov 2020 19:07:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=oFMSo+GJNEgaaZ5yNsIGpJUzjgKARczCMDIFteDVII8=; b=mAc7Eq71ryR1pzCsfSRYwmCYU/ JCGcN2QMNxni/S6dKxkM4Wb19VsYomMJsNIikrDh39l1R+rlb8cywON8+lXHhR3cuw0oIy1MIOyX7 tfgxG9iaVQbEifizl33H8kX2QwR/2hhVV2eiG9REegNhtIMtFAVVKuMzB1Quq5UfzsYA=; From: Paul Durrant To: xen-devel@lists.xenproject.org Cc: Paul Durrant , Wei Liu , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v3 01/13] viridian: don't blindly write to 32-bit registers is 'mode' is invalid Date: Tue, 24 Nov 2020 19:07:32 +0000 Message-Id: <20201124190744.11343-2-paul@xen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201124190744.11343-1-paul@xen.org> References: <20201124190744.11343-1-paul@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @xen.org) From: Paul Durrant If hvm_guest_x86_mode() returns something other than 8 or 4 then viridian_hypercall() will return immediately but, on the way out, will write back status as if 'mode' was 4. This patch simply makes it leave the regist= ers alone. NOTE: The formatting of the 'out' label and the switch statement are also adjusted as per CODING_STYLE. Signed-off-by: Paul Durrant --- Cc: Wei Liu Cc: Jan Beulich Cc: Andrew Cooper Cc: "Roger Pau Monn=C3=A9" v2: - New in v2 --- xen/arch/x86/hvm/viridian/viridian.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/hvm/viridian/viridian.c b/xen/arch/x86/hvm/viridi= an/viridian.c index dc7183a54627..54035f75cb1a 100644 --- a/xen/arch/x86/hvm/viridian/viridian.c +++ b/xen/arch/x86/hvm/viridian/viridian.c @@ -692,13 +692,14 @@ int viridian_hypercall(struct cpu_user_regs *regs) break; } =20 -out: + out: output.result =3D status; switch (mode) { case 8: regs->rax =3D output.raw; break; - default: + + case 4: regs->rdx =3D output.raw >> 32; regs->rax =3D (uint32_t)output.raw; break; --=20 2.20.1