From nobody Thu Mar 28 14:58:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1605797700; cv=none; d=zohomail.com; s=zohoarc; b=Z1s2vT2/tTcOExkEHNlTMKQIX/CKcT1k9AxblrK2DXGEb5nsvxJFRgu3KbJ9Bmnl7qte+G2ey8e+QrCSLyv2UJqHF930R8wOd0DUxvXla/Y06AI7UssZWHyauZOnHQkqJDL6OgnmJ+xT88gvNOrCufs6D35yETbIMUrzKflMt3c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605797700; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To; bh=IjvAESUItdtzLYryfFbk/PumKSZoZap17L392zxaSg0=; b=hbRfLgEXWMdb/AfEQUgysWWJeejRU7saA0N3FFjdlc1QCxhoj+NiYWPYPxY2Q2u6pE758DEny+vOWk87BdANJIW3pttue2ezf26emwtOeOKkLL1abO4D+dBnidv4vG8WSlfKT2pxAf5+wQpBTtwthKjShG3UZh7rUcLFQQp6lpU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1605797700931998.1222194546402; Thu, 19 Nov 2020 06:55:00 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.30869.61049 (Exim 4.92) (envelope-from ) id 1kflKd-0005k9-92; Thu, 19 Nov 2020 14:54:43 +0000 Received: by outflank-mailman (output) from mailman id 30869.61049; Thu, 19 Nov 2020 14:54:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kflKd-0005k2-54; Thu, 19 Nov 2020 14:54:43 +0000 Received: by outflank-mailman (input) for mailman id 30869; Thu, 19 Nov 2020 14:54:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kflKb-0005jw-VR for xen-devel@lists.xenproject.org; Thu, 19 Nov 2020 14:54:41 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kflKb-0005wS-HP; Thu, 19 Nov 2020 14:54:41 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kflKb-0003Ic-7K; Thu, 19 Nov 2020 14:54:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kflKb-0005jw-VR for xen-devel@lists.xenproject.org; Thu, 19 Nov 2020 14:54:41 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kflKb-0005wS-HP; Thu, 19 Nov 2020 14:54:41 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kflKb-0003Ic-7K; Thu, 19 Nov 2020 14:54:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=IjvAESUItdtzLYryfFbk/PumKSZoZap17L392zxaSg0=; b=aUUKccIm6WEHV+NVl8UJtVbd/h wS19pwTVyB9NKwBiAGs9bUt4ETT++QNdv5qc6gz5S/2fRmRg5hTzKtabD3TCI39swY3G87Mnfo3Ig M+hjKT7o8a/wk/05rRFIB41YPQqYh7H9rpsFlOzOUWBLFEavZzMCWX2DnDIW0IYdjcLc=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH] xen/irq: Propagate the error from init_one_desc_irq() in init_irq_data() Date: Thu, 19 Nov 2020 14:54:34 +0000 Message-Id: <20201119145434.28065-1-julien@xen.org> X-Mailer: git-send-email 2.17.1 X-ZohoMail-DKIM: pass (identity @xen.org) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Julien Grall init_one_desc_irq() can return an error if it is unable to allocate memory. While this is unlikely to happen during boot (called from init_irq_data()), it is better to harden the code by propagting the return value. Spotted by coverity. CID: 106529 Signed-off-by: Julien Grall Reviewed-by: Bertrand Marquis Reviewed-by: Roger Pau Monn=C3=A9 --- xen/arch/arm/irq.c | 7 ++++++- xen/arch/x86/irq.c | 7 ++++++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c index 3877657a5277..279d221a2b85 100644 --- a/xen/arch/arm/irq.c +++ b/xen/arch/arm/irq.c @@ -88,7 +88,12 @@ static int __init init_irq_data(void) for ( irq =3D NR_LOCAL_IRQS; irq < NR_IRQS; irq++ ) { struct irq_desc *desc =3D irq_to_desc(irq); - init_one_irq_desc(desc); + int rc; + + rc =3D init_one_irq_desc(desc); + if ( rc ) + return rc; + desc->irq =3D irq; desc->action =3D NULL; } diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c index 45966947919e..3ebd684415ac 100644 --- a/xen/arch/x86/irq.c +++ b/xen/arch/x86/irq.c @@ -428,9 +428,14 @@ int __init init_irq_data(void) =20 for ( irq =3D 0; irq < nr_irqs_gsi; irq++ ) { + int rc; + desc =3D irq_to_desc(irq); desc->irq =3D irq; - init_one_irq_desc(desc); + + rc =3D init_one_irq_desc(desc); + if ( rc ) + return rc; } for ( ; irq < nr_irqs; irq++ ) irq_to_desc(irq)->irq =3D irq; --=20 2.17.1