From nobody Sat Apr 20 11:03:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1604671531; cv=none; d=zohomail.com; s=zohoarc; b=KmYXH7hw2k+hMangm1dmJy6uwG1PvrJKUcv1lL+QzWZ6SVajswIP1sQ3L3tG5IpolLK89s87MDGsEJ+suRSNPvs8MN+vk3jmFCvZ5G+Kpg+hHqYibmj0KQjfR6BURQxFsypAQoLAlEsW3wWR9edYGbIu+YNGM5JRZXrVtMUdPPY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604671531; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=q3SxtmeG7Rpmzb0sczZsSNaIt8qtRAlvGjC8n51vPLY=; b=QAHnx62qV1jdVHVnFRewLX0Tueyd0IEFjNAoBvtfuoMx2jHvGeN91GCpC2vWq3Mu0wmkn2htXgXicdyYoeFFTj6NJSBRZ5YO9qGvKejdssNWilbHH4Q3xDAYa+jGX1qMo3s0iwAQQRjR8E3IsIGyfvyUrwn5zKJcquoaICtwYn8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1604671531743165.37040250648988; Fri, 6 Nov 2020 06:05:31 -0800 (PST) Received: from list by lists.xenproject.org with outflank-mailman.20820.46833 (Exim 4.92) (envelope-from ) id 1kb2MX-0001lR-Cg; Fri, 06 Nov 2020 14:05:09 +0000 Received: by outflank-mailman (output) from mailman id 20820.46833; Fri, 06 Nov 2020 14:05:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kb2MX-0001lK-9L; Fri, 06 Nov 2020 14:05:09 +0000 Received: by outflank-mailman (input) for mailman id 20820; Fri, 06 Nov 2020 14:05:08 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kb2MW-0001lF-5M for xen-devel@lists.xenproject.org; Fri, 06 Nov 2020 14:05:08 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 58534034-284d-41d8-8933-883d7a961d01; Fri, 06 Nov 2020 14:05:07 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id AEA6BABDE; Fri, 6 Nov 2020 14:05:05 +0000 (UTC) Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kb2MW-0001lF-5M for xen-devel@lists.xenproject.org; Fri, 06 Nov 2020 14:05:08 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 58534034-284d-41d8-8933-883d7a961d01; Fri, 06 Nov 2020 14:05:07 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id AEA6BABDE; Fri, 6 Nov 2020 14:05:05 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 58534034-284d-41d8-8933-883d7a961d01 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1604671505; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=q3SxtmeG7Rpmzb0sczZsSNaIt8qtRAlvGjC8n51vPLY=; b=j56sZVbVdjmFskmMbHF3wfA8TFXwlrMXPd98g2zH7hucnIp/2NtDBKLs+0jCgBktK6PEae 9m72Th+tr0eE2qxZdTl+ln5q9NvIFP7PzuenzQOw77Ui17aoGu7PeI3czhIFh63ceA8mlY R3UzfBZRFC+Q5LcvytOZuyuilNSzzLA= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Ian Jackson , Wei Liu , Anthony PERARD Subject: [PATCH] tools/libs/light: correct bitmap operations Date: Fri, 6 Nov 2020 15:05:04 +0100 Message-Id: <20201106140504.25488-1-jgross@suse.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @suse.com) Content-Type: text/plain; charset="utf-8" Libxl bitmap operations for single bits (test, set, reset) take the bit number as a signed integer without testing the value to be larger than 0. Correct that by adding the appropriate tests. Signed-off-by: Juergen Gross Acked-by: Wei Liu --- tools/libs/light/libxl_utils.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/libs/light/libxl_utils.c b/tools/libs/light/libxl_utils.c index b039143b8a..4699c4a0a3 100644 --- a/tools/libs/light/libxl_utils.c +++ b/tools/libs/light/libxl_utils.c @@ -688,21 +688,21 @@ int libxl_bitmap_is_empty(const libxl_bitmap *bitmap) =20 int libxl_bitmap_test(const libxl_bitmap *bitmap, int bit) { - if (bit >=3D bitmap->size * 8) + if (bit >=3D bitmap->size * 8 || bit < 0) return 0; return (bitmap->map[bit / 8] & (1 << (bit & 7))) ? 1 : 0; } =20 void libxl_bitmap_set(libxl_bitmap *bitmap, int bit) { - if (bit >=3D bitmap->size * 8) + if (bit >=3D bitmap->size * 8 || bit < 0) return; bitmap->map[bit / 8] |=3D 1 << (bit & 7); } =20 void libxl_bitmap_reset(libxl_bitmap *bitmap, int bit) { - if (bit >=3D bitmap->size * 8) + if (bit >=3D bitmap->size * 8 || bit < 0) return; bitmap->map[bit / 8] &=3D ~(1 << (bit & 7)); } --=20 2.26.2