[PATCH] xen/drivers: remove unused pcidevs_trylock()

Juergen Gross posted 1 patch 3 years, 4 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/xen tags/patchew/20201104082202.12194-1-jgross@suse.com
Maintainers: Andrew Cooper <andrew.cooper3@citrix.com>, Stefano Stabellini <sstabellini@kernel.org>, Ian Jackson <iwj@xenproject.org>, George Dunlap <george.dunlap@citrix.com>, Wei Liu <wl@xen.org>, Paul Durrant <paul@xen.org>, Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>
xen/drivers/passthrough/pci.c | 5 -----
xen/include/xen/pci.h         | 1 -
2 files changed, 6 deletions(-)
[PATCH] xen/drivers: remove unused pcidevs_trylock()
Posted by Juergen Gross 3 years, 4 months ago
pcidevs_trylock() is used nowhere, so remove it.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 xen/drivers/passthrough/pci.c | 5 -----
 xen/include/xen/pci.h         | 1 -
 2 files changed, 6 deletions(-)

diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index 2a3bce1462..51e584127e 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -69,11 +69,6 @@ bool_t pcidevs_locked(void)
     return !!spin_is_locked(&_pcidevs_lock);
 }
 
-bool_t pcidevs_trylock(void)
-{
-    return !!spin_trylock_recursive(&_pcidevs_lock);
-}
-
 static struct radix_tree_root pci_segments;
 
 static inline struct pci_seg *get_pseg(u16 seg)
diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h
index c4d3879761..20a54a5bb4 100644
--- a/xen/include/xen/pci.h
+++ b/xen/include/xen/pci.h
@@ -148,7 +148,6 @@ struct pci_dev {
 void pcidevs_lock(void);
 void pcidevs_unlock(void);
 bool_t __must_check pcidevs_locked(void);
-bool_t __must_check pcidevs_trylock(void);
 
 bool_t pci_known_segment(u16 seg);
 bool_t pci_device_detect(u16 seg, u8 bus, u8 dev, u8 func);
-- 
2.26.2


RE: [PATCH] xen/drivers: remove unused pcidevs_trylock()
Posted by Paul Durrant 3 years, 4 months ago
> -----Original Message-----
> From: Juergen Gross <jgross@suse.com>
> Sent: 04 November 2020 08:22
> To: xen-devel@lists.xenproject.org
> Cc: Juergen Gross <jgross@suse.com>; Jan Beulich <jbeulich@suse.com>; Paul Durrant <paul@xen.org>;
> Andrew Cooper <andrew.cooper3@citrix.com>; George Dunlap <george.dunlap@citrix.com>; Ian Jackson
> <iwj@xenproject.org>; Julien Grall <julien@xen.org>; Stefano Stabellini <sstabellini@kernel.org>; Wei
> Liu <wl@xen.org>
> Subject: [PATCH] xen/drivers: remove unused pcidevs_trylock()
> 
> pcidevs_trylock() is used nowhere, so remove it.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Paul Durrant <paul@xen.org>