From nobody Tue May 7 11:56:19 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1603980132; cv=none; d=zohomail.com; s=zohoarc; b=FJdoMWh/eh+78F21IzgGPQaBRq6sTnyue7f/MO6xlbQqa8jCPJAr/pv6M0qI7LvVIeXIj5XsYMl9qtGWiAjC/Bh+e1j22iNFC1l1eji0O8ji7APwTvtsbvtqOF4lvYvH9w13LJDDgNUUHWrmScj+ZWvk6ZWqKtpgiTvtK415sLA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603980132; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=OBkAKLeKM01Jm1DnM2cfIdjf2VDL+BHN4gdARAEg950=; b=l8mOzP5aB1YbUduSZI+i7vQHjnmNF78Hao97XdmD1naBnRbidFRcFbxOuhGDFRSuu5l2YsIXrr5F5qm5OGlK7o7TS16WL3BGY0uU5N00iZrp+jZWAYllekkWp66lIynqpgwH03BpaTqWlNMc2ppIX0BdgGyuEr+7wzfPpHU83gE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1603980132394221.72987798574854; Thu, 29 Oct 2020 07:02:12 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.14195.35241 (Exim 4.92) (envelope-from ) id 1kY8Uf-0007g1-Qw; Thu, 29 Oct 2020 14:01:33 +0000 Received: by outflank-mailman (output) from mailman id 14195.35241; Thu, 29 Oct 2020 14:01:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kY8Uf-0007fu-Nv; Thu, 29 Oct 2020 14:01:33 +0000 Received: by outflank-mailman (input) for mailman id 14195; Thu, 29 Oct 2020 14:01:32 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kY8Ue-0007fp-KE for xen-devel@lists.xenproject.org; Thu, 29 Oct 2020 14:01:32 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6b261967-038a-452e-a746-fb7780b2e5e9; Thu, 29 Oct 2020 14:01:30 +0000 (UTC) Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kY8Ue-0007fp-KE for xen-devel@lists.xenproject.org; Thu, 29 Oct 2020 14:01:32 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6b261967-038a-452e-a746-fb7780b2e5e9; Thu, 29 Oct 2020 14:01:30 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6b261967-038a-452e-a746-fb7780b2e5e9 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1603980090; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=0C2T7H5utLXNgmzYD5sBnHV5mV4tc2r1W12ZbIfWW4U=; b=Tkicl1PwrkkbCOOJSqTj6ycb00e64Ez3vhN0k9sZAVpQDTIL3BHH3kUl YlEzHrt8lw1AcKtSkAEhca3ndvymFK99QcQCYltHGG0DxXJYSyZNBBmRJ YfS+l3B92y10o7mTsccX4roSGoJ9g3hSPHM+62GwlgjlzwJv7mYOggvVQ U=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: u1wlRsvtVKk7DFfUXO06V3DGPG2mjL+Sawr5OB3JUIpJCRSSOXvUbWc2GjiGog3WStqg+Poslj 0etr4Z1TuZXgSgGvCU0tpqM8a9II9yE0sKuJV0yJRTpAZlXuVG0a9hOQyt6ekuM4HsAu4Iwr1l 7/kVipOaE+mEyljWIkdNhRumdLb2RVZ+TPiwPeerS8W7NI3tClAwfZduRuccDT458svBRizfYG ifxOZc8WqrfhoVtKAwD/LZhMlc7vmyISpU1xyhJJviScqR11B2gUASKL8xDKkf99Ii33bIyOrx bKs= X-SBRS: None X-MesageID: 30067431 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.77,430,1596513600"; d="scan'208";a="30067431" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH] x86/pv: Drop stale comment in dom0_construct_pv() Date: Thu, 29 Oct 2020 14:00:41 +0000 Message-ID: <20201029140041.18343-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) This comment has been around since c/s 1372bca0615 in 2004. It is stale, as it predates the introduction of struct vcpu. It is not obvious that it was even correct at the time. Where a vcpu (doma= in at the time) has been configured to run is unrelated to construct the domai= n's initial pagetables, etc. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monn=C3=A9 CC: Wei Liu Almost... I'm not entirely sure NUMA memory allocation is plumbed through correctly, but even that still has nothing to do with v->processor --- xen/arch/x86/pv/dom0_build.c | 1 - 1 file changed, 1 deletion(-) diff --git a/xen/arch/x86/pv/dom0_build.c b/xen/arch/x86/pv/dom0_build.c index d79503d6a9..f7165309a2 100644 --- a/xen/arch/x86/pv/dom0_build.c +++ b/xen/arch/x86/pv/dom0_build.c @@ -616,7 +616,6 @@ int __init dom0_construct_pv(struct domain *d, v->arch.pv.event_callback_cs =3D FLAT_COMPAT_KERNEL_CS; } =20 - /* WARNING: The new domain must have its 'processor' field filled in! = */ if ( !is_pv_32bit_domain(d) ) { maddr_to_page(mpt_alloc)->u.inuse.type_info =3D PGT_l4_page_table; --=20 2.11.0