From nobody Tue Feb 10 15:45:38 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1603385146; cv=none; d=zohomail.com; s=zohoarc; b=VUblQct1avg2+BchwJZYO5yRuQnxnXQqspAGDgZp5GvJIZ6tbemRMFRrouyqAazTWDiX71CAXAOoVD6qQm4/coKbxEhlXUqRDytVquqqbLm7NAED6T7079FoQVz4JhCLFDCCL4ffr9KQhos84B1ZCeCc0cAbGMTjZRhkzgMxu9g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603385146; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=8uGskAcKrvh3idP+a9aM9+Bc0CPtEtIIFIHW822S8R4=; b=b/Z4412Gj7o2/3V1Q2i3gQRBchao/4dGd+9VI1YH5VuHo1TxPcNRQtVTgClD6j38tzcJAj7rxgbKIDmY55JgNEZPe8RiAz7y38gTOdn3q22qxeUBvfqcBGVQx637pTYYXgnJ4QEchDOqQF7pafCy8/lWfCpfONyJRwa8lmiuc9A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1603385146304527.8024970785533; Thu, 22 Oct 2020 09:45:46 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.10563.28148 (Exim 4.92) (envelope-from ) id 1kVdiT-0007Tw-Am; Thu, 22 Oct 2020 16:45:29 +0000 Received: by outflank-mailman (output) from mailman id 10563.28148; Thu, 22 Oct 2020 16:45:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiT-0007TZ-1w; Thu, 22 Oct 2020 16:45:29 +0000 Received: by outflank-mailman (input) for mailman id 10563; Thu, 22 Oct 2020 16:45:28 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiR-0007J9-Uf for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:27 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id fa7c4406-f7f6-42b8-8760-d03d6f623f99; Thu, 22 Oct 2020 16:45:17 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiH-0005Kl-LN for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:17 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVdiH-0007TI-Kb for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:17 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiF-00059e-TV; Thu, 22 Oct 2020 17:45:15 +0100 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiR-0007J9-Uf for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:27 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id fa7c4406-f7f6-42b8-8760-d03d6f623f99; Thu, 22 Oct 2020 16:45:17 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiH-0005Kl-LN for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:17 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVdiH-0007TI-Kb for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:17 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiF-00059e-TV; Thu, 22 Oct 2020 17:45:15 +0100 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fa7c4406-f7f6-42b8-8760-d03d6f623f99 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=8uGskAcKrvh3idP+a9aM9+Bc0CPtEtIIFIHW822S8R4=; b=j31a3kr2aW1B4s4Ac5mX/Fkyco wY9Er0fLXxa2T9Hngjiek6YcNHKvO0x05IrTlPXmJWHLjwlGvEvpIrF5jKCGy0lKHsnCRZjx0tuP3 iz9A1BhmFqYJqb3H9HK4yjgptZiY6S92SmjGFjGzM8yaXyw2p6zLn2AyrEJDzZ2XMGV8=; From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: Ian Jackson Subject: [OSSTEST PATCH 09/16] PDU/MSU: Retransmit on/off until PDU has changed Date: Thu, 22 Oct 2020 17:44:59 +0100 Message-Id: <20201022164506.1552-10-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201022164506.1552-1-iwj@xenproject.org> References: <20201022164506.1552-1-iwj@xenproject.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @xenproject.org) Content-Type: text/plain; charset="utf-8" The main effect of this is that the transcript will actually show the new PDU state. Previously we would call show(), but APC PDUs would normally not change immediately, so the transcript would show the old state. This also guards against an unresponsive PDU or a packet getting lost. I don't think we have ever seen that. Signed-off-by: Ian Jackson --- pdu-msw | 21 ++++++++++++++++++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/pdu-msw b/pdu-msw index 2d4ec967..c57f9f7c 100755 --- a/pdu-msw +++ b/pdu-msw @@ -41,6 +41,7 @@ while (@ARGV && $ARGV[0] =3D~ m/^-/) { =20 if (@ARGV<2 || @ARGV>3 || $ARGV[0] =3D~ m/^-/) { die "bad usage\n$usagemsg= "; } =20 +our ($max_retries) =3D 16; # timeout =3D 0.05 * max_retries^2 our ($dnsname,$outlet,$action) =3D @ARGV; =20 my ($session,$error) =3D Net::SNMP->session( @@ -142,7 +143,21 @@ if (!defined $action) { } else { my $valset =3D action_value(); print "was: "; show(); - set($valset); - print "now: "; show(); - print "^ note, PDUs often do not update returned info immediately\n"; + + my $retries =3D 0; + for (;;) { + set($valset); + sleep $retries * 0.1; + print "now: "; my $got =3D show(); + if ($got eq $map[$valset]) { last; } + if ($map[$valset] !~ m{^(?:off|on)$}) { + print + "^ note, PDUs often do not update returned info immediately\n"; + last; + } + if ($retries >=3D $max_retries) { + die "PDU does not seem to be changing state!\n"; + } + $retries++; + } } --=20 2.20.1