From nobody Sat May 4 22:04:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1603385160; cv=none; d=zohomail.com; s=zohoarc; b=VRGr/YtvkTqdbb5dCw9PHf0itcT1JseBzN99GHnHaECnBpYyHo7h9bQUTACWKdEqFJ3jm7etDH4p+eF5bsCHW9adGQLSsxKUi5wUzjdJexfMkjSxEdSENAUM4pxwrPmFXEDJC7PqNvNskUlP1pw9C/a0NDiqIOxAewCPaEJlW9U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603385160; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=V79wG/LQmL2k7Tyv4zkT6Uv1QsFd5R/iMJN6smjFWKQ=; b=Bw7SLDOOARvCrO8FOt3BBU2SaPktCaTTSLJFuhgMlW0R0tnfUzko4D4wUcRAsB5in13wtDdPrsyvPGdODONlFBINSbfO8Fvqt0+TMPIamtbiC1t+wFk1okCY4NpdXs62Mx3hycQtFJ+Hrta1E7s8YRLvcjyFuRjCRdPMuK+nwTE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 160338516023286.51842868731183; Thu, 22 Oct 2020 09:46:00 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.10568.28189 (Exim 4.92) (envelope-from ) id 1kVdih-0007sb-KI; Thu, 22 Oct 2020 16:45:43 +0000 Received: by outflank-mailman (output) from mailman id 10568.28189; Thu, 22 Oct 2020 16:45:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdih-0007sR-FR; Thu, 22 Oct 2020 16:45:43 +0000 Received: by outflank-mailman (input) for mailman id 10568; Thu, 22 Oct 2020 16:45:42 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdig-0007J4-GN for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:42 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 16143a18-e853-431d-a4a4-b49a52ec336c; Thu, 22 Oct 2020 16:45:15 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiF-0005KC-J3 for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:15 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVdiF-0007Qi-H8 for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:15 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiD-00059e-Pb; Thu, 22 Oct 2020 17:45:13 +0100 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdig-0007J4-GN for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:42 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 16143a18-e853-431d-a4a4-b49a52ec336c; Thu, 22 Oct 2020 16:45:15 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiF-0005KC-J3 for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:15 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVdiF-0007Qi-H8 for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:15 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiD-00059e-Pb; Thu, 22 Oct 2020 17:45:13 +0100 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 16143a18-e853-431d-a4a4-b49a52ec336c DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=V79wG/LQmL2k7Tyv4zkT6Uv1QsFd5R/iMJN6smjFWKQ=; b=vkinM3MIoJN07Athigc4mvVWxC LGxBzYZc9nN3fYT4Uo3b7H2XpVHUb/Lp5P4IPZ6nGxlfUxmWKZcRHQ2WnV7jbl/ZNGlRpu20EX1sk qFAyyFWk3kKPSsraoAWMq2uzY5Y40a8wcuMUDsqJOC6a4j1oo8Mbb5kB+HokgSVMO7Is=; From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: Ian Jackson Subject: [OSSTEST PATCH 01/16] share in jobdb: Break out $checkconstraints and move call Date: Thu, 22 Oct 2020 17:44:51 +0100 Message-Id: <20201022164506.1552-2-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201022164506.1552-1-iwj@xenproject.org> References: <20201022164506.1552-1-iwj@xenproject.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @xenproject.org) Content-Type: text/plain; charset="utf-8" This must happen after we introduce our new row or it is not effective! Signed-off-by: Ian Jackson --- Osstest/JobDB/Executive.pm | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Osstest/JobDB/Executive.pm b/Osstest/JobDB/Executive.pm index f69ce277..071f31f1 100644 --- a/Osstest/JobDB/Executive.pm +++ b/Osstest/JobDB/Executive.pm @@ -582,6 +582,11 @@ END VALUES (?, ?, ?, ?, ?, ?, ? ) END =20 + my $checkconstraints =3D sub { + $constraintsq->execute($hostname, $ttaskid); + $constraintsq->fetchrow_array() or confess "$hostname ?"; + }; + my $ojvn =3D "$ho->{Ident}_lifecycle"; =20 if (length $r{$ojvn}) { @@ -654,8 +659,6 @@ END push @lifecycle, "$omarks$otj:$o->{stepno}$osuffix"; } } - $constraintsq->execute($hostname, $ttaskid); - $constraintsq->fetchrow_array() or confess "$hostname ?"; =20 if (defined $flight) { $insertq->execute($hostname, $ttaskid, @@ -670,6 +673,7 @@ END undef, undef,undef); } + $checkconstraints->(); }); =20 if (defined $flight) { --=20 2.20.1 From nobody Sat May 4 22:04:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1603385150; cv=none; d=zohomail.com; s=zohoarc; b=AThOCuj4LqCBLcybkCUdYTaon9cAQz3L9k5zLvxcyX/1T4/RLtkffiVN2+C2jGXJTI90fXIFxrtr7IXQfr/FnNIeuXIpMz0YPW6viKelHUzN7Zo7wuQRr0MJnwB7L5yOf0nfNqdU2XUdIk9fCusbFJQKzlhSkClG89EOcpTaF2Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603385150; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=pVToY0m3Sc+yduYNkjYcp+9aOZ5fk0ZnWu2I935eP+I=; b=Vj4XiRV0ITNyITHBs2/vP7x5Y0EAc7tB/6KOtcJN7lT+/XRxpsJ9RbrE9N/uFJdKHOOTXJeoEFN5uju65m3xOx5cWPvpA3CQGfiHp4TNey07HzwyuG9O/CWmkmLDHTFbrDN0e8AXqcpHJVlbRRgEPtEIUFs+bEP6DvfblF/v06k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1603385150048474.42952663801134; Thu, 22 Oct 2020 09:45:50 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.10564.28165 (Exim 4.92) (envelope-from ) id 1kVdiX-0007bF-J5; Thu, 22 Oct 2020 16:45:33 +0000 Received: by outflank-mailman (output) from mailman id 10564.28165; Thu, 22 Oct 2020 16:45:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiX-0007b2-E6; Thu, 22 Oct 2020 16:45:33 +0000 Received: by outflank-mailman (input) for mailman id 10564; Thu, 22 Oct 2020 16:45:32 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiW-0007J4-GJ for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:32 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1bfb5d76-f5c8-40c1-9df1-aa70e381cd8b; Thu, 22 Oct 2020 16:45:15 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiF-0005KF-Pr for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:15 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVdiF-0007Qx-Ot for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:15 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiE-00059e-38; Thu, 22 Oct 2020 17:45:14 +0100 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiW-0007J4-GJ for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:32 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1bfb5d76-f5c8-40c1-9df1-aa70e381cd8b; Thu, 22 Oct 2020 16:45:15 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiF-0005KF-Pr for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:15 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVdiF-0007Qx-Ot for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:15 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiE-00059e-38; Thu, 22 Oct 2020 17:45:14 +0100 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1bfb5d76-f5c8-40c1-9df1-aa70e381cd8b DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=pVToY0m3Sc+yduYNkjYcp+9aOZ5fk0ZnWu2I935eP+I=; b=mbfhseFH6bQXqaNQMBa7wubdjY 9aJgs0UHrwf56Pda0zztYS98M3mWdtQ6SCMltkv5tbQPsMMvKmwWmy7+kYJqDoSPewOzimwKQvPtj anFermhV+Lf2ugm+sMI1Biz8GkQUQLKANSVWRTimvAPBtjYK4nG3be9szLR0PwHEsVao=; From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: Ian Jackson Subject: [OSSTEST PATCH 02/16] share in jobdb: Move out-of-flight special case higher up Date: Thu, 22 Oct 2020 17:44:52 +0100 Message-Id: <20201022164506.1552-3-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201022164506.1552-1-iwj@xenproject.org> References: <20201022164506.1552-1-iwj@xenproject.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @xenproject.org) Content-Type: text/plain; charset="utf-8" This avoids running the runvar computation loop outside flights. This is good amongst other things because that loop prints warnings about undef $flight and $job. Signed-off-by: Ian Jackson --- Osstest/JobDB/Executive.pm | 33 ++++++++++++++++++--------------- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/Osstest/JobDB/Executive.pm b/Osstest/JobDB/Executive.pm index 071f31f1..4fa42e5d 100644 --- a/Osstest/JobDB/Executive.pm +++ b/Osstest/JobDB/Executive.pm @@ -587,6 +587,18 @@ END $constraintsq->fetchrow_array() or confess "$hostname ?"; }; =20 + + if (!defined $flight) { + db_retry($dbh_tests,[], sub { + $insertq->execute($hostname, $ttaskid, + undef,undef, + undef, + undef,undef); + $checkconstraints->(); + }); + return; + } + my $ojvn =3D "$ho->{Ident}_lifecycle"; =20 if (length $r{$ojvn}) { @@ -660,26 +672,17 @@ END } } =20 - if (defined $flight) { - $insertq->execute($hostname, $ttaskid, - $flight, $job, - ($mode eq 'selectprep')+0, + $insertq->execute($hostname, $ttaskid, + $flight, $job, + ($mode eq 'selectprep')+0, # ^ DBD::Pg doesn't accept perl canonical false for bool! # https://rt.cpan.org/Public/Bug/Display.html?id=3D133229 - $tident, $tstepno); - } else { - $insertq->execute($hostname, $ttaskid, - undef,undef, - undef, - undef,undef); - } + $tident, $tstepno); $checkconstraints->(); }); =20 - if (defined $flight) { - push @lifecycle, $newsigil if length $newsigil; - store_runvar($ojvn, "@lifecycle"); - } + push @lifecycle, $newsigil if length $newsigil; + store_runvar($ojvn, "@lifecycle"); } =20 sub current_stepno ($) { #method --=20 2.20.1 From nobody Sat May 4 22:04:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1603385144; cv=none; d=zohomail.com; s=zohoarc; b=XOmuo70+WGqweV5sQ4EA9Gge3FPQIhM1tGHPKTZ0XyiVcpmsuztZU9ZjRNKciYUvFGwutLL/XVX5StBki0AXdoPRCFR9aaq5oNpA8rmUiuBL9ZdsuH3DkiViNI67YWx+JcEXxXnK9hLEu4pobfF1xZQ7ZNJP0LYnKG6fjBozd6Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603385144; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=VA0MrPoomWT3D4MkBrEL/LD+ZtLasw0letLMtdwmVoo=; b=DzzAsMrinans1KXy1UAO6xU4sdiznBuyv7ot9mg/6BmtakoON+0KRdtp0Vc7WJ/VacmtMeReKe0lEeZa1H7AFGNlg0mhwNAZBhTTaDj3WttwBjCWbMGiHTWmi/fJzqIKlubY1dAzwzhLgHNK+S3B1EeLw1f6EVbeRL9isbEOOQ0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1603385144028329.72418279697354; Thu, 22 Oct 2020 09:45:44 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.10558.28093 (Exim 4.92) (envelope-from ) id 1kVdiJ-0007JL-KX; Thu, 22 Oct 2020 16:45:19 +0000 Received: by outflank-mailman (output) from mailman id 10558.28093; Thu, 22 Oct 2020 16:45:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiJ-0007JE-HK; Thu, 22 Oct 2020 16:45:19 +0000 Received: by outflank-mailman (input) for mailman id 10558; Thu, 22 Oct 2020 16:45:17 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiH-0007J4-LK for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:17 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 61030cba-ae82-48ad-b164-aef21b3733e6; Thu, 22 Oct 2020 16:45:16 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiG-0005KI-3b for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:16 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVdiG-0007RI-2W for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:16 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiE-00059e-Aq; Thu, 22 Oct 2020 17:45:14 +0100 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiH-0007J4-LK for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:17 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 61030cba-ae82-48ad-b164-aef21b3733e6; Thu, 22 Oct 2020 16:45:16 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiG-0005KI-3b for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:16 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVdiG-0007RI-2W for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:16 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiE-00059e-Aq; Thu, 22 Oct 2020 17:45:14 +0100 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 61030cba-ae82-48ad-b164-aef21b3733e6 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=VA0MrPoomWT3D4MkBrEL/LD+ZtLasw0letLMtdwmVoo=; b=p4+G4XG0pUFpbh94MGkdGu02z5 WqnNdxe2RlLXu9VjaAGH2FXurQYatuo4cFX0LN8VOud5EL04EqVLbgzy2N+JYEAvZMMm9GVlEw5NJ lJNBqLCrTaMXAascAik3c1Cwr34TLJDtSlpopt+Eq0WptgWNnUss9FjtoBlaN+be3ovI=; From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: Ian Jackson Subject: [OSSTEST PATCH 03/16] PDU/IPMI: Retransmit, don't just wait Date: Thu, 22 Oct 2020 17:44:53 +0100 Message-Id: <20201022164506.1552-4-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201022164506.1552-1-iwj@xenproject.org> References: <20201022164506.1552-1-iwj@xenproject.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @xenproject.org) Content-Type: text/plain; charset="utf-8" We have a system for which ipmitool -H sabro0m -U root -P XXXX -I lanplus power on seems to work but doesn't take effect the first time. Retransit each retry. Signed-off-by: Ian Jackson --- Osstest/PDU/ipmi.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Osstest/PDU/ipmi.pm b/Osstest/PDU/ipmi.pm index 98e8957f..21c94d98 100644 --- a/Osstest/PDU/ipmi.pm +++ b/Osstest/PDU/ipmi.pm @@ -66,11 +66,12 @@ sub pdu_power_state { return; } =20 - system_checked((@cmd, qw(power), $onoff)); - my $count =3D 60; for (;;) { last if $getstatus->() eq $onoff; + + system_checked((@cmd, qw(power), $onoff)); + die "did not power $onoff" unless --$count > 0; sleep(1); } --=20 2.20.1 From nobody Sat May 4 22:04:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1603385144; cv=none; d=zohomail.com; s=zohoarc; b=dNUH8IXgVd3+4LqvI0gpA0HIUs/Juqrbs28CfWaBI6dP81xuG8MnO77N1HUXpTTGgWz5fRNLgQHJdOOm6XFlY9Vxaubg/ftmVBLCJE861c04pmWo+fNPqn3KZ6WKo7gZwf+oOUyk3RrcONqG7NET57A6gpcyLYWi5Cnz6elONA8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603385144; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=C+1e1LkAwGgC5IFexQaEraHAaghkz1YDhSurK5LkpAI=; b=jcGYOqp/TVDASfBveKWXXe4AFtuqjfw3U/NkyVI/NVUWfFzp7VsfVpFsouCnVOoCirkHWnxA4jXGTmu99TbIRJEr0/c/qFVZqTq+m+Eo6JXYBb0b7yxGmCPfsNljlWSgp6T45SJHKXXrn0GNjbtZTSmQGvEoqja5KlTLgds9sfQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1603385144321271.96190883071097; Thu, 22 Oct 2020 09:45:44 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.10560.28117 (Exim 4.92) (envelope-from ) id 1kVdiN-0007M7-7y; Thu, 22 Oct 2020 16:45:23 +0000 Received: by outflank-mailman (output) from mailman id 10560.28117; Thu, 22 Oct 2020 16:45:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiN-0007Lx-3c; Thu, 22 Oct 2020 16:45:23 +0000 Received: by outflank-mailman (input) for mailman id 10560; Thu, 22 Oct 2020 16:45:22 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiM-0007J4-Fr for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:22 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3f992d3f-b987-4b7f-9091-d96978f70784; Thu, 22 Oct 2020 16:45:16 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiG-0005KL-Ac for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:16 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVdiG-0007RX-9l for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:16 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiE-00059e-Jn; Thu, 22 Oct 2020 17:45:14 +0100 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiM-0007J4-Fr for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:22 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3f992d3f-b987-4b7f-9091-d96978f70784; Thu, 22 Oct 2020 16:45:16 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiG-0005KL-Ac for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:16 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVdiG-0007RX-9l for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:16 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiE-00059e-Jn; Thu, 22 Oct 2020 17:45:14 +0100 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f992d3f-b987-4b7f-9091-d96978f70784 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=C+1e1LkAwGgC5IFexQaEraHAaghkz1YDhSurK5LkpAI=; b=05HUeVddBmvdon7uTzWT8QgIbQ g+PurN72ldhACXhYkec8QhHh7S6syxyIKF5W7+t9wsMQKWti+wgMHe6tYCD9dxg7RfQOetmcbK4O4 4y8OSFgonK3LnFStk52FNjCTl8Tm/lLYkDjf7kU/OusOkEBB0VNAikSAgrND3zp/pPRg=; From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: Ian Jackson Subject: [OSSTEST PATCH 04/16] PDU/MSW: Warn that SNMP status is often not immediately updated Date: Thu, 22 Oct 2020 17:44:54 +0100 Message-Id: <20201022164506.1552-5-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201022164506.1552-1-iwj@xenproject.org> References: <20201022164506.1552-1-iwj@xenproject.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @xenproject.org) Content-Type: text/plain; charset="utf-8" If you don't know this, it's very confusing. Signed-off-by: Ian Jackson --- pdu-msw | 1 + 1 file changed, 1 insertion(+) diff --git a/pdu-msw b/pdu-msw index d2691567..04b03a22 100755 --- a/pdu-msw +++ b/pdu-msw @@ -133,4 +133,5 @@ if (!defined $action) { print "was: "; show(); set(); print "now: "; show(); + print "^ note, PDUs often do not update returned info immediately\n"; } --=20 2.20.1 From nobody Sat May 4 22:04:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1603385154; cv=none; d=zohomail.com; s=zohoarc; b=dKzNDKEsL1OTBohFD+1+rToe1qD1TJ5b4fvDOzEoKqUDnaxPqF4a6kc5FXXspE12BUAKaiYJs28uZL4f4b4vPIaZd2Gscw3wIVnV3ztOV8VR0M9ZIk4TJk5oUtiwQIqFeyLM/YrU2sJ4Mpgu3LBXKli/wzhzKDLvnRzrfvoxfNk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603385154; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=pa077BjlAALhun+Yyi8NReU98V341OBBWUC/iUdKDE4=; b=bHssWhL9a5nlsaDgoLoBES7hGIjTtoLQLwEQKMorjuH/FvTKq94lfoYDvYcktTnC/bvzDR20Z99jEiav3gyJS59zoLbpzHZE+BMgUXXwogBlUl/yKAxLxQQhhwL4N367dKBon0yGxf0907THfglLI2Foa3lzQuCXov7Cm9qLR/I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1603385154224628.3917325441065; Thu, 22 Oct 2020 09:45:54 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.10565.28177 (Exim 4.92) (envelope-from ) id 1kVdid-0007kN-1q; Thu, 22 Oct 2020 16:45:39 +0000 Received: by outflank-mailman (output) from mailman id 10565.28177; Thu, 22 Oct 2020 16:45:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdic-0007k7-Re; Thu, 22 Oct 2020 16:45:38 +0000 Received: by outflank-mailman (input) for mailman id 10565; Thu, 22 Oct 2020 16:45:37 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdib-0007J4-GJ for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:37 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ac949d06-cb98-42ec-8bf9-e6ec95e409e3; Thu, 22 Oct 2020 16:45:16 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiG-0005KO-L0 for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:16 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVdiG-0007Rs-J3 for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:16 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiE-00059e-S2; Thu, 22 Oct 2020 17:45:14 +0100 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdib-0007J4-GJ for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:37 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ac949d06-cb98-42ec-8bf9-e6ec95e409e3; Thu, 22 Oct 2020 16:45:16 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiG-0005KO-L0 for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:16 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVdiG-0007Rs-J3 for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:16 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiE-00059e-S2; Thu, 22 Oct 2020 17:45:14 +0100 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ac949d06-cb98-42ec-8bf9-e6ec95e409e3 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=pa077BjlAALhun+Yyi8NReU98V341OBBWUC/iUdKDE4=; b=cvdEr3Hk5nzZwKzhmrsJJqzop0 eskRHXJOZsEttWed1bDYUDVmuFyd2YHS4pFQ3qIy4u6KCqjt+qRk/0fIcdRmlFrHIRSkhiRxRUtgN ejryRhn/AW3zWK4IZFWxysj4Av/5rMczWeTOclFVZPR7xdb0VZ57mOsb4UhANBdYBDnA=; From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: Ian Jackson Subject: [OSSTEST PATCH 05/16] PDU/MSW: Break out get() Date: Thu, 22 Oct 2020 17:44:55 +0100 Message-Id: <20201022164506.1552-6-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201022164506.1552-1-iwj@xenproject.org> References: <20201022164506.1552-1-iwj@xenproject.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @xenproject.org) Content-Type: text/plain; charset="utf-8" This is going to be useful in a moment. Signed-off-by: Ian Jackson --- pdu-msw | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/pdu-msw b/pdu-msw index 04b03a22..58c33952 100755 --- a/pdu-msw +++ b/pdu-msw @@ -106,13 +106,18 @@ my @map=3D (undef, qw( delayed-off delayed-reboot)); =20 -sub show () { +sub get () { my $got=3D $session->get_request($read_oid); die "SNMP error reading $read_oid ".$session->error()." " unless $got; my $val=3D $got->{$read_oid}; die unless $val; my $mean=3D $map[$val]; die "$val ?" unless defined $mean; + return $mean; +} + +sub show () { + my $mean =3D get(); printf "pdu-msw $dnsname: #%s \"%s\" =3D %s\n", $useport, $usename, $m= ean; } =20 --=20 2.20.1 From nobody Sat May 4 22:04:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1603385163; cv=none; d=zohomail.com; s=zohoarc; b=ERJY2WmvA1gjvgtI4CtFu0FrG9kxFnO6WIevmtbCAEzGdSUf0dbSn8pw2SBP9IKSWL+DpEz5jhHbCmkPhXe8+xe/2pIM0V6wT/eVgvJb9ly3eDpzZZdTsMvmJ4/WhHRHq/9p9LqBI4e31ngpo/vdNNKeERWilx7XNktjFW1PAHQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603385163; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ntqiqHkBhbltgpOYvMT5RzXTVuOOnIgx7foXFuhot5c=; b=Sn7PxFGsT73UZKt1vU3wHLY0ghvOZauKkZboyrfMldX2x6iFIIjFzmZ5Vpeum5diriWcfVgZf1DNEPOAcH8Kulh1GjIiT9mwp8MYSEGgI3vJUR0T7uQpXBKANkjbKGgB4yLStMEg4jI4uBQlwrp3uwjdOcasp0ruVZ3Pi3dhA+E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1603385163745268.90425842814034; Thu, 22 Oct 2020 09:46:03 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.10571.28201 (Exim 4.92) (envelope-from ) id 1kVdin-00080J-0g; Thu, 22 Oct 2020 16:45:49 +0000 Received: by outflank-mailman (output) from mailman id 10571.28201; Thu, 22 Oct 2020 16:45:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdim-000808-SN; Thu, 22 Oct 2020 16:45:48 +0000 Received: by outflank-mailman (input) for mailman id 10571; Thu, 22 Oct 2020 16:45:47 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdil-0007J4-Gg for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:47 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a3e2e9d0-401e-4da9-ab8f-1d6bb4e73d93; Thu, 22 Oct 2020 16:45:17 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiG-0005KR-RH for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:16 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVdiG-0007SA-QQ for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:16 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiF-00059e-47; Thu, 22 Oct 2020 17:45:15 +0100 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdil-0007J4-Gg for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:47 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a3e2e9d0-401e-4da9-ab8f-1d6bb4e73d93; Thu, 22 Oct 2020 16:45:17 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiG-0005KR-RH for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:16 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVdiG-0007SA-QQ for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:16 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiF-00059e-47; Thu, 22 Oct 2020 17:45:15 +0100 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a3e2e9d0-401e-4da9-ab8f-1d6bb4e73d93 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=ntqiqHkBhbltgpOYvMT5RzXTVuOOnIgx7foXFuhot5c=; b=2iAOwRkuvPW0EZagl7nN9EmOth fYgb6YvbHkqltJgvB032wVCXk+SgeIcmILNyTSzp6sCwpCV7qZGG7BzlFHxHNq2p0/fQWCaa/D1E0 Fr1hLOBwZ2ek6j0hsJE7X1HlC6Cb0ycgBO0dO7A+2gvlLuhm/APGHU9o7sDDnNEpkKg4=; From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: Ian Jackson Subject: [OSSTEST PATCH 06/16] PDU/MSW: Break out action_value() Date: Thu, 22 Oct 2020 17:44:56 +0100 Message-Id: <20201022164506.1552-7-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201022164506.1552-1-iwj@xenproject.org> References: <20201022164506.1552-1-iwj@xenproject.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @xenproject.org) Content-Type: text/plain; charset="utf-8" This is going to be useful in a moment. Signed-off-by: Ian Jackson --- pdu-msw | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/pdu-msw b/pdu-msw index 58c33952..03b0f342 100755 --- a/pdu-msw +++ b/pdu-msw @@ -121,13 +121,17 @@ sub show () { printf "pdu-msw $dnsname: #%s \"%s\" =3D %s\n", $useport, $usename, $m= ean; } =20 -sub set () { +sub action_value () { my $delayadd=3D ($action =3D~ s/^delayed-// ? 3 : 0); my $valset=3D ($action =3D~ m/^(?:0|off)$/ ? 2 : $action =3D~ m/^(?:1|on)$/ ? 1 : $action =3D~ m/^(?:reboot)$/ ? 3 : die "unknown action $action\n$usagemsg"); - =20 + return $valset; +} + +sub set ($) { + my ($valset) =3D @_; my $res=3D $session->set_request(-varbindlist =3D> [ $write_oid, INTEG= ER, $valset ]); die "SNMP set ".$session->error()." " unless $res; } @@ -135,8 +139,9 @@ sub set () { if (!defined $action) { show(); } else { + my $valset =3D action_value(); print "was: "; show(); - set(); + set($valset); print "now: "; show(); print "^ note, PDUs often do not update returned info immediately\n"; } --=20 2.20.1 From nobody Sat May 4 22:04:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1603385144; cv=none; d=zohomail.com; s=zohoarc; b=MPnxuJ8Z5WZTYckPMFDIOxJkNWnf9pUI7JaSNCRBVozDuph6VBA1R4bV/cN9M7+6E0HK0iqCdKgWW8dxUFZu3b6F9QKr4vPXdgolRLZAQl0z4lrRO5ronZZ1Nmjb477MLeK94E210D3Tngj0CIgqRAMI7mKWMcwqcS8EGAFSoPs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603385144; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=lTKozFywdZBXuKF9Bj7Cq1GHxhWrqzo800hkAgAt6wI=; b=Ngf1XrtcJLVUOZ2tzQJA/aAjJEqOvrgBWWLTv/m3nogoXWyvtJ3NHBIa98gAc2Hgxa2xCEDw7Z2J4eb4c0rFZLtI+oCRu/qmKe80ua9ZmCUPvoMi04zmGJtKiH0PH/3wWUO08iayr0qPcAyurB1tFgWWZlwT8pXUgFiv0qPSw28= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1603385144808902.3660218353361; Thu, 22 Oct 2020 09:45:44 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.10559.28100 (Exim 4.92) (envelope-from ) id 1kVdiJ-0007Jn-WC; Thu, 22 Oct 2020 16:45:19 +0000 Received: by outflank-mailman (output) from mailman id 10559.28100; Thu, 22 Oct 2020 16:45:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiJ-0007JY-P6; Thu, 22 Oct 2020 16:45:19 +0000 Received: by outflank-mailman (input) for mailman id 10559; Thu, 22 Oct 2020 16:45:18 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiI-0007J9-0W for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:18 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0f11cb73-a3a8-404f-98a9-c4b5274c2d3a; Thu, 22 Oct 2020 16:45:17 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiH-0005KZ-3E for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:17 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVdiH-0007SY-2Q for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:17 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiF-00059e-Bv; Thu, 22 Oct 2020 17:45:15 +0100 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiI-0007J9-0W for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:18 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0f11cb73-a3a8-404f-98a9-c4b5274c2d3a; Thu, 22 Oct 2020 16:45:17 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiH-0005KZ-3E for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:17 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVdiH-0007SY-2Q for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:17 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiF-00059e-Bv; Thu, 22 Oct 2020 17:45:15 +0100 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0f11cb73-a3a8-404f-98a9-c4b5274c2d3a DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=lTKozFywdZBXuKF9Bj7Cq1GHxhWrqzo800hkAgAt6wI=; b=MylLuYkvvp9ULb4KjJpXm0fxNN wgEaHk7iPKq7S9V1OeJU79pTUGyB5znm4veg0iJDvwWdIweFwbzv5B6QIlELGW++9zX1KB/FO5Pgd GQkDGFLQhwGiZOSGBG2lEdKbpAvyY5cXMJ3U5Rs4ao6Qff4twuB0NbioXQNzR6cWrPEg=; From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: Ian Jackson Subject: [OSSTEST PATCH 07/16] PDU/MSW: Actually implement delayed-* Date: Thu, 22 Oct 2020 17:44:57 +0100 Message-Id: <20201022164506.1552-8-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201022164506.1552-1-iwj@xenproject.org> References: <20201022164506.1552-1-iwj@xenproject.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @xenproject.org) Content-Type: text/plain; charset="utf-8" Nothing in our tree uses this but having it here is useful docs for the protocol so I shan't just delete it. Signed-off-by: Ian Jackson --- pdu-msw | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pdu-msw b/pdu-msw index 03b0f342..196b6c45 100755 --- a/pdu-msw +++ b/pdu-msw @@ -127,7 +127,7 @@ sub action_value () { $action =3D~ m/^(?:1|on)$/ ? 1 : $action =3D~ m/^(?:reboot)$/ ? 3 : die "unknown action $action\n$usagemsg"); - return $valset; + return $valset + $delayadd; } =20 sub set ($) { --=20 2.20.1 From nobody Sat May 4 22:04:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1603385144; cv=none; d=zohomail.com; s=zohoarc; b=Wrp4a3Rdn3WB6OTgmpMxvZdcdo4eAVHf7Sx2tVjgK2YaGx/WEg82PMD61l7Tewj1H03ikWXsG+JYsxwwJeAsFyTP2qw9hcdOI6AveU8Fol4FQAHIogWs/2GLvXgbkCQ9pRPxwcZGcsozVYYPPXttiCTzc8RBD6cZcW9AGVOjYQk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603385144; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=bFPgih86ZB+5E8DS2+fY36fGNFvkYHro0nXN3elXtQs=; b=XNTFRyuNo/8sutgBIvC0ih9U9+iX4TG7EXziTU/rAjopISW1rvbZw4/279nm/ydF1wAmZD6IJjO+z6YgVfgg0ALjuoRf9yGoxf4yxev1XgXdMTqozumeDaFnlWLOdi6as1jDLxrsRj1q8kmPTloUSUS/Ya1nOf6QdxzI8h9BTzI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1603385144809887.7867047722111; Thu, 22 Oct 2020 09:45:44 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.10561.28129 (Exim 4.92) (envelope-from ) id 1kVdiO-0007Nq-GW; Thu, 22 Oct 2020 16:45:24 +0000 Received: by outflank-mailman (output) from mailman id 10561.28129; Thu, 22 Oct 2020 16:45:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiO-0007Ni-Cj; Thu, 22 Oct 2020 16:45:24 +0000 Received: by outflank-mailman (input) for mailman id 10561; Thu, 22 Oct 2020 16:45:23 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiM-0007J9-UC for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:22 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 06f363db-1555-4fd7-92a8-8a5ce08226d0; Thu, 22 Oct 2020 16:45:17 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiH-0005Kf-DH for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:17 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVdiH-0007T1-CK for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:17 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiF-00059e-Ka; Thu, 22 Oct 2020 17:45:15 +0100 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiM-0007J9-UC for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:22 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 06f363db-1555-4fd7-92a8-8a5ce08226d0; Thu, 22 Oct 2020 16:45:17 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiH-0005Kf-DH for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:17 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVdiH-0007T1-CK for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:17 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiF-00059e-Ka; Thu, 22 Oct 2020 17:45:15 +0100 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 06f363db-1555-4fd7-92a8-8a5ce08226d0 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=bFPgih86ZB+5E8DS2+fY36fGNFvkYHro0nXN3elXtQs=; b=mFv0ByEi14am0LJl3NtKkn8hzw 93y3ookXVXDgNgILgqtiOMsaW1T5XgCZx8vN5vx+ScNCaN9IM7uVT3R7YSQ2ID0uEoH4NgsMovgye yIbmgnkSf4uneRQB1/et8pn0DgOORtB9sc7LRgYUPjw1GlX4GjcT3DzpD6teDnjqVKeY=; From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: Ian Jackson Subject: [OSSTEST PATCH 08/16] PDU/MSW: Make show() return the value from get() Date: Thu, 22 Oct 2020 17:44:58 +0100 Message-Id: <20201022164506.1552-9-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201022164506.1552-1-iwj@xenproject.org> References: <20201022164506.1552-1-iwj@xenproject.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @xenproject.org) Content-Type: text/plain; charset="utf-8" No-one uses this return value yet, so NFC. Signed-off-by: Ian Jackson --- pdu-msw | 1 + 1 file changed, 1 insertion(+) diff --git a/pdu-msw b/pdu-msw index 196b6c45..2d4ec967 100755 --- a/pdu-msw +++ b/pdu-msw @@ -119,6 +119,7 @@ sub get () { sub show () { my $mean =3D get(); printf "pdu-msw $dnsname: #%s \"%s\" =3D %s\n", $useport, $usename, $m= ean; + return $mean; } =20 sub action_value () { --=20 2.20.1 From nobody Sat May 4 22:04:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1603385146; cv=none; d=zohomail.com; s=zohoarc; b=VUblQct1avg2+BchwJZYO5yRuQnxnXQqspAGDgZp5GvJIZ6tbemRMFRrouyqAazTWDiX71CAXAOoVD6qQm4/coKbxEhlXUqRDytVquqqbLm7NAED6T7079FoQVz4JhCLFDCCL4ffr9KQhos84B1ZCeCc0cAbGMTjZRhkzgMxu9g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603385146; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=8uGskAcKrvh3idP+a9aM9+Bc0CPtEtIIFIHW822S8R4=; b=b/Z4412Gj7o2/3V1Q2i3gQRBchao/4dGd+9VI1YH5VuHo1TxPcNRQtVTgClD6j38tzcJAj7rxgbKIDmY55JgNEZPe8RiAz7y38gTOdn3q22qxeUBvfqcBGVQx637pTYYXgnJ4QEchDOqQF7pafCy8/lWfCpfONyJRwa8lmiuc9A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1603385146304527.8024970785533; Thu, 22 Oct 2020 09:45:46 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.10563.28148 (Exim 4.92) (envelope-from ) id 1kVdiT-0007Tw-Am; Thu, 22 Oct 2020 16:45:29 +0000 Received: by outflank-mailman (output) from mailman id 10563.28148; Thu, 22 Oct 2020 16:45:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiT-0007TZ-1w; Thu, 22 Oct 2020 16:45:29 +0000 Received: by outflank-mailman (input) for mailman id 10563; Thu, 22 Oct 2020 16:45:28 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiR-0007J9-Uf for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:27 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id fa7c4406-f7f6-42b8-8760-d03d6f623f99; Thu, 22 Oct 2020 16:45:17 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiH-0005Kl-LN for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:17 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVdiH-0007TI-Kb for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:17 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiF-00059e-TV; Thu, 22 Oct 2020 17:45:15 +0100 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiR-0007J9-Uf for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:27 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id fa7c4406-f7f6-42b8-8760-d03d6f623f99; Thu, 22 Oct 2020 16:45:17 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVdiH-0005Kl-LN for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:17 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVdiH-0007TI-Kb for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 16:45:17 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiF-00059e-TV; Thu, 22 Oct 2020 17:45:15 +0100 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fa7c4406-f7f6-42b8-8760-d03d6f623f99 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=8uGskAcKrvh3idP+a9aM9+Bc0CPtEtIIFIHW822S8R4=; b=j31a3kr2aW1B4s4Ac5mX/Fkyco wY9Er0fLXxa2T9Hngjiek6YcNHKvO0x05IrTlPXmJWHLjwlGvEvpIrF5jKCGy0lKHsnCRZjx0tuP3 iz9A1BhmFqYJqb3H9HK4yjgptZiY6S92SmjGFjGzM8yaXyw2p6zLn2AyrEJDzZ2XMGV8=; From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: Ian Jackson Subject: [OSSTEST PATCH 09/16] PDU/MSU: Retransmit on/off until PDU has changed Date: Thu, 22 Oct 2020 17:44:59 +0100 Message-Id: <20201022164506.1552-10-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201022164506.1552-1-iwj@xenproject.org> References: <20201022164506.1552-1-iwj@xenproject.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @xenproject.org) Content-Type: text/plain; charset="utf-8" The main effect of this is that the transcript will actually show the new PDU state. Previously we would call show(), but APC PDUs would normally not change immediately, so the transcript would show the old state. This also guards against an unresponsive PDU or a packet getting lost. I don't think we have ever seen that. Signed-off-by: Ian Jackson --- pdu-msw | 21 ++++++++++++++++++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/pdu-msw b/pdu-msw index 2d4ec967..c57f9f7c 100755 --- a/pdu-msw +++ b/pdu-msw @@ -41,6 +41,7 @@ while (@ARGV && $ARGV[0] =3D~ m/^-/) { =20 if (@ARGV<2 || @ARGV>3 || $ARGV[0] =3D~ m/^-/) { die "bad usage\n$usagemsg= "; } =20 +our ($max_retries) =3D 16; # timeout =3D 0.05 * max_retries^2 our ($dnsname,$outlet,$action) =3D @ARGV; =20 my ($session,$error) =3D Net::SNMP->session( @@ -142,7 +143,21 @@ if (!defined $action) { } else { my $valset =3D action_value(); print "was: "; show(); - set($valset); - print "now: "; show(); - print "^ note, PDUs often do not update returned info immediately\n"; + + my $retries =3D 0; + for (;;) { + set($valset); + sleep $retries * 0.1; + print "now: "; my $got =3D show(); + if ($got eq $map[$valset]) { last; } + if ($map[$valset] !~ m{^(?:off|on)$}) { + print + "^ note, PDUs often do not update returned info immediately\n"; + last; + } + if ($retries >=3D $max_retries) { + die "PDU does not seem to be changing state!\n"; + } + $retries++; + } } --=20 2.20.1 From nobody Sat May 4 22:04:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1603386565; cv=none; d=zohomail.com; s=zohoarc; b=hbEelIcUoNvH+ZbIFGTqh6hlDIWFRq+8PTHYSUNyXL29V4x4S+fTddSya1BTD/zmMrVDGD3cEuoCcgBmigMYbXMMlXEFiBgDIeth5pII2b7HNYfLdOMvVp3lqAzXJmUb4L6N2tSwIHxwD3qW1uaRBTS+doYcAu/Y1crjhvezHAk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603386565; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=jyYAayf5B+K21/iZZz63Au1pWfx5cy+b2HyWQ2k+sfw=; b=daHLpuXzXQ7qMdUdsO3+7tSc9JrWKEuIRlGcNv9SHqZVHzeB73rwlxOCskEuPeOxudz9VtnReooFWe0EpHdWShUACZtyvSErjTpDSYNR9HTIFI4yfQEMzWVnKs87RfNxzRErYxve42frHlk+AX76krc3W9lfonsuNr30kaCOGDw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1603386565350180.05592384584145; Thu, 22 Oct 2020 10:09:25 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.10596.28251 (Exim 4.92) (envelope-from ) id 1kVe5K-0002Gr-PE; Thu, 22 Oct 2020 17:09:06 +0000 Received: by outflank-mailman (output) from mailman id 10596.28251; Thu, 22 Oct 2020 17:09:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5K-0002Gj-Ll; Thu, 22 Oct 2020 17:09:06 +0000 Received: by outflank-mailman (input) for mailman id 10596; Thu, 22 Oct 2020 17:09:04 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5I-0002GB-Su for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:04 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e49d44e6-1121-4059-adb0-b8ea33001a15; Thu, 22 Oct 2020 17:09:03 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5H-0005tI-Iv for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:03 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVe5H-0005V6-GN for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:03 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiG-00059e-4k; Thu, 22 Oct 2020 17:45:16 +0100 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5I-0002GB-Su for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:04 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e49d44e6-1121-4059-adb0-b8ea33001a15; Thu, 22 Oct 2020 17:09:03 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5H-0005tI-Iv for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:03 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVe5H-0005V6-GN for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:03 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiG-00059e-4k; Thu, 22 Oct 2020 17:45:16 +0100 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e49d44e6-1121-4059-adb0-b8ea33001a15 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=jyYAayf5B+K21/iZZz63Au1pWfx5cy+b2HyWQ2k+sfw=; b=E3pXTXt0upA4zBxDHgZwtEZVsm wr1soaVACF6w6hzG5J3gaN7ZbKofp1JIgDhaeORq9iEB+dFuRr2pjNabUeFh4bkhT6Qa461KfS4A4 DnMLAtypNzSwmrIXtDCoFuBQie/n1yEyQvt68n51GUYH2PKFVxyBolqANh+tOeSxXk40=; From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: Ian Jackson Subject: [OSSTEST PATCH 10/16] host reuse fixes: Fix running of steps adhoc Date: Thu, 22 Oct 2020 17:45:00 +0100 Message-Id: <20201022164506.1552-11-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201022164506.1552-1-iwj@xenproject.org> References: <20201022164506.1552-1-iwj@xenproject.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @xenproject.org) Content-Type: text/plain; charset="utf-8" When a ts script is run by hand, for adhoc testing, there is no OSSTEST_TESTID variable in the environment and the script does not know it's own step number. Such adhoc runs are not tracked as steps in the steps table. For host lifecycle purposes, treat these as ad-hoc out-of-flight uses, based only on the taskid (which will usually be a person's personal static task). Without this, these adhoc runs fail with a constraint violating trying to insert a flight/job/step row into the host lifecycle table: the constraint requires the step to be specified but it is NULL. Signed-off-by: Ian Jackson --- Osstest/JobDB/Executive.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Osstest/JobDB/Executive.pm b/Osstest/JobDB/Executive.pm index 4fa42e5d..04555113 100644 --- a/Osstest/JobDB/Executive.pm +++ b/Osstest/JobDB/Executive.pm @@ -588,7 +588,7 @@ END }; =20 =20 - if (!defined $flight) { + if (!defined $flight || !defined $tstepno) { db_retry($dbh_tests,[], sub { $insertq->execute($hostname, $ttaskid, undef,undef, --=20 2.20.1 From nobody Sat May 4 22:04:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1603386573; cv=none; d=zohomail.com; s=zohoarc; b=bLE84kC2slRGwNwyZ/ZvlDR1M/xJYQuEfIV5mbEa4iCSTPtHSWgTmOwkB+8KSGclGRvwWJiJvERxIkd01HwgHmjERuf7hcJ34T/75OWHihE2cl3u/7BZPw3YiSVZexDlu6vK63mQvHl0BOojzrTQ5pDkU1I+mSopG3DoyYCukWc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603386573; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=hVU1+g4bJC8UHbCyURdy+z5xK2i7GZBXZk4m60xh6gI=; b=Q3Bt0qtZ+kQaYyCfwBsxCGLFjx7kRrRd7wI/0k5rFYnYj9RZbH8yjZFuZ2t/goLW8GpXcg3DNm7SL/nMwPxF09ZTed4vzVAubBf9mEB06scLOHAmNtkVl9x+JM4VpexqebNEm4KVkAB+3aX4MCv2xsFNaxuTGbbrr7kk0QINmFY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1603386573243936.8900808894684; Thu, 22 Oct 2020 10:09:33 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.10598.28276 (Exim 4.92) (envelope-from ) id 1kVe5T-0002O0-CN; Thu, 22 Oct 2020 17:09:15 +0000 Received: by outflank-mailman (output) from mailman id 10598.28276; Thu, 22 Oct 2020 17:09:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5T-0002Ns-80; Thu, 22 Oct 2020 17:09:15 +0000 Received: by outflank-mailman (input) for mailman id 10598; Thu, 22 Oct 2020 17:09:14 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5S-0002N0-1M for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:14 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0f495b60-ce14-4014-9d06-1feaf311c5d6; Thu, 22 Oct 2020 17:09:13 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5R-0005td-2I for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:13 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVe5R-0005X1-02 for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:13 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiG-00059e-C8; Thu, 22 Oct 2020 17:45:16 +0100 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5S-0002N0-1M for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:14 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0f495b60-ce14-4014-9d06-1feaf311c5d6; Thu, 22 Oct 2020 17:09:13 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5R-0005td-2I for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:13 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVe5R-0005X1-02 for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:13 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiG-00059e-C8; Thu, 22 Oct 2020 17:45:16 +0100 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0f495b60-ce14-4014-9d06-1feaf311c5d6 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=hVU1+g4bJC8UHbCyURdy+z5xK2i7GZBXZk4m60xh6gI=; b=T4KHNm77Mgj+qRdM3pGkpeph6X I3K7wgG3miPJ55KYAG6ofd5iZwvJW2D9YoLyuT9nmsjM9xOv4OQFD1J86vckNQTL7NgvR4Y3AKQA4 s3H4Ol3M+wtmFr72WVlxTe5vo3X7Jk4JZKPBiKH9K1bFY8xt2sXxhFJgjK/frYxz2B9Y=; From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: Ian Jackson Subject: [OSSTEST PATCH 11/16] host reuse fixes: Fix runvar entry for adhoc tasks Date: Thu, 22 Oct 2020 17:45:01 +0100 Message-Id: <20201022164506.1552-12-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201022164506.1552-1-iwj@xenproject.org> References: <20201022164506.1552-1-iwj@xenproject.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @xenproject.org) Content-Type: text/plain; charset="utf-8" When processing an item from the host lifecycle table into the runvar, we don't want to do all the processing of flight and job. Instead, we should simply put the ? into the runvar. Previously this would produce ?: which the flight reporting code would choke on. Signed-off-by: Ian Jackson --- Osstest/JobDB/Executive.pm | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Osstest/JobDB/Executive.pm b/Osstest/JobDB/Executive.pm index 04555113..1dcf55ff 100644 --- a/Osstest/JobDB/Executive.pm +++ b/Osstest/JobDB/Executive.pm @@ -649,6 +649,11 @@ END } next if $tj_seen{$oisprepmark.$otj}++; =20 + if (!defined $o->{flight}) { + push @lifecycle, "$omarks$otj"; + next; + } + if (!$omarks && !$olive && defined($o->{flight}) && $ho->{Shared} && $ho->{Shared}{Type} =3D~ m/^build-/ && --=20 2.20.1 From nobody Sat May 4 22:04:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1603386562; cv=none; d=zohomail.com; s=zohoarc; b=SXvUlNMH9L+GQ7BeVBpu9wy9vSOlwSmrEIq8uyiL7b5OLKO5ZeCE4p9XFmAohigkgrIZl5teOGhty0+VKHhLy1D9jmqmB/JxKgadA8576O5cCc7krdQHQRqrhS6cLuciDrCCQQ467T8sPnPUAj2rCl7jYJ+r1owwERNBTLJ4kg4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603386562; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=jomMV8uxLbcen1kF7hY6ev+qMAIxd7EdISVfjmqx5yM=; b=F2yDmf1A/nHhXlnKWUtvI1gk/1nz8kQf/PO49e2lp055UwvoeecTd4tG6CSpsfVPotB63BKtVOgb7i8chi43zyuInESOZAKOCfNauwS1Uk2To2hSiNocBwr3vBOCES2aTF7m942Opanq//TJD44xNe2ZTE7svlvpExBjOwNBnD8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1603386562810647.6092484465119; Thu, 22 Oct 2020 10:09:22 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.10595.28240 (Exim 4.92) (envelope-from ) id 1kVe5F-0002Eq-Gq; Thu, 22 Oct 2020 17:09:01 +0000 Received: by outflank-mailman (output) from mailman id 10595.28240; Thu, 22 Oct 2020 17:09:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5F-0002Ej-CY; Thu, 22 Oct 2020 17:09:01 +0000 Received: by outflank-mailman (input) for mailman id 10595; Thu, 22 Oct 2020 17:09:00 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5E-0002Eb-7k for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:00 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id dfec223b-9a9f-4bac-8dd4-dfbb138bdaa5; Thu, 22 Oct 2020 17:08:59 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5C-0005sw-UZ for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:08:58 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVe5C-0005Tq-TA for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:08:58 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiG-00059e-L7; Thu, 22 Oct 2020 17:45:16 +0100 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5E-0002Eb-7k for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:00 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id dfec223b-9a9f-4bac-8dd4-dfbb138bdaa5; Thu, 22 Oct 2020 17:08:59 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5C-0005sw-UZ for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:08:58 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVe5C-0005Tq-TA for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:08:58 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiG-00059e-L7; Thu, 22 Oct 2020 17:45:16 +0100 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dfec223b-9a9f-4bac-8dd4-dfbb138bdaa5 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=jomMV8uxLbcen1kF7hY6ev+qMAIxd7EdISVfjmqx5yM=; b=N2TvamoVcy3UV9381dfufm20ym w3ylL5ogO+Ryu0b6CCn0GtVCxiuXzqvNVFuTXpRoBfZCwjR/kKaq2ncideCTRWr3wXnGo5EekXx+4 sXBT6v+zLG0p2NMkJrqUUevymK/hQ1C1HenDso0mEtKz4N0gYCJg9LHr8+wnuiHxG6lM=; From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: Ian Jackson Subject: [OSSTEST PATCH 12/16] Introduce guest_mk_lv_name Date: Thu, 22 Oct 2020 17:45:02 +0100 Message-Id: <20201022164506.1552-13-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201022164506.1552-1-iwj@xenproject.org> References: <20201022164506.1552-1-iwj@xenproject.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @xenproject.org) Content-Type: text/plain; charset="utf-8" This changes the way the disk name is constructed but not to any overall effect. Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm | 9 +++++++-- ts-debian-install | 2 +- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm index 5e6b15d9..12aaba79 100644 --- a/Osstest/TestSupport.pm +++ b/Osstest/TestSupport.pm @@ -76,7 +76,7 @@ BEGIN { target_jobdir target_extract_jobdistpath_subdir target_extract_jobdistpath target_extract_distpart target_tftp_prefix - lv_create lv_dev_mapper + lv_create lv_dev_mapper guest_mk_lv_name =20 poll_loop tcpconnect await_tcp contents_make_cpio file_simple_write_contents @@ -2177,6 +2177,11 @@ sub guest_var_commalist ($$) { return split /\,/, guest_var($gho,$runvartail,''); } =20 +sub guest_mk_lv_name ($$) { + my ($gho, $suffix) =3D @_; + return "$gho->{Name}".$suffix; +} + sub prepareguest ($$$$$$) { my ($ho, $gn, $hostname, $tcpcheckport, $mb, $boot_timeout) =3D @_; @@ -2205,7 +2210,7 @@ sub prepareguest ($$$$$$) { # If we have defined guest specific disksize, use it $mb =3D guest_var($gho,'disksize',$mb); if (defined $mb) { - store_runvar("${gn}_disk_lv", $r{"${gn}_hostname"}.'-disk'); + store_runvar("${gn}_disk_lv", guest_mk_lv_name($gho, '-disk')); } =20 if (defined $mb) { diff --git a/ts-debian-install b/ts-debian-install index f07dd676..8caa9d76 100755 --- a/ts-debian-install +++ b/ts-debian-install @@ -100,7 +100,7 @@ END =20 my $cfg=3D "/etc/xen/$gho->{Name}.cfg"; store_runvar("$gho->{Guest}_cfgpath", $cfg); - store_runvar("$gho->{Guest}_swap_lv", "$gho->{Name}-swap"); + store_runvar("$gho->{Guest}_swap_lv", guest_mk_lv_name($gho, "-swap")); } =20 prep(); --=20 2.20.1 From nobody Sat May 4 22:04:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1603386585; cv=none; d=zohomail.com; s=zohoarc; b=ZYBDyhw32HmUSqv3pS7bxqEYSwLy2ys2cQJbMCKFZTdCy6C2kjevHsaxKNXjpStPfcCrycR3VpjPILFbyNMlrhvSf3uGjfrKprcqMKrNzfp3ZvfG6RV6IaFPPG7fAAQ8WArwCar9puqexq97JAq5vtDw0vWD+K8l9oUsD3o16bA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603386585; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=tffHUjllB3zjo74/ONxS2tl01DELgFF4aymKZDnBl6s=; b=DUcRR6SgHxTL84IQgOZvZf0WiEmAhMMnl4BbVX1gNtDLmzb7MzN8eCevWbT09g+9A5hcgM4RQTcllGSBvOXLyei6PKk6rSArySwoFHc5HiV0REtkXkIJyKOo5FUBtM9t6+YLO2VfoK9KGeMP9aO80qrMhuESaYn8aem3R1W0BjQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1603386585674600.5736898443835; Thu, 22 Oct 2020 10:09:45 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.10603.28312 (Exim 4.92) (envelope-from ) id 1kVe5i-0002eH-I7; Thu, 22 Oct 2020 17:09:30 +0000 Received: by outflank-mailman (output) from mailman id 10603.28312; Thu, 22 Oct 2020 17:09:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5i-0002e6-E9; Thu, 22 Oct 2020 17:09:30 +0000 Received: by outflank-mailman (input) for mailman id 10603; Thu, 22 Oct 2020 17:09:29 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5h-0002cx-1W for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:29 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7a78ae94-1a34-442e-8627-7d4668985e07; Thu, 22 Oct 2020 17:09:28 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5f-0005uZ-Vr for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:27 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVe5f-0005aW-UB for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:27 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiG-00059e-T6; Thu, 22 Oct 2020 17:45:16 +0100 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5h-0002cx-1W for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:29 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7a78ae94-1a34-442e-8627-7d4668985e07; Thu, 22 Oct 2020 17:09:28 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5f-0005uZ-Vr for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:27 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVe5f-0005aW-UB for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:27 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiG-00059e-T6; Thu, 22 Oct 2020 17:45:16 +0100 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7a78ae94-1a34-442e-8627-7d4668985e07 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=tffHUjllB3zjo74/ONxS2tl01DELgFF4aymKZDnBl6s=; b=l85ZnbYzAVvw+Bl6L2MKk6LvYa Mhia8nAexPHBnkeZ12z2yFLRT95RfIt9lqPu2MoOpFIa63aCS+hhE6ZIUX/utCtFQW+4k7mIPTW+t fThutrSQocFtDz3ne6Q+u4ffmox/Au1esazD7tKyZblx7uLUUkW0WlyMH0rP+mOxErCU=; From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: Ian Jackson Subject: [OSSTEST PATCH 13/16] Prefix guest LV names with the job name Date: Thu, 22 Oct 2020 17:45:03 +0100 Message-Id: <20201022164506.1552-14-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201022164506.1552-1-iwj@xenproject.org> References: <20201022164506.1552-1-iwj@xenproject.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @xenproject.org) Content-Type: text/plain; charset="utf-8" This means that a subsequent test which reuses the same host will not use the same LVs. This is a good idea because reusing the same LV names in a subsequent job means relying on the "ad hoc run" cleanup code. This is a bad idea because that code is rarely tested. And because, depending on the situation, the old LVs may even still be in use. For example, in a pair test, the guest's LVs will still be set up for use with nbd. It seems better to fix this by using a fresh LV rather than adding more teardown code. The "wear limit" on host reuse is what prevents the disk filling up with LVs from old guests. ts-debian-fixup needs special handling, because Debian's xen-tools' xen-create-image utility hardcodes its notion of LV name construction. We need to rename the actual LVs (perhaps overwriting old ones from a previous ad-hoc run) and also update the config. Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm | 2 +- ts-debian-fixup | 22 ++++++++++++++++++++++ 2 files changed, 23 insertions(+), 1 deletion(-) diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm index 12aaba79..9362a865 100644 --- a/Osstest/TestSupport.pm +++ b/Osstest/TestSupport.pm @@ -2179,7 +2179,7 @@ sub guest_var_commalist ($$) { =20 sub guest_mk_lv_name ($$) { my ($gho, $suffix) =3D @_; - return "$gho->{Name}".$suffix; + return $job."_$gho->{Name}".$suffix; } =20 sub prepareguest ($$$$$$) { diff --git a/ts-debian-fixup b/ts-debian-fixup index a878fe50..810b3aba 100755 --- a/ts-debian-fixup +++ b/ts-debian-fixup @@ -37,6 +37,27 @@ sub savecfg () { $cfg=3D get_filecontents("$cfgstash.orig"); } =20 +sub lvnames () { + my $lvs =3D target_cmd_output_root($ho, "lvdisplay --colon", 30); + foreach my $suffix (qw(disk swap)) { + my $old =3D "$gho->{Name}-$suffix"; + my $new =3D "${job}_${old}"; + my $full_old =3D "/dev/$gho->{Vg}/$old"; + my $full_new =3D "/dev/$gho->{Vg}/$new"; + $cfg =3D~ s{\Q$full_old\E(?![0-9a-zA-Z/_.-])}{ + logm "Replacing in domain config \`$&' with \`$full_new'"; + $full_new; + }ge; + if ($lvs =3D~ m{^ *\Q$full_old\E}m) { + if ($lvs =3D~ m{^ *\Q$full_new\E}m) { + # In case we are re-running (eg, adhoc) + target_cmd_root($ho, "lvremove -f $full_new", 30); + } + target_cmd_root($ho, "lvrename $full_old $new", 30); + } + } +} + sub ether () { # $cfg =3D~ s/^ [ \t]* # ( vif [ \t]* \=3D [ \t]* \[ [ \t]* [\'\"] @@ -207,6 +228,7 @@ sub writecfg () { } =20 savecfg(); +lvnames(); ether(); access(); $console =3D target_setup_rootdev_console_inittab($ho,$gho,"$mountpoint"); --=20 2.20.1 From nobody Sat May 4 22:04:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1603386581; cv=none; d=zohomail.com; s=zohoarc; b=Yye9T5gvRnIbiIHlLD5VVoiZK7EzaYpyYKZqwvSaiIJI2Chwh1fXgSTN5+7ZxrIS4xClIr0SCxKNzov6jCckJubkia6yNLFjMNp2Rr79KfOk/Kjp+fCAal/UjzK9d/DUPin9piwEE6ihWM9O708mEKp07CVrC5F8JM10XSMO+MQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603386581; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=dXejovIZMPj7AL5cM5Q0Y7OBdfs/GA2ayGeb8CLSfew=; b=K/cVmgRopOgUgSCZ2gIg26G/G+fPfJiDd+EarrBq1uwKfp9Bn04WM6NX1TlO/xMCvOW875x4iJA2rJfGql2sJ7I/rG7DJOHgNy7m6qGINUU7MtK4PNCBqxDBgFH+Xv3381QlGq4FnFuySsAOh2/WZw//YQ7xH3vadDtfOlY2YVc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1603386581887983.8043221164203; Thu, 22 Oct 2020 10:09:41 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.10601.28299 (Exim 4.92) (envelope-from ) id 1kVe5e-0002ZQ-6L; Thu, 22 Oct 2020 17:09:26 +0000 Received: by outflank-mailman (output) from mailman id 10601.28299; Thu, 22 Oct 2020 17:09:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5e-0002ZE-24; Thu, 22 Oct 2020 17:09:26 +0000 Received: by outflank-mailman (input) for mailman id 10601; Thu, 22 Oct 2020 17:09:24 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5c-0002Xb-7U for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:24 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0cc435bc-f243-4d0d-abd9-0c2707d32535; Thu, 22 Oct 2020 17:09:23 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5b-0005tz-Eb for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:23 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVe5b-0005ZN-Dn for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:23 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiH-00059e-4G; Thu, 22 Oct 2020 17:45:17 +0100 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5c-0002Xb-7U for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:24 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0cc435bc-f243-4d0d-abd9-0c2707d32535; Thu, 22 Oct 2020 17:09:23 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5b-0005tz-Eb for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:23 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVe5b-0005ZN-Dn for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:23 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiH-00059e-4G; Thu, 22 Oct 2020 17:45:17 +0100 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0cc435bc-f243-4d0d-abd9-0c2707d32535 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=dXejovIZMPj7AL5cM5Q0Y7OBdfs/GA2ayGeb8CLSfew=; b=PE56Vwgb/z5+PpFiMI/wQa0TlL TwX6Xaoao/AJEczGPuOvS1D+WwwQZBJsrs8Aam1fEy6cFHTGh+uX3Y1ZR5g46H4n9sHERRYaZavvN Okc7kReR21rkhA9pbsw5nIgoL//gZS1q67JV/D9g7nBohHKz4gTuqZSb7QUV7bfK8odI=; From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: Ian Jackson Subject: [OSSTEST PATCH 14/16] reporting: Minor fix to reporting of tasks with no subtask Date: Thu, 22 Oct 2020 17:45:04 +0100 Message-Id: <20201022164506.1552-15-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201022164506.1552-1-iwj@xenproject.org> References: <20201022164506.1552-1-iwj@xenproject.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @xenproject.org) Content-Type: text/plain; charset="utf-8" subtask can be NULL. If so, do not include it. This change fixes a warning and a minor cosmetic defect. Signed-off-by: Ian Jackson --- Osstest/Executive.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm index e3ab1dc3..d95d848d 100644 --- a/Osstest/Executive.pm +++ b/Osstest/Executive.pm @@ -427,7 +427,7 @@ sub report_rogue_task_description ($) { my $info=3D "rogue task "; $info .=3D " $arow->{type} $arow->{refkey}"; $info .=3D " ($arow->{comment})" if defined $arow->{comment}; - $info .=3D " $arow->{subtask}"; + $info .=3D " $arow->{subtask}" if defined $arow->{subtask}; $info .=3D " (user $arow->{username})"; return $info; } --=20 2.20.1 From nobody Sat May 4 22:04:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1603386567; cv=none; d=zohomail.com; s=zohoarc; b=gqw4Hufj38BciqQSCorHQgojej3cnfjaIOJQUUqsp4WX0ebbgL0/cuZUf6S7pxEUnccS/0Flbuhq5bJ2DKo538BJ4As+V0RtmE8ukrs+74DUoNHWAgRE8B76iB0wVaiAU6GnSZ7WX/112zravk+t4JAOXB11Gt1WryrUiZEohXM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603386567; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=uD3SLBKiMkKsr66Riht6zcwv/GQ882j78TtfYVzfoKE=; b=clIHTzcs7aZ3IZ1AgxEew/Ojg+fnS4XILRHcrF5242w3gxrGETzRBYLUsgaZ2oeHthaYo6VtqLUEVBI65moHvyaoAtvEWyxf1s1W7yIIFXk0yUKI2XCMlMZ81vKkF4G2Np8Mzz8qbTiA+R7KGhidH7/yt5AlEw/ZsFxOBPjP7Uk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1603386567021732.9514494639338; Thu, 22 Oct 2020 10:09:27 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.10597.28264 (Exim 4.92) (envelope-from ) id 1kVe5Q-0002KN-1o; Thu, 22 Oct 2020 17:09:12 +0000 Received: by outflank-mailman (output) from mailman id 10597.28264; Thu, 22 Oct 2020 17:09:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5P-0002KF-UN; Thu, 22 Oct 2020 17:09:11 +0000 Received: by outflank-mailman (input) for mailman id 10597; Thu, 22 Oct 2020 17:09:09 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5N-0002GB-Ok for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:09 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 586d40d2-9e6f-43e5-8ea2-2722e0efbe36; Thu, 22 Oct 2020 17:09:08 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5M-0005tU-Hj for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:08 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVe5M-0005W0-Gu for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:08 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiH-00059e-Cj; Thu, 22 Oct 2020 17:45:17 +0100 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5N-0002GB-Ok for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:09 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 586d40d2-9e6f-43e5-8ea2-2722e0efbe36; Thu, 22 Oct 2020 17:09:08 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5M-0005tU-Hj for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:08 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVe5M-0005W0-Gu for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:08 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiH-00059e-Cj; Thu, 22 Oct 2020 17:45:17 +0100 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 586d40d2-9e6f-43e5-8ea2-2722e0efbe36 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=uD3SLBKiMkKsr66Riht6zcwv/GQ882j78TtfYVzfoKE=; b=oNAJn4NbsakzNZDpST6aDvIwWy v3eFTy0uKSG6l3lsKn9PaVP0iLv3a+ssXfkNGpg6todEHlxijFZq9YSge1+0xH9F7OWgo4fCK60fQ ZwDecxOiN6ZVdbJ7vQ/7eLWwa6TwOTrGBKi3zNGiyHQa4KkhqK2nOvMyBmuITB/9Tivs=; From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: Ian Jackson Subject: [OSSTEST PATCH 15/16] host reuse fixes: Do not break host-reuse if no host allocated Date: Thu, 22 Oct 2020 17:45:05 +0100 Message-Id: <20201022164506.1552-16-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201022164506.1552-1-iwj@xenproject.org> References: <20201022164506.1552-1-iwj@xenproject.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @xenproject.org) Content-Type: text/plain; charset="utf-8" If host allocation failed, or our dependency jobs failed, then we won't have allocated a host. The host runvar will not be set. In this case, we want to do nothing. But we forgot to pass $noneok to selecthost. Signed-off-by: Ian Jackson --- ts-host-reuse | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ts-host-reuse b/ts-host-reuse index e2498bb6..b885a3e6 100755 --- a/ts-host-reuse +++ b/ts-host-reuse @@ -165,7 +165,7 @@ sub act_start_test () { =20 sub act_final () { if (!@ARGV) { - $ho =3D selecthost($whhost); + $ho =3D selecthost($whhost, 1); return unless $ho; host_update_lifecycle_info($ho, 'final'); } elsif ("@ARGV" eq "--post-test-ok") { --=20 2.20.1 From nobody Sat May 4 22:04:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1603386576; cv=none; d=zohomail.com; s=zohoarc; b=W5XHn0pPgUix5fNnTCMYxjbEiYPzZgHTXo0GlEXQmQCnyZc7GfdKzu9MDVjs8MUNGSqmHGKJ+402nr1EGFhFMMgxMGGVSIei74D9Cl0IEgbNwfPq32HCJ6uYNfAcjuXgg837/FHONNZwxRPvFBlosOK+AG7hHfoPnKQm0DEEBRA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603386576; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=4+xtJRn0orKXngPYVez9yveephWwMruvVYUsWR0keuQ=; b=cV6u7R2LYoBLiTiDN9YyCJibHWhldIRu4iWOF4NMuRBNJwYUv6JixKxKsMSomlCO98K6jQpOBKDVjI+9PMdpJkLR2BiK/ESzeG7DEEkGf66vVZWAzqJzTz9sfT1U7z044iZSknLfyVvh7Pv/sX/nqTiGpLOXaoLOxhwx1+NZFrc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 160338657607553.47352079839493; Thu, 22 Oct 2020 10:09:36 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.10599.28288 (Exim 4.92) (envelope-from ) id 1kVe5Y-0002Te-T4; Thu, 22 Oct 2020 17:09:20 +0000 Received: by outflank-mailman (output) from mailman id 10599.28288; Thu, 22 Oct 2020 17:09:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5Y-0002TW-Oo; Thu, 22 Oct 2020 17:09:20 +0000 Received: by outflank-mailman (input) for mailman id 10599; Thu, 22 Oct 2020 17:09:19 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5X-0002Sc-OG for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:19 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f7c8abf9-876c-4136-9dc3-beec4f6f91f0; Thu, 22 Oct 2020 17:09:19 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5W-0005tp-Ra for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:18 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVe5W-0005YD-Qs for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:18 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiH-00059e-L8; Thu, 22 Oct 2020 17:45:17 +0100 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5X-0002Sc-OG for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:19 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f7c8abf9-876c-4136-9dc3-beec4f6f91f0; Thu, 22 Oct 2020 17:09:19 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kVe5W-0005tp-Ra for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:18 +0000 Received: from iwj (helo=mynotebook.example.org) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1kVe5W-0005YD-Qs for xen-devel@lists.xenproject.org; Thu, 22 Oct 2020 17:09:18 +0000 Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by mariner.uk.xensource.com with esmtp (Exim 4.89) (envelope-from ) id 1kVdiH-00059e-L8; Thu, 22 Oct 2020 17:45:17 +0100 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f7c8abf9-876c-4136-9dc3-beec4f6f91f0 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=4+xtJRn0orKXngPYVez9yveephWwMruvVYUsWR0keuQ=; b=py3IxVqKXg9Kv+dUjFAFRkctIc Wj6kWqyNdx0kCaXJ91JJgEPYIHeuk7JabmNx6RglGaFJYHoiDKSzzxJ+jeO5hP1rG3OAc6bnDnvdi iIHPAejtEEFoyaCgonCIJ5mppPTsAyyfw11YQ0lFBA/B6PY13LfXAE5fmzLbt/DHxIMU=; From: Ian Jackson To: xen-devel@lists.xenproject.org Cc: Ian Jackson Subject: [OSSTEST PATCH 16/16] starvation: Do not count more than half a flight as starved Date: Thu, 22 Oct 2020 17:45:06 +0100 Message-Id: <20201022164506.1552-17-iwj@xenproject.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201022164506.1552-1-iwj@xenproject.org> References: <20201022164506.1552-1-iwj@xenproject.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @xenproject.org) Content-Type: text/plain; charset="utf-8" This seems like a sensible rule. This also prevents the following bizarre behaviour: when a flight has a handful of jobs that cannot be run at all (eg because it's a commissioning flight for only hosts of a particular arch), those jobs can complete quite quickly. Even with a high X value because only a smallish portion of the flight has finished, this can lead to a modest threshhold value. This combines particularly badly with commissioning flights, where the duraation estimates are often nonsense. Signed-off-by: Ian Jackson --- ts-hosts-allocate-Executive | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ts-hosts-allocate-Executive b/ts-hosts-allocate-Executive index b216186a..459b9215 100755 --- a/ts-hosts-allocate-Executive +++ b/ts-hosts-allocate-Executive @@ -863,7 +863,7 @@ sub starving ($$) { "D=3D%d W=3D%d X=3D%.3f t_D=3D%s t_me=3D%s t_lim=3D%.3f X'=3D%.4f (fi.s= =3D%s)", $d, $w, $X, $total_d, $projected_me, $lim, $Xcmp, $fi->{started} - $now; - my $bad =3D $projected_me > $lim; + my $bad =3D $projected_me > $lim && $d >=3D $w; return ($bad, $m); } =20 --=20 2.20.1