From nobody Tue May 7 04:30:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=reject dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1601638270; cv=none; d=zohomail.com; s=zohoarc; b=S4TGShnnLS9uEu0qwsaTuywrOqZuSNCyhLv6+gvUbcYbkkd/gdJNdNWUDT0j+Dq3t++wFjvY5doRgll7B9E8vMFEGUGGLbPc23kymKv0yMrmP1v/AetimQ+FsSiWj+v62kp2mN7U9zyS2y7bb9qBRwoF1/B57VmPO3vXJhI2Bi8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1601638270; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=Ej7YYLrQP15hJyCrbzG8Pty9SySiF8GR6ati8zrSo+g=; b=ibdjR33wCZtQwEZ3ZNNG2MJGC99Ec2XCvvhicQp351jdQrnvaCjTmn6ZsN0mgtaNgBtddULQJjG1M6xcuOxSAXR7IGvGyNeaw7kJqCexDgKNFLDZaxC5k5WgKHfaGEgNG0VwhbBzsBwh828ssl9dDQtUGxfaQQ/CeXeApTjXRzg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=reject dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1601638270032981.1752349499031; Fri, 2 Oct 2020 04:31:10 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1974.5883 (Exim 4.92) (envelope-from ) id 1kOJGq-0004KV-24; Fri, 02 Oct 2020 11:30:40 +0000 Received: by outflank-mailman (output) from mailman id 1974.5883; Fri, 02 Oct 2020 11:30:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kOJGp-0004KO-Tu; Fri, 02 Oct 2020 11:30:39 +0000 Received: by outflank-mailman (input) for mailman id 1974; Fri, 02 Oct 2020 11:30:38 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kOJGo-0004Jz-6z for xen-devel@lists.xenproject.org; Fri, 02 Oct 2020 11:30:38 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4a78ad48-1773-4da8-8fef-805ca647fb72; Fri, 02 Oct 2020 11:30:37 +0000 (UTC) Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kOJGo-0004Jz-6z for xen-devel@lists.xenproject.org; Fri, 02 Oct 2020 11:30:38 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4a78ad48-1773-4da8-8fef-805ca647fb72; Fri, 02 Oct 2020 11:30:37 +0000 (UTC) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a78ad48-1773-4da8-8fef-805ca647fb72 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1601638237; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=zCR6Dv3onCS8k84WLM6YzxWdsEqTYK3W+Ynyk/DsUJU=; b=PfheIrpwkEZII+GxkPZJaevi+N0SyrhRAu1LiRpJeNuQWa1ghwypAtzt QB8tJbqUsJxhQl/UcxqhSkbUGrG1rxjudGB89ZkndFmsp7IKHJn2901U1 J6XJP8In3KpCia2/k/L3gCApW7Bxen1+YbX9XMjB/JK4m7rJVVrVNJKO2 w=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: goJ9Yi/246u1J3b5DSRDg54+JZMFdCm17xpnULr0EByx8xUAKQXtjNAAfzMZ70FivXxFnyGwMZ lqfP7VFAHAGCKbBM2cT3H0CsN6/PC6IIStMhA8YFKaq5xlrXVzAOYBPpBtykF2F93TGAuhuAIA XGG0NqKB4ZFD1PBTmTsBlEHS/Q+izF90UnkhHvfYdvmkN2V+rrhn0PIO9Ro7E2plJU6ynKdCVP O61pfmvLtHojPlPd7gtiKgKnTniv9vzRtKPXMZoul6igIOPUByWLHmB8rqSM/ZYT0zMBrXCluI +Qo= X-SBRS: None X-MesageID: 29170748 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.77,327,1596513600"; d="scan'208";a="29170748" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH] x86/hvm: Correct error message in check_segment() Date: Fri, 2 Oct 2020 12:30:12 +0100 Message-ID: <20201002113012.29932-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @citrix.com) The error message is wrong (given AMD's older interpretation of what a NUL segment should contain, attribute wise), and actively unhelpful because you only get it in response to a hypercall where the one piece of information y= ou cannot provide is the segment selector. Fix the message to talk about segment attributes, rather than the selector. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monn=C3=A9 CC: Wei Liu --- xen/arch/x86/hvm/domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/hvm/domain.c b/xen/arch/x86/hvm/domain.c index 8e3375265c..ffe952c2df 100644 --- a/xen/arch/x86/hvm/domain.c +++ b/xen/arch/x86/hvm/domain.c @@ -39,7 +39,7 @@ static int check_segment(struct segment_register *reg, en= um x86_segment seg) { if ( seg !=3D x86_seg_ds && seg !=3D x86_seg_es ) { - gprintk(XENLOG_ERR, "Null selector provided for CS, SS or TR\n= "); + gprintk(XENLOG_ERR, "Empty segment attributes for CS, SS or TR= \n"); return -EINVAL; } return 0; --=20 2.11.0