[PATCH -next v2] x86/xen: Convert to DEFINE_SHOW_ATTRIBUTE

Qinglang Miao posted 1 patch 3 years, 6 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
arch/x86/xen/p2m.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
[PATCH -next v2] x86/xen: Convert to DEFINE_SHOW_ATTRIBUTE
Posted by Qinglang Miao 3 years, 6 months ago
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
---
v2: based on linux-next(20200917), and can be applied to
    mainline cleanly now.

 arch/x86/xen/p2m.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/arch/x86/xen/p2m.c b/arch/x86/xen/p2m.c
index be4151f42..3301875dd 100644
--- a/arch/x86/xen/p2m.c
+++ b/arch/x86/xen/p2m.c
@@ -795,17 +795,7 @@ static int p2m_dump_show(struct seq_file *m, void *v)
 	return 0;
 }
 
-static int p2m_dump_open(struct inode *inode, struct file *filp)
-{
-	return single_open(filp, p2m_dump_show, NULL);
-}
-
-static const struct file_operations p2m_dump_fops = {
-	.open		= p2m_dump_open,
-	.read		= seq_read,
-	.llseek		= seq_lseek,
-	.release	= single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(p2m_dump);
 
 static struct dentry *d_mmu_debug;
 
-- 
2.23.0


Re: [PATCH -next v2] x86/xen: Convert to DEFINE_SHOW_ATTRIBUTE
Posted by Jürgen Groß 3 years, 3 months ago
On 17.09.20 14:55, Qinglang Miao wrote:
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
> 
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>

Applied to: xen/tip.git for-linus-5.11


Juergen