From nobody Fri Mar 29 01:32:43 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1599900603; cv=none; d=zohomail.com; s=zohoarc; b=GJXJ29LVx6tLdJ6KnaUB1PvulE+L2RuJ8PV3Njnty9boxqi9rouSIe8/Y0jkyIkq3QwBhO/srsJSy6MlEfwGmaiZtgrnfrHYn7WkFAxAP8ix7LAH6T5ZpiyWnEH4COHyBBji9+ecCJI8qFSLlfCHlvTiM5OAXgoALdk1BpF7Sow= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599900603; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=7fZUOXLJWkUkcsrpViX0jTFWIDxSlU9qHugchLE/ufw=; b=eliDqQ4yXqjDeQ4SfwRsPr7G0wq2ciqh5BSeQKllCiXY+cvNjr5IdOs9fNqZClHBTXEuDjMLJTW2LbAh+B3kmIo6DsveBEdCO0t2Le1+E+2eMzD6kGPzZ6rl8DolUkqgVr1hRSllYEy9+VZKpC/R6T3EJjWSOfmDHSjO0ikI4Uk= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1599900603773767.4238891131513; Sat, 12 Sep 2020 01:50:03 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kH1Dv-0001RO-HW; Sat, 12 Sep 2020 08:49:31 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kH1Du-0001RJ-Ql for xen-devel@lists.xenproject.org; Sat, 12 Sep 2020 08:49:30 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0143afed-ded0-4899-b556-db9000d3a358; Sat, 12 Sep 2020 08:49:30 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 064B4B02C; Sat, 12 Sep 2020 08:49:45 +0000 (UTC) X-Inumbo-ID: 0143afed-ded0-4899-b556-db9000d3a358 X-Virus-Scanned: by amavisd-new at test-mx.suse.de From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Ian Jackson , Wei Liu Subject: [PATCH] tools/build: avoid $(file ...) directive in Makefile Date: Sat, 12 Sep 2020 10:49:13 +0200 Message-Id: <20200912084913.5318-1-jgross@suse.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Content-Type: text/plain; charset="utf-8" Using $(file ...) breaks the build with make older than version 4.0. Replace it with echo. Fixes: 52dbd6f07cea7a ("tools: generate pkg-config files from make variable= s") Signed-off-by: Juergen Gross --- tools/Rules.mk | 48 ++++++++++++++++++++++++------------------------ 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/tools/Rules.mk b/tools/Rules.mk index ccb197596e..8ba8230270 100644 --- a/tools/Rules.mk +++ b/tools/Rules.mk @@ -175,29 +175,29 @@ $(PKG_CONFIG_DIR): mkdir -p $(PKG_CONFIG_DIR) =20 $(PKG_CONFIG_DIR)/%.pc: Makefile $(XEN_ROOT)/tools/Rules.mk $(PKG_CONFIG_D= IR) - $(file >$@,prefix=3D$(PKG_CONFIG_PREFIX)) - $(file >>$@,includedir=3D$(PKG_CONFIG_INCDIR)) - $(file >>$@,libdir=3D$(PKG_CONFIG_LIBDIR)) - $(foreach var,$(PKG_CONFIG_VARS),$(file >>$@,$(var))) - $(file >>$@,) - $(file >>$@,Name: $(PKG_CONFIG_NAME)) - $(file >>$@,Description: $(PKG_CONFIG_DESC)) - $(file >>$@,Version: $(PKG_CONFIG_VERSION)) - $(file >>$@,Cflags: -I$${includedir} $(CFLAGS_xeninclude)) - $(file >>$@,Libs: -L$${libdir} $(PKG_CONFIG_USELIBS) -l$(PKG_CONFIG_LIB)) - $(file >>$@,Libs.private: $(PKG_CONFIG_LIBSPRIV)) - $(file >>$@,Requires.private: $(PKG_CONFIG_REQPRIV)) + @echo "prefix=3D$(PKG_CONFIG_PREFIX)" >$@ + @echo "includedir=3D$(PKG_CONFIG_INCDIR)" >>$@ + @echo "libdir=3D$(PKG_CONFIG_LIBDIR)" >>$@ + @for v in $(PKG_CONFIG_VARS); do echo "$$v" >>$@; done + @echo "" >>$@ + @echo "Name: $(PKG_CONFIG_NAME)" >>$@ + @echo "Description: $(PKG_CONFIG_DESC)" >>$@ + @echo "Version: $(PKG_CONFIG_VERSION)" >>$@ + @echo "Cflags: -I\$${includedir} $(CFLAGS_xeninclude)" >>$@ + @echo "Libs: -L\$${libdir} $(PKG_CONFIG_USELIBS) -l$(PKG_CONFIG_LIB)" >>$@ + @echo "Libs.private: $(PKG_CONFIG_LIBSPRIV)" >>$@ + @echo "Requires.private: $(PKG_CONFIG_REQPRIV)" >>$@ =20 %.pc: Makefile $(XEN_ROOT)/tools/Rules.mk - $(file >$@,prefix=3D$(PKG_CONFIG_PREFIX)) - $(file >>$@,includedir=3D$(PKG_CONFIG_INCDIR)) - $(file >>$@,libdir=3D$(PKG_CONFIG_LIBDIR)) - $(foreach var,$(PKG_CONFIG_VARS),$(file >>$@,$(var))) - $(file >>$@,) - $(file >>$@,Name: $(PKG_CONFIG_NAME)) - $(file >>$@,Description: $(PKG_CONFIG_DESC)) - $(file >>$@,Version: $(PKG_CONFIG_VERSION)) - $(file >>$@,Cflags: -I$${includedir}) - $(file >>$@,Libs: -L$${libdir} -l$(PKG_CONFIG_LIB)) - $(file >>$@,Libs.private: $(PKG_CONFIG_LIBSPRIV)) - $(file >>$@,Requires.private: $(PKG_CONFIG_REQPRIV)) + @echo "prefix=3D$(PKG_CONFIG_PREFIX)" >$@ + @echo "includedir=3D$(PKG_CONFIG_INCDIR)" >>$@ + @echo "libdir=3D$(PKG_CONFIG_LIBDIR)" >>$@ + @for v in $(PKG_CONFIG_VARS); do echo "$$v" >>$@; done + @echo "" >>$@ + @echo "Name: $(PKG_CONFIG_NAME)" >>$@ + @echo "Description: $(PKG_CONFIG_DESC)" >>$@ + @echo "Version: $(PKG_CONFIG_VERSION)" >>$@ + @echo "Cflags: -I\$${includedir}" >>$@ + @echo "Libs: -L\$${libdir} -l$(PKG_CONFIG_LIB)" >>$@ + @echo "Libs.private: $(PKG_CONFIG_LIBSPRIV)" >>$@ + @echo "Requires.private: $(PKG_CONFIG_REQPRIV)" >>$@ --=20 2.26.2