From nobody Fri Mar 29 10:20:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1599641973; cv=none; d=zohomail.com; s=zohoarc; b=Vq8VvYQYPIYY4EjUo+mZMtg9VRtemCJPp9/i4BsM8X0HJ4MIHakfc9tATIZiZ5SNuQ7OT3FfYXfbvG5fQ4jtVcsSFFobE1D0n/LJiVoFUSsGkABxSoA7/E/5mwAWZHZtNCR7tc+rvxaSlQJvyAwLD59M14J6vVEsDOfD4rtT90Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599641973; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=WEHC+LUD2lp0yflyObE68XDDsOT9j8D1jg9DQQfoJzY=; b=Y1vYcceKvjEbJwEYRKboTPQyAseGeDo7CCRNY+ze/SL7gz7n8KvPsN4aLYq2Bz2kba8BYSZ3fvbPuIRYFqES+vuu9X0a52IkjXxGtjBgMdXJUY5b425yInrY3dt2kCDwlypBUkv2NYfn1+y0Nsjrs6ld7W0/m2ROzHEKLk/QED8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 159964197308324.90469621626471; Wed, 9 Sep 2020 01:59:33 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kFvwH-0002ox-U1; Wed, 09 Sep 2020 08:58:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kFvwG-0002os-0S for xen-devel@lists.xenproject.org; Wed, 09 Sep 2020 08:58:48 +0000 Received: from mo4-p00-ob.smtp.rzone.de (unknown [85.215.255.21]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 736bf33b-0534-44f9-ae53-411b0d5cf7ca; Wed, 09 Sep 2020 08:58:46 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 46.10.7 SBL|AUTH) with ESMTPSA id 60ad29w898wbKkT (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256 bits)) (Client did not present a certificate); Wed, 9 Sep 2020 10:58:37 +0200 (CEST) X-Inumbo-ID: 736bf33b-0534-44f9-ae53-411b0d5cf7ca DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1599641925; s=strato-dkim-0002; d=aepfle.de; h=Message-Id:Date:Subject:Cc:To:From:X-RZG-CLASS-ID:X-RZG-AUTH:From: Subject:Sender; bh=WEHC+LUD2lp0yflyObE68XDDsOT9j8D1jg9DQQfoJzY=; b=ImXBeEeCBLLhAGcHaXklaOPhMeSAvYB/k+WstaIrBtIXKCUwePaz7TrE01xf6RgUH1 0Vw6ARLptdIteMFX2stiYocyB8qbYJceUKcP/y9D7G8vYCf802HHjJoiIGPKoOu0rX5i RJJrA9AyauuFSCDX/t2ISlZbVfhSsycHFZMbXTbJrBuDtzgBOQr0E9kTLqvW1SrmvcQT 0CPF7cMTluLb1zlfg7OFvRs9lzH27F6bXWIlAjWVhmsw6rhzE7EcQwdZMEo+58yWf8fI 5Ph1j2I9AFA3qdj5HKTdJJ+sgxgxpzxsI3tM3NQ7aiNV1XedbLQvlkNf0TagDwA88N8G uPpw== X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QXkBR9MXjAuzBW/OdlBZQ4AHSS32hIjw==" X-RZG-CLASS-ID: mo00 From: Olaf Hering To: xen-devel@lists.xenproject.org Cc: Olaf Hering , Daniel De Graaf , Quan Xu , Samuel Thibault Subject: [PATCH v2] stubdom: remove tpm_version from vtpmmgr Date: Wed, 9 Sep 2020 10:58:28 +0200 Message-Id: <20200909085829.29393-1-olaf@aepfle.de> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Giving an enum a name turns it into a variable, which is bad when it is done in a header file that is consumbed by multiple files. ld: /home/abuild/rpmbuild/BUILD/xen-4.14.20200616T103126.3625b04991/non-dbg= /stubdom/vtpmmgr/vtpmmgr.a(vtpm_cmd_handler.o):(.bss+0x0): multiple definit= ion of `tpm_version'; /home/abuild/rpmbuild/BUILD/xen-4.14.20200616T103126.= 3625b04991/non-dbg/stubdom/vtpmmgr/vtpmmgr.a(vtpmmgr.o):(.bss+0x0): first d= efined here Signed-off-by: Olaf Hering Reviewed-by: Samuel Thibault --- stubdom/vtpmmgr/vtpmmgr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stubdom/vtpmmgr/vtpmmgr.h b/stubdom/vtpmmgr/vtpmmgr.h index 2e6f8de9e4..f40ca9fd67 100644 --- a/stubdom/vtpmmgr/vtpmmgr.h +++ b/stubdom/vtpmmgr/vtpmmgr.h @@ -53,7 +53,7 @@ enum { TPM1_HARDWARE =3D 1, TPM2_HARDWARE, -} tpm_version; +}; =20 struct tpm_hardware_version { int hw_version;