From nobody Sun May 5 09:14:11 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1598961530; cv=none; d=zohomail.com; s=zohoarc; b=GILdJ95v44SUt6j5wTwbgBSq3JIbClKRtoRXPmgH90PCtJhq7ZItxI/d01kW7309ofpmHkn0ZNl/06XFwVlvF9+xE6Y3y5ixD0bDcALb89fBvw0mFY7eaPovy09c14+1D5onO/daQtUt8b3xpJHHiHmiovVVEYKMuAwJ0o8Cap8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598961530; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=R58A+smPZwVWCsx/961546nMWt9UHvARKx5RFjIQn1Y=; b=nMaDcd4uFSYlFt6BAIDpyHdpwmH2uRczi+AVgUBP5x6elN4NwrueNJW1PHOTaeC0FoOZZfDDspJ3+2lvzatKdSu00OpdzI4mBIWAyntMMxfmJXCJFrq55ymadZU/ow3xIeOTQy/yHang3uSRZWoiD75x12i624ZCJgZJzRishsc= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1598961530980712.5410480924841; Tue, 1 Sep 2020 04:58:50 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kD4vf-000557-1K; Tue, 01 Sep 2020 11:58:23 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kD4vd-000552-Fx for xen-devel@lists.xenproject.org; Tue, 01 Sep 2020 11:58:21 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 703913d2-0e5d-4e13-9702-45fee4bb0533; Tue, 01 Sep 2020 11:58:19 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1C25FB76E; Tue, 1 Sep 2020 11:58:19 +0000 (UTC) X-Inumbo-ID: 703913d2-0e5d-4e13-9702-45fee4bb0533 X-Virus-Scanned: by amavisd-new at test-mx.suse.de From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Ian Jackson , Wei Liu , Samuel Thibault , Jan Beulich Subject: [PATCH] fix build with make 3.81 Date: Tue, 1 Sep 2020 13:58:16 +0200 Message-Id: <20200901115816.16672-1-jgross@suse.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Content-Type: text/plain; charset="utf-8" make 3.81 doesn't support multiline variables defined with define var =3D ... endef Dropping the "=3D" in the first line will fix the issue. Fixes: ded08cdfa72bb ("tools: generate most contents of library make variab= les") Fixes: ddb2934a914df ("stubdom: add correct dependencies for Xen libraries") Reported-by: Jan Beulich Signed-off-by: Juergen Gross Reviewed-by: Ian Jackson --- stubdom/Makefile | 2 +- tools/Rules.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/stubdom/Makefile b/stubdom/Makefile index 4fd86dd44b..98eba8efe3 100644 --- a/stubdom/Makefile +++ b/stubdom/Makefile @@ -25,7 +25,7 @@ endif =20 include $(XEN_ROOT)/tools/libs/uselibs.mk =20 -define LIB_deps =3D +define LIB_deps LIBDEPS_$(1) =3D $$(foreach use,$$(USELIBS_$(1)),libxen$$(use)) endef $(foreach lib,$(LIBS_LIBS),$(eval $(call LIB_deps,$(lib)))) diff --git a/tools/Rules.mk b/tools/Rules.mk index 7e019a8a65..385807a71c 100644 --- a/tools/Rules.mk +++ b/tools/Rules.mk @@ -94,7 +94,7 @@ endif # Consumers of libfoo should not directly use $(SHDEPS_libfoo) or # $(SHLIB_libfoo) =20 -define LIB_defs =3D +define LIB_defs XEN_libxen$(1) =3D $$(XEN_ROOT)/tools/libs/$(1) CFLAGS_libxen$(1) =3D -I$$(XEN_libxen$(1))/include $$(CFLAGS_xeninclude) SHDEPS_libxen$(1) =3D $$(foreach use,$$(USELIBS_$(1)),$$(SHLIB_libxen$$(u= se))) --=20 2.26.2