From nobody Mon Feb 9 10:12:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1598627307; cv=none; d=zohomail.com; s=zohoarc; b=lKi6lom9H3c9AoIy/h+ot5ki8sDo79k4IDv4JLhHZafassGrP0VoS1I//rj5megDQjnGl9yax2kEBHdOEj57qZfXz+Im/al97avddUf25dVkYqIG5msQb6oLbe0idqiQgTJ1FYmTJoN9Rb0wiru9fOYPquTKTzeARejZycCMV+A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598627307; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=VtLhTM3HW1uumAcURL7uYxRGtetE8xce6OamCE7gckE=; b=IqOwOlxgGHaaOMLYxDYwrerYnqnBPYvBMpukAwaqN7GLp9wbENBCE5ITlLCtctwcDAqlHBBjmu44CbbMpE8J8RsLMoe5xRAryN0jGkCVkArvY/6g/heYeOdOpBxIZiVT8d3x/xHoIyFYNTmCwWpogszRduuzDAA6ubbvLsfglEQ= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1598627307855904.3011798207752; Fri, 28 Aug 2020 08:08:27 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kBfyy-0004f7-F7; Fri, 28 Aug 2020 15:08:00 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kBfyx-0004eL-HO for xen-devel@lists.xenproject.org; Fri, 28 Aug 2020 15:07:59 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 291fdadd-8143-4246-979b-7221a0cd4d83; Fri, 28 Aug 2020 15:07:53 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D3F7DAF2B; Fri, 28 Aug 2020 15:08:23 +0000 (UTC) X-Inumbo-ID: 291fdadd-8143-4246-979b-7221a0cd4d83 X-Virus-Scanned: by amavisd-new at test-mx.suse.de From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Ian Jackson , Wei Liu , Anthony PERARD Subject: [PATCH v4 05/31] tools: don't assume libxenguest and libxenctrl to be in same directory Date: Fri, 28 Aug 2020 17:07:21 +0200 Message-Id: <20200828150747.25305-6-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200828150747.25305-1-jgross@suse.com> References: <20200828150747.25305-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Content-Type: text/plain; charset="utf-8" There are quite some places in Makefiles assuming libxenguest and libxenctrl being built in the same directory via a single Makefile. Drop this assumption by specifying the dependencies and path variables for both libraries correctly. Signed-off-by: Juergen Gross Acked-by: Wei Liu --- tools/Rules.mk | 7 +++---- tools/libxl/Makefile | 2 +- tools/misc/Makefile | 1 + 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/Rules.mk b/tools/Rules.mk index 7ad72bebd3..4f3aaaacd3 100644 --- a/tools/Rules.mk +++ b/tools/Rules.mk @@ -16,8 +16,7 @@ XEN_INCLUDE =3D $(XEN_ROOT)/tools/include include $(XEN_ROOT)/tools/libs/uselibs.mk =20 XEN_libxenctrl =3D $(XEN_ROOT)/tools/libxc -# Currently libxenguest lives in the same directory as libxenctrl -XEN_libxenguest =3D $(XEN_libxenctrl) +XEN_libxenguest =3D $(XEN_ROOT)/tools/libxc XEN_libxenlight =3D $(XEN_ROOT)/tools/libxl # Currently libxlutil lives in the same directory as libxenlight XEN_libxlutil =3D $(XEN_libxenlight) @@ -117,7 +116,7 @@ LDLIBS_libxenguest =3D $(SHDEPS_libxenguest) $(XEN_libx= enguest)/libxenguest$(libex SHLIB_libxenguest =3D $(SHDEPS_libxenguest) -Wl,-rpath-link=3D$(XEN_libxe= nguest) =20 CFLAGS_libxenstore =3D -I$(XEN_libxenstore)/include $(CFLAGS_xeninclude) -SHDEPS_libxenstore =3D $(SHLIB_libxentoolcore) +SHDEPS_libxenstore =3D $(SHLIB_libxentoolcore) $(SHLIB_libxenctrl) LDLIBS_libxenstore =3D $(SHDEPS_libxenstore) $(XEN_libxenstore)/libxenstor= e$(libextension) SHLIB_libxenstore =3D $(SHDEPS_libxenstore) -Wl,-rpath-link=3D$(XEN_libxe= nstore) ifeq ($(CONFIG_Linux),y) @@ -144,7 +143,7 @@ CFLAGS +=3D -O2 -fomit-frame-pointer endif =20 CFLAGS_libxenlight =3D -I$(XEN_libxenlight) $(CFLAGS_libxenctrl) $(CFLAGS_= xeninclude) -SHDEPS_libxenlight =3D $(SHLIB_libxenctrl) $(SHLIB_libxenstore) $(SHLIB_li= bxenhypfs) +SHDEPS_libxenlight =3D $(SHLIB_libxenctrl) $(SHLIB_libxenstore) $(SHLIB_li= bxenhypfs) $(SHLIB_libxenguest) LDLIBS_libxenlight =3D $(SHDEPS_libxenlight) $(XEN_libxenlight)/libxenligh= t$(libextension) SHLIB_libxenlight =3D $(SHDEPS_libxenlight) -Wl,-rpath-link=3D$(XEN_libxe= nlight) =20 diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile index 684da32a5b..b815c548de 100644 --- a/tools/libxl/Makefile +++ b/tools/libxl/Makefile @@ -188,7 +188,7 @@ libxl_dom.o: CFLAGS +=3D -I$(XEN_ROOT)/tools # include= libacpi/x86.h libxl_x86_acpi.o: CFLAGS +=3D -I$(XEN_ROOT)/tools =20 SAVE_HELPER_OBJS =3D libxl_save_helper.o _libxl_save_msgs_helper.o -$(SAVE_HELPER_OBJS): CFLAGS +=3D $(CFLAGS_libxenctrl) $(CFLAGS_libxenevtch= n) +$(SAVE_HELPER_OBJS): CFLAGS +=3D $(CFLAGS_libxenctrl) $(CFLAGS_libxenevtch= n) $(CFLAGS_libxenguest) =20 PKG_CONFIG =3D xenlight.pc xlutil.pc PKG_CONFIG_VERSION :=3D $(MAJOR).$(MINOR) diff --git a/tools/misc/Makefile b/tools/misc/Makefile index 9fdb13597f..e7e74db85f 100644 --- a/tools/misc/Makefile +++ b/tools/misc/Makefile @@ -6,6 +6,7 @@ CFLAGS +=3D -Werror CFLAGS +=3D -include $(XEN_ROOT)/tools/config.h CFLAGS +=3D $(CFLAGS_libxenevtchn) CFLAGS +=3D $(CFLAGS_libxenctrl) +CFLAGS +=3D $(CFLAGS_libxenguest) CFLAGS +=3D $(CFLAGS_xeninclude) CFLAGS +=3D $(CFLAGS_libxenstore) =20 --=20 2.26.2