From nobody Sun May 5 07:35:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1597490178; cv=none; d=zohomail.com; s=zohoarc; b=OqR22WfxJeF3idUXpT9FZtZb5re1964zVklxfmqmMBaTP9h75PwKADPajWfYkys0xcE3HN1coScxwnT808jIRZga9nVlAWf1zM9GRR5b1EzN/oV0msnNXei53D+wgTPLFk0EwrODoI8iHa+cd6nvHxNpkZsZjc+C5O5Sbo7Qm4Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597490178; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=69r3+3ydb7bwOvCyZ4m9kJkibSlo8hoQk9wZNpJYicU=; b=OkAdMc3cwYzl3Y19GB581Rf3iIifiHGm5kXmYYOlMbViNlHyrspEkAUcNLoOGM9tVQ3smLwxnD79aSAtsAhg+1t8wzdjA3+3JakQCUddS8J3O998Jbs/r1nhjJKPCn2uuk7k5+pGRmXh2osTufKZP5c15BuS0Dn4qpOcuNIsd4o= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1597490178278612.2566116688496; Sat, 15 Aug 2020 04:16:18 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k6uAL-0005Y5-RP; Sat, 15 Aug 2020 11:16:01 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k6uAL-0005Y0-A5 for xen-devel@lists.xenproject.org; Sat, 15 Aug 2020 11:16:01 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id dd838711-5613-43cc-99de-5935b60c0053; Sat, 15 Aug 2020 11:15:59 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 08C5FB73B; Sat, 15 Aug 2020 11:16:22 +0000 (UTC) X-Inumbo-ID: dd838711-5613-43cc-99de-5935b60c0053 X-Virus-Scanned: by amavisd-new at test-mx.suse.de From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, wl@xen.org, Juergen Gross Subject: [PATCH] mini-os: correct memory access rights for pvh mode Date: Sat, 15 Aug 2020 13:15:57 +0200 Message-Id: <20200815111557.29564-1-jgross@suse.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Content-Type: text/plain; charset="utf-8" When running as a PVH guest the memory access rights are not set correctly: _PAGE_USER should not be set and CR0.WP should be set. Especially CR0.WP is important in order to let the allocate on demand feature work, as it requires a page fault when writing to a read-only page. Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault --- arch/x86/x86_hvm.S | 2 +- include/x86/arch_mm.h | 18 ++++++++++++------ include/x86/os.h | 1 + 3 files changed, 14 insertions(+), 7 deletions(-) diff --git a/arch/x86/x86_hvm.S b/arch/x86/x86_hvm.S index 6e8ad98..42a5f02 100644 --- a/arch/x86/x86_hvm.S +++ b/arch/x86/x86_hvm.S @@ -20,7 +20,7 @@ _start: #endif /* __x86_64__ */ =20 mov %cr0, %eax - or $X86_CR0_PG, %eax + or $(X86_CR0_PG | X86_CR0_WP), %eax mov %eax, %cr0 =20 lgdt gdt_ptr diff --git a/include/x86/arch_mm.h b/include/x86/arch_mm.h index cbbeb21..ffbec5a 100644 --- a/include/x86/arch_mm.h +++ b/include/x86/arch_mm.h @@ -171,17 +171,23 @@ typedef unsigned long pgentry_t; #define _PAGE_PSE CONST(0x080) #define _PAGE_GLOBAL CONST(0x100) =20 +#ifdef CONFIG_PARAVIRT +#define PAGE_USER _PAGE_USER +#else +#define PAGE_USER CONST(0) +#endif + #if defined(__i386__) #define L1_PROT (_PAGE_PRESENT|_PAGE_RW|_PAGE_ACCESSED) #define L1_PROT_RO (_PAGE_PRESENT|_PAGE_ACCESSED) -#define L2_PROT (_PAGE_PRESENT|_PAGE_RW|_PAGE_ACCESSED|_PAGE_DIRTY |_PAGE_= USER) +#define L2_PROT (_PAGE_PRESENT|_PAGE_RW|_PAGE_ACCESSED|_PAGE_DIRTY |PAGE_U= SER) #define L3_PROT (_PAGE_PRESENT) #elif defined(__x86_64__) -#define L1_PROT (_PAGE_PRESENT|_PAGE_RW|_PAGE_ACCESSED|_PAGE_USER) -#define L1_PROT_RO (_PAGE_PRESENT|_PAGE_ACCESSED|_PAGE_USER) -#define L2_PROT (_PAGE_PRESENT|_PAGE_RW|_PAGE_ACCESSED|_PAGE_DIRTY|_PAGE_U= SER) -#define L3_PROT (_PAGE_PRESENT|_PAGE_RW|_PAGE_ACCESSED|_PAGE_DIRTY|_PAGE_U= SER) -#define L4_PROT (_PAGE_PRESENT|_PAGE_RW|_PAGE_ACCESSED|_PAGE_DIRTY|_PAGE_U= SER) +#define L1_PROT (_PAGE_PRESENT|_PAGE_RW|_PAGE_ACCESSED|PAGE_USER) +#define L1_PROT_RO (_PAGE_PRESENT|_PAGE_ACCESSED|PAGE_USER) +#define L2_PROT (_PAGE_PRESENT|_PAGE_RW|_PAGE_ACCESSED|_PAGE_DIRTY|PAGE_US= ER) +#define L3_PROT (_PAGE_PRESENT|_PAGE_RW|_PAGE_ACCESSED|_PAGE_DIRTY|PAGE_US= ER) +#define L4_PROT (_PAGE_PRESENT|_PAGE_RW|_PAGE_ACCESSED|_PAGE_DIRTY|PAGE_US= ER) #endif /* __i386__ || __x86_64__ */ =20 /* flags for ioremap */ diff --git a/include/x86/os.h b/include/x86/os.h index a73b63e..46a824d 100644 --- a/include/x86/os.h +++ b/include/x86/os.h @@ -27,6 +27,7 @@ #define MSR_EFER 0xc0000080 #define _EFER_LME 8 /* Long mode enable */ =20 +#define X86_CR0_WP 0x00010000 /* Write protect */ #define X86_CR0_PG 0x80000000 /* Paging */ #define X86_CR4_PAE 0x00000020 /* enable physical address extensi= ons */ #define X86_CR4_OSFXSR 0x00000200 /* enable fast FPU save and restor= e */ --=20 2.26.2