From nobody Mon Feb 9 16:12:50 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=eu.citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1596196961; cv=none; d=zohomail.com; s=zohoarc; b=S41YIyuNNXNG6doMdu2fUmoLEGIcy7Ihlsb56+Hz+I4Veh55KIwqqZgKe0GE3yYDNEqxV6hsaSpFi5wh7druMW3mWelM9T5PG/bx+UfqpsO3KbrsUVxg7DEOXc5+t7uUCzBT30L8hsaR7YVzx43NRt/81kbP6JQfQhLovVQNiIo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1596196961; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=WoFUjXBWBDlvECsedWsXS7r5AuUWvl6nXsXWgFuYp4I=; b=VNeWdh5tQzZvdhV5vubQhACgEJ6Op3eYY1iRo1wVbgncsv6MCcg/mSOCo2b+Zt5QvPXpVdADau+6LfQlwZw5L1jDqyviK6urG7XbPi3nFy8AjcxhySnDADTJkC4SE1UG8S3+sszO3CVhTY2AxRJpT6mQnFA2CKqG7oN7ezREkhE= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1596196961322353.6645214056422; Fri, 31 Jul 2020 05:02:41 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k1Tk0-0002Cz-IP; Fri, 31 Jul 2020 12:02:24 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k1Tjz-00026u-58 for xen-devel@lists.xenproject.org; Fri, 31 Jul 2020 12:02:23 +0000 Received: from chiark.greenend.org.uk (unknown [2001:ba8:1e3::]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id af900828-d325-11ea-8e2b-bc764e2007e4; Fri, 31 Jul 2020 12:02:20 +0000 (UTC) Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by chiark.greenend.org.uk (Debian Exim 4.84_2 #1) with esmtp (return-path ijackson@chiark.greenend.org.uk) id 1k1TN6-0001W4-2a; Fri, 31 Jul 2020 12:38:44 +0100 X-Inumbo-ID: af900828-d325-11ea-8e2b-bc764e2007e4 From: Ian Jackson To: xen-devel@lists.xenproject.org Subject: [OSSTEST PATCH v2 40/41] cs-bisection-step: Lay out the revision tuple graph once Date: Fri, 31 Jul 2020 12:38:19 +0100 Message-Id: <20200731113820.5765-41-ian.jackson@eu.citrix.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200731113820.5765-1-ian.jackson@eu.citrix.com> References: <20200731113820.5765-1-ian.jackson@eu.citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Ian Jackson Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Content-Type: text/plain; charset="utf-8" The graph layout algorithm is not very fast, particularly if the revision graph is big. In my test case this saves about 10s. Signed-off-by: Ian Jackson --- v2: New patch. --- cs-bisection-step | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/cs-bisection-step b/cs-bisection-step index 027032a1..8544bac0 100755 --- a/cs-bisection-step +++ b/cs-bisection-step @@ -1113,10 +1113,15 @@ END or die "$!"; =20 if (eval { + print DEBUG "RUNNING dot -Txdot\n"; + system_checked("dot", "-Txdot", "-o$graphfile.xdot", + "$graphfile.dot"); foreach my $fmt (qw(ps png svg)) { - print DEBUG "RUNNING dot -T$fmt\n"; - system_checked("dot", "-T$fmt", "-o$graphfile.$fmt", - "$graphfile.dot"); + # neato rather than dot, because neato just uses positions + # etc. in the input whereas dot does (re)calculation work. + print DEBUG "RUNNING neato -n2 -T$fmt\n"; + system_checked("neato", "-n2", "-T$fmt", "-o$graphfile.$fmt", + "$graphfile.xdot"); } open SVGI, "$graphfile.svg" or die "$graphfile.svg $!"; open SVGO, ">", "$graphfile.svg.new" or die "$graphfile.svg.new $!"; --=20 2.20.1