From nobody Mon Feb 9 13:38:04 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=eu.citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1596196952; cv=none; d=zohomail.com; s=zohoarc; b=elVWVhsDt6eQAdrYeffnyiKPVdN7EVsFzwTLqk4RBSv5ERfL0CorPL2yAfHAxHMcHLmcZl6KF/D0H1RAm+w2rlMT/bua4Sf5pLLqIOlHtz/DrRZ3t1B7XWVl2Iz8aHZK+KBkftLPRfNYZCrihG2+eeXPHGXlNznWoLrySvENX68= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1596196952; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=pjeDVzUtdR4kb5dabVHEyISibR6LFVgNAcfFS243cTw=; b=gKDYkhrNQAjPZlvWCNvZkyuJ0ZdwZDRzVBgazG6yq6NbVI+4rFqajJ7X7Fwhhr/b/eG7k9aU7P77bNcmxAJeD2IO3EQ9LkTAcLfq8yHKQTIqg+ttKyMYYL0Y2mJPcOEGROMmaiRjJBR9Suzy20nbqs2R5jhaH5ncL/YJJM/6qSA= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1596196952791448.990419202603; Fri, 31 Jul 2020 05:02:32 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k1Tjt-00027b-0S; Fri, 31 Jul 2020 12:02:17 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k1Tjr-00026u-HR for xen-devel@lists.xenproject.org; Fri, 31 Jul 2020 12:02:15 +0000 Received: from chiark.greenend.org.uk (unknown [2001:ba8:1e3::]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ac328bec-d325-11ea-8e2b-bc764e2007e4; Fri, 31 Jul 2020 12:02:14 +0000 (UTC) Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by chiark.greenend.org.uk (Debian Exim 4.84_2 #1) with esmtp (return-path ijackson@chiark.greenend.org.uk) id 1k1TN2-0001W4-LZ; Fri, 31 Jul 2020 12:38:40 +0100 X-Inumbo-ID: ac328bec-d325-11ea-8e2b-bc764e2007e4 From: Ian Jackson To: xen-devel@lists.xenproject.org Subject: [OSSTEST PATCH v2 33/41] cs-bisection-step: Generalise qtxt_common_rev_ok Date: Fri, 31 Jul 2020 12:38:12 +0100 Message-Id: <20200731113820.5765-34-ian.jackson@eu.citrix.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200731113820.5765-1-ian.jackson@eu.citrix.com> References: <20200731113820.5765-1-ian.jackson@eu.citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Ian Jackson Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Content-Type: text/plain; charset="utf-8" * Make it into a subref which takes a $table argument. * Change the two references into function calls using the @{...} syntax * Move the definition earlier in the file No change to the generated query. Signed-off-by: Ian Jackson --- v2: New patch. --- cs-bisection-step | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/cs-bisection-step b/cs-bisection-step index 9a0fee39..5d4e179e 100755 --- a/cs-bisection-step +++ b/cs-bisection-step @@ -182,6 +182,14 @@ END sub flight_rmap ($$) { my ($flight, $need_urls) =3D @_; =20 + my $qtxt_common_rev_ok =3D sub { + my ($table) =3D @_; + [<do(<('rev') } =20 ORDER by rev.name; =20 @@ -262,7 +266,7 @@ $qtxt_common_tables CROSS JOIN tmp_build_info AS url =20 WHERE -$qtxt_common_rev_condition +@{ $qtxt_common_rev_ok->('rev') } AND url.name LIKE E'tree\\_%' AND url.use =3D rev.use AND url.job =3D rev.job --=20 2.20.1