From nobody Tue Feb 10 04:03:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=eu.citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1595356985; cv=none; d=zohomail.com; s=zohoarc; b=Iu2TDbbiw9sD93sCQkZoIuN/RIICigFtb1F+dAsCOxKIQazNFNSrQHs8pmcRCPqugsZQH/KhyKcQto21JW0IRITSfZXwcASPA+njDW0ENFcO7r/I+pVJfVQKlzjUrnKu+8a3pMdrZT5HBJluk2VcX4wUJvu/TttZtt7LF+NOrAI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1595356985; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=5b7yP4YyNa49x5n3rCbAk+c6YKoRrGdtoBR81I7DbME=; b=hk5kCbvdw0RCAyAi3vDSVM8FATCx9mAOdZ0HuPLpCFfGU1f1d3QY6skWiH8YyRQejmASaQjsVhV6nQmIvmfcdi4VoNUGqwBDQ8OxmtGE1JPfJ8ClOkooQUhuHZXy6mDSs6Va/c5KOsQQ0wVlzOr4RtsQ9jDUKnXwVeyFbgujrNQ= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1595356985192282.0432688524494; Tue, 21 Jul 2020 11:43:05 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jxxE4-0002AF-H7; Tue, 21 Jul 2020 18:42:52 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jxxE3-0001xV-NL for xen-devel@lists.xenproject.org; Tue, 21 Jul 2020 18:42:51 +0000 Received: from chiark.greenend.org.uk (unknown [2001:ba8:1e3::]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e8d90019-cb81-11ea-85a2-bc764e2007e4; Tue, 21 Jul 2020 18:42:21 +0000 (UTC) Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by chiark.greenend.org.uk (Debian Exim 4.84_2 #1) with esmtp (return-path ijackson@chiark.greenend.org.uk) id 1jxxDZ-0001u7-0G; Tue, 21 Jul 2020 19:42:21 +0100 X-Inumbo-ID: e8d90019-cb81-11ea-85a2-bc764e2007e4 From: Ian Jackson To: xen-devel@lists.xenproject.org Subject: [OSSTEST PATCH 07/14] sg-report-flight: Use the job row from the intitial query Date: Tue, 21 Jul 2020 19:41:58 +0100 Message-Id: <20200721184205.15232-8-ian.jackson@eu.citrix.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200721184205.15232-1-ian.jackson@eu.citrix.com> References: <20200721184205.15232-1-ian.jackson@eu.citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Ian Jackson Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Content-Type: text/plain; charset="utf-8" $jcheckq is redundant: we looked this up right at the start. This is not expected to speed things up very much, but it makes things somewhat cleaner and clearer. Signed-off-by: Ian Jackson --- sg-report-flight | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/sg-report-flight b/sg-report-flight index b8d948da..bcb0d427 100755 --- a/sg-report-flight +++ b/sg-report-flight @@ -160,10 +160,6 @@ sub findaflight ($$$$$) { return undef; } =20 - my $jcheckq=3D db_prepare(<fetchrow_array) { + while (my ($tflight, $tjstatus) =3D $flightsq->fetchrow_array) { # Recurse from the starting flight looking for relevant build # jobs. We start with all jobs in $tflight, and for each job # we also process any other jobs it refers to in *buildjob runvars. @@ -407,8 +403,7 @@ END $checkq->execute($tflight, $job, $testid); ($chkst) =3D $checkq->fetchrow_array(); if (!defined $chkst) { - $jcheckq->execute($tflight, $job); - my ($jchkst) =3D $jcheckq->fetchrow_array(); + my $jchkst =3D $tflight->{status}; $chkst =3D $jchkst if $jchkst eq 'starved'; } } --=20 2.20.1