From nobody Mon May 6 07:21:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=canonical.com ARC-Seal: i=1; a=rsa-sha256; t=1591878731; cv=none; d=zohomail.com; s=zohoarc; b=R5PouxRIwnpfnc8Gahu3en33cbNmmGyfOw58TB9qbCWeA3J7kqm2aFOojc+2GXTPRnDFDLh5Wd9I0INXIlGehtgLHmvZEngsK8kwtvsjBIj7G15Ux+JNDExIJlUnIdF3Sp0T6/eF0Qtx+WCqon9ssXDJxmeuqF1+Nw6x7azBlyI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591878731; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=EIDK843VOthvVhz9iCfyKJqHb9qAdFey3aD00t89z4o=; b=Sl5QgsgdmUVmhF8UvUQZmSpDUjP9xzFALzZcAkMSU53jdjlFw6GW18SJlVSBfxh2z+dFFiOaCjwgNEIxa7RP+eTqJpXWFhgOm6f0LVMOsn5l+Fr7ZLiZM/xyhp0Gs3n3JSEwuRE7F4gHjLB5W6b6Bvoo9mvLJQw5eckezbH2jlA= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1591878731809958.9171281797087; Thu, 11 Jun 2020 05:32:11 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jjMN0-0004JB-N5; Thu, 11 Jun 2020 12:31:46 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jjMMz-0004J6-DO for xen-devel@lists.xenproject.org; Thu, 11 Jun 2020 12:31:45 +0000 Received: from youngberry.canonical.com (unknown [91.189.89.112]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8254edb4-abdf-11ea-b516-12813bfff9fa; Thu, 11 Jun 2020 12:31:44 +0000 (UTC) Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jjMMo-0005qP-MA; Thu, 11 Jun 2020 12:31:34 +0000 X-Inumbo-ID: 8254edb4-abdf-11ea-b516-12813bfff9fa From: Colin King To: Konrad Rzeszutek Wilk , Bjorn Helgaas , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , xen-devel@lists.xenproject.org, linux-pci@vger.kernel.org Subject: [PATCH] xen: remove redundant initialization of variable irq Date: Thu, 11 Jun 2020 13:31:34 +0100 Message-Id: <20200611123134.922395-1-colin.king@canonical.com> X-Mailer: git-send-email 2.27.0.rc0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Colin Ian King The variable irq is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- arch/x86/pci/xen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c index e3f1ca316068..9f9aad42ccff 100644 --- a/arch/x86/pci/xen.c +++ b/arch/x86/pci/xen.c @@ -62,7 +62,7 @@ static int xen_pcifront_enable_irq(struct pci_dev *dev) #ifdef CONFIG_ACPI static int xen_register_pirq(u32 gsi, int triggering, bool set_pirq) { - int rc, pirq =3D -1, irq =3D -1; + int rc, pirq =3D -1, irq; struct physdev_map_pirq map_irq; int shareable =3D 0; char *name; --=20 2.27.0.rc0