From nobody Sun Apr 28 23:57:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1591717577; cv=none; d=zohomail.com; s=zohoarc; b=AOv5Qv3hR8vDTt9cUwqA87MdPGZd5ZBTeZexQ+epF6OxGoBC1aCQWUNT0iVKRdikB7we5hm9JTkPpcGe02ipvSvm43a4G6MjG6wtgST2hmBO5FTNTIGCCtfXMGZDeAB50avZWRcX6QOj0VR/I1Z91QuvwO1JWf5Bh1HYR0PJyyA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591717577; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=1+dV3I7w8n84E+3L1TPuw5MOEvmVxJ1NyE830sW1I3o=; b=jybztfBWDnYUbo7nczRW/XaA/H8+UNVUKcJ71dnyKfGTcJ+9O58bSrc9Bn5NRlEgOOkFpmQ2MxdmLYsuS3xir8De4BXlIG7Rb9gNC/JcMa5YBx+4WkPs3bTOGTJPVUynoKzsAHG8jxeNtLGC8kSTRWza3Gbjk1W+SjFOdSboCos= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1591717577301617.3392945953184; Tue, 9 Jun 2020 08:46:17 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jigRk-0005GT-8C; Tue, 09 Jun 2020 15:45:52 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jigRi-0005GO-Uk for xen-devel@lists.xenproject.org; Tue, 09 Jun 2020 15:45:50 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 4add515a-aa68-11ea-b339-12813bfff9fa; Tue, 09 Jun 2020 15:45:50 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 83301AC5B; Tue, 9 Jun 2020 15:45:52 +0000 (UTC) X-Inumbo-ID: 4add515a-aa68-11ea-b339-12813bfff9fa X-Virus-Scanned: by amavisd-new at test-mx.suse.de From: Juergen Gross To: xen-devel@lists.xenproject.org Subject: [PATCH for-4.14] xen/hypfs: fix loglvl parameter setting Date: Tue, 9 Jun 2020 17:45:46 +0200 Message-Id: <20200609154546.4531-1-jgross@suse.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Stefano Stabellini , Julien Grall , Wei Liu , paul@xen.org, Andrew Cooper , Ian Jackson , George Dunlap , Jan Beulich Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Content-Type: text/plain; charset="utf-8" Writing the runtime parameters loglvl or guest_loglvl omits setting the new length of the resulting parameter value. Reported-by: George Dunlap Signed-off-by: Juergen Gross Reviewed-by: Julien Grall --- xen/drivers/char/console.c | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c index 56e24821b2..861ad53a8f 100644 --- a/xen/drivers/char/console.c +++ b/xen/drivers/char/console.c @@ -241,14 +241,25 @@ static int _parse_loglvl(const char *s, int *lower, i= nt *upper, char *val) =20 static int parse_loglvl(const char *s) { - return _parse_loglvl(s, &xenlog_lower_thresh, &xenlog_upper_thresh, - xenlog_val); + int ret; + + ret =3D _parse_loglvl(s, &xenlog_lower_thresh, &xenlog_upper_thresh, + xenlog_val); + custom_runtime_set_var(param_2_parfs(parse_loglvl), xenlog_val); + + return ret; } =20 static int parse_guest_loglvl(const char *s) { - return _parse_loglvl(s, &xenlog_guest_lower_thresh, - &xenlog_guest_upper_thresh, xenlog_guest_val); + int ret; + + ret =3D _parse_loglvl(s, &xenlog_guest_lower_thresh, + &xenlog_guest_upper_thresh, xenlog_guest_val); + custom_runtime_set_var(param_2_parfs(parse_guest_loglvl), + xenlog_guest_val); + + return ret; } =20 static char *loglvl_str(int lvl) --=20 2.26.2