From nobody Sun May 5 16:46:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=eu.citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1591274732; cv=none; d=zohomail.com; s=zohoarc; b=PGnP1ED2JvRyvrebgFlCWioL/4HjiK+2Mu933C53bfbbC2N+iZwO1LPHA0omKB27pJNSU9uUqH6UquAIRRzVcMIGT4XJL3GSiS0SZvhboPlRmbxHMnguNhXjsl16GcKPXNTMsjBPEDbwX7HS6hWTGyvZe7nyqgaOXjanGPTbWwM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591274732; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=zrbKCh2bTtSDIi2fmSkFbjS3fHSc8gOTPjlkIUnvmj0=; b=khj4d9FrHy0HTo9pI1x7Oc73X2DsyRo5BG7qs4jTq7GAXveHUMWD6Fu/VeRBo6YyEnhTp6rgL4Xkd0vOhs/BbGjidlLMv28skCZKd+/AjJZFZXEz0gRCHW/8hPaxTaPluoCMG9q5rSUQgEFl3KNI4QdBd0bejfQuIsSs4mI49wU= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 159127473231821.16616982764856; Thu, 4 Jun 2020 05:45:32 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jgpFI-0005Ze-Bq; Thu, 04 Jun 2020 12:45:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jgpFH-0005ZI-Cc for xen-devel@lists.xenproject.org; Thu, 04 Jun 2020 12:45:19 +0000 Received: from chiark.greenend.org.uk (unknown [2001:ba8:1e3::]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 36dc180e-a661-11ea-81bc-bc764e2007e4; Thu, 04 Jun 2020 12:45:05 +0000 (UTC) Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by chiark.greenend.org.uk (Debian Exim 4.84_2 #1) with esmtp (return-path ijackson@chiark.greenend.org.uk) id 1jgpF2-0006vr-Nt; Thu, 04 Jun 2020 13:45:04 +0100 X-Inumbo-ID: 36dc180e-a661-11ea-81bc-bc764e2007e4 From: Ian Jackson To: xen-devel@lists.xenproject.org Subject: [OSSTEST PATCH 1/4] cs-bisection-step: need_repro_sequence: Provide info to callback Date: Thu, 4 Jun 2020 13:44:56 +0100 Message-Id: <20200604124459.18453-2-ian.jackson@eu.citrix.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200604124459.18453-1-ian.jackson@eu.citrix.com> References: <20200604124459.18453-1-ian.jackson@eu.citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Ian Jackson Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Content-Type: text/plain; charset="utf-8" This will be used by the callback in a moment. No functional change yet. Signed-off-by: Ian Jackson --- cs-bisection-step | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/cs-bisection-step b/cs-bisection-step index 478baa5b..35085e89 100755 --- a/cs-bisection-step +++ b/cs-bisection-step @@ -805,7 +805,8 @@ our $repro_count; sub need_repro_sequence ($$) { my ($need_each, $code) =3D @_; # - # $code->() should call, in turn for each required event, + # $code->($repro_count, $is_last_repro) + # should call, in turn for each required event, # need_repro('pass', $nodes{SOMETHING}, $what) or # need_repro('fail', $nodes{SOMETHING}, $what) # and return true as soon as any of the need_repro's return true. @@ -817,7 +818,7 @@ sub need_repro_sequence ($$) { local ($repro_lastflight) =3D 0; local ($repro_count); for ($repro_count=3D0; $repro_count<$need_each; $repro_count++) { - return 1 if $code->(); + return 1 if $code->($repro_count, $repro_count=3D=3D$need_each-1); } } =20 @@ -851,6 +852,7 @@ sub search () { =20 return if=20 need_repro_sequence(2, sub { + my ($repro_count, $is_last_repro) =3D @_; need_repro('pass', $nodes{"@basispass_rtuple"}, "basis pass") = || need_repro('fail', $nodes{"@latest_rtuple"}, "basis failure= "); }); --=20 2.20.1 From nobody Sun May 5 16:46:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=eu.citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1591274726; cv=none; d=zohomail.com; s=zohoarc; b=lYKl98NDBvvUrxJE7pGnrNkWh0ySGMZz6xpX9esNhcRLyc3NiI7g7c7mh7RbbzeG9JY6JeFfPgKYAubP3iHY0JhSd0JIkeqwPg9ewuHRCY9Ih5VYDTuH26BCF3cZymqMaOBDGNmGCLs4b13LHJGTIpBVcSV/cAQlmxV5TGlR/r4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591274726; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=hpvmRMpv0a35Rbbws2Wl+vT9ZNi86sng6pMZObIfyUc=; b=eYIqzZUQltvJWGxX6C/9sxepxJf2uExfV9bJlAri848dRtDFim/90D6J2FgaMQqrEHfK8XmyT08tRS2ZfNcoZzJl27JR/2Bg7R4FAStBgwXfzdq+m5F1EK6DQV28TLUg8PiDcOrUgPkwRlr6BrRuT02ZvsYepSWfWeiQYSqxcE4= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1591274726068686.021523100748; Thu, 4 Jun 2020 05:45:26 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jgpF8-0005W0-OH; Thu, 04 Jun 2020 12:45:10 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jgpF7-0005Vi-E5 for xen-devel@lists.xenproject.org; Thu, 04 Jun 2020 12:45:09 +0000 Received: from chiark.greenend.org.uk (unknown [2001:ba8:1e3::]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 36fed506-a661-11ea-81bc-bc764e2007e4; Thu, 04 Jun 2020 12:45:05 +0000 (UTC) Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by chiark.greenend.org.uk (Debian Exim 4.84_2 #1) with esmtp (return-path ijackson@chiark.greenend.org.uk) id 1jgpF2-0006vr-U6; Thu, 04 Jun 2020 13:45:05 +0100 X-Inumbo-ID: 36fed506-a661-11ea-81bc-bc764e2007e4 From: Ian Jackson To: xen-devel@lists.xenproject.org Subject: [OSSTEST PATCH 2/4] cs-bisection-step: need_repro: Provision for $xinfo Date: Thu, 4 Jun 2020 13:44:57 +0100 Message-Id: <20200604124459.18453-3-ian.jackson@eu.citrix.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200604124459.18453-1-ian.jackson@eu.citrix.com> References: <20200604124459.18453-1-ian.jackson@eu.citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Ian Jackson Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Content-Type: text/plain; charset="utf-8" This becomes part of the message but right now it is juse "". So no functional change yet. Signed-off-by: Ian Jackson --- cs-bisection-step | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cs-bisection-step b/cs-bisection-step index 35085e89..90e0601a 100755 --- a/cs-bisection-step +++ b/cs-bisection-step @@ -828,6 +828,7 @@ sub need_repro ($$$) { return 1 if conflicted_warning($n, $what); =20 my $fl=3D $n->{Flights} || []; + my $xinfo=3D''; foreach my $f (sort { $a->{Flight} <=3D> $b->{Flight} } @$fl) { next unless $f->{Flight} > $repro_lastflight; if ($f->{Result} ne $st) { @@ -837,7 +838,7 @@ sub need_repro ($$$) { } print STDERR " ". ($repro_count ? "Repro" : "Result"). - " found: flight $f->{Flight} ($st), for $what\n"; + " found: flight $f->{Flight} ($st), for $what$xinfo\n"; $repro_lastflight=3D $f->{Flight}; $repro_firstflight ||=3D $f->{Flight}; return 0; --=20 2.20.1 From nobody Sun May 5 16:46:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=eu.citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1591274726; cv=none; d=zohomail.com; s=zohoarc; b=H2UJZcrnG9Pqfnv4QAY4w1cvkQJJl0djL9i5AJVC1/5TBE6QI2xgv5mBVI+bW0FirHVRUpBqieL/JNcq50zFHXhuVk5f5qSC7HM/y+Gmo1aspCAFoetIoxJtdCYt/PJ8ApxU6U8uHHyHMiWiN8aAz+4OXWWWuxBa/lRgCb2M3eA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591274726; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=GWka9VMt/UIKdcnq+vEK0RL+KFRu756zNhyogUEnLwk=; b=l/zyYbmgE4n+JQP+yc1JNayyF1zyj4SaFmm+5JGKd7tjIi/m0ygXuoH1utRUPd/qMHbP/u82eGJUGCAk65oNzIeXBgm5NzJitdhb0AgtPPAHpxv3pQ0Hrkda44b7EGKDT3LZ8NVEAERnBMir6e+Nl0JNDpwW5rv6KUgui6Wby40= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1591274726736279.167931766519; Thu, 4 Jun 2020 05:45:26 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jgpFD-0005XU-0d; Thu, 04 Jun 2020 12:45:15 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jgpFC-0005XL-C0 for xen-devel@lists.xenproject.org; Thu, 04 Jun 2020 12:45:14 +0000 Received: from chiark.greenend.org.uk (unknown [2001:ba8:1e3::]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 371a3fa8-a661-11ea-9947-bc764e2007e4; Thu, 04 Jun 2020 12:45:05 +0000 (UTC) Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by chiark.greenend.org.uk (Debian Exim 4.84_2 #1) with esmtp (return-path ijackson@chiark.greenend.org.uk) id 1jgpF3-0006vr-5i; Thu, 04 Jun 2020 13:45:05 +0100 X-Inumbo-ID: 371a3fa8-a661-11ea-9947-bc764e2007e4 From: Ian Jackson To: xen-devel@lists.xenproject.org Subject: [OSSTEST PATCH 3/4] cs-bisection-step: need_repro: Support $consider_parents Date: Thu, 4 Jun 2020 13:44:58 +0100 Message-Id: <20200604124459.18453-4-ian.jackson@eu.citrix.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200604124459.18453-1-ian.jackson@eu.citrix.com> References: <20200604124459.18453-1-ian.jackson@eu.citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Ian Jackson Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Content-Type: text/plain; charset="utf-8" This flag tells need_repro to look at parent commits of the indicated rtuple node, as well as the node itself. We walk up the tree. If there are multiple parents, we stop; likewise if we find any rtuple which doesn't have the expected results. Signed-off-by: Ian Jackson --- cs-bisection-step | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/cs-bisection-step b/cs-bisection-step index 90e0601a..bc6fb794 100755 --- a/cs-bisection-step +++ b/cs-bisection-step @@ -822,13 +822,31 @@ sub need_repro_sequence ($$) { } } =20 -sub need_repro ($$$) { - my ($st, $n, $what) =3D @_; +sub need_repro ($$$;$) { + my ($st, $n, $what, $consider_parents) =3D @_; =20 return 1 if conflicted_warning($n, $what); =20 my $fl=3D $n->{Flights} || []; my $xinfo=3D''; + if ($consider_parents) { + $fl =3D [ @$fl ]; + my $nloop =3D $n; + my $iters =3D 0; + for (;;) { + last unless @{ $nloop->{Parents} } =3D=3D 1; + $nloop =3D $nloop->{Parents}[0]; + $iters++; + $xinfo =3D " (at ancestor ~$iters)"; + my @others =3D grep { $_->{Result} ne $st } @{ $nloop->{Flights} }; + if (@others) { + print STDERR + " For $what, parent search stopping at $nloop->{Rtuple}, results @others"; + } + push @$fl, @{ $nloop->{Flights} }; + } + } + foreach my $f (sort { $a->{Flight} <=3D> $b->{Flight} } @$fl) { next unless $f->{Flight} > $repro_lastflight; if ($f->{Result} ne $st) { --=20 2.20.1 From nobody Sun May 5 16:46:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=eu.citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1591274739; cv=none; d=zohomail.com; s=zohoarc; b=VHaUAk6IwTZf3/7kMPKYoqYDJly/ZixZnQc2qyrCATWqWycqwfLia7fp6wqqo1wckTmi8YZvd7EiAZ2yjUC/varVsC4+JnaU8E1z0phegyFIOg087oHtoy3SFmcHK0XYgtR4OcDDXgRb89q9Ch7QuXdGfM/1PlWoTtvRGo8QlpI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591274739; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ut4Xw7rvxrz4fPX+YlsI+B2pU8+vwqJOVqjnfUHDzdk=; b=fXhV0Y26CojZ23GFeORLP28A4sYg4bi8GoXv8s/SmusmszoyrV0TAmFLTVvngPGbGA7GiUQDPFB2+m1CLXcn/Wj+KIN0F2k6eyk4+KFFGGLms5BSFY/hAoN+aruaphJlbU++M+iy0yJZFXnthB8Omi+dZyAqFgz18GT5cTPf0rk= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1591274739313118.99481921884296; Thu, 4 Jun 2020 05:45:39 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jgpFN-0005c6-L8; Thu, 04 Jun 2020 12:45:25 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jgpFM-0005bg-Bn for xen-devel@lists.xenproject.org; Thu, 04 Jun 2020 12:45:24 +0000 Received: from chiark.greenend.org.uk (unknown [2001:ba8:1e3::]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3745003a-a661-11ea-9947-bc764e2007e4; Thu, 04 Jun 2020 12:45:06 +0000 (UTC) Received: from [172.18.45.5] (helo=zealot.relativity.greenend.org.uk) by chiark.greenend.org.uk (Debian Exim 4.84_2 #1) with esmtp (return-path ijackson@chiark.greenend.org.uk) id 1jgpF3-0006vr-Bn; Thu, 04 Jun 2020 13:45:05 +0100 X-Inumbo-ID: 3745003a-a661-11ea-9947-bc764e2007e4 From: Ian Jackson To: xen-devel@lists.xenproject.org Subject: [OSSTEST PATCH 4/4] cs-bisection-step: Do not needlessly repro on tip Date: Thu, 4 Jun 2020 13:44:59 +0100 Message-Id: <20200604124459.18453-5-ian.jackson@eu.citrix.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200604124459.18453-1-ian.jackson@eu.citrix.com> References: <20200604124459.18453-1-ian.jackson@eu.citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Ian Jackson Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Content-Type: text/plain; charset="utf-8" If we were halfway through bisecting, we treat the incident failure as the basis failure. But our previous bisection results can count as indications that things are really failing - we don't need to repro on the very final commit. Signed-off-by: Ian Jackson --- cs-bisection-step | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cs-bisection-step b/cs-bisection-step index bc6fb794..9a0fee39 100755 --- a/cs-bisection-step +++ b/cs-bisection-step @@ -873,7 +873,8 @@ sub search () { need_repro_sequence(2, sub { my ($repro_count, $is_last_repro) =3D @_; need_repro('pass', $nodes{"@basispass_rtuple"}, "basis pass") = || - need_repro('fail', $nodes{"@latest_rtuple"}, "basis failure= "); + need_repro('fail', $nodes{"@latest_rtuple"}, "basis failure", + !$is_last_repro); }); =20 foreach my $startfail (@failures) { --=20 2.20.1