From nobody Tue May 7 22:37:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1591198048; cv=none; d=zohomail.com; s=zohoarc; b=QkvbuWdw5l42SZXnyB5KEnM0BSZANoRZthfi7CybDDq8wuFp/R8lZfZFDNrcCdyi2erlPXzvTzrlEEeYl5oMKPW3dMFoPHVO9BTcGpCgEyA2thyZNZJtDhOWYYMfEaxdps+Vl80LtNuHYoNfk5swyeeoZase94xA0gE/YvguPno= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591198048; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=TI71EQkgRiykB9cwyrszJwVo6ai3Du0dG7EYNU5AcZI=; b=WwGvQvvpbnhXQMmw2uTon+1LZHL5R9qFCLH734vsuLLAJn/wr8/it2GRZGPNpLy8uxOXYxCi9FxFmv47YRal1EDJ6oIulpCAi7yCndC+gTpbJtoq566/EuoAQr//hX4UtTrLwVV2Ouc1CXXk4tej43+M74IU5UAx/gnFfK+FVxs= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1591198048419648.752454464782; Wed, 3 Jun 2020 08:27:28 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jgVIP-00018y-4H; Wed, 03 Jun 2020 15:27:13 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jgVIN-00018t-3l for xen-devel@lists.xenproject.org; Wed, 03 Jun 2020 15:27:11 +0000 Received: from mail-lj1-f194.google.com (unknown [209.85.208.194]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b041b22b-a5ae-11ea-ad4a-12813bfff9fa; Wed, 03 Jun 2020 15:27:09 +0000 (UTC) Received: by mail-lj1-f194.google.com with SMTP id y11so1624289ljm.9 for ; Wed, 03 Jun 2020 08:27:09 -0700 (PDT) Received: from localhost.localdomain (broadband-37-110-38-130.ip.moscow.rt.ru. [37.110.38.130]) by smtp.googlemail.com with ESMTPSA id e21sm631714ljb.135.2020.06.03.08.27.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2020 08:27:07 -0700 (PDT) X-Inumbo-ID: b041b22b-a5ae-11ea-ad4a-12813bfff9fa X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=TI71EQkgRiykB9cwyrszJwVo6ai3Du0dG7EYNU5AcZI=; b=aztgwI5ND/gKIXZrIKxfgotansGLpy+RY0QTPJxtCD3DxXGAvMWu1yrNRnXZOT6DcQ ZGSQaCwfbHGHQ0kX+DvyAGcmxnVMvnzd5mTtOWjfstdNXUYKqhYlPIXIGiE80ksx8Q2F 3nGMqjJ98ilqDR/F4gfML0m3xzJ5IYuJyELEt6n6je0Dj0TB4DYVcadMdvD+52UTXwE6 QBOfH4n361svG+ZTV8XJG1J/4SSz4yrPTHQV6lIpdqUf5gZOTizwzQMh9q30pASvkPgq 0N2a05zGyt5qAqS28cCJZfNM/1W431RReeMGxUrb5eLf3uvBMd+vGCjleDxcCQIwpGS4 Vklw== X-Gm-Message-State: AOAM532sEq9FNyB3V5Yqo1JxXIXHmtc5cOtHC+DfWmfOWORlloPH28Dn Lr8FGgUakPgNmSFQjfOimOw= X-Google-Smtp-Source: ABdhPJwfYTS9uPM/HnqTboQLV6Ltg2RwfZqWlLMLltkoaHufYDdfd//e3kI/YThjJUvVF6uDszv/jw== X-Received: by 2002:a2e:b8ce:: with SMTP id s14mr2196638ljp.89.1591198028574; Wed, 03 Jun 2020 08:27:08 -0700 (PDT) From: Denis Efremov To: "David S. Miller" Subject: [PATCH] xen-netback: use kstrdup() in connect_data_rings() Date: Wed, 3 Jun 2020 18:26:43 +0300 Message-Id: <20200603152643.18215-1-efremov@linux.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Wei Liu , linux-kernel@vger.kernel.org, Denis Efremov , Paul Durrant Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Content-Type: text/plain; charset="utf-8" Use kstrdup() instead of opencoded alloc and copy. kzalloc() is excessive here. Signed-off-by: Denis Efremov Acked-by: Wei Liu --- drivers/net/xen-netback/xenbus.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xen= bus.c index 286054b60d47..69352154a51b 100644 --- a/drivers/net/xen-netback/xenbus.c +++ b/drivers/net/xen-netback/xenbus.c @@ -839,13 +839,12 @@ static int connect_data_rings(struct backend_info *be, * queue-N. */ if (num_queues =3D=3D 1) { - xspath =3D kzalloc(strlen(dev->otherend) + 1, GFP_KERNEL); + xspath =3D kstrdup(dev->otherend, GFP_KERNEL); if (!xspath) { xenbus_dev_fatal(dev, -ENOMEM, "reading ring references"); return -ENOMEM; } - strcpy(xspath, dev->otherend); } else { xspathsize =3D strlen(dev->otherend) + xenstore_path_ext_size; xspath =3D kzalloc(xspathsize, GFP_KERNEL); --=20 2.26.2