[PATCH v1] INSTALL: remove TODO section

Olaf Hering posted 1 patch 3 years, 10 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/xen tags/patchew/20200529135303.18457-1-olaf@aepfle.de
Maintainers: Ian Jackson <ian.jackson@eu.citrix.com>, Stefano Stabellini <sstabellini@kernel.org>, Andrew Cooper <andrew.cooper3@citrix.com>, Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>, Julien Grall <julien@xen.org>, George Dunlap <george.dunlap@citrix.com>
INSTALL | 7 -------
1 file changed, 7 deletions(-)
[PATCH v1] INSTALL: remove TODO section
Posted by Olaf Hering 3 years, 10 months ago
The default value '/' for DESTDIR is unusual, but does probably not hurt.

Fixes commit f2b40dababedcd8355bf3e85d00baf17f9827131
Fixes commit 8e986e5a61efeca92b9b268e77957d45d8316ee4

Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
 INSTALL | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/INSTALL b/INSTALL
index 72dc4b67dd..0d3eb89f02 100644
--- a/INSTALL
+++ b/INSTALL
@@ -365,12 +365,5 @@ make XEN_TARGET_ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- \
         DESTDIR=/some/path install
 
 
-TODO
-====
-
- - DESTDIR should be empty, not "/"
- - add make uninstall targets
- - replace private path variables as needed (SBINDIR/sbindir)
- - ...
 
 # vim: tw=72 et

Re: [PATCH v1] INSTALL: remove TODO section
Posted by Wei Liu 3 years, 10 months ago
On Fri, May 29, 2020 at 03:53:03PM +0200, Olaf Hering wrote:
> The default value '/' for DESTDIR is unusual, but does probably not hurt.
> 
> Fixes commit f2b40dababedcd8355bf3e85d00baf17f9827131
> Fixes commit 8e986e5a61efeca92b9b268e77957d45d8316ee4
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>

Acked-by: Wei Liu <wl@xen.org>

Based on the fact that you're the original author of this documentation.
:-)

Cc Paul.

> ---
>  INSTALL | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/INSTALL b/INSTALL
> index 72dc4b67dd..0d3eb89f02 100644
> --- a/INSTALL
> +++ b/INSTALL
> @@ -365,12 +365,5 @@ make XEN_TARGET_ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- \
>          DESTDIR=/some/path install
>  
>  
> -TODO
> -====
> -
> - - DESTDIR should be empty, not "/"
> - - add make uninstall targets
> - - replace private path variables as needed (SBINDIR/sbindir)
> - - ...
>  
>  # vim: tw=72 et

RE: [PATCH v1] INSTALL: remove TODO section
Posted by Paul Durrant 3 years, 10 months ago
> -----Original Message-----
> From: Wei Liu <wl@xen.org>
> Sent: 02 June 2020 09:44
> To: Olaf Hering <olaf@aepfle.de>
> Cc: xen-devel@lists.xenproject.org; Andrew Cooper <andrew.cooper3@citrix.com>; George Dunlap
> <george.dunlap@citrix.com>; Ian Jackson <ian.jackson@eu.citrix.com>; Jan Beulich <jbeulich@suse.com>;
> Julien Grall <julien@xen.org>; Stefano Stabellini <sstabellini@kernel.org>; Wei Liu <wl@xen.org>; Paul
> Durrant <paul@xen.org>
> Subject: Re: [PATCH v1] INSTALL: remove TODO section
> 
> On Fri, May 29, 2020 at 03:53:03PM +0200, Olaf Hering wrote:
> > The default value '/' for DESTDIR is unusual, but does probably not hurt.
> >
> > Fixes commit f2b40dababedcd8355bf3e85d00baf17f9827131
> > Fixes commit 8e986e5a61efeca92b9b268e77957d45d8316ee4
> >
> > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> 
> Acked-by: Wei Liu <wl@xen.org>
> 
> Based on the fact that you're the original author of this documentation.
> :-)
> 
> Cc Paul.

Release-acked-by: Paul Durrant <paul@xen.org>

> 
> > ---
> >  INSTALL | 7 -------
> >  1 file changed, 7 deletions(-)
> >
> > diff --git a/INSTALL b/INSTALL
> > index 72dc4b67dd..0d3eb89f02 100644
> > --- a/INSTALL
> > +++ b/INSTALL
> > @@ -365,12 +365,5 @@ make XEN_TARGET_ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- \
> >          DESTDIR=/some/path install
> >
> >
> > -TODO
> > -====
> > -
> > - - DESTDIR should be empty, not "/"
> > - - add make uninstall targets
> > - - replace private path variables as needed (SBINDIR/sbindir)
> > - - ...
> >
> >  # vim: tw=72 et