From nobody Tue May 7 22:32:48 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1590748233; cv=none; d=zohomail.com; s=zohoarc; b=C8XzbhGT7VgFI98hHIY9ZgpwOSnP3fo6VyzWkydecO0j4W4wg/uRoVY+sw+pHO4uoJaV+jP3bDPhDsMwjgj9MNERkljgc96KTwUGUAA/RcheRsxQO/Y3MenmB0NEK6MOgvz2DvG68Pk77DU2/2+E8uDdqUCm7H3+JxjKuLutu5Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1590748233; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=mUAjpf2lUBAEAj4piZ7Rzd3WcFXw4sZyUbO6+C5etpk=; b=UvQ0ewiVDUxxh96b1w1ajWhi97sMNcBLUStf88bsvgX6YasCewB7WKYhs1r+PSeaGfN/x3+y07JnabsQsHkDigrdT4PuA7SJ5nu0cyDhWtf7WEoSP0gbBA/ZKeBsyfobjd7gwsWvOtIaak3VzYQFQtajPXdEG/wTx3o+GwRdRRQ= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1590748233606922.6009077585194; Fri, 29 May 2020 03:30:33 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jecH3-0007ui-Gh; Fri, 29 May 2020 10:30:01 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jecH1-0007sh-V7 for xen-devel@lists.xenproject.org; Fri, 29 May 2020 10:29:59 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 572bcec0-a197-11ea-a88b-12813bfff9fa; Fri, 29 May 2020 10:29:56 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 8DBD3AC2C; Fri, 29 May 2020 10:29:55 +0000 (UTC) X-Inumbo-ID: 572bcec0-a197-11ea-a88b-12813bfff9fa X-Virus-Scanned: by amavisd-new at test-mx.suse.de From: Juergen Gross To: xen-devel@lists.xenproject.org Subject: [PATCH] tools: fix Rules.mk library make variables Date: Fri, 29 May 2020 12:29:53 +0200 Message-Id: <20200529102953.12714-1-jgross@suse.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Ian Jackson , Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Content-Type: text/plain; charset="utf-8" Both SHDEPS_libxendevicemodel and SHDEPS_libxenhypfs have a bug by adding $(SHLIB_xencall) instead of $(SHLIB_libxencall). The former seems not to have any negative impact, probably because it is not used anywhere in Xen without the correct $(SHLIB_libxencall) being used, too. Fixes: 86234eafb95295 ("libs: add libxenhypfs") Signed-off-by: Juergen Gross Acked-by: Ian Jackson --- tools/Rules.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/Rules.mk b/tools/Rules.mk index 518bb5660a..936fb83fa4 100644 --- a/tools/Rules.mk +++ b/tools/Rules.mk @@ -128,12 +128,12 @@ LDLIBS_libxenforeignmemory =3D $(SHDEPS_libxenforeign= memory) $(XEN_LIBXENFOREIGNME SHLIB_libxenforeignmemory =3D $(SHDEPS_libxenforeignmemory) -Wl,-rpath-li= nk=3D$(XEN_LIBXENFOREIGNMEMORY) =20 CFLAGS_libxendevicemodel =3D -I$(XEN_LIBXENDEVICEMODEL)/include $(CFLAGS_x= eninclude) -SHDEPS_libxendevicemodel =3D $(SHLIB_libxentoollog) $(SHLIB_libxentoolcore= ) $(SHLIB_xencall) +SHDEPS_libxendevicemodel =3D $(SHLIB_libxentoollog) $(SHLIB_libxentoolcore= ) $(SHLIB_libxencall) LDLIBS_libxendevicemodel =3D $(SHDEPS_libxendevicemodel) $(XEN_LIBXENDEVIC= EMODEL)/libxendevicemodel$(libextension) SHLIB_libxendevicemodel =3D $(SHDEPS_libxendevicemodel) -Wl,-rpath-link= =3D$(XEN_LIBXENDEVICEMODEL) =20 CFLAGS_libxenhypfs =3D -I$(XEN_LIBXENHYPFS)/include $(CFLAGS_xeninclude) -SHDEPS_libxenhypfs =3D $(SHLIB_libxentoollog) $(SHLIB_libxentoolcore) $(SH= LIB_xencall) +SHDEPS_libxenhypfs =3D $(SHLIB_libxentoollog) $(SHLIB_libxentoolcore) $(SH= LIB_libxencall) LDLIBS_libxenhypfs =3D $(SHDEPS_libxenhypfs) $(XEN_LIBXENHYPFS)/libxenhypf= s$(libextension) SHLIB_libxenhypfs =3D $(SHDEPS_libxenhypfs) -Wl,-rpath-link=3D$(XEN_LIBXE= NHYPFS) =20 --=20 2.26.2