From nobody Fri May 3 04:35:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1590531431; cv=none; d=zohomail.com; s=zohoarc; b=K4C9hVtQe7Hy4IhgfNZr33U01LZvUbpfX8gG6OZfdAp3BlZLxKl1u9eE9GoE5NzlR9YaB0SeR/95LohA2b8tuqTX117GKjzUUARysXugtMQRJKK7VB738fpuEDMDw8DeI4ELFdBPDo9XWMsaWf2HhEA+UXoFqGmqSL1Sjvdca2c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1590531431; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=LWW3qsGZHcm9dewOIE3cphHtzO5kfLW9WrPbcRRHC0o=; b=UCIU1UAOxuj3HJZPIXjiHdlZdAAium/1K31VSVB2owS3tKYrKuphgPXFebUG6RbZLbdwBewzHd1po7UOXYPxvXUz0Ues4lrzXbRDAw43J0imlbcxDJLYup22owf1Ha17/d9elCbMugfZoasvRF+6DWAyb1RWMFSrFLkUcd1/JCU= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1590531431878576.1014088839186; Tue, 26 May 2020 15:17:11 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jdhsI-0007wY-Gi; Tue, 26 May 2020 22:16:42 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jdhsH-0007wT-KB for xen-devel@lists.xenproject.org; Tue, 26 May 2020 22:16:41 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 929bb0d8-9f9e-11ea-a6c3-12813bfff9fa; Tue, 26 May 2020 22:16:40 +0000 (UTC) X-Inumbo-ID: 929bb0d8-9f9e-11ea-a6c3-12813bfff9fa Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: tPOJu4PQ63FYA20aQt6/WSEoTQZcS9T1BmehDgtkkbZDhK+XKyX/nX9GYBhvHr1EAbSdVXbxHR TYUoqgAuUOLxWX2uPTNLiL3yUTsNACjHESTxduH3LSHxi4hXY4NofWud4lNUn1XxYGxJqtYaLT vQqcsF61mtY7q1oNc/g7gONSHlh+NQhrvUI7qSBdd7xAjxqZBZPxFBM5Z3EugiqWwFI/tHlGkB +gH7tFIhiZHFA9cJr7XnDijJ9Jku3qap/j/5fQFe0PWJvghN7Vz7xMut2d6iPdbYjcvuO77jtW RXs= X-SBRS: 2.7 X-MesageID: 19238409 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.73,439,1583211600"; d="scan'208";a="19238409" From: George Dunlap To: Subject: [PATCH v2 1/5] libxl: Generate golang bindings in libxl Makefile Date: Tue, 26 May 2020 23:16:08 +0100 Message-ID: <20200526221612.900922-2-george.dunlap@citrix.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200526221612.900922-1-george.dunlap@citrix.com> References: <20200526221612.900922-1-george.dunlap@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Nick Rosbrook , Ian Jackson , Ian Jackson , George Dunlap , Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Content-Type: text/plain; charset="utf-8" The generated golang bindings (types.gen.go and helpers.gen.go) are left checked in so that they can be fetched from xenbits using the golang tooling. This means that they must be updated whenever libxl_types.idl (or other dependencies) are updated. However, the golang bindings are only built optionally; we can't assume that anyone updating libxl_types.idl will also descend into the tools/golang tree to re-generate the bindings. Fix this by re-generating the golang bindings from the libxl Makefile when the IDL dependencies are updated, so that anyone who updates libxl_types.idl will also end up updating the golang generated files as well. - Make a variable for the generated files, and a target in xenlight/Makefile which will only re-generate the files. - Add a target in libxl/Makefile to call external idl generation targets (currently only golang). For ease of testing, also add a specific target in libxl/Makefile just to check and update files generated from the IDL. This does mean that there are two potential paths for generating the files during a parallel build; but that shouldn't be an issue, since tools/golang/xenlight should never be built until after tools/libxl has completed building anyway. Signed-off-by: George Dunlap Reviewed-by: Nick Rosbrook Acked-by: Ian Jackson --- v2: - Add comments explaining parallel make safety CC: Ian Jackson CC: Wei Liu CC: Nick Rosbrook --- tools/golang/xenlight/Makefile | 11 ++++++++++- tools/libxl/Makefile | 17 ++++++++++++++++- 2 files changed, 26 insertions(+), 2 deletions(-) diff --git a/tools/golang/xenlight/Makefile b/tools/golang/xenlight/Makefile index cd0a62505f..8ab4cb5665 100644 --- a/tools/golang/xenlight/Makefile +++ b/tools/golang/xenlight/Makefile @@ -17,12 +17,21 @@ all: build .PHONY: package package: $(XEN_GOPATH)$(GOXL_PKG_DIR) =20 -$(XEN_GOPATH)/src/$(XEN_GOCODE_URL)/xenlight/: xenlight.go types.gen.go he= lpers.gen.go +GOXL_GEN_FILES =3D types.gen.go helpers.gen.go + +$(XEN_GOPATH)/src/$(XEN_GOCODE_URL)/xenlight/: xenlight.go $(GOXL_GEN_FILE= S) $(INSTALL_DIR) $(XEN_GOPATH)$(GOXL_PKG_DIR) $(INSTALL_DATA) xenlight.go $(XEN_GOPATH)$(GOXL_PKG_DIR) $(INSTALL_DATA) types.gen.go $(XEN_GOPATH)$(GOXL_PKG_DIR) $(INSTALL_DATA) helpers.gen.go $(XEN_GOPATH)$(GOXL_PKG_DIR) =20 +# NOTE: This target is called from libxl/Makefile:all. Since that +# target must finish before golang/Makefile is called, this is +# currently safe. It must not be called from anywhere else in the +# Makefile system without careful thought about races with +# xenlight/Makefile:all +idl-gen: $(GOXL_GEN_FILES) + %.gen.go: gengotypes.py $(LIBXL_SRC_DIR)/libxl_types.idl $(LIBXL_SRC_DIR)/= idl.py XEN_ROOT=3D$(XEN_ROOT) $(PYTHON) gengotypes.py $(LIBXL_SRC_DIR)/libxl_typ= es.idl =20 diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile index 69fcf21577..947eb6036e 100644 --- a/tools/libxl/Makefile +++ b/tools/libxl/Makefile @@ -218,7 +218,7 @@ testidl.c: libxl_types.idl gentest.py libxl.h $(AUTOINC= S) .PHONY: all all: $(CLIENTS) $(TEST_PROGS) $(PKG_CONFIG) $(PKG_CONFIG_LOCAL) \ libxenlight.so libxenlight.a libxlutil.so libxlutil.a \ - $(AUTOSRCS) $(AUTOINCS) + $(AUTOSRCS) $(AUTOINCS) idl-external =20 $(LIBXL_OBJS) $(LIBXLU_OBJS) $(SAVE_HELPER_OBJS) \ $(LIBXL_TEST_OBJS) $(TEST_PROG_OBJS): \ @@ -274,6 +274,21 @@ _libxl_type%.h _libxl_type%_json.h _libxl_type%_privat= e.h _libxl_type%.c: libxl_ $(call move-if-changed,__libxl_type$(stem)_json.h,_libxl_type$(stem)_json= .h) $(call move-if-changed,__libxl_type$(stem).c,_libxl_type$(stem).c) =20 +# NOTE: This is safe to do at the moment because idl-external and +# idl-gen are only called from libxl/Makefile:all, which must return +# before golang/Makefile is callid. idl-external and idl-gen must +# never be called from another part of the make system without careful tho= ught +# about races with tools/golang/xenlight/Makefile:all +.PHONY: idl-external +idl-external: + $(MAKE) -C $(XEN_ROOT)/tools/golang/xenlight idl-gen + +LIBXL_IDLGEN_FILES =3D _libxl_types.h _libxl_types_json.h _libxl_types_pri= vate.h _libxl_types.c \ + _libxl_types_internal.h _libxl_types_internal_json.h _libxl_types_interna= l_private.h _libxl_types_internal.c + + +idl-gen: $(LIBXL_GEN_FILES) idl-external + libxenlight.so: libxenlight.so.$(MAJOR) $(SYMLINK_SHLIB) $< $@ =20 --=20 2.25.1 From nobody Fri May 3 04:35:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1590531443; cv=none; d=zohomail.com; s=zohoarc; b=Zh83Gjk8+gkc8Ltrkc9t1LMbRA6SvZHnoOdq50N5trXXg8jGPetVEIIu6wMBAytxXP6zWi1vDOc3KyzxyQQdBBmxV2PCMm8vTQuk6KuGQqghjWnD/lErYXyoizJb2w21wsYOrZozcYznTBHRSz5u6ZFhK7KIz+nAgFQjzTMfx/4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1590531443; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=HzL3pJOle94lOLIwBOcd2Y0soIH0wApILhmo1FKjqsk=; b=PKSJTwy/HOtgoVHxyQ4pm1SqpZcECk/uPCsCDA/J+fwGA/uprKtwicokVkWfRqppJLygFdIwqKB1beSSWawUA6QT0Tv5TESfxMqjSCq9AA+KOw6P62VkDPT/twOYh6V/+/PibduhpXJuHPnZb9brG2wEQkH3Zs6UkzAAucSPQNk= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1590531443898250.29547053366946; Tue, 26 May 2020 15:17:23 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jdhsX-00081x-Ne; Tue, 26 May 2020 22:16:57 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jdhsW-00081S-Ie for xen-devel@lists.xenproject.org; Tue, 26 May 2020 22:16:56 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 929bb0da-9f9e-11ea-a6c3-12813bfff9fa; Tue, 26 May 2020 22:16:42 +0000 (UTC) X-Inumbo-ID: 929bb0da-9f9e-11ea-a6c3-12813bfff9fa Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: yW0inEishecCLkrpueYmCQX7SwgD6cEnEpRYPwL4Ph6EZXjjCl2Z7efPQFhiaJZjYHQxkbcTgK Ckpo8xSFETBl72pDg7BjZtr5+lGfHQ7HfOoDgHFvuJFyhQ82xEutpxtW+QEuDUhGDEUaowQaRo sJt/n3LXVYKMmYCrms7Xe2rKT8HOi6ToR1e5qUK97kJ1xE3HZJIoYKsp4x5WwI+iSPK8F3FDU/ Xw9GaXBfqcQ7UKIVVhCyDcYbaIs7cFSR+ZrAKG0p9oxrmMkxkDaItTgIf8mpD0B+8kUD9eEPzF I+Q= X-SBRS: 2.7 X-MesageID: 19238412 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.73,439,1583211600"; d="scan'208";a="19238412" From: George Dunlap To: Subject: [PATCH v2 2/5] golang/xenlight: Get rid of GOPATH-based build artefacts Date: Tue, 26 May 2020 23:16:09 +0100 Message-ID: <20200526221612.900922-3-george.dunlap@citrix.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200526221612.900922-1-george.dunlap@citrix.com> References: <20200526221612.900922-1-george.dunlap@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Nick Rosbrook , Ian Jackson , George Dunlap Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Content-Type: text/plain; charset="utf-8" The original build setup used a "fake GOPATH" in tools/golang to test the mechanism of building from go package files installed on a filesystem. With the move to modules, this isn't necessary, and leads to potentially confusing directories being created. (I.e., it might not be obvious that files under tools/golang/src shouldn't be edited.) Get rid of the code that creates this (now unused) intermediate directory. Add direct dependencies from 'build' onto the source files. Signed-off-by: George Dunlap Reviewed-by: Nick Rosbrook --- v2: - New CC: Ian Jackson CC: Nick Rosbrook --- tools/Rules.mk | 1 - tools/golang/Makefile | 10 ---------- tools/golang/xenlight/Makefile | 19 ++++--------------- 3 files changed, 4 insertions(+), 26 deletions(-) diff --git a/tools/Rules.mk b/tools/Rules.mk index 59c72e7a88..76acaef988 100644 --- a/tools/Rules.mk +++ b/tools/Rules.mk @@ -35,7 +35,6 @@ XENSTORE_XENSTORED ?=3D y debug ?=3D y debug_symbols ?=3D $(debug) =20 -XEN_GOPATH =3D $(XEN_ROOT)/tools/golang XEN_GOCODE_URL =3D golang.xenproject.org =20 ifeq ($(debug_symbols),y) diff --git a/tools/golang/Makefile b/tools/golang/Makefile index aba11ebc39..b022e2c5a3 100644 --- a/tools/golang/Makefile +++ b/tools/golang/Makefile @@ -1,16 +1,6 @@ XEN_ROOT=3D$(CURDIR)/../.. include $(XEN_ROOT)/tools/Rules.mk =20 -# In order to link against a package in Go, the package must live in a -# directory tree in the way that Go expects. To make this possible, -# there must be a directory such that we can set GOPATH=3D${dir}, and -# the package will be under $GOPATH/src/${full-package-path}. - -# So we set XEN_GOPATH to $XEN_ROOT/tools/golang. The xenlight -# "package build" directory ($PWD/xenlight) will create the "package -# source" directory in the proper place. Go programs can use this -# package by setting GOPATH=3D$(XEN_GOPATH). - SUBDIRS-y =3D xenlight =20 .PHONY: build all diff --git a/tools/golang/xenlight/Makefile b/tools/golang/xenlight/Makefile index 8ab4cb5665..f8d8047524 100644 --- a/tools/golang/xenlight/Makefile +++ b/tools/golang/xenlight/Makefile @@ -14,17 +14,8 @@ LIBXL_SRC_DIR =3D ../../libxl .PHONY: all all: build =20 -.PHONY: package -package: $(XEN_GOPATH)$(GOXL_PKG_DIR) - GOXL_GEN_FILES =3D types.gen.go helpers.gen.go =20 -$(XEN_GOPATH)/src/$(XEN_GOCODE_URL)/xenlight/: xenlight.go $(GOXL_GEN_FILE= S) - $(INSTALL_DIR) $(XEN_GOPATH)$(GOXL_PKG_DIR) - $(INSTALL_DATA) xenlight.go $(XEN_GOPATH)$(GOXL_PKG_DIR) - $(INSTALL_DATA) types.gen.go $(XEN_GOPATH)$(GOXL_PKG_DIR) - $(INSTALL_DATA) helpers.gen.go $(XEN_GOPATH)$(GOXL_PKG_DIR) - # NOTE: This target is called from libxl/Makefile:all. Since that # target must finish before golang/Makefile is called, this is # currently safe. It must not be called from anywhere else in the @@ -43,23 +34,21 @@ idl-gen: $(GOXL_GEN_FILES) # in the LDFLAGS; and thus we need to add -L$(XEN_XENLIGHT) here # so that it can find the actual library. .PHONY: build -build: package +build: xenlight.go $(GOXL_GEN_FILES) CGO_CFLAGS=3D"$(CFLAGS_libxenlight) $(CFLAGS_libxentoollog)" CGO_LDFLAGS= =3D"$(LDLIBS_libxenlight) $(LDLIBS_libxentoollog) -L$(XEN_XENLIGHT) -L$(XEN= _LIBXENTOOLLOG)" $(GO) build -x =20 .PHONY: install install: build $(INSTALL_DIR) $(DESTDIR)$(GOXL_INSTALL_DIR) - $(INSTALL_DATA) $(XEN_GOPATH)$(GOXL_PKG_DIR)xenlight.go $(DESTDIR)$(GOXL_= INSTALL_DIR) - $(INSTALL_DATA) $(XEN_GOPATH)$(GOXL_PKG_DIR)types.gen.go $(DESTDIR)$(GOXL= _INSTALL_DIR) - $(INSTALL_DATA) $(XEN_GOPATH)$(GOXL_PKG_DIR)helpers.gen.go $(DESTDIR)$(GO= XL_INSTALL_DIR) + $(INSTALL_DATA) xenlight.go $(DESTDIR)$(GOXL_INSTALL_DIR) + $(INSTALL_DATA) types.gen.go $(DESTDIR)$(GOXL_INSTALL_DIR) + $(INSTALL_DATA) helpers.gen.go $(DESTDIR)$(GOXL_INSTALL_DIR) =20 .PHONY: uninstall rm -rf $(DESTDIR)$(GOXL_INSTALL_DIR) =20 .PHONY: clean clean: - $(RM) -r $(XEN_GOPATH)$(GOXL_PKG_DIR) - $(RM) $(XEN_GOPATH)/pkg/*/$(XEN_GOCODE_URL)/xenlight.a =20 .PHONY: distclean distclean: clean --=20 2.25.1 From nobody Fri May 3 04:35:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1590531431; cv=none; d=zohomail.com; s=zohoarc; b=YyBPOh4SbbhVFJQmnMvdrSBookP2ml+ZMrkxUp+il8NO5SWseIGKLtSFfJi5+/L15N0h92+SMZ7h2RxHI8Ym+BGAcfqYEIEhZqT7tUkE9hDqxr65a7EO+TzMWAKcyOxaKh3mcF1wVRo5LsMrASvGrftYnzWWG6Q2aAMOXPyAKqc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1590531431; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=RPbqQ1ys5YXC9ISVaFOetNceLEa17bOFR8t47Z9rPX8=; b=Mphe9kQNg0OnZYr9jb2VlmCOdHz816YjlIq27S++9XfPqmSJJPp0z9dSu/NkzENQtwBtoWzB7SVSyEB8JdXnHTyHkZeTZUvJudwSb2q1UHSecqmQhil8UW5CcPsEvzbIbLQBXw6TPUPgNDyn1kojc5NQYtgviFgdUqaX4fJZIZs= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1590531431838465.3354879446207; Tue, 26 May 2020 15:17:11 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jdhsO-0007xm-4x; Tue, 26 May 2020 22:16:48 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jdhsM-0007xL-I9 for xen-devel@lists.xenproject.org; Tue, 26 May 2020 22:16:46 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 929bb0d9-9f9e-11ea-a6c3-12813bfff9fa; Tue, 26 May 2020 22:16:41 +0000 (UTC) X-Inumbo-ID: 929bb0d9-9f9e-11ea-a6c3-12813bfff9fa Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: YeKW0jUKxEquevFRXYynJNH92Ps5LOSQIwW22tVNkuVltKfq5xh4EbEVGrfkGTyrO8gAV512nt Wb2UTg9xXlosgsogqdUskZf5GbR3x740niaw1lMhCPZYR8TdB/6Ke9lrE8qDVQzD9inpD7aTR1 IUTStwAAHSrLm1JZ2+rkgi6eVnpRDiMxP182HrEZWSt1RE7OdGrHnKgKMuN6+U5X38IWIPUTaX 1ZOrTKVl5Gj+M53qgTzn5uaA+i6RQcW3DC5GGek2l82PwsS8mlVlLDggKGahQMMIOT67+UHB9k 3QA= X-SBRS: 2.7 X-MesageID: 19238411 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.73,439,1583211600"; d="scan'208";a="19238411" From: George Dunlap To: Subject: [PATCH v2 3/5] automation/archlinux: Add 32-bit glibc headers Date: Tue, 26 May 2020 23:16:10 +0100 Message-ID: <20200526221612.900922-4-george.dunlap@citrix.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200526221612.900922-1-george.dunlap@citrix.com> References: <20200526221612.900922-1-george.dunlap@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony Perard , Doug Goldstein , George Dunlap , Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Content-Type: text/plain; charset="utf-8" This fixes the following build error in hvmloader: usr/include/gnu/stubs.h:7:11: fatal error: gnu/stubs-32.h: No such file or = directory Signed-off-by: George Dunlap Acked-by: Anthony PERARD Acked-by: Wei Liu --- v2: - New CC: Doug Goldstein CC: Wei Liu CC: Anthony Perard --- automation/build/archlinux/current.dockerfile | 1 + 1 file changed, 1 insertion(+) diff --git a/automation/build/archlinux/current.dockerfile b/automation/bui= ld/archlinux/current.dockerfile index 9af5d66afc..5095de65b8 100644 --- a/automation/build/archlinux/current.dockerfile +++ b/automation/build/archlinux/current.dockerfile @@ -19,6 +19,7 @@ RUN pacman -S --refresh --sysupgrade --noconfirm --noprog= ressbar --needed \ iasl \ inetutils \ iproute \ + lib32-glibc \ libaio \ libcacard \ libgl \ --=20 2.25.1 From nobody Fri May 3 04:35:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1590531447; cv=none; d=zohomail.com; s=zohoarc; b=WmmqLPC5PT6BuVK/vCXivi10ZPj6Da2d7v0AVRZmYYzxUJwUZXlNuw3LsyJ8VDChIMsXcknJs/7fB3wuWUrQsS7wJGa8EbBqxBm+7a4SHGTFnag2hX0laALT19/x9mcr3EH08u5402KDukayt+YIHiUsxdQ1pjBekfD0U3PVJSw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1590531447; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=1r6p60j0R/Bth8rqPPDUdr8BQaBjrzX68Be29HkiJDE=; b=LOKCOFS9QSGWkK94YElxZ/y5/h572IaXAjvYnJNlgR8ONX0zRfmycWscuBT90+ReDp7AtEPRebhNqQqd4xL07WMaXAgG+UZLeEqW3sizy4PIvygNMaUK01Dp2sATYFuL8DzZvkBW3vKu/743BwA7GE7t7TF3fznzVrRH+iHKP60= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1590531447668558.0156719300765; Tue, 26 May 2020 15:17:27 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jdhsd-00084P-1F; Tue, 26 May 2020 22:17:03 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jdhsb-00083n-J8 for xen-devel@lists.xenproject.org; Tue, 26 May 2020 22:17:01 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 94daf39a-9f9e-11ea-a6c3-12813bfff9fa; Tue, 26 May 2020 22:16:44 +0000 (UTC) X-Inumbo-ID: 94daf39a-9f9e-11ea-a6c3-12813bfff9fa Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: cu8UWhvEil7kDZD8zHi5/jSJQD0btiknIDvUtyRoaZOu5JTNQNJuhxwRU8GYWVJ9i698NuCL1I Mgu4pRtHmAIP88qZMM0ZJK63RxGG+g1CyXeVQHDQm9rEtnoXG5GKUIp40KJo0oXLZoehC86n6J h7gEWVSr34fKFia57eCXrCS4DF5r2PaqtwfikLD59jz9b6j3m4FcBMmfvRh+4OYuJOkip8HMNW KAwL/l2LPuXJ+G8kGyah9iXkbYsKo4Ce2h8M5TUg11rYR0O+jvIfzZa2TL1SETYvXyYjc0IAIa 2W4= X-SBRS: 2.7 X-MesageID: 18520581 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.73,439,1583211600"; d="scan'208";a="18520581" From: George Dunlap To: Subject: [PATCH v2 4/5] automation: Add golang packages to various dockerfiles Date: Tue, 26 May 2020 23:16:11 +0100 Message-ID: <20200526221612.900922-5-george.dunlap@citrix.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200526221612.900922-1-george.dunlap@citrix.com> References: <20200526221612.900922-1-george.dunlap@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Doug Goldstein , George Dunlap , Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Content-Type: text/plain; charset="utf-8" Specifically, Fedora 29, Archlinux, and Debian unstable. This will cause the CI loop to detect golang build failures. CentOS 6 and 7 don't have golang packages, and the packages in stretch, jessie, xenial, and trusty are too old. Signed-off-by: George Dunlap --- v2: - New CC: Wei Liu CC: Doug Goldstein --- automation/build/archlinux/current.dockerfile | 1 + automation/build/debian/unstable.dockerfile | 1 + automation/build/fedora/29.dockerfile | 1 + 3 files changed, 3 insertions(+) diff --git a/automation/build/archlinux/current.dockerfile b/automation/bui= ld/archlinux/current.dockerfile index 5095de65b8..d8fbebaf79 100644 --- a/automation/build/archlinux/current.dockerfile +++ b/automation/build/archlinux/current.dockerfile @@ -16,6 +16,7 @@ RUN pacman -S --refresh --sysupgrade --noconfirm --noprog= ressbar --needed \ ghostscript \ git \ gnutls \ + go \ iasl \ inetutils \ iproute \ diff --git a/automation/build/debian/unstable.dockerfile b/automation/build= /debian/unstable.dockerfile index d0aa5ad2bb..aeb4f3448b 100644 --- a/automation/build/debian/unstable.dockerfile +++ b/automation/build/debian/unstable.dockerfile @@ -45,6 +45,7 @@ RUN apt-get update && \ nasm \ gnupg \ apt-transport-https \ + golang \ && \ apt-get autoremove -y && \ apt-get clean && \ diff --git a/automation/build/fedora/29.dockerfile b/automation/build/fedor= a/29.dockerfile index 5be4a9e229..6a4e5b0413 100644 --- a/automation/build/fedora/29.dockerfile +++ b/automation/build/fedora/29.dockerfile @@ -40,5 +40,6 @@ RUN dnf -y install \ nasm \ ocaml \ ocaml-findlib \ + golang \ && dnf clean all && \ rm -rf /var/cache/dnf --=20 2.25.1 From nobody Fri May 3 04:35:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1590531429; cv=none; d=zohomail.com; s=zohoarc; b=c5hIF89OJLk5suNNkBDJ8ut8Z1yBm8f8HlPJBLeMMmqCsJCQAVykGWzLpaUpxswQROpWv5tOv4akPa2uxAet2R1C1nTazOPo0+rF6ayoYVF18r0kJG+tFm/Pk0X4WRIvwLZgQFTbv9qaU5nyzD/4QC/lwEW2UrMrqqmCcEnlAPg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1590531429; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=wlOGvl3YAgauTRVAHZvK4mXouMDQ508P+bcuA8qzZcE=; b=UbzNqJYP8OcgnIX6ctOi5XzLFhDwZ1M1oi0TZmB84CpL/H3WG0/PUEWa54mJA6B0FblhwKQzaOPo19F40leV69ydQ9xYLdzehEHq4wreXOc4KaIAwbTAxBag2FcTJJp9ExeBsW/pCMOYu4Vvgi+KmdPBXO5OikcV/8c2WzfYqLs= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1590531429226192.51848049745956; Tue, 26 May 2020 15:17:09 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jdhsK-0007wl-Om; Tue, 26 May 2020 22:16:44 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jdhsJ-0007we-Pr for xen-devel@lists.xenproject.org; Tue, 26 May 2020 22:16:43 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 940e59e8-9f9e-11ea-8993-bc764e2007e4; Tue, 26 May 2020 22:16:43 +0000 (UTC) X-Inumbo-ID: 940e59e8-9f9e-11ea-8993-bc764e2007e4 Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: eTEhCJ/mCCQHeXvQIyLpMeRUv7+peNP5dOgSSyYqLeB8zC+ed1/0TLuZK6vlVfNIGko+tqoG6n T7tMQUngaCKt/CXqMWtz78gIUTSeILGE7F3iFtIVjw/A07LtYHI2dIOIvbWsaIIfu0zpY8wJdD E+JfePvQ5/J4argGdB4m3kuEaLcVRz2a2AHMkqGWHej1vCte7MTRA3UpthGlsjaOQYG52nOozm xYVIFntpnV9nFNthvSZuv8kjS7hXLlBLzTWqCj9lFSpl6qPgJjBYLv8bZ+t+iD4XzGpSYbigZ3 Ol0= X-SBRS: 2.7 X-MesageID: 18759804 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.73,439,1583211600"; d="scan'208";a="18759804" From: George Dunlap To: Subject: [PATCH v2 5/5] automation/containerize: Add a shortcut for Debian unstable Date: Tue, 26 May 2020 23:16:12 +0100 Message-ID: <20200526221612.900922-6-george.dunlap@citrix.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200526221612.900922-1-george.dunlap@citrix.com> References: <20200526221612.900922-1-george.dunlap@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Doug Goldstein , George Dunlap , Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Content-Type: text/plain; charset="utf-8" Signed-off-by: George Dunlap --- v2: - New CC: Doug Goldstein CC: Wei Liu --- automation/scripts/containerize | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/automation/scripts/containerize b/automation/scripts/container= ize index fbc4bc22d6..b71edd736c 100755 --- a/automation/scripts/containerize +++ b/automation/scripts/containerize @@ -22,6 +22,7 @@ case "_${CONTAINER}" in _fedora) CONTAINER=3D"${BASE}/fedora:29";; _jessie) CONTAINER=3D"${BASE}/debian:jessie" ;; _stretch|_) CONTAINER=3D"${BASE}/debian:stretch" ;; + _unstable|_) CONTAINER=3D"${BASE}/debian:unstable" ;; _trusty) CONTAINER=3D"${BASE}/ubuntu:trusty" ;; _xenial) CONTAINER=3D"${BASE}/ubuntu:xenial" ;; esac @@ -91,4 +92,3 @@ exec docker run \ -${termint}i --rm -- \ ${CONTAINER} \ ${cmd} - --=20 2.25.1