From nobody Thu Mar 28 18:51:50 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1590160096; cv=none; d=zohomail.com; s=zohoarc; b=WxtrzeCPe7NvTJmGuZ/zpT4fJz559NE2hA7EHsrA6YP3wDaEkSxhvgdtxtzmvlYOKXYQ06VrpzDwg3nJI3B0j76d3WE9y6LKmiIxqIhJdomCucNpoZexVydWEOxCkNsE/orKA6cGKZPcXyqNpwSFUW9QYY/V5+6kn+qzDM9HyJE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1590160096; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=EXJwNg5MOp0wnNwZhuIxIkrqPNIyb13SIG4vr9XOy5k=; b=Zrnp/SvtcMAoYZB9uJK++2VhqB5CmzYMR32VhlnD8sICiNPH7OfAzU5XBClaZh8SbKZR9trUMnsR/kBWKCR+2+7zH7TyLprVdMvGP8NMITT0hFtWVA60OHkTsqiDryTqgRtg4Qf/EN169j+2X4NKgq2rnjPlt0tZVg4BAARR5vw= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1590160096125381.8532447136274; Fri, 22 May 2020 08:08:16 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jc9H9-0007h2-EM; Fri, 22 May 2020 15:07:55 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jc9H7-0007gx-RN for xen-devel@lists.xenproject.org; Fri, 22 May 2020 15:07:53 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 01c67b96-9c3e-11ea-ae69-bc764e2007e4; Fri, 22 May 2020 15:07:52 +0000 (UTC) X-Inumbo-ID: 01c67b96-9c3e-11ea-ae69-bc764e2007e4 Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: pywG/WyueHGMEDxq8X+fh8wZanoO5OpJS1+aiLTRESYwg1GCNloMICFlG+JfSS9bVyJjzZXMYM eT7dAQQ0eRjsFMHCZm9tpf7UtUysia/NIrFNKt4JqpD5LiA05zStGO4h7c2dToLqv5n7uV/iqM MtFLu6LY0TL+PF2XKkizuvEcwfo7dTnXBo/paJmK0KRxMrKY8JNqU3tDuCb32BaJcPUtbnO0oK OsoWXO/rTvP0BA0QNTszdvAYx6t+Sg/I8zA/ABx/L33KVZfUKk0K6zaSH4k3ncEwF8rxc/6VPK zfY= X-SBRS: 2.7 X-MesageID: 18449305 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.73,422,1583211600"; d="scan'208";a="18449305" From: Andrew Cooper To: Xen-devel Subject: [PATCH] x86/idle: Extend ISR/C6 erratum workaround to Haswell Date: Fri, 22 May 2020 16:07:33 +0100 Message-ID: <20200522150733.18422-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" This bug was first discovered against Haswell. It is definitely affected. (The XenServer ticket for this bug was opened on 2013-05-30 which is coming= up on 7 years old, and predates Broadwell). Signed-off-by: Andrew Cooper Acked-by: Jan Beulich --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monn=C3=A9 We've followed up with Intel, but based on conversations, I was expecting Haswell to be treated the same as Broadwell in this regard. --- xen/arch/x86/acpi/cpu_idle.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/xen/arch/x86/acpi/cpu_idle.c b/xen/arch/x86/acpi/cpu_idle.c index 178cb607c2..a2248ea11f 100644 --- a/xen/arch/x86/acpi/cpu_idle.c +++ b/xen/arch/x86/acpi/cpu_idle.c @@ -583,8 +583,16 @@ bool errata_c6_workaround(void) * registers), the processor may dispatch the second interrupt (fr= om * the IRR bit) before the first interrupt has completed and writt= en to * the EOI register, causing the first interrupt to never complete. + * + * Note: Haswell hasn't had errata issued, but this issue was first + * discovered on Haswell hardware, and is affected. */ static const struct x86_cpu_id isr_errata[] =3D { + /* Haswell */ + INTEL_FAM6_MODEL(0x3c), + INTEL_FAM6_MODEL(0x3f), + INTEL_FAM6_MODEL(0x45), + INTEL_FAM6_MODEL(0x46), /* Broadwell */ INTEL_FAM6_MODEL(0x47), INTEL_FAM6_MODEL(0x3d), --=20 2.11.0