From nobody Fri Apr 26 23:22:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=citrix.com ARC-Seal: i=1; a=rsa-sha256; t=1589655795; cv=none; d=zohomail.com; s=zohoarc; b=cNpaK7aeygcvhDYwi+NdlA/9quQi1i7rZsGtwjdGdbgfjKkBayR0ROf9LFCqAjAVUgzk7T5SzzhRfWCcqbZP/bh6GwhnzWJhcWk2i+9JkW1nt0NI+sRSKEOXH9CpAchDWR5aGLdaqHIWAehOvGi6KQNYdiiwWBfbNiCTaqWZPQo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1589655795; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=AqmuSTuY2yEUBujkHSipdVvPfBcKTZzlp3V/PHb6x8s=; b=TrlwgSqN2hNCPhQiqHBE5H/rTfJO8kGfICHjV20zUTEY3fEd8OE2htOtqsr1BVd0IWQZWt05ZE6uNDyOyJuUuis2vJunzyPL0R1huKQArB1GVTlOAduEx2s+EDgpLcxhwsRHIo2Pi+I161Iq+wm5a+m/LhbOFswq7eR3eAM+9v8= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1589655795140843.8683899729558; Sat, 16 May 2020 12:03:15 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ja24q-0004zT-3S; Sat, 16 May 2020 19:02:28 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ja24p-0004zO-JX for xen-devel@lists.xenproject.org; Sat, 16 May 2020 19:02:27 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c83f51b2-97a7-11ea-a6f8-12813bfff9fa; Sat, 16 May 2020 19:02:27 +0000 (UTC) X-Inumbo-ID: c83f51b2-97a7-11ea-a6f8-12813bfff9fa Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: GVkynst+cvXN7JmYxKUw0wzgjon4EQJhl7SNg2qSyhvX70uvy0IAA4Kk3pM3YGTjihGQMCxt4H eHBh9s3M+R+23UgGJ+1DMiRlhzCS1sIqeZWGrl5T9WU9EEjzGRbbbPB6aYFjv0dcJwtmr/lShz aBi+n9AMma00cEQQkisy+MnfjifUmaIQ3yQSZW2HwsT/W9lqCFKw2FvpPNehW5P9P4gB1/AZwP n5pQAfQcvwM8sEWXk0b7pKJFeUGHAwFYfpuWF3SskIX5XXl/26ZjZZCGs4o06Kwbv4horo+KUn HUc= X-SBRS: None X-MesageID: 17735596 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.73,400,1583211600"; d="scan'208";a="17735596" From: Andrew Cooper To: Xen-devel Subject: [PATCH] x86/hvm: Fix shifting in stdvga_mem_read() Date: Sat, 16 May 2020 20:02:11 +0100 Message-ID: <20200516190211.4120-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" stdvga_mem_read() has a return type of uint8_t, which promotes to int rather than unsigned int. Shifting by 24 may hit the sign bit. Spotted by Coverity. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monn=C3=A9 --- xen/arch/x86/hvm/stdvga.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/hvm/stdvga.c b/xen/arch/x86/hvm/stdvga.c index bd398dbb1b..e2675139e7 100644 --- a/xen/arch/x86/hvm/stdvga.c +++ b/xen/arch/x86/hvm/stdvga.c @@ -322,7 +322,7 @@ static int stdvga_mem_read(const struct hvm_io_handler = *handler, data =3D stdvga_mem_readb(addr); data |=3D stdvga_mem_readb(addr + 1) << 8; data |=3D stdvga_mem_readb(addr + 2) << 16; - data |=3D stdvga_mem_readb(addr + 3) << 24; + data |=3D (uint32_t)stdvga_mem_readb(addr + 3) << 24; break; =20 case 8: --=20 2.11.0