From nobody Mon Nov 10 19:38:15 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1589182989; cv=none; d=zohomail.com; s=zohoarc; b=dSfosLrdkMkmJ7PN9eENJFQnOfFk4Dz8ZHNq0G8vfTxNjr6d8f7PZYZTerl5FVLnL5NAurNHWZusZU2Pckg6eJC0d3k+/H3to8/egA6hRPfWqB7njgj3rdP1PSAQ2OFyMIAjwKvz2+9+9ifYwuf8lPxYUm0mUj1ztKDlsSApt3s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1589182989; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=KXAj78D3INgRmMIVYEqjOBzNJE62mfvT+vBskDqdVp0=; b=PMwkyF77MsmlaMpmbiwIjoYFUkKhMxBHlbb318nld6AaOAm0VJlWbDLsqM87U5z0+ynBE5yoqu3zqGRpiEbmHKSzp1Osp0WYI8M8bRBpM+MNaXel4a2QUFEOvyoEumYWq+mtVbVUNyhDNNxyfPzYbF9RRyfSp3fOlpSC1RYdP5s= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1589182989639976.6580252844013; Mon, 11 May 2020 00:43:09 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jY35D-0005PA-2R; Mon, 11 May 2020 07:42:39 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jY35B-0005P5-Fu for xen-devel@lists.xenproject.org; Mon, 11 May 2020 07:42:37 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id faa844b6-935a-11ea-a1f4-12813bfff9fa; Mon, 11 May 2020 07:42:35 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 15307AC90; Mon, 11 May 2020 07:42:37 +0000 (UTC) X-Inumbo-ID: faa844b6-935a-11ea-a1f4-12813bfff9fa X-Virus-Scanned: by amavisd-new at test-mx.suse.de From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Subject: [PATCH] xen/pvcalls-back: test for errors when calling backend_connect() Date: Mon, 11 May 2020 09:42:31 +0200 Message-Id: <20200511074231.19794-1-jgross@suse.com> X-Mailer: git-send-email 2.26.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , stable@vger.kernel.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Content-Type: text/plain; charset="utf-8" backend_connect() can fail, so switch the device to connected only if no error occurred. Fixes: 0a9c75c2c7258f2 ("xen/pvcalls: xenbus state handling") Cc: stable@vger.kernel.org Signed-off-by: Juergen Gross Reviewed-by: Stefano Stabellini --- drivers/xen/pvcalls-back.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c index cf4ce3e9358d..41a18ece029a 100644 --- a/drivers/xen/pvcalls-back.c +++ b/drivers/xen/pvcalls-back.c @@ -1088,7 +1088,8 @@ static void set_backend_state(struct xenbus_device *d= ev, case XenbusStateInitialised: switch (state) { case XenbusStateConnected: - backend_connect(dev); + if (backend_connect(dev)) + return; xenbus_switch_state(dev, XenbusStateConnected); break; case XenbusStateClosing: --=20 2.26.1