[PATCH] x86/IST: Fix comment about stack layout

Andrew Cooper posted 1 patch 3 years, 11 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/xen tags/patchew/20200427131702.13991-1-andrew.cooper3@citrix.com
xen/include/asm-x86/current.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] x86/IST: Fix comment about stack layout
Posted by Andrew Cooper 3 years, 11 months ago
This was an oversight in c/s 5d37af364dc "x86/traps: Use an Interrupt Stack
Table for #DB" which introduced the #DB IST to begin with.

Reported-by: Jan Beulich <JBeulich@suse.com>
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Wei Liu <wl@xen.org>
CC: Roger Pau Monné <roger.pau@citrix.com>
---
 xen/include/asm-x86/current.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/include/asm-x86/current.h b/xen/include/asm-x86/current.h
index 0b47485337..39c2c6cbf8 100644
--- a/xen/include/asm-x86/current.h
+++ b/xen/include/asm-x86/current.h
@@ -18,7 +18,7 @@
  * 6 - Primary stack
  * 5 - Optionally not present (MEMORY_GUARD)
  * 4 - Unused; optionally not present (MEMORY_GUARD)
- * 3 - Unused; optionally not present (MEMORY_GUARD)
+ * 3 -  DB IST stack
  * 2 - MCE IST stack
  * 1 - NMI IST stack
  * 0 - Double Fault IST stack
-- 
2.11.0


Re: [PATCH] x86/IST: Fix comment about stack layout
Posted by Wei Liu 3 years, 11 months ago
On Mon, Apr 27, 2020 at 02:17:02PM +0100, Andrew Cooper wrote:
> This was an oversight in c/s 5d37af364dc "x86/traps: Use an Interrupt Stack
> Table for #DB" which introduced the #DB IST to begin with.
> 
> Reported-by: Jan Beulich <JBeulich@suse.com>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Wei Liu <wl@xen.org>
> CC: Roger Pau Monné <roger.pau@citrix.com>
> ---
>  xen/include/asm-x86/current.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/include/asm-x86/current.h b/xen/include/asm-x86/current.h
> index 0b47485337..39c2c6cbf8 100644
> --- a/xen/include/asm-x86/current.h
> +++ b/xen/include/asm-x86/current.h
> @@ -18,7 +18,7 @@
>   * 6 - Primary stack
>   * 5 - Optionally not present (MEMORY_GUARD)
>   * 4 - Unused; optionally not present (MEMORY_GUARD)
> - * 3 - Unused; optionally not present (MEMORY_GUARD)
> + * 3 -  DB IST stack

There seems to be an extraneous space before "DB".

Wei.

>   * 2 - MCE IST stack
>   * 1 - NMI IST stack
>   * 0 - Double Fault IST stack
> -- 
> 2.11.0
> 

Re: [PATCH] x86/IST: Fix comment about stack layout
Posted by Andrew Cooper 3 years, 11 months ago
On 27/04/2020 14:19, Wei Liu wrote:
> On Mon, Apr 27, 2020 at 02:17:02PM +0100, Andrew Cooper wrote:
>> This was an oversight in c/s 5d37af364dc "x86/traps: Use an Interrupt Stack
>> Table for #DB" which introduced the #DB IST to begin with.
>>
>> Reported-by: Jan Beulich <JBeulich@suse.com>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> ---
>> CC: Jan Beulich <JBeulich@suse.com>
>> CC: Wei Liu <wl@xen.org>
>> CC: Roger Pau Monné <roger.pau@citrix.com>
>> ---
>>  xen/include/asm-x86/current.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/xen/include/asm-x86/current.h b/xen/include/asm-x86/current.h
>> index 0b47485337..39c2c6cbf8 100644
>> --- a/xen/include/asm-x86/current.h
>> +++ b/xen/include/asm-x86/current.h
>> @@ -18,7 +18,7 @@
>>   * 6 - Primary stack
>>   * 5 - Optionally not present (MEMORY_GUARD)
>>   * 4 - Unused; optionally not present (MEMORY_GUARD)
>> - * 3 - Unused; optionally not present (MEMORY_GUARD)
>> + * 3 -  DB IST stack
> There seems to be an extraneous space before "DB".

Yes.  The alternative would be for misaligned tabulation with the lower
"IST stack".

~Andrew

>
> Wei.
>
>>   * 2 - MCE IST stack
>>   * 1 - NMI IST stack
>>   * 0 - Double Fault IST stack
>> -- 
>> 2.11.0
>>


Re: [PATCH] x86/IST: Fix comment about stack layout
Posted by Jan Beulich 3 years, 11 months ago
On 27.04.2020 15:19, Wei Liu wrote:
>> --- a/xen/include/asm-x86/current.h
>> +++ b/xen/include/asm-x86/current.h
>> @@ -18,7 +18,7 @@
>>   * 6 - Primary stack
>>   * 5 - Optionally not present (MEMORY_GUARD)
>>   * 4 - Unused; optionally not present (MEMORY_GUARD)
>> - * 3 - Unused; optionally not present (MEMORY_GUARD)
>> + * 3 -  DB IST stack
> 
> There seems to be an extraneous space before "DB".

I guess #DB was meant. With that

Acked-by: Jan Beulich <jbeulich@suse.com>

Jan