From nobody Mon May 6 12:17:19 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail(p=none dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1587161810; cv=none; d=zohomail.com; s=zohoarc; b=gUrpaGQF5Q9JIUyYZ4QYJsFMi4zQY2zMcEN4vAfTse1LugTGzfXUL9VQM75L/RS6uMf7xKwJJuuM/76bzJ3896A+a/k2ozvuHeICbx67SmtTY9HtClQJ4Z7hoMhjYQfLGZRkN47kmTLzTwS6wawFMybfb3U0lB1pkJz44szTxMU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1587161810; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To; bh=C1Uifu/fdxGxOtmMquW7KP4LRLPpkmt7Uhl09GO0HtI=; b=XRin90TDhRlhVo5GWf9xjP7WNOyCECsmVKqLY0uRJ2VKRKyCKQLKpKn4FsgJ8ew5d8z9LdUt6wFVa2VCrWATSKcJASPQLhzvhAZUHq8Qp6qtcVMc+FMN4t9EsfOQ3Ggbwq+N+nBOHGa+7GEKxqIIObH6GFzHuETvxLFj6ZEHpWo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1587161810787392.9835552143179; Fri, 17 Apr 2020 15:16:50 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jPZHR-0006fb-Mt; Fri, 17 Apr 2020 22:16:13 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jPZHQ-0006fW-E3 for xen-devel@lists.xenproject.org; Fri, 17 Apr 2020 22:16:12 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0b924700-80f9-11ea-b58d-bc764e2007e4; Fri, 17 Apr 2020 22:16:12 +0000 (UTC) Received: from sstabellini-ThinkPad-T480s.hsd1.ca.comcast.net (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1F32220656; Fri, 17 Apr 2020 22:16:11 +0000 (UTC) X-Inumbo-ID: 0b924700-80f9-11ea-b58d-bc764e2007e4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587161771; bh=gb3Z9a2VrqqwohrS52ctiZQwXXCEVwx1D9sYthQAaBA=; h=From:To:Cc:Subject:Date:From; b=rCo8cU3hxVvD+j2afiY73LvWzbGWr81CAXYZXvJloPVc2WLXNBApK7OE1L8avdFAu DM8KWKwmgCfsD2KZ3vYgRsfIt/CrbWkqXsG45TJeqZEOnVFGmiMHcLDVdX6VQRY3xc s6OMUUMjpT/MvOXkqSuevESQd9B7FDK1UYj2wDVQ= From: Stefano Stabellini To: julien@xen.org Subject: [PATCH][RESEND] xen/arm: vgic-v3: fix GICD_ISACTIVER range Date: Fri, 17 Apr 2020 15:16:09 -0700 Message-Id: <20200417221609.19928-1-sstabellini@kernel.org> X-Mailer: git-send-email 2.17.1 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Peng Fan , sstabellini@kernel.org, Stefano Stabellini Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Peng Fan The end should be GICD_ISACTIVERN not GICD_ISACTIVER. (See https://marc.info/?l=3Dxen-devel&m=3D158527653730795 for a discussion = on what it would take to implement GICD_ISACTIVER/GICD_ICACTIVER properly.) Signed-off-by: Peng Fan Signed-off-by: Stefano Stabellini Reviewed-by: Stefano Stabellini Acked-by: Julien Grall reviewed-by. I agree it looks kind of weird.=20 reviewed-by/acked-by tag. --- xen/arch/arm/vgic-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c index 4e60ba15cc..fd8cfc156d 100644 --- a/xen/arch/arm/vgic-v3.c +++ b/xen/arch/arm/vgic-v3.c @@ -713,7 +713,7 @@ static int __vgic_v3_distr_common_mmio_read(const char = *name, struct vcpu *v, goto read_as_zero; =20 /* Read the active status of an IRQ via GICD/GICR is not supported */ - case VRANGE32(GICD_ISACTIVER, GICD_ISACTIVER): + case VRANGE32(GICD_ISACTIVER, GICD_ISACTIVERN): case VRANGE32(GICD_ICACTIVER, GICD_ICACTIVERN): goto read_as_zero; =20 --=20 2.17.1