From nobody Mon Feb 9 11:30:14 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org ARC-Seal: i=1; a=rsa-sha256; t=1586441637; cv=none; d=zohomail.com; s=zohoarc; b=YAIpfXwGIQEde86v6LQIc/ZLGFt/Ba1nmn1/ONYarFIeZVqd+5v+Dgwq73G8GUpDTnDq7rQHXeICqFbliQkU04DsggGfNrzGZPwgsHhxKvnfX827i1j+YBc1ZSgPlQRbcaHw91rd+Wpyi5uJ6zwNPaVAEOKF7UnlNf+wSXJmv5g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1586441637; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=AmwueCeHVHvBgDophbhj/5mqT4X7ebmqwWJmR1el6E8=; b=CE1FbSEqQVx385//D9kO35xyNlkhnIl/zdU2oanq6d2jaEJfMBta1X1IBV+9QDtGAF7VZ1iChTD147xYJNe+8v+mw+Wqj9z1tsc0ZleXJ1MVeeMYg202+EqkohU/JqwcXC0Gbj11i/WXy6yckI32P4kMtgBOp9dNOMIsD/rdbC8= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 158644163725973.4449142800164; Thu, 9 Apr 2020 07:13:57 -0700 (PDT) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jMXvF-0002nv-2C; Thu, 09 Apr 2020 14:12:49 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jMXvD-0002nk-T3 for xen-devel@lists.xenproject.org; Thu, 09 Apr 2020 14:12:47 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 2f0d72f6-7a6c-11ea-82d6-12813bfff9fa; Thu, 09 Apr 2020 14:12:46 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 0607EAE59; Thu, 9 Apr 2020 14:12:43 +0000 (UTC) X-Inumbo-ID: 2f0d72f6-7a6c-11ea-82d6-12813bfff9fa X-Virus-Scanned: by amavisd-new at test-mx.suse.de From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org Subject: [PATCH 2/3] mini-os: fix double free() in xenbus Date: Thu, 9 Apr 2020 16:12:39 +0200 Message-Id: <20200409141240.28876-3-jgross@suse.com> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20200409141240.28876-1-jgross@suse.com> References: <20200409141240.28876-1-jgross@suse.com> X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , samuel.thibault@ens-lyon.org, wl@xen.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Commit 973ad0c4de1b48 ("Save/Restore Support: Add suspend/restore support for xenbus") introduced a double free of some memory and leaked another memory allocation. Fix those. Coverity-ID: 1433640 Fixes: 973ad0c4de1b48 ("Save/Restore Support: Add suspend/restore support f= or xenbus") Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault --- xenbus/xenbus.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/xenbus/xenbus.c b/xenbus/xenbus.c index d72dc3a..b12cef7 100644 --- a/xenbus/xenbus.c +++ b/xenbus/xenbus.c @@ -413,9 +413,11 @@ void resume_xenbus(int canceled) =20 rep =3D xenbus_msg_reply(XS_WATCH, XBT_NIL, req, ARRAY_SIZE(re= q)); msg =3D errmsg(rep); - if (msg) + if (msg) { xprintk("error on XS_WATCH: %s\n", msg); - free(rep); + free(msg); + } else + free(rep); } } =20 --=20 2.16.4